Issue #140: Non free javascript (conservancy/kallithea)

New issue 140: Non free javascript https://bitbucket.org/conservancy/kallithea/issue/140/non-free-javascript _aurelien_: LibreJS claim about non free javascript in Kallithea ___ kallithea-general mailing list kallithea-general@sfconservancy.org

[PATCH 1 of 2] pullrequest: warn for duplication of reviewer handling with base.js

# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1434721227 -7200 # Fri Jun 19 15:40:27 2015 +0200 # Node ID ea284e51ec2eb80cbf3d3552798b9a060d1746b1 # Parent a7ac467edbf5b71b4198f3e0e6b543c3fbb8cc47 pullrequest: warn for duplication of

[PATCH 2 of 2] pullrequest: when adding a reviewer, show full name only

# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1434721370 -7200 # Fri Jun 19 15:42:50 2015 +0200 # Node ID 90e982b6bca805a574f6dc7f7535169d827ea3fa # Parent ea284e51ec2eb80cbf3d3552798b9a060d1746b1 pullrequest: when adding a reviewer,

[PATCH 7 of 7] tests: remove hardcoded reference to GIT_REPO

# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434831005 -7200 # Sat Jun 20 22:10:05 2015 +0200 # Node ID 153ef33bf4ee2d0067825618e1c0f53f37b3d071 # Parent 63ba8bff3323c303944c1fef9cf57eecd49890fa tests: remove hardcoded reference to GIT_REPO

[PATCH 2 of 7] tests: remove hardcoded test_regular2 username

# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434829395 -7200 # Sat Jun 20 21:43:15 2015 +0200 # Node ID f60ea96cc104a334e336e03c38c3d99b86f7f1a6 # Parent af8e9af347d94a8b996d9c649a4267d585dc3745 tests: remove hardcoded test_regular2 username

[PATCH 6 of 7] tests: remove hardcoded reference to HG_REPO

# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434830876 -7200 # Sat Jun 20 22:07:56 2015 +0200 # Node ID 63ba8bff3323c303944c1fef9cf57eecd49890fa # Parent 95518c56b04c78511c7e003b6a02337e32d7c8e0 tests: remove hardcoded reference to HG_REPO

[PATCH 0 of 7] tests: remove hardcoded strings defined symbolically in kallithea/tests/__init__.py

Some trivial cleanups related to hardcoded strings in tests. ___ kallithea-general mailing list kallithea-general@sfconservancy.org http://lists.sfconservancy.org/mailman/listinfo/kallithea-general

[PATCH 5 of 7] tests: remove hardcoded test passwords

# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434830216 -7200 # Sat Jun 20 21:56:56 2015 +0200 # Node ID 95518c56b04c78511c7e003b6a02337e32d7c8e0 # Parent 359e871608759bf729ad8378be00f3a3bf677942 tests: remove hardcoded test passwords diff

[PATCH 4 of 7] tests: remove hardcoded test e-mail addresses

# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434832304 -7200 # Sat Jun 20 22:31:44 2015 +0200 # Node ID 359e871608759bf729ad8378be00f3a3bf677942 # Parent 087a949ad8b7d7ecd5416d5fca89ec2953f33eaf tests: remove hardcoded test e-mail addresses

[PATCH 1 of 7] tests: remove hardcoded test_admin username

# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1434829259 -7200 # Sat Jun 20 21:40:59 2015 +0200 # Node ID af8e9af347d94a8b996d9c649a4267d585dc3745 # Parent a7ac467edbf5b71b4198f3e0e6b543c3fbb8cc47 tests: remove hardcoded test_admin username

Re: [PATCH 0 of 7] tests: remove hardcoded strings defined symbolically in kallithea/tests/__init__.py

On 06/20/2015 10:37 PM, Thomas De Schampheleire wrote: Some trivial cleanups related to hardcoded strings in tests. I think another school of thought is that tests should be as simple, static and explicit as possible. To avoid begging the question they are asking, they should avoid any