Re: [PATCH 0 of 9] remove UI notification feature

On 12/6/18 1:02 PM, Thomas De Schampheleire wrote: And we have so much cruft in upgraded databases anyway. I think we either should accept a bit more tech debt there and rely on a future "only preserve schema things we use now" database migration option, or just add a migration step now to drop

Re: [PATCH 0 of 9] remove UI notification feature

El jue., 6 dic. 2018 a las 12:26, Mads Kiilerich () escribió: > > Thanks. Thanks for pushing so quickly. > > I wonder if some css also could be cleaned up? Do you have specific examples or details? I searched for 'notif' but found nothing. > > And we have so much cruft in upgraded databases

[PATCH 9 of 9] model: comment out but retain Notification and UserNotification classes

# HG changeset patch # User Thomas De Schampheleire # Date 1544042393 -3600 # Wed Dec 05 21:39:53 2018 +0100 # Node ID a6e7e098056c78e54d541c9cc410a5c94b320c74 # Parent 7e14c85c74fc6726ea46f41a98eba68093495d6f model: comment out but retain Notification and UserNotification classes This

[PATCH 5 of 9] tests: remove tests of UI notifications

# HG changeset patch # User Thomas De Schampheleire # Date 1543992000 -3600 # Wed Dec 05 07:40:00 2018 +0100 # Node ID c8c333e621e32f8f6f09fb45ce43cc57c38a # Parent 4473f2fb4f7e34ee0d842d163b4412ba6a04e7cb tests: remove tests of UI notifications This commit is part of the removal of

[PATCH 7 of 9] model: remove UI notification feature

# HG changeset patch # User Thomas De Schampheleire # Date 1544041678 -3600 # Wed Dec 05 21:27:58 2018 +0100 # Node ID 97752bbee442057da88f03a75fc4dcf3945d90bb # Parent 3ececf31e315c414f49a19ed0c5f7544d5c305bb model: remove UI notification feature This commit is part of the removal of the

[PATCH 8 of 9] model: move notification types from Notification to NotificationModel

# HG changeset patch # User Thomas De Schampheleire # Date 1544042241 -3600 # Wed Dec 05 21:37:21 2018 +0100 # Node ID 7e14c85c74fc6726ea46f41a98eba68093495d6f # Parent 97752bbee442057da88f03a75fc4dcf3945d90bb model: move notification types from Notification to NotificationModel This

[PATCH 2 of 9] tests: notifications: increase indentation of multi-line for loop condition

# HG changeset patch # User Thomas De Schampheleire # Date 1543698298 -3600 # Sat Dec 01 22:04:58 2018 +0100 # Node ID cf7e97eceeed93f74bf2db3b6ffaca4b55896a70 # Parent d0eaee2ca6b205ad58b6e46723252e3e57bfa31c tests: notifications: increase indentation of multi-line for loop condition Code

[PATCH 6 of 9] controllers/templates: remove UI notification feature

# HG changeset patch # User Thomas De Schampheleire # Date 1544041299 -3600 # Wed Dec 05 21:21:39 2018 +0100 # Node ID 3ececf31e315c414f49a19ed0c5f7544d5c305bb # Parent c8c333e621e32f8f6f09fb45ce43cc57c38a controllers/templates: remove UI notification feature This commit is part of the

[PATCH 3 of 9] lib: remove unused method 'notify' from DbManage

# HG changeset patch # User Thomas De Schampheleire # Date 1543955255 -3600 # Tue Dec 04 21:27:35 2018 +0100 # Node ID 7e7de9b59fb7af2f1926e628c88a50a0498d9dba # Parent cf7e97eceeed93f74bf2db3b6ffaca4b55896a70 lib: remove unused method 'notify' from DbManage This method is no longer used.

[PATCH 1 of 9] model: notification: don't round-trip via list if you want a set

# HG changeset patch # User Thomas De Schampheleire # Date 1543436548 -3600 # Wed Nov 28 21:22:28 2018 +0100 # Node ID d0eaee2ca6b205ad58b6e46723252e3e57bfa31c # Parent 2c54a82aeaed569ef27f7813d9537d4f1adcfb32 model: notification: don't round-trip via list if you want a set 'create' in

[PATCH 0 of 9] remove UI notification feature

Hello, As discussed, this patch series removes the UI notification feature from Kallithea. Notifications are now email-only. This change simplifies the code base and will make later changes in the email notifications easier. The first three commits are not directly related to the removal, but

[PATCH 4 of 9] templates: remove notification count from user profile button

# HG changeset patch # User Thomas De Schampheleire # Date 1543955577 -3600 # Tue Dec 04 21:32:57 2018 +0100 # Node ID 4473f2fb4f7e34ee0d842d163b4412ba6a04e7cb # Parent 7e7de9b59fb7af2f1926e628c88a50a0498d9dba templates: remove notification count from user profile button This commit is