Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-23 Thread Mads Kiilerich
On 03/20/2015 01:18 PM, Thomas De Schampheleire wrote: Regardless of this TODO, I think the patch is fine in removing a different behavior depending on the fact that the PR head happens to be the tip at the time of PR creation or not. Yes - I was verifying it in production. Pushed - thanks!

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-20 Thread Thomas De Schampheleire
On Fri, Mar 20, 2015 at 1:24 AM, Mads Kiilerich wrote: > On 03/19/2015 07:59 PM, Thomas De Schampheleire wrote: >> >> On March 19, 2015 3:38:39 PM CET, Mads Kiilerich >> wrote: >>> >>> On 03/19/2015 03:00 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen # Date 142

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-19 Thread Mads Kiilerich
On 03/19/2015 07:59 PM, Thomas De Schampheleire wrote: On March 19, 2015 3:38:39 PM CET, Mads Kiilerich wrote: On 03/19/2015 03:00 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen # Date 1426767186 -3600 # Thu Mar 19 13:13:06 2015 +0100 # Node ID beae6b3ec2fc556a274630de6d7b0

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-19 Thread Thomas De Schampheleire
On Thu, Mar 19, 2015 at 7:59 PM, Thomas De Schampheleire wrote: > On March 19, 2015 3:38:39 PM CET, Mads Kiilerich wrote: >>On 03/19/2015 03:00 PM, Jan Heylen wrote: >>> # HG changeset patch >>> # User Jan Heylen >>> # Date 1426767186 -3600 >>> # Thu Mar 19 13:13:06 2015 +0100 >>> # Node ID

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-19 Thread Thomas De Schampheleire
On March 19, 2015 3:38:39 PM CET, Mads Kiilerich wrote: >On 03/19/2015 03:00 PM, Jan Heylen wrote: >> # HG changeset patch >> # User Jan Heylen >> # Date 1426767186 -3600 >> # Thu Mar 19 13:13:06 2015 +0100 >> # Node ID beae6b3ec2fc556a274630de6d7b02b1cf54052a >> # Parent b08aab61c41d60562f

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-19 Thread Mads Kiilerich
On 03/19/2015 03:00 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen # Date 1426767186 -3600 # Thu Mar 19 13:13:06 2015 +0100 # Node ID beae6b3ec2fc556a274630de6d7b02b1cf54052a # Parent b08aab61c41d60562f0033f927cf32c8e024e24b pullrequests: saving raw_id instead of branch in or

[PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-19 Thread Jan Heylen
# HG changeset patch # User Jan Heylen # Date 1426767186 -3600 # Thu Mar 19 13:13:06 2015 +0100 # Node ID beae6b3ec2fc556a274630de6d7b02b1cf54052a # Parent b08aab61c41d60562f0033f927cf32c8e024e24b pullrequests: saving raw_id instead of branch in org_ref This fixes an issue when the pull req