Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 8:20 PM, Ross Thomas wrote: On 2/11/20 10:27 AM, Ross Thomas wrote: Looking into it here. Yep. I've been bitten by this before. :-p The onClick handler needs to return the result of the called function. A fix patch is attached for illustration as it affects both this enhancement an

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 11:20 AM, Ross Thomas wrote: > The onClick handler needs to return the result of the called function. I've had a couple of folks ask 'Why?' so I guess this isn't as commonly understood as I thought. For those that may not be aware, when the event handler is coded via html like this:

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 10:27 AM, Ross Thomas wrote: > Looking into it here. Yep. I've been bitten by this before. :-p The onClick handler needs to return the result of the called function. A fix patch is attached for illustration as it affects both this enhancement and stable/default. Ross. diff -r 0c69146

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

On 2/11/20 5:33 AM, Mads Kiilerich wrote: > Do you also see the repo list scroll to top when toggling "follow"? Yep. I'm guessing it has something to do with toggleFollowingRepo() since it also does it on the repo page using the Options menu. Looking into it here. Ross.

Re: [PATCH 0 of 1] Enhancement: Repo browser quick action icons

Do you also see the repo list scroll to top when toggling "follow"? /Mads ___ kallithea-general mailing list kallithea-general@sfconservancy.org https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

[PATCH 0 of 1] Enhancement: Repo browser quick action icons

This replaces the previously submitted patch changeset: 504adebdb501 It changes the names that were identified as too generic. It also fixes and refines the configurable nature of the enhancement. It does NOT impl