Re: [PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

2020-02-09 Thread Mads Kiilerich
On 2/8/20 9:21 PM, Ross Thomas wrote: On 2/8/20 6:05 AM, Mads Kiilerich wrote: Thanks. I do agree this is better. But is it fixing an actual problem? The old manual encoding seems to work fine too? Yep, it worked but it was mostly fortunate 'luck'. It ended up using matrix mode instead of

Re: [PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

2020-02-08 Thread Ross Thomas
On 2/8/20 6:05 AM, Mads Kiilerich wrote: > Thanks. I do agree this is better. But is it fixing an actual problem? > The old manual encoding seems to work fine too? Yep, it worked but it was mostly fortunate 'luck'. It ended up using matrix mode instead of true query params. The resulting query

Re: [PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

2020-02-08 Thread Mads Kiilerich
On 2/8/20 2:06 AM, Ross Thomas wrote: # HG changeset patch # User Ross Thomas # Date 1581112527 28800 # Fri Feb 07 13:55:27 2020 -0800 # Branch stable # Node ID f273a7b53fe035c12a55b6a3e34f849af245d797 # Parent 2571674c4a2fd6247a6dee7d9b4e27df13df1429 follow: Fix args for $.post() call in

[PATCH 1 of 2] follow: Fix args for $.post() call in toggleFollowingRepo()

2020-02-07 Thread Ross Thomas
# HG changeset patch # User Ross Thomas # Date 1581112527 28800 # Fri Feb 07 13:55:27 2020 -0800 # Branch stable # Node ID f273a7b53fe035c12a55b6a3e34f849af245d797 # Parent 2571674c4a2fd6247a6dee7d9b4e27df13df1429 follow: Fix args for $.post() call in toggleFollowingRepo() diff -r