Re: [PATCH stable] diff: don't cut binary diff parsing short

2017-01-03 Thread Mads Kiilerich
On 01/03/2017 09:09 AM, Andrew Shadura wrote: Right, I made a mistake of rebasing it to the stable branch as I thought OOK ran stable, which it didn't. Sure, there's no op there, the crash happens on the default branch only, it's 'in ' requires string as left operand, not NoneType in the line w

Re: [PATCH stable] diff: don't cut binary diff parsing short

2017-01-03 Thread Andrew Shadura
On 02/01/17 23:20, Mads Kiilerich wrote: > On 01/02/2017 07:17 PM, Andrew Shadura wrote: >> diff: don't cut binary diff parsing short >> >> With binary diffs, user might want to see something more meaningful >> than just 'Binary file', for example, an image diff. However, >> interrupting parsing on

Re: [PATCH stable] diff: don't cut binary diff parsing short

2017-01-02 Thread Mads Kiilerich
On 01/02/2017 07:17 PM, Andrew Shadura wrote: kallithea/lib/diffs.py | 7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) # HG changeset patch # User Andrew Shadura # Date 1483380766 -3600 # Mon Jan 02 19:12:46 2017 +0100 # Branch stable # Node ID ee8c9993a3aacb371fc5e59addc9

[PATCH stable] diff: don't cut binary diff parsing short

2017-01-02 Thread Andrew Shadura
kallithea/lib/diffs.py | 7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) # HG changeset patch # User Andrew Shadura # Date 1483380766 -3600 # Mon Jan 02 19:12:46 2017 +0100 # Branch stable # Node ID ee8c9993a3aacb371fc5e59addc9434008290679 # Parent b4dd4c16c12d8932d99a2182c7e