Re: Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-12-06 Thread Mads Kiilerich
On 12/05/2016 05:59 PM, Alessandro Molina wrote: Following up to point out that TurboGears 2.3.10 no longer requires helpers and app_globals to be imported into lib (TG will automatically import them if available as submodules). Thanks - and congratulations with the release. Thomas is doing

Re: Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-12-05 Thread Alessandro Molina
Following up to point out that TurboGears 2.3.10 no longer requires helpers and app_globals to be imported into lib (TG will automatically import them if available as submodules). I remember that was causing some issues in Kallithea port On Sun, Sep 18, 2016 at 9:18 PM, Thomas De Schampheleire <

Re: Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-09-18 Thread Thomas De Schampheleire
On Sun, Sep 18, 2016 at 12:28 PM, Alessandro Molina wrote: > If I remember correctly kallithea explicitly handles commits, so probably it > has no need for the transaction manager. > Try to add base_config['tm.enabled'] = False in app_cfg.py and see it > everything

Re: Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-09-18 Thread Mads Kiilerich
On 09/18/2016 01:01 PM, Thomas De Schampheleire wrote: On Sep 18, 2016 12:28, "Alessandro Molina" > wrote: > > If I remember correctly kallithea explicitly handles commits, so probably it has no need for the transaction

Re: Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-09-18 Thread Thomas De Schampheleire
On Sep 18, 2016 12:28, "Alessandro Molina" wrote: > > If I remember correctly kallithea explicitly handles commits, so probably it has no need for the transaction manager. > Try to add base_config['tm.enabled'] = False in app_cfg.py and see it everything still works

Re: Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-09-18 Thread Alessandro Molina
If I remember correctly kallithea explicitly handles commits, so probably it has no need for the transaction manager. Try to add base_config['tm.enabled'] = False in app_cfg.py and see it everything still works as expected and the error disappeared. Alessandro On Wed, Aug 31, 2016 at 2:15 PM,

Turbogears2 migration: import of helpers/app_globals into kallithea.lib

2016-08-31 Thread Thomas De Schampheleire
Hi Alessandro, In kallithea/lib/__init__.py you added following statements: from . import helpers from . import app_globals following an expectation of Turbogears2. This poses problems with statements like 'from kallithea.lib import vcs'. I have now dug deeper to the real requirement of this