Some problem of kallithea searching feature.

2018-12-20 Thread Zhou, Squall (NSB - CN/Qingdao) 
Hi All

I am a user of Kallithea, it is a great tool which help me to manage my project 
and review the code of it.
However, I meet some problem when I what to search the commits. It always 
report "An error occurred during search operation".
So, am I using the searching feature in a wrong way? Or there is an issue in 
this feature.

Hope for your response.

Thanks very much
Squall
___
kallithea-general mailing list
kallithea-general@sfconservancy.org
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Re: errors with cloning remote mercurial that's HTTPS based

2018-12-20 Thread Mads Kiilerich 

On 12/21/18 5:52 AM, Ed Wong wrote:

Hi,

I've followed the Contribution page [1] page and
would like to understand what I might be doing wrong.

I've set up the 0.3.99 Kallithea (via [1]) and while the dev site isn't
https-based, the remote repos that I clone off of do use HTTPS and
the code doesn't seem to like that. (It's perfectly ok with 0.3.6.
but 0.3.99 doesn't like it)

I am getting:

Exception AttributeError: "'httppeer' object has no attribute
'_urlopener'" in > ignored
2018-12-21 12:28:38.122 ERROR [kallithea.model.validators] URL
validation failed
Traceback (most recent call last):
   File "/home/kali/kallithea/kallithea/model/validators.py", line 430,
in validate_python
 is_valid_repo_uri(repo_type, url, make_ui('db', clear_session=False))
   File "/home/kali/kallithea/kallithea/lib/utils.py", line 226, in
is_valid_repo_uri
 MercurialRepository._check_url(url, ui)
   File
"/home/kali/kallithea/kallithea/lib/vcs/backends/hg/repository.py", line
349, in _check_url
 % (cleaned_uri, e))
URLError: https://:*@hg.mozilla.org/releases/comm-beta] does not look like an
hg repo org_exc: __init__() takes exactly 7 arguments (3 given)>



It sounds like an issue that is solved by 
https://lists.sfconservancy.org/pipermail/kallithea-general/2018q4/002877.html 
- can you confirm?


And thanks for giving feedback!

/Mads

___
kallithea-general mailing list
kallithea-general@sfconservancy.org
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

errors with cloning remote mercurial that's HTTPS based

2018-12-20 Thread Ed Wong 
Hi,

I've followed the Contribution page [1] page and
would like to understand what I might be doing wrong.

I've set up the 0.3.99 Kallithea (via [1]) and while the dev site isn't
https-based, the remote repos that I clone off of do use HTTPS and
the code doesn't seem to like that. (It's perfectly ok with 0.3.6.
but 0.3.99 doesn't like it)

I am getting:

Exception AttributeError: "'httppeer' object has no attribute
'_urlopener'" in > ignored
2018-12-21 12:28:38.122 ERROR [kallithea.model.validators] URL
validation failed
Traceback (most recent call last):
  File "/home/kali/kallithea/kallithea/model/validators.py", line 430,
in validate_python
is_valid_repo_uri(repo_type, url, make_ui('db', clear_session=False))
  File "/home/kali/kallithea/kallithea/lib/utils.py", line 226, in
is_valid_repo_uri
MercurialRepository._check_url(url, ui)
  File
"/home/kali/kallithea/kallithea/lib/vcs/backends/hg/repository.py", line
349, in _check_url
% (cleaned_uri, e))
URLError: https://:*@hg.mozilla.org/releases/comm-beta] does not look like an
hg repo org_exc: __init__() takes exactly 7 arguments (3 given)>

This is when I try to add a repository:
https://hg.mozilla.org/releases/comm-beta.

I'm using Mercurial 4.8.1 and I noticed this version's httppeer.py's
httppeer class has 7 arguments as opposed to 4.3.1's version which
only has 3.

Basically from this (line336 from
kallithea/lib/vcs/backends/hg/repository.py:

try:
httppeer(repoui or ui.ui(), url).lookup('tip')


and for 4.3.1's httppeer.py :

class httppeer(wireproto.wirepeer):

def __init__(self, ui, path):

self.path = path
self.caps = None


whereas 4.8.1's httppeer:


class httppeer(wireprotov1peer.wirepeer):
def __init__(self, ui, path, url, opener, requestbuilder, caps):


Is this a known issue?


Thanks



[1]-
https://kallithea.readthedocs.io/en/latest/contributing.html#getting-started
___
kallithea-general mailing list
kallithea-general@sfconservancy.org
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general

Re: Clone repo from remote URL fails

2018-12-20 Thread Mads Kiilerich 

On 12/12/18 12:58 PM, Mads Kiilerich wrote:

On 12/11/18 5:03 PM, Thomas De Schampheleire wrote:

El mar., 11 dic. 2018 a las 12:19, Mads Kiilerich
() escribió:

It's been a while that I tested this, but I wonder if it could be
related to a mercurial version? This instance is running 4.7.2.
In commit 03dfcbe52906 there has been a change in this area, but I
didn't investigate it further.


Yes, that change was insufficient.

Proposed fix on
https://kallithea-scm.org/repos/kallithea-incoming/changeset/8107a49198fbbb1474f84cc0e6c8c1cfea5d2de4 


Thanks.


Extra annoying that it just fails in a URL validation check. The actual
clone works ... and it would fail if the URL was invalid. So it would
perhaps be better to drop the check and just try it, similar to how ssh
URLs are handled?

Note that I was cloning from an SSH URL.



Right. How about 
https://kallithea-scm.org/repos/kallithea-incoming/changeset/8670f5906fa6760638cb5485a03c675b68c589fe 
?



Can you confirm this looks OK and works for you?

/Mads
___
kallithea-general mailing list
kallithea-general@sfconservancy.org
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general