Re: [PATCH] tests: fix assertion rewriting in some tests with pytest-3.0.0+

2016-09-09 Thread Mads Kiilerich
On 09/09/2016 04:03 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire # Date 1473428048 -7200 # Fri Sep 09 15:34:08 2016 +0200 # Node ID 6889d3b7435f1c4bb91d24a3af7774323ecbc778 # Parent

[PATCH] tests: fix assertion rewriting in some tests with pytest-3.0.0+

2016-09-09 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire # Date 1473428048 -7200 # Fri Sep 09 15:34:08 2016 +0200 # Node ID 6889d3b7435f1c4bb91d24a3af7774323ecbc778 # Parent 59639343672495cb89be54b98f1d6d3a4c44307c tests: fix assertion rewriting in some tests

Re: [PATCH] tests: fix assertion rewriting in some tests with pytest-3.0.0+

2016-09-09 Thread Thomas De Schampheleire
On Sep 9, 2016 4:21 PM, "Mads Kiilerich" wrote: > > On 09/09/2016 04:03 PM, Thomas De Schampheleire wrote: >> >> # HG changeset patch >> # User Thomas De Schampheleire >> # Date 1473428048 -7200 >> # Fri Sep 09 15:34:08 2016 +0200 >> #

Re: [PATCH] tests: fix assertion rewriting in some tests with pytest-3.0.0+

2016-09-09 Thread Mads Kiilerich
On 09/09/2016 06:38 PM, Thomas De Schampheleire wrote: > ... or we could desupport pytest < 3. But I guess this shows that it can be convenient to keep the old version around a bit. I would rather argue that it is better to support a single version, then this mistake could not have

Re: [PATCH] tests: fix assertion rewriting in some tests with pytest-3.0.0+

2016-09-09 Thread Thomas De Schampheleire
On Fri, Sep 9, 2016 at 7:03 PM, Mads Kiilerich wrote: > On 09/09/2016 06:38 PM, Thomas De Schampheleire wrote: >> >> > ... or we could desupport pytest < 3. But I guess this shows that it can >> > be convenient to keep the old version around a bit. >> >> I would rather argue