Re: merging approved pull requests

2014-12-04 Thread Thomas De Schampheleire
Hi Mads, On Wed, Dec 3, 2014 at 4:31 PM, Jan Heylen heyl...@gmail.com wrote: Hi, we are trying to setup a POC Kallithea system to be able to do code review. what I did: * setup a repo A * fork rep A to A' * clone A', make changes, push changes, amend changes, force push changes, all to

Re: discussion on issue #77 (review icon position for in-line code comments)

2015-02-07 Thread Thomas De Schampheleire
On Mon, Jan 26, 2015 at 4:59 PM, Mads Kiilerich m...@kiilerich.com wrote: On 01/26/2015 02:41 AM, Sean Farley wrote: Mads Kiilerich writes: I also think it is odd that both Bitbucket, Github and Kallithea shows the line numbers for each line in a diff. It is usually worthless information

YUI remainders

2015-02-07 Thread Thomas De Schampheleire
Hi Takumi, I noticed that you have sent a pull request in the past: https://bitbucket.org/conservancy/kallithea/pull-request/63/remove-global-shortcut-yuc-and-yuq-v2 This replaces several uses of the YUI (Yahoo user interface library) by jQuery. However, there still remain several YUx calls in

Re: Kallithea internals overview

2015-02-03 Thread Thomas De Schampheleire
Hi, On Thu, Jan 29, 2015 at 11:50 AM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: ... What would be useful to me (and probably to other new contributors) is a technical overview of Kallithea's internals. Since my first attempt, I've been reading documentation of pylons and mako

Re: new commits to Kallithea should be sent to the mailing list

2015-02-03 Thread Thomas De Schampheleire
Hi, On Sun, Jan 25, 2015 at 5:49 AM, Sean Farley sean.michael.far...@gmail.com wrote: Thomas De Schampheleire writes: Hi, Currently, new commits on the Kallithea project silently end up in Bitbucket. In order for users to become aware of such changes and to create an active community, I

Re: Commits from Unity to mainline

2015-02-19 Thread Thomas De Schampheleire
On Thu, Feb 19, 2015 at 1:59 PM, Mads Kiilerich m...@kiilerich.com wrote: On 02/19/2015 11:13 AM, Nick Coghlan wrote: On 18 February 2015 at 13:14, Mads Kiilerich m...@kiilerich.com wrote: What do others say; would you like to have the don't add repo owner as reviewer in all PRs change in

Re: pull requests: variable names

2015-02-19 Thread Thomas De Schampheleire
On Thu, Feb 19, 2015 at 11:07 AM, Nick Coghlan ncogh...@gmail.com wrote: On 17 February 2015 at 13:13, Mads Kiilerich m...@kiilerich.com wrote: On 02/14/2015 09:36 PM, Thomas De Schampheleire wrote: Hi, In the pull request code (both controllers and templates) I find the variable names non

pull requests: default target branch

2015-01-29 Thread Thomas De Schampheleire
Hi, When creating a pull request in Kallithea, the tip (or specified revision) in the originating repository is compared with the destination repo's tip. When having several release branches, this choice could be confusing: suppose someone makes changes on the default branch and creates a pull

Re: contribution path

2015-03-14 Thread Thomas De Schampheleire
Hi Paul, On Sat, Mar 14, 2015 at 12:14 AM, Paul Nathan pnat...@alumni.uidaho.edu wrote: Hallo, I'd like to occasionally fix Kallithea bugs. I love the project and have followed it for the past few years. Great to hear, thanks for your offer on contributing! In order to do help out, I

[PATCH] website: emphasize source code location and contribution

2015-03-14 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426362759 -3600 # Sat Mar 14 20:52:39 2015 +0100 # Node ID fffcf8e1a17ac1e5501780b01a66817673f7abb6 # Parent 5ca6989b8971b5f5d96dd9a723d5f60a0389af2c website: emphasize source code location

[PATCH] docs/contributing: cleanup test section

2015-03-14 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426364334 -3600 # Sat Mar 14 21:18:54 2015 +0100 # Node ID 97af92113da02ebcd00de22d99348374a6182667 # Parent 6892b0515af98fd2e4e6db9c535a854e1ba2e0b1 docs/contributing: cleanup test section diff

[PATCH 3 of 3] docs/installation: clarify root privileges requirement for 'pip install'

2015-03-14 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426366315 -3600 # Sat Mar 14 21:51:55 2015 +0100 # Node ID b5efe92cea65b44e102a90508db3d53f5919466f # Parent f5e05f4a8bff420c63924b3764fcf33d162624ed docs/installation: clarify root privileges

[PATCH 2 of 3] docs/installation: add section on installation from source

2015-03-14 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426366293 -3600 # Sat Mar 14 21:51:33 2015 +0100 # Node ID f5e05f4a8bff420c63924b3764fcf33d162624ed # Parent 42db321baa410e0cbf91003750fafeec0e9e5cbf docs/installation: add section on installation

[PATCH 1 of 3] README: link to readthedocs.org rather than python.org for documentation

2015-03-14 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426366244 -3600 # Sat Mar 14 21:50:44 2015 +0100 # Node ID 42db321baa410e0cbf91003750fafeec0e9e5cbf # Parent 97af92113da02ebcd00de22d99348374a6182667 README: link to readthedocs.org rather than

Re: [PATCH 0 of 1 RFC] login-required pragma

2015-03-22 Thread Thomas De Schampheleire
Hi Mads, On Fri, Mar 20, 2015 at 1:09 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/19/2015 09:34 PM, Thomas De Schampheleire wrote: Hi, Issue I'm trying to solve is this: we're implementing a script to create a pull request directly from a repo, without using the web interface

Re: [PATCH 3 of 3] docs/installation: clarify root privileges requirement for 'pip install'

2015-03-15 Thread Thomas De Schampheleire
Hi, On Sun, Mar 15, 2015 at 2:06 PM, Mads Kiilerich m...@kiilerich.com wrote: On 03/15/2015 01:04 PM, Andrew Shadura wrote: Hello, On Sat, 14 Mar 2015 23:03:27 +0100 Mads Kiilerich m...@kiilerich.com wrote: +Note that this method requires root privileges. When installing as a regular

[PATCH] docs/installation: clarify and reorder alternative installation methods

2015-03-15 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426453734 -3600 # Sun Mar 15 22:08:54 2015 +0100 # Node ID 0e43ad4a28cdaa4218ccacea0963c7bf0a1a3b9f # Parent 5e66d3ec9880073b78653861518fe810c3bb1754 docs/installation: clarify and reorder

[PATCH] docs/contributing: move 'roadmap' to the wiki

2015-03-17 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426627294 -3600 # Tue Mar 17 22:21:34 2015 +0100 # Node ID 7b0b09fb44be4848f67906e7f99f92e58f906e96 # Parent 929f9f598fc914a940c9766e465f23eebc3a0e9b docs/contributing: move 'roadmap' to the wiki

[PATCH 3 of 3] docs/contributing: explicitly mention some useful options to nosetests

2015-03-17 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426622030 -3600 # Tue Mar 17 20:53:50 2015 +0100 # Node ID 929f9f598fc914a940c9766e465f23eebc3a0e9b # Parent af53a31a3ae8aa3d6c01fd4c6dd33cff5feb5f0e docs/contributing: explicitly mention some

[PATCH 1 of 3] docs: move all instructions on Celery to Setup

2015-03-17 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426621620 -3600 # Tue Mar 17 20:47:00 2015 +0100 # Node ID ec7899cb95c051cc5957c37e67c5ffeb56400591 # Parent 7c952ea3d7b3ce2192b285fc28ab2ccddee53402 docs: move all instructions on Celery to Setup

Re: what is the issue with database changes?

2015-03-17 Thread Thomas De Schampheleire
Hi, On Tue, Mar 17, 2015 at 8:40 PM, Matt Mackall m...@selenic.com wrote: On Tue, 2015-03-17 at 20:15 +0100, Jan Heylen wrote: On Tue, Mar 3, 2015 at 7:55 PM, Matt Mackall m...@selenic.com wrote: On Tue, 2015-03-03 at 15:24 +0100, Thomas De Schampheleire wrote: Hi, Regularly I hear

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-19 Thread Thomas De Schampheleire
On March 19, 2015 3:38:39 PM CET, Mads Kiilerich m...@kiilerich.com wrote: On 03/19/2015 03:00 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen jan.hey...@alcatel-lucent.com # Date 1426767186 -3600 # Thu Mar 19 13:13:06 2015 +0100 # Node ID

[PATCH 1 of 1 RFC] login: add login-required Pragma to HTTP headers

2015-03-19 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426796699 -3600 # Thu Mar 19 21:24:59 2015 +0100 # Node ID a9f2e162a9ecad5d13ee44848a73b64cc3de3285 # Parent cf8eab44c6ec583f7a0642b7274da30d15e3 login: add login-required Pragma to HTTP headers

Re: [PATCH 1 of 1 RFC] login: add login-required Pragma to HTTP headers

2015-03-19 Thread Thomas De Schampheleire
On Thu, Mar 19, 2015 at 9:34 PM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426796699 -3600 # Thu Mar 19 21:24:59 2015 +0100 # Node ID a9f2e162a9ecad5d13ee44848a73b64cc3de3285

Re: [PATCH] pullrequests: saving raw_id instead of branch in org_ref

2015-03-20 Thread Thomas De Schampheleire
On Fri, Mar 20, 2015 at 1:24 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/19/2015 07:59 PM, Thomas De Schampheleire wrote: On March 19, 2015 3:38:39 PM CET, Mads Kiilerich m...@kiilerich.com wrote: On 03/19/2015 03:00 PM, Jan Heylen wrote: # HG changeset patch # User Jan Heylen

Re: [PATCH 3 of 3] docs/installation: clarify root privileges requirement for 'pip install'

2015-03-16 Thread Thomas De Schampheleire
On March 16, 2015 6:28:05 PM CET, Andrew Shadura and...@shadura.me wrote: Hi, On 15 March 2015 at 14:06, Mads Kiilerich m...@kiilerich.com wrote: It really does work, it installs packages into ~/.local, which is useful if you just want to test things out, and if you do want to mix your system

Re: [PATCH] docs/installation: clarify and reorder alternative installation methods

2015-03-16 Thread Thomas De Schampheleire
On March 16, 2015 12:10:31 AM CET, Mads Kiilerich m...@kiilerich.com wrote: On 03/15/2015 10:11 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426453734 -3600 # Sun Mar 15 22:08:54 2015 +0100 # Node ID

Re: [PATCH] changelog: repeat pager links on top of changelog

2015-03-10 Thread Thomas De Schampheleire
On Tue, Mar 10, 2015 at 3:35 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/08/2015 10:20 AM, Thomas De Schampheleire wrote: On Sun, Mar 8, 2015 at 2:30 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/07/2015 08:50 PM, Thomas De Schampheleire wrote: On Fri, Mar 6, 2015 at 5:29 PM

Issue #106: UI: repository selector does not respect right-click or middle-click (conservancy/kallithea)

2015-03-10 Thread Thomas De Schampheleire
New issue 106: UI: repository selector does not respect right-click or middle-click https://bitbucket.org/conservancy/kallithea/issue/106/ui-repository-selector-does-not-respect Thomas De Schampheleire: In the repository selector in the main UI, one cannot right-click a repository link to open

Re: bug: 'unknown revision' when opening a pull request

2015-03-10 Thread Thomas De Schampheleire
Hi Mads, On Fri, Mar 6, 2015 at 4:05 PM, Mads Kiilerich m...@kiilerich.com wrote: On 03/03/2015 10:49 PM, Thomas De Schampheleire wrote: Hi Mads, As discussed on IRC, there is currently a bug in the pullrequest display code that can trigger for pullrequests between different repositories

[PATCH] ini file: clarify that beaker.session.key should be unique

2015-03-12 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426014041 -3600 # Tue Mar 10 20:00:41 2015 +0100 # Node ID 6b1790f954863fa61a32b0028b6cc1ef3add3683 # Parent 66d6dc56479bbe8c1fd5077b5705e2d6b9ee73db ini file: clarify that beaker.session.key should

pullrequest creation API

2015-03-12 Thread Thomas De Schampheleire
Hi, I would like to create a way to create a pull request programmatically, through an API call. At first sight, using the api_access=True method to create a callable web view is the easiest, since you could take in the request and pass it to the existing PullrequestsController:create() method.

Re: pullrequest creation API

2015-03-12 Thread Thomas De Schampheleire
Hi Mads, On Thu, Mar 12, 2015 at 3:08 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/11/2015 09:56 PM, Thomas De Schampheleire wrote: Hi, I would like to create a way to create a pull request programmatically, through an API call. You also asked for feedback on the related https

Re: [PATCH] date representation: use ISO8601 rather than a specific locale

2015-03-06 Thread Thomas De Schampheleire
On Thu, Feb 26, 2015 at 10:51 PM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1424987487 -3600 # Thu Feb 26 22:51:27 2015 +0100 # Node ID d80090d1053468f6b84eb8ef41c62446995ddb73

Re: [PATCH] date representation: use ISO8601 rather than a specific locale

2015-03-06 Thread Thomas De Schampheleire
On Fri, Mar 6, 2015 at 4:31 PM, Mads Kiilerich m...@kiilerich.com wrote: On 03/06/2015 02:03 PM, Thomas De Schampheleire wrote: On Thu, Feb 26, 2015 at 10:51 PM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire

Re: [PATCH] date representation: use ISO8601 rather than a specific locale

2015-03-06 Thread Thomas De Schampheleire
[..] diff --git a/kallithea/lib/helpers.py b/kallithea/lib/helpers.py --- a/kallithea/lib/helpers.py +++ b/kallithea/lib/helpers.py @@ -469,7 +469,7 @@ def fmt_date(date): if date: -_fmt = u%a, %d %b %Y %H:%M:%S.encode('utf8') Heh - making a const unicode string with

Re: [PATCH] date representation: use ISO8601 rather than a specific locale

2015-03-06 Thread Thomas De Schampheleire
On March 6, 2015 5:35:45 PM CET, Mads Kiilerich m...@kiilerich.com wrote: On 03/06/2015 05:29 PM, Thomas De Schampheleire wrote: [..] diff --git a/kallithea/lib/helpers.py b/kallithea/lib/helpers.py --- a/kallithea/lib/helpers.py +++ b/kallithea/lib/helpers.py @@ -469,7 +469,7 @@ def

Re: [PATCH] changelog: repeat pager links on top of changelog

2015-03-08 Thread Thomas De Schampheleire
On Sun, Mar 8, 2015 at 2:30 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/07/2015 08:50 PM, Thomas De Schampheleire wrote: On Fri, Mar 6, 2015 at 5:29 PM, Mads Kiilerich m...@kiilerich.com wrote: On 03/04/2015 10:06 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas

Re: [PATCH] changelog: repeat pager links on top of changelog

2015-03-08 Thread Thomas De Schampheleire
On Sun, Mar 8, 2015 at 4:20 AM, Nick Coghlan ncogh...@gmail.com wrote: On 8 March 2015 at 11:30, Mads Kiilerich m...@kiilerich.com wrote: On 03/07/2015 08:50 PM, Thomas De Schampheleire wrote: For example because he is trying to find something around a given revision number, and uses the first

Re: [PATCH] changelog: repeat pager links on top of changelog

2015-03-07 Thread Thomas De Schampheleire
On Fri, Mar 6, 2015 at 5:29 PM, Mads Kiilerich m...@kiilerich.com wrote: On 03/04/2015 10:06 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1425503195 -3600 # Wed Mar 04 22:06:35 2015 +0100 # Node ID

Re: ssh support

2015-03-07 Thread Thomas De Schampheleire
Hi Mike, On Sat, Mar 7, 2015 at 6:29 PM, Michael V. DePalatis m...@depalatis.net wrote: I have been wondering about ssh support in Kallithea. From what I can tell, at this point, there is no option either in the web admin interface or in the ini file to configure ssh clone URLs. I'm willing to

[PATCH 1 of 3] controllers: trivial typo fixes

2015-03-12 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426195197 -3600 # Thu Mar 12 22:19:57 2015 +0100 # Node ID 38ae235a0df6eaa497fe1d2d98d322bb3ba04623 # Parent cf8eab44c6ec583f7a0642b7274da30d15e3 controllers: trivial typo fixes diff --git

[PATCH 2 of 3] lib: trivial typo fixes

2015-03-12 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426190950 -3600 # Thu Mar 12 21:09:10 2015 +0100 # Node ID cf7a42169bc6ea366ca64a647b69dc5c2667df08 # Parent 38ae235a0df6eaa497fe1d2d98d322bb3ba04623 lib: trivial typo fixes diff --git a/kallithea

[PATCH 3 of 3] model: trivial typo fixes

2015-03-12 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1426194420 -3600 # Thu Mar 12 22:07:00 2015 +0100 # Node ID 475baaa473eb3ea0f4efe567cab0822f372f3b97 # Parent cf7a42169bc6ea366ca64a647b69dc5c2667df08 model: trivial typo fixes diff --git

Re: Invitation to adopt pytest month

2015-03-25 Thread Thomas De Schampheleire
On Wed, Mar 25, 2015 at 11:15 AM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: Hi, On Mon, Mar 23, 2015 at 10:35 AM, Nick Coghlan ncogh...@gmail.com wrote: On 20 Mar 2015 09:32, Mads Kiilerich m...@kiilerich.com wrote: On 03/19/2015 11:30 PM, Brianna Laugher wrote: Hello, I

Re: 1st try - no repos found

2015-03-25 Thread Thomas De Schampheleire
Hi Neal, On Wed, Mar 25, 2015 at 4:03 PM, Neal Becker ndbeck...@gmail.com wrote: installed 0.1 on fedora f21 into venv using instructions for install and setup. I chose for root /home/nbecker/sigproc.export which is a clone of a working hg repo, under my home dir. Kallithea is about

Re: 1st try - no repos found

2015-03-25 Thread Thomas De Schampheleire
Hi Neal, On Wed, Mar 25, 2015 at 4:53 PM, Neal Becker ndbeck...@gmail.com wrote: Thomas De Schampheleire wrote: [..] I'm running into a problem. I'm using hg-3.3.2, and I have a repo using obsolete markers. When I start kallithea, go to admin page, it says hg is 3.1.2. I can't figure out

Re: 1st try - no repos found

2015-03-25 Thread Thomas De Schampheleire
On Wed, Mar 25, 2015 at 6:16 PM, Neal Becker ndbeck...@gmail.com wrote: Thomas De Schampheleire wrote: Hi Neal, On Wed, Mar 25, 2015 at 4:53 PM, Neal Becker ndbeck...@gmail.com wrote: Thomas De Schampheleire wrote: [..] I'm running into a problem. I'm using hg-3.3.2, and I have a repo

Re: [PATCH 1 of 2] helpers: add automatic logging to Flash

2015-03-28 Thread Thomas De Schampheleire
On Sat, Mar 28, 2015 at 10:34 PM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427573281 -3600 # Sat Mar 28 21:08:01 2015 +0100 # Node ID 2f4d67b8acefc3e85ddb5c165bc4054b0ddab90d

[PATCH 2 of 2] controllers, lib: reduce log level of flashes

2015-03-28 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427577130 -3600 # Sat Mar 28 22:12:10 2015 +0100 # Node ID 039f3d14bdd3a07a9a071d3911b07ab2b06328b6 # Parent 2f4d67b8acefc3e85ddb5c165bc4054b0ddab90d controllers, lib: reduce log level of flashes

[PATCH 1 of 2] helpers: add automatic logging to Flash

2015-03-28 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427573281 -3600 # Sat Mar 28 21:08:01 2015 +0100 # Node ID 2f4d67b8acefc3e85ddb5c165bc4054b0ddab90d # Parent 65c5e70a1d0c1861d7dc835f204d132342920da2 helpers: add automatic logging to Flash Log all

Re: Invitation to adopt pytest month

2015-03-28 Thread Thomas De Schampheleire
On Sat, Mar 28, 2015 at 12:13 AM, Brianna Laugher brianna.laug...@gmail.com wrote: On 27 March 2015 at 20:27, Thomas De Schampheleire patrickdeping...@gmail.com wrote: That sounds great, thanks! In practice, how will this work? Well, I'm kind of making it up as I go, but I envisage something

[PATCH] base: add request time to footer

2015-03-31 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427813112 -7200 # Tue Mar 31 16:45:12 2015 +0200 # Node ID 66accc3fb9a93d6e704177c80ea7500f1a34f02b # Parent de5eaaad471f2c746a1b1fed0022a483284d243c base: add request time to footer Currently

Re: [PATCH] base: add request time to footer

2015-03-31 Thread Thomas De Schampheleire
On March 31, 2015 5:05:01 PM CEST, Mads Kiilerich m...@kiilerich.com wrote: On 03/31/2015 05:00 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427813112 -7200 # Tue Mar 31 16:45:12 2015 +0200 # Node ID

Re: [PATCH 1 of 2] helpers: add automatic logging to Flash

2015-03-29 Thread Thomas De Schampheleire
On Sun, Mar 29, 2015 at 4:50 AM, Mads Kiilerich m...@kiilerich.com wrote: On 03/28/2015 10:35 PM, Thomas De Schampheleire wrote: On Sat, Mar 28, 2015 at 10:34 PM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Thomas De Schampheleire

Re: Invitation to adopt pytest month

2015-03-29 Thread Thomas De Schampheleire
On Sun, Mar 29, 2015 at 3:51 PM, Mads Kiilerich m...@kiilerich.com wrote: On 03/28/2015 08:54 PM, Thomas De Schampheleire wrote: On Sat, Mar 28, 2015 at 12:13 AM, Brianna Laugher brianna.laug...@gmail.com wrote: Well, I'm kind of making it up as I go, but I envisage something like ยท initial

Kill RST

2015-03-02 Thread Thomas De Schampheleire
Hi, The subject should be non-ambiguous but let me add a little more body to it: currently comments and pull request descriptions are parsed as RST (restructured text). From my perspective (and that of several others) this is counterproductive and not necessary: - when typing a comment or PR

Re: Kill RST

2015-03-02 Thread Thomas De Schampheleire
On March 2, 2015 7:35:36 PM CET, Sean Farley sean.michael.far...@gmail.com wrote: Thomas De Schampheleire writes: Hi, The subject should be non-ambiguous but let me add a little more body to it: currently comments and pull request descriptions are parsed as RST (restructured text). From my

[PATCH 3 of 6] pullrequest overview: create overview from a function to allow re-use

2015-03-03 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1425415467 -3600 # Tue Mar 03 21:44:27 2015 +0100 # Node ID acea7f4e8c6bfefb8526ebe5b1b1ad7914c7ee5d # Parent a076460a649e0e6fd03a530512fbcd838fe52ee5 pullrequest overview: create overview from

[PATCH 1 of 6] pullrequest overview: display in table to improve readability

2015-03-03 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1425414784 -3600 # Tue Mar 03 21:33:04 2015 +0100 # Node ID c3adb366628c8e7a5cfa016801a7c2f44abc312b # Parent d80090d1053468f6b84eb8ef41c62446995ddb73 pullrequest overview: display in table

[PATCH] ini file: make cookie name unique

2015-03-04 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1425502595 -3600 # Wed Mar 04 21:56:35 2015 +0100 # Node ID d88fe779ac6cf324062c6a4bd8b5071c8de32c3f # Parent fc311d8c3997063a8c6020f4e8d32ca77be339e5 ini file: make cookie name unique When several

Re: [PATCH] middleware: use secure cookies over secure connections

2015-03-05 Thread Thomas De Schampheleire
Hi Andrew, On Thu, Mar 5, 2015 at 8:01 AM, Andrew Shadura and...@shadura.me wrote: Hello, On Thu, 05 Mar 2015 06:58:30 +0100 Thomas De Schampheleire patrickdeping...@gmail.com wrote: Then with this wrapper, can't we also change the cookie name to append the port, as an alternative to my

Re: [PATCH] middleware: use secure cookies over secure connections

2015-03-04 Thread Thomas De Schampheleire
On March 4, 2015 11:58:19 PM CET, Andrew Shadura and...@shadura.me wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1425509877 -3600 # Wed Mar 04 23:57:57 2015 +0100 # Node ID 6e0cecf00cdad2d108caca97c4cd9dece0333d73 # Parent 599fba9967a4981e8c401c39521a52635dd93380

Issue #105: comment handling / e-mail: link to specific comments only works when page is already loaded (conservancy/kallithea)

2015-03-04 Thread Thomas De Schampheleire
New issue 105: comment handling / e-mail: link to specific comments only works when page is already loaded https://bitbucket.org/conservancy/kallithea/issue/105/comment-handling-e-mail-link-to-specific Thomas De Schampheleire: Scenario: - receive a mail about a pull request comment - click

Re: Kill RST

2015-03-03 Thread Thomas De Schampheleire
On Tue, Mar 3, 2015 at 7:57 AM, Andrew Shadura and...@shadura.me wrote: Hello, On Mon, 02 Mar 2015 10:35:36 -0800 Sean Farley sean.michael.far...@gmail.com wrote: - the average user does not need the features RST provides. So as far as I'm concerned, RST can be removed entirely. The

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-23 Thread Thomas De Schampheleire
On Mon, Feb 23, 2015 at 3:57 PM, Mads Kiilerich m...@kiilerich.com wrote: On 02/22/2015 10:19 PM, Thomas De Schampheleire wrote: On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich m...@kiilerich.com wrote: On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: # HG changeset patch # User

[PATCH] templates: move site branding in page title to base template

2015-02-23 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424725898 -3600 # Mon Feb 23 22:11:38 2015 +0100 # Node ID 289eb91740c05785c239df947a41c8bbe351c067 # Parent 1619d9ebc1b9b40379c192ddb45e5802ecfb8f2b templates: move site branding in page

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-23 Thread Thomas De Schampheleire
On Mon, Feb 23, 2015 at 4:21 PM, Mads Kiilerich m...@kiilerich.com wrote: [..] Yes. Pages working in the context of a repo (and usually a changeset/branch) is so common and important that I think it makes sense to have extra support and convenience functions for that. It would perhaps be

[PATCH 4 of 5 v2] my pullrequests: line up controller/template handling with repo pullrequests

2015-02-24 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424554186 -3600 # Sat Feb 21 22:29:46 2015 +0100 # Node ID 2490789dd26d56d501793516ce32e0df30efa236 # Parent 35d2e797a6884547065c88d5b671f29aff2c5773 my pullrequests: line up controller

[PATCH 0 of 5 v2] (my) pullrequest overview: line-up and sanitize style (+misc changes)

2015-02-24 Thread Thomas De Schampheleire
Hi, This patch series is a first step in improving the pull request overviews (both 'my' and 'repo' overviews). The next step is to improve the way data is displayed: - use a fixed order of fields for each PR (curiously enough, on the 'my pullrequests' page, the order of fields is different

[PATCH 1 of 5 v2] giticon.png: use repotag class to make an icon

2015-02-24 Thread Thomas De Schampheleire
# HG changeset patch # User Sean Farley sean.michael.far...@gmail.com # Date 1424214154 28800 # Tue Feb 17 15:02:34 2015 -0800 # Node ID 1619d9ebc1b9b40379c192ddb45e5802ecfb8f2b # Parent 0cb4a35d8248c8dd94027539dbc1e463d491c403 giticon.png: use repotag class to make an icon A quick search

[PATCH 2 of 5 v2] controllers: don't pass rendered templates in context variables

2015-02-24 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424552694 -3600 # Sat Feb 21 22:04:54 2015 +0100 # Node ID fe50f1415d66f5be1cc05cca0b103d3a502fe6af # Parent 1619d9ebc1b9b40379c192ddb45e5802ecfb8f2b controllers: don't pass rendered

Re: [PATCH 1 of 5 v2] giticon.png: use repotag class to make an icon

2015-02-24 Thread Thomas De Schampheleire
On Tue, Feb 24, 2015 at 10:36 PM, Thomas De Schampheleire patrickdeping...@gmail.com wrote: # HG changeset patch # User Sean Farley sean.michael.far...@gmail.com # Date 1424214154 28800 # Tue Feb 17 15:02:34 2015 -0800 # Node ID 1619d9ebc1b9b40379c192ddb45e5802ecfb8f2b # Parent

About patches on the mailing list vs bitbucket pull requests

2015-02-24 Thread Thomas De Schampheleire
Hi, As you noticed I have been sending patches to the mailing list lately, rather than opening bitbucket pullrequests. I find the feedback/discussion more easy on such e-mailed patches. However, the biggest downside is that it is difficult to see which patches are still to be applied/discussed.

[PATCH 5 of 5 v2] templates: changelog_summary: remove non-existing CSS class table_disp

2015-02-24 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424812656 -3600 # Tue Feb 24 22:17:36 2015 +0100 # Node ID c7f97c237dacbed8770d4aacf20feb8175ee8d99 # Parent 2490789dd26d56d501793516ce32e0df30efa236 templates: changelog_summary: remove

Re: [PATCH] docs: improve issue tracker integration docs

2015-02-25 Thread Thomas De Schampheleire
Hi Andrew, On Wed, Feb 25, 2015 at 2:06 PM, Andrew Shadura and...@shadura.me wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1424869587 -3600 # Wed Feb 25 14:06:27 2015 +0100 # Node ID 5b85679c832b1de3471ed3c62a555d22cbad0c33 # Parent

Re: [PATCH] templates: centre the feed icon vertially in the public journal

2015-02-25 Thread Thomas De Schampheleire
On Wed, Feb 25, 2015 at 12:43 PM, Andrew Shadura and...@shadura.me wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1424864441 -3600 # Wed Feb 25 12:40:41 2015 +0100 # Node ID 54ca0422017d790f16135b4da347850c68458c55 # Parent

Re: templates and controllers

2015-02-22 Thread Thomas De Schampheleire
On Sun, Feb 22, 2015 at 4:56 PM, Mads Kiilerich m...@kiilerich.com wrote: On 02/21/2015 09:35 PM, Thomas De Schampheleire wrote: On Tue, Feb 17, 2015 at 4:26 AM, Mads Kiilerich m...@kiilerich.com wrote: On 02/15/2015 09:45 PM, Thomas De Schampheleire wrote: A quick search reveils

Re: [PATCH] my pull requests: fix page title when no site branding is set

2015-02-22 Thread Thomas De Schampheleire
On Sun, Feb 22, 2015 at 4:44 PM, Mads Kiilerich m...@kiilerich.com wrote: On 02/21/2015 08:48 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1423170039 -3600 # Thu Feb 05 22:00:39 2015 +0100

[PATCH 2 of 3] pullrequest overview: sanitize display style

2015-02-21 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424555122 -3600 # Sat Feb 21 22:45:22 2015 +0100 # Node ID 0728fc3662d27756523ae0d03b91caffb1587ad9 # Parent ddadf072c99554bfb9d174664148f77d453912fc pullrequest overview: sanitize display

[PATCH 3 of 3] my pullrequests: line up internal handling with repository pullrequests

2015-02-21 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424554186 -3600 # Sat Feb 21 22:29:46 2015 +0100 # Node ID 8ed5da3e4184defac92036cd8f19aa7cb61ba0fb # Parent 0728fc3662d27756523ae0d03b91caffb1587ad9 my pullrequests: line up internal

Re: [PATCH 0 of 1] Bad input handling: discussion

2015-02-26 Thread Thomas De Schampheleire
On Thu, Feb 26, 2015 at 4:50 PM, Andrew Shadura and...@shadura.me wrote: In [1], Mads and I had a discussion on what to do with bad input we may sometimes receive. My idea is that we should use everything we know how to handle and ignore what we can't. Mads, if I understood him correctly,

Issue #104: redirects for logins should remember GET arguments (conservancy/kallithea)

2015-02-26 Thread Thomas De Schampheleire
New issue 104: redirects for logins should remember GET arguments https://bitbucket.org/conservancy/kallithea/issue/104/redirects-for-logins-should-remember-get Thomas De Schampheleire: Scenario: - logout - go to changelog of a repository - select a particular revision and click 'create a pull

[PATCH] date representation: use ISO8601 rather than a specific locale

2015-02-26 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1424987487 -3600 # Thu Feb 26 22:51:27 2015 +0100 # Node ID d80090d1053468f6b84eb8ef41c62446995ddb73 # Parent c7f97c237dacbed8770d4aacf20feb8175ee8d99 date representation: use ISO8601 rather than

Issue #101: UI: consistent font sizes (conservancy/kallithea)

2015-02-20 Thread Thomas De Schampheleire
New issue 101: UI: consistent font sizes https://bitbucket.org/conservancy/kallithea/issue/101/ui-consistent-font-sizes Thomas De Schampheleire: Kallithea is using a large mix of font sizes, big and small, inconsistently. At least, I don't understand the logic. Examples of illogical font sizes

[PATCH 1 of 2 RFC] tests: move helper commit_change from compare test to fixture

2015-02-21 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de_schamphele...@alcatel-lucent.com # Date 1424291941 -3600 # Wed Feb 18 21:39:01 2015 +0100 # Node ID 50af637aabb506a6afeb44940e1ac498cce8311a # Parent c9bfc0bc10dc8a36403a2c4d8b8ec81c930b6547 tests: move helper commit_change from

Re: [PATCH 0 of 5 v2] (my) pullrequest overview: line-up and sanitize style (+misc changes)

2015-02-26 Thread Thomas De Schampheleire
On Tue, Feb 24, 2015 at 11:07 PM, Mads Kiilerich m...@kiilerich.com wrote: Thomas, I pushed all your pending changes (I hope) ... except this updated patch set that I will put in test for a couple of days. Thanks a lot for all the high quality contributions! I forgot to thank you for the

Re: Invitation to adopt pytest month

2015-03-27 Thread Thomas De Schampheleire
Hi Brianna, On Fri, Mar 27, 2015 at 7:55 PM, Brianna Laugher brianna.laug...@gmail.com wrote: OK well... as both you (Nick) and Thomas can help a bit from Kallithea's side, I think we can try and see how we go. I have set 3 pytesters (with a variety of experience) to assist with Kallithea (as

[PATCH 1 of 5] auth: do not redirect to login page on invalid API key

2015-03-25 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427269791 -3600 # Wed Mar 25 08:49:51 2015 +0100 # Node ID c5828585502f1a061f162abe8cbd181c17039843 # Parent 6017996e4dcfda0f5623498a45c51bb184eb67bb auth: do not redirect to login page on invalid

[PATCH 2 of 5] auth: return early in LoginRequired on invalid IP

2015-03-25 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427271075 -3600 # Wed Mar 25 09:11:15 2015 +0100 # Node ID 43b0bc9088d3eedacf7610ffbf2f4b429ae98c45 # Parent c5828585502f1a061f162abe8cbd181c17039843 auth: return early in LoginRequired on invalid

[PATCH 4 of 5] auth: simplify logging of regular authentication in LoginRequired

2015-03-25 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427274714 -3600 # Wed Mar 25 10:11:54 2015 +0100 # Node ID e1a755428e3abd3d011c7c033233272dadb34572 # Parent 32ced9e32b506c7441339f67da3c4237de0e6fa3 auth: simplify logging of regular authentication

[PATCH 3 of 5] auth: return early in LoginRequired on API key validation

2015-03-25 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427274589 -3600 # Wed Mar 25 10:09:49 2015 +0100 # Node ID 32ced9e32b506c7441339f67da3c4237de0e6fa3 # Parent 43b0bc9088d3eedacf7610ffbf2f4b429ae98c45 auth: return early in LoginRequired on API key

[PATCH 5 of 5] auth: fix tests after changing API key handling

2015-03-25 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1427279629 -3600 # Wed Mar 25 11:33:49 2015 +0100 # Node ID eaeea9ea95b036e8d5eaac16aea1e6c8c62868c9 # Parent e1a755428e3abd3d011c7c033233272dadb34572 auth: fix tests after changing API key handling

[PATCH] pullrequest overview: fix 'my pullrequests' overview

2015-04-21 Thread Thomas De Schampheleire
# HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429599924 -7200 # Tue Apr 21 09:05:24 2015 +0200 # Branch stable # Node ID 2f8b21e9b783429c9535583f11169c1d0c7bb44a # Parent bd4f453a00553ed0ea3016596621106293acbf7d pullrequest overview: fix 'my

Re: [PATCH] css: make 'add comment' button look more like a button

2015-04-21 Thread Thomas De Schampheleire
On April 21, 2015 7:36:24 PM CEST, Andrew Shadura and...@shadura.me wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429637769 -7200 # Tue Apr 21 19:36:09 2015 +0200 # Node ID fe9a1f5d259c186b7d9cd0c3e10aa99217a37fed # Parent

Re: [PATCH 2 of 2] css: add text +/- markers to the diff to improve readability for colour blind (fixes #77)

2015-04-23 Thread Thomas De Schampheleire
On Thu, Apr 23, 2015 at 4:56 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/22/2015 02:20 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura and...@shadura.me # Date 1429705229 -7200 # Wed Apr 22 14:20:29 2015 +0200 # Branch stable # Node ID

Re: [PATCH PoC] hacks: the concept of python files that will be loaded and can monkeypatch Kallithea internals

2015-04-23 Thread Thomas De Schampheleire
On Mon, Apr 20, 2015 at 11:28 PM, Mads Kiilerich m...@kiilerich.com wrote: # HG changeset patch # User Mads Kiilerich mad...@unity3d.com # Date 1429565291 -7200 # Mon Apr 20 23:28:11 2015 +0200 # Node ID fcfd593347c8240544996f5516113595c0ff390a # Parent

Re: [PATCH PoC] hacks: the concept of python files that will be loaded and can monkeypatch Kallithea internals

2015-04-24 Thread Thomas De Schampheleire
On Thu, Apr 23, 2015 at 10:28 PM, Mads Kiilerich m...@kiilerich.com wrote: On 04/23/2015 10:00 PM, Thomas De Schampheleire wrote: On Mon, Apr 20, 2015 at 11:28 PM, Mads Kiilerich m...@kiilerich.com wrote: # HG changeset patch # User Mads Kiilerich mad...@unity3d.com # Date 1429565291 -7200

Re: [PATCH PoC] hacks: the concept of python files that will be loaded and can monkeypatch Kallithea internals

2015-04-21 Thread Thomas De Schampheleire
On Mon, Apr 20, 2015 at 11:28 PM, Mads Kiilerich m...@kiilerich.com wrote: # HG changeset patch # User Mads Kiilerich mad...@unity3d.com # Date 1429565291 -7200 # Mon Apr 20 23:28:11 2015 +0200 # Node ID fcfd593347c8240544996f5516113595c0ff390a # Parent

Re: [PATCH] comments: avoid confusing 'No comments' on empty general comments

2015-04-19 Thread Thomas De Schampheleire
On Sun, Apr 19, 2015 at 12:37 AM, Mads Kiilerich m...@kiilerich.com wrote: On 04/18/2015 04:12 PM, Thomas De Schampheleire wrote: # HG changeset patch # User Thomas De Schampheleire thomas.de.schamphele...@gmail.com # Date 1429294302 -7200 # Fri Apr 17 20:11:42 2015 +0200 # Node ID

  1   2   3   4   5   6   7   >