[ I haven't seen David's patch but maybe this was a merge problem? -dan ] tree: https://github.com/dsahern/linux 5.1-next-v6-refactor head: 0293742ba53011833a9a1fc9f596a89f595e3c55 commit: 4a35ef611a939c3047937c58d935021ab08788ce [5/13] ipv6: Pass fib6_result to ip6_create_rt_rcu
New smatch warnings: net/ipv6/route.c:1063 ip6_create_rt_rcu() error: uninitialized symbol 'dev'. Old smatch warnings: net/ipv6/route.c:2838 ip6_route_check_nh() error: we previously assumed '_dev' could be null (see line 2808) net/ipv6/route.c:4487 ip6_route_multipath_add() error: we previously assumed 'cfg->fc_nlinfo.nlh' could be null (see line 4389) # https://github.com/dsahern/linux/commit/4a35ef611a939c3047937c58d935021ab08788ce git remote add dsahern-linux https://github.com/dsahern/linux git remote update dsahern-linux git checkout 4a35ef611a939c3047937c58d935021ab08788ce vim +/dev +1063 net/ipv6/route.c d3843fe5 Wei Wang 2017-10-06 1039 dec9b0e2 David Ahern 2018-04-17 1040 /* called with rcu_lock held */ 4a35ef61 David Ahern 2019-04-13 1041 static struct rt6_info *ip6_create_rt_rcu(const struct fib6_result *res) dec9b0e2 David Ahern 2018-04-17 1042 { 4a35ef61 David Ahern 2019-04-13 1043 struct fib6_info *f6i = res->f6i; 4a35ef61 David Ahern 2019-04-13 1044 struct net_device *dev; ^^^ 4a35ef61 David Ahern 2019-04-13 1045 unsigned short flags; dec9b0e2 David Ahern 2018-04-17 1046 struct rt6_info *nrt; dec9b0e2 David Ahern 2018-04-17 1047 4a35ef61 David Ahern 2019-04-13 1048 if (!fib6_info_hold_safe(f6i)) 1c87e79a Xin Long 2019-03-20 1049 goto fallback; ^^^^^^^^^^^^^^ e873e4b9 Wei Wang 2018-07-21 1050 4a35ef61 David Ahern 2019-04-13 1051 flags = fib6_info_dst_flags(f6i); 4a35ef61 David Ahern 2019-04-13 1052 dev = res->nh->fib_nh_dev; 93531c67 David Ahern 2018-04-17 1053 nrt = ip6_dst_alloc(dev_net(dev), dev, flags); 1c87e79a Xin Long 2019-03-20 1054 if (!nrt) { 4a35ef61 David Ahern 2019-04-13 1055 fib6_info_release(f6i); 1c87e79a Xin Long 2019-03-20 1056 goto fallback; 1c87e79a Xin Long 2019-03-20 1057 } 1c87e79a Xin Long 2019-03-20 1058 4a35ef61 David Ahern 2019-04-13 1059 ip6_rt_copy_init(nrt, f6i); 1c87e79a Xin Long 2019-03-20 1060 return nrt; dec9b0e2 David Ahern 2018-04-17 1061 1c87e79a Xin Long 2019-03-20 1062 fallback: 1c87e79a Xin Long 2019-03-20 @1063 nrt = dev_net(dev)->ipv6.ip6_null_entry; ^^^ 1c87e79a Xin Long 2019-03-20 1064 dst_hold(&nrt->dst); dec9b0e2 David Ahern 2018-04-17 1065 return nrt; dec9b0e2 David Ahern 2018-04-17 1066 } dec9b0e2 David Ahern 2018-04-17 1067 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild
