[kbuild] [nfc-next:master 16/19] drivers/nfc/nfcmrvl/main.c:100 nfcmrvl_nci_register_dev() warn: possible memory leak of 'priv'
TO: Amitkumar Karwar akar...@marvell.com
CC: Samuel Ortiz sa...@linux.intel.com
CC: Bing Zhao bz...@marvell.com
Hi Amitkumar,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git master
head: b711ad524bf5a6a078c4d0a1a44ca1db204802f6
commit: f26e30cc6b50ba81e30ca3016c29ad4b48b93eaa [16/19] NFC: nfcmrvl: Initial
commit for Marvell NFC driver
:: branch date: 62 minutes ago
:: commit date: 18 hours ago
drivers/nfc/nfcmrvl/main.c:100 nfcmrvl_nci_register_dev() warn: possible memory
leak of 'priv'
git remote add nfc-next
git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-next.git
git remote update nfc-next
git checkout f26e30cc6b50ba81e30ca3016c29ad4b48b93eaa
vim +/priv +100 drivers/nfc/nfcmrvl/main.c
f26e30cc Amitkumar Karwar 2014-01-06 84 if (!priv)
f26e30cc Amitkumar Karwar 2014-01-06 85 return ERR_PTR(-ENOMEM);
f26e30cc Amitkumar Karwar 2014-01-06 86
f26e30cc Amitkumar Karwar 2014-01-06 87 priv-drv_data = drv_data;
f26e30cc Amitkumar Karwar 2014-01-06 88 priv-if_ops = ops;
f26e30cc Amitkumar Karwar 2014-01-06 89 priv-dev = dev;
f26e30cc Amitkumar Karwar 2014-01-06 90
f26e30cc Amitkumar Karwar 2014-01-06 91 protocols = NFC_PROTO_JEWEL_MASK
f26e30cc Amitkumar Karwar 2014-01-06 92 | NFC_PROTO_MIFARE_MASK
| NFC_PROTO_FELICA_MASK
f26e30cc Amitkumar Karwar 2014-01-06 93 |
NFC_PROTO_ISO14443_MASK
f26e30cc Amitkumar Karwar 2014-01-06 94 |
NFC_PROTO_ISO14443_B_MASK
f26e30cc Amitkumar Karwar 2014-01-06 95 |
NFC_PROTO_NFC_DEP_MASK;
f26e30cc Amitkumar Karwar 2014-01-06 96
f26e30cc Amitkumar Karwar 2014-01-06 97 priv-ndev =
nci_allocate_device(nfcmrvl_nci_ops, protocols, 0, 0);
f26e30cc Amitkumar Karwar 2014-01-06 98 if (!priv-ndev) {
f26e30cc Amitkumar Karwar 2014-01-06 99 nfc_err(dev,
nci_allocate_device failed);
f26e30cc Amitkumar Karwar 2014-01-06 @100 return ERR_PTR(-ENOMEM);
f26e30cc Amitkumar Karwar 2014-01-06 101 }
f26e30cc Amitkumar Karwar 2014-01-06 102
f26e30cc Amitkumar Karwar 2014-01-06 103 nci_set_drvdata(priv-ndev,
priv);
f26e30cc Amitkumar Karwar 2014-01-06 104
f26e30cc Amitkumar Karwar 2014-01-06 105 rc =
nci_register_device(priv-ndev);
f26e30cc Amitkumar Karwar 2014-01-06 106 if (rc) {
f26e30cc Amitkumar Karwar 2014-01-06 107 nfc_err(dev,
nci_register_device failed %d, rc);
f26e30cc Amitkumar Karwar 2014-01-06 108
nci_free_device(priv-ndev);
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
___
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
[kbuild] [mmc:mmc-next 35/36] drivers/mmc/host/sh_mmcif.c:824 sh_mmcif_set_cmd() error: we previously assumed 'data' could be null (see line 789)
Hi Laurent,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git mmc-next
head: 259245a845a173124bfe768fa1a2ac88e034b5b8
commit: 0111fc4646a6e84a432dda3e6398a8a69319e617 [35/36] mmc: sh_mmcif: Enable
driver compilation with COMPILE_TEST
drivers/mmc/host/sh_mmcif.c:824 sh_mmcif_set_cmd() error: we previously assumed
'data' could be null (see line 789)
drivers/mmc/host/sh_mmcif.c:1124 sh_mmcif_end_cmd() error: we previously
assumed 'host-chan_rx' could be null (see line 1107)
drivers/mmc/host/sh_mmcif.c:1128 sh_mmcif_end_cmd() error: we previously
assumed 'host-chan_tx' could be null (see line 1110)
git remote add mmc git://git.kernel.org/pub/scm/linux/kernel/git/cjb/mmc.git
git remote update mmc
git checkout 0111fc4646a6e84a432dda3e6398a8a69319e617
vim +/data +824 drivers/mmc/host/sh_mmcif.c
fdc50a94 Yusuke Goda 2010-05-26 783 case MMC_CLR_WRITE_PROT:
fdc50a94 Yusuke Goda 2010-05-26 784 case MMC_ERASE:
fdc50a94 Yusuke Goda 2010-05-26 785 tmp |=
CMD_SET_RBSY;
fdc50a94 Yusuke Goda 2010-05-26 786 break;
fdc50a94 Yusuke Goda 2010-05-26 787 }
fdc50a94 Yusuke Goda 2010-05-26 788 /* WDAT / DATW */
69983404 Guennadi Liakhovetski 2011-12-26 @789 if (data) {
fdc50a94 Yusuke Goda 2010-05-26 790 tmp |=
CMD_SET_WDAT;
fdc50a94 Yusuke Goda 2010-05-26 791 switch
(host-bus_width) {
fdc50a94 Yusuke Goda 2010-05-26 792 case
MMC_BUS_WIDTH_1:
fdc50a94 Yusuke Goda 2010-05-26 793 tmp |=
CMD_SET_DATW_1;
fdc50a94 Yusuke Goda 2010-05-26 794 break;
fdc50a94 Yusuke Goda 2010-05-26 795 case
MMC_BUS_WIDTH_4:
fdc50a94 Yusuke Goda 2010-05-26 796 tmp |=
CMD_SET_DATW_4;
fdc50a94 Yusuke Goda 2010-05-26 797 break;
fdc50a94 Yusuke Goda 2010-05-26 798 case
MMC_BUS_WIDTH_8:
fdc50a94 Yusuke Goda 2010-05-26 799 tmp |=
CMD_SET_DATW_8;
fdc50a94 Yusuke Goda 2010-05-26 800 break;
fdc50a94 Yusuke Goda 2010-05-26 801 default:
e47bf32a Guennadi Liakhovetski 2010-11-24 802
dev_err(host-pd-dev, Unsupported bus width.\n);
fdc50a94 Yusuke Goda 2010-05-26 803 break;
fdc50a94 Yusuke Goda 2010-05-26 804 }
555061f9 Teppei Kamijou2012-12-12 805 switch
(host-timing) {
555061f9 Teppei Kamijou2012-12-12 806 case
MMC_TIMING_UHS_DDR50:
555061f9 Teppei Kamijou2012-12-12 807 /*
555061f9 Teppei Kamijou2012-12-12 808 * MMC
core will only set this timing, if the host
555061f9 Teppei Kamijou2012-12-12 809 *
advertises the MMC_CAP_UHS_DDR50 capability. MMCIF
555061f9 Teppei Kamijou2012-12-12 810 *
implementations with this capability, e.g. sh73a0,
555061f9 Teppei Kamijou2012-12-12 811 * will
have to set it in their platform data.
555061f9 Teppei Kamijou2012-12-12 812 */
555061f9 Teppei Kamijou2012-12-12 813 tmp |=
CMD_SET_DARS;
555061f9 Teppei Kamijou2012-12-12 814 break;
555061f9 Teppei Kamijou2012-12-12 815 }
fdc50a94 Yusuke Goda 2010-05-26 816 }
fdc50a94 Yusuke Goda 2010-05-26 817 /* DWEN */
fdc50a94 Yusuke Goda 2010-05-26 818 if (opc ==
MMC_WRITE_BLOCK || opc == MMC_WRITE_MULTIPLE_BLOCK)
fdc50a94 Yusuke Goda 2010-05-26 819 tmp |=
CMD_SET_DWEN;
fdc50a94 Yusuke Goda 2010-05-26 820 /* CMLTE/CMD12EN */
fdc50a94 Yusuke Goda 2010-05-26 821 if (opc ==
MMC_READ_MULTIPLE_BLOCK || opc == MMC_WRITE_MULTIPLE_BLOCK) {
fdc50a94 Yusuke Goda 2010-05-26 822 tmp |=
CMD_SET_CMLTE | CMD_SET_CMD12EN;
fdc50a94 Yusuke Goda 2010-05-26 823
sh_mmcif_bitset(host, MMCIF_CE_BLOCK_SET,
69983404 Guennadi Liakhovetski 2011-12-26 @824
data-blocks 16);
fdc50a94 Yusuke Goda 2010-05-26 825 }
fdc50a94 Yusuke Goda 2010-05-26 826 /* RIDXC[1:0] check
bits */
fdc50a94 Yusuke Goda 2010-05-26 827 if (opc ==
MMC_SEND_OP_COND || opc == MMC_ALL_SEND_CID ||
---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild
