Re: [kbuild] [staging:staging-next 124/151] drivers/staging/bcm/Bcmchar.c:816 bcm_char_ioctl_buffer_download_start() warn: inconsistent returns sem:Adapter-NVMRdmWrmLock: locked (798 [(-16)]) unlock

2014-02-14 Thread Dan Carpenter
Not really new. This code won't move out of staging until these are fixed. regards, dan carpenter On Fri, Feb 14, 2014 at 10:54:35AM +0800, kbuild test robot wrote: TO: Dave Jones da...@redhat.com CC: Greg Kroah-Hartman gre...@linuxfoundation.org Hi Dave, FYI, there are new smatch

[kbuild] [net-next:master 96/108] net/tipc/node.c:258 tipc_node_detach_link() error: buffer overflow 'n_ptr-links' 2 = 2

2014-02-14 Thread Dan Carpenter
This is a style question and not a real bug: Which is better: OPTION #1: ignore static checker warnings for (i = 0; i ARRAY_SIZE(x); i++) { if (found) break; } x[i] = 0; OPTION #2: stop on the last element for (i = 0; i

[kbuild] [net-next:master 98/108] net/tipc/link.c:2616 tipc_link_cmd_reset_stats() warn: inconsistent returns spin_lock:node-lock: locked (2611 [s32min-s32max], 2616 [s32min-s32max]) unlocked (2592

2014-02-14 Thread Dan Carpenter
The real bug is that bottom_half is unbalanced because we lock with spin_lock(node-lock) but tipc_node_unlock() which calls spin_unlock_bh(). regards, dan carpenter --- Hi Jon, FYI, there are new smatch warnings show up in tree: