[kbuild] [omap-dss2:for-next 16/27] drivers/video/fbdev/s3fb.c:1406 s3_pci_remove() warn: variable dereferenced before check 'info' (see line 1404)

2014-03-03 Thread kbuild test robot
TO: Tomi Valkeinen tomi.valkei...@ti.com


Hi Tomi,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git for-next
head:   2b04f21e69a186f645dc543aa3c90a72ffb946a0
commit: 08667731d1d4105296ee760eb2b8b6ca162bb0f8 [16/27] video: move fbdev to 
drivers/video/fbdev
config: make ARCH=i386 allyesconfig
:: branch date: 74 minutes ago
:: commit date: 3 days ago

All warnings:

   drivers/video/fbdev/vt8623fb.c: In function 'vt8623_pci_probe':
 drivers/video/fbdev/vt8623fb.c:734:23: warning: cast to pointer from integer 
 of different size [-Wint-to-pointer-cast]
 par-state.vgabase = (void __iomem *) vga_res.start;
  ^
--
   drivers/video/fbdev/s3fb.c: In function 's3_pci_probe':
 drivers/video/fbdev/s3fb.c:1185:23: warning: cast to pointer from integer of 
 different size [-Wint-to-pointer-cast]
 par-state.vgabase = (void __iomem *) vga_res.start;
  ^
--
   drivers/video/fbdev/arkfb.c: In function 'ark_pci_probe':
 drivers/video/fbdev/arkfb.c:1019:23: warning: cast to pointer from integer 
 of different size [-Wint-to-pointer-cast]
 par-state.vgabase = (void __iomem *) vga_res.start;
  ^
drivers/video/fbdev/s3fb.c:1406 s3_pci_remove() warn: variable dereferenced 
before check 'info' (see line 1404)
drivers/video/fbdev/arkfb.c:454 ics5342_init() warn: struct type mismatch 
'dac_info vs ics5342_info'
drivers/video/fbdev/hgafb.c:420 hgafb_pan_display() warn: unsigned 
'var-yoffset' is never less than zero.
drivers/video/fbdev/udlfb.c:1498 dlfb_select_std_channel() error: doing dma on 
the stack (set_def_chn)
drivers/video/fbdev/uvesafb.c:1509 uvesafb_init_info() error: we previously 
assumed 'mode' could be null (see line 1477)
drivers/video/fbdev/uvesafb.c:1815 uvesafb_remove() warn: variable dereferenced 
before check 'par' (see line 1810)
drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:248 mb86290fb_imageblit() error: 
no modifiers for allocation.
drivers/video/fbdev/matrox/matroxfb_base.c:1974 matroxfb_register_device() 
error: we previously assumed 'drv' could be null (see line 1975)
drivers/video/fbdev/matrox/matroxfb_base.c:2032 matroxfb_probe() warn: 
returning -1 instead of -ENOMEM is sloppy
drivers/video/fbdev/riva/fbdev.c:1120 rivafb_check_var() warn: missing break? 
reassigning 'var-green.length'
drivers/video/fbdev/matrox/matroxfb_Ti3026.c:375 Ti3026_init() error: 
__builtin_memcpy() 'MGADACbpp32' too small (21 vs 80)
drivers/video/fbdev/sis/sis_main.c:1576 sisfb_check_var() warn: unsigned 
'var-xoffset' is never less than zero.
drivers/video/fbdev/sis/sis_main.c:1577 sisfb_check_var() warn: unsigned 
'var-yoffset' is never less than zero.
drivers/video/fbdev/sis/sis_main.c:4433 sisfb_post_sis300() error: we 
previously assumed 'bios' could be null (see line 4418)
drivers/video/fbdev/sis/sis_main.c:4809 sisfb_post_xgi_ramsize() error: buffer 
overflow 'dramsr13_4' 20 = 59
drivers/video/fbdev/sis/sis_main.c:4814 sisfb_post_xgi_ramsize() error: buffer 
overflow 'dramsr13_4' 20 = 58
drivers/video/fbdev/via/viafbdev.c:866 viafb_cursor() error: buffer overflow 
'cr_data-bak' 2048 = 2048
drivers/video/fbdev/via/viafbdev.c:872 viafb_cursor() error: buffer overflow 
'cr_data-bak' 2048 = 2048
drivers/video/fbdev/via/viafbdev.c:873 viafb_cursor() error: buffer overflow 
'cr_data-bak' 2048 = 2049
drivers/video/fbdev/via/viafbdev.c:874 viafb_cursor() error: buffer overflow 
'cr_data-bak' 2048 = 2050
drivers/video/fbdev/sis/init.c:656 SiS_GetModeID_LCD() warn: missing break? 
reassigning 'ModeIndex'
drivers/video/fbdev/sis/init.c:996 SiSRegInit() warn: the 'SIS_CRT2_PORT_04' 
macro might need parens
drivers/video/fbdev/sis/init.c:997 SiSRegInit() warn: the 'SIS_CRT2_PORT_10' 
macro might need parens
drivers/video/fbdev/sis/init.c:998 SiSRegInit() warn: the 'SIS_CRT2_PORT_12' 
macro might need parens
drivers/video/fbdev/sis/init.c:999 SiSRegInit() warn: the 'SIS_CRT2_PORT_14' 
macro might need parens
drivers/video/fbdev/sis/init.c:1000 SiSRegInit() warn: the 'SIS_CRT2_PORT_14' 
macro might need parens
drivers/video/fbdev/sis/init.c:1002 SiSRegInit() warn: the 'SIS_VIDEO_CAPTURE' 
macro might need parens
drivers/video/fbdev/sis/init.c:1003 SiSRegInit() warn: the 'SIS_VIDEO_PLAYBACK' 
macro might need parens
drivers/video/fbdev/aty/radeon_base.c:1091 radeon_setcolreg() error: buffer 
overflow 'rinfo-palette' 256 = 510
drivers/video/fbdev/matrox/matroxfb_crtc2.c:440 matroxfb_dh_ioctl() warn: check 
that 'vblank.hcount' doesn't leak information
drivers/video/fbdev/aty/aty128fb.c:2279 aty128fb_setcolreg() error: buffer 
overflow 'par-green' 64 = 255
drivers/video/fbdev/aty/aty128fb.c:2286 aty128fb_setcolreg() error: buffer 
overflow 'par-red' 32 = 127
drivers/video/fbdev/aty/aty128fb.c:2287 aty128fb_setcolreg() error: buffer 
overflow 'par-blue' 32 = 127
drivers/video/fbdev/cyber2000fb.c:344 cyber2000fb_setcolreg() error: buffer 
overflow 'cfb-palette' 256 = 504

git 

Re: [kbuild] [omap-dss2:for-next 16/27] drivers/video/fbdev/s3fb.c:1406 s3_pci_remove() warn: variable dereferenced before check 'info' (see line 1404)

2014-03-03 Thread Dan Carpenter
This commit is very old 2011-04-20.

regards,
dan carpenter

On Mon, Mar 03, 2014 at 05:39:52PM +0800, kbuild test robot wrote:
 TO: Tomi Valkeinen tomi.valkei...@ti.com
 
 
 Hi Tomi,
 
 FYI, there are new smatch warnings show up in
 
 tree:   git://git.kernel.org/pub/scm/linux/kernel/git/tomba/linux.git for-next
 head:   2b04f21e69a186f645dc543aa3c90a72ffb946a0
 commit: 08667731d1d4105296ee760eb2b8b6ca162bb0f8 [16/27] video: move fbdev to 
 drivers/video/fbdev
 config: make ARCH=i386 allyesconfig
 :: branch date: 74 minutes ago
 :: commit date: 3 days ago
 
 All warnings:
 
drivers/video/fbdev/vt8623fb.c: In function 'vt8623_pci_probe':
  drivers/video/fbdev/vt8623fb.c:734:23: warning: cast to pointer from 
  integer of different size [-Wint-to-pointer-cast]
  par-state.vgabase = (void __iomem *) vga_res.start;
   ^
 --
drivers/video/fbdev/s3fb.c: In function 's3_pci_probe':
  drivers/video/fbdev/s3fb.c:1185:23: warning: cast to pointer from integer 
  of different size [-Wint-to-pointer-cast]
  par-state.vgabase = (void __iomem *) vga_res.start;
   ^
 --
drivers/video/fbdev/arkfb.c: In function 'ark_pci_probe':
  drivers/video/fbdev/arkfb.c:1019:23: warning: cast to pointer from integer 
  of different size [-Wint-to-pointer-cast]
  par-state.vgabase = (void __iomem *) vga_res.start;
   ^
 drivers/video/fbdev/s3fb.c:1406 s3_pci_remove() warn: variable dereferenced 
 before check 'info' (see line 1404)
 drivers/video/fbdev/arkfb.c:454 ics5342_init() warn: struct type mismatch 
 'dac_info vs ics5342_info'
 drivers/video/fbdev/hgafb.c:420 hgafb_pan_display() warn: unsigned 
 'var-yoffset' is never less than zero.
 drivers/video/fbdev/udlfb.c:1498 dlfb_select_std_channel() error: doing dma 
 on the stack (set_def_chn)
 drivers/video/fbdev/uvesafb.c:1509 uvesafb_init_info() error: we previously 
 assumed 'mode' could be null (see line 1477)
 drivers/video/fbdev/uvesafb.c:1815 uvesafb_remove() warn: variable 
 dereferenced before check 'par' (see line 1810)
 drivers/video/fbdev/mb862xx/mb862xxfb_accel.c:248 mb86290fb_imageblit() 
 error: no modifiers for allocation.
 drivers/video/fbdev/matrox/matroxfb_base.c:1974 matroxfb_register_device() 
 error: we previously assumed 'drv' could be null (see line 1975)
 drivers/video/fbdev/matrox/matroxfb_base.c:2032 matroxfb_probe() warn: 
 returning -1 instead of -ENOMEM is sloppy
 drivers/video/fbdev/riva/fbdev.c:1120 rivafb_check_var() warn: missing break? 
 reassigning 'var-green.length'
 drivers/video/fbdev/matrox/matroxfb_Ti3026.c:375 Ti3026_init() error: 
 __builtin_memcpy() 'MGADACbpp32' too small (21 vs 80)
 drivers/video/fbdev/sis/sis_main.c:1576 sisfb_check_var() warn: unsigned 
 'var-xoffset' is never less than zero.
 drivers/video/fbdev/sis/sis_main.c:1577 sisfb_check_var() warn: unsigned 
 'var-yoffset' is never less than zero.
 drivers/video/fbdev/sis/sis_main.c:4433 sisfb_post_sis300() error: we 
 previously assumed 'bios' could be null (see line 4418)
 drivers/video/fbdev/sis/sis_main.c:4809 sisfb_post_xgi_ramsize() error: 
 buffer overflow 'dramsr13_4' 20 = 59
 drivers/video/fbdev/sis/sis_main.c:4814 sisfb_post_xgi_ramsize() error: 
 buffer overflow 'dramsr13_4' 20 = 58
 drivers/video/fbdev/via/viafbdev.c:866 viafb_cursor() error: buffer overflow 
 'cr_data-bak' 2048 = 2048
 drivers/video/fbdev/via/viafbdev.c:872 viafb_cursor() error: buffer overflow 
 'cr_data-bak' 2048 = 2048
 drivers/video/fbdev/via/viafbdev.c:873 viafb_cursor() error: buffer overflow 
 'cr_data-bak' 2048 = 2049
 drivers/video/fbdev/via/viafbdev.c:874 viafb_cursor() error: buffer overflow 
 'cr_data-bak' 2048 = 2050
 drivers/video/fbdev/sis/init.c:656 SiS_GetModeID_LCD() warn: missing break? 
 reassigning 'ModeIndex'
 drivers/video/fbdev/sis/init.c:996 SiSRegInit() warn: the 'SIS_CRT2_PORT_04' 
 macro might need parens
 drivers/video/fbdev/sis/init.c:997 SiSRegInit() warn: the 'SIS_CRT2_PORT_10' 
 macro might need parens
 drivers/video/fbdev/sis/init.c:998 SiSRegInit() warn: the 'SIS_CRT2_PORT_12' 
 macro might need parens
 drivers/video/fbdev/sis/init.c:999 SiSRegInit() warn: the 'SIS_CRT2_PORT_14' 
 macro might need parens
 drivers/video/fbdev/sis/init.c:1000 SiSRegInit() warn: the 'SIS_CRT2_PORT_14' 
 macro might need parens
 drivers/video/fbdev/sis/init.c:1002 SiSRegInit() warn: the 
 'SIS_VIDEO_CAPTURE' macro might need parens
 drivers/video/fbdev/sis/init.c:1003 SiSRegInit() warn: the 
 'SIS_VIDEO_PLAYBACK' macro might need parens
 drivers/video/fbdev/aty/radeon_base.c:1091 radeon_setcolreg() error: buffer 
 overflow 'rinfo-palette' 256 = 510
 drivers/video/fbdev/matrox/matroxfb_crtc2.c:440 matroxfb_dh_ioctl() warn: 
 check that 'vblank.hcount' doesn't leak information
 drivers/video/fbdev/aty/aty128fb.c:2279 aty128fb_setcolreg() error: buffer 
 overflow 'par-green' 64 = 255
 drivers/video/fbdev/aty/aty128fb.c:2286 aty128fb_setcolreg() error: buffer 
 overflow 'par-red' 32 =