Hi Michal,

FYI, there are coccinelle warnings in

tree:   git://github.com/kvalo/ath ath-next-test
head:   748afc4735361e21ad655c0dc021ea3aaeeb3efd
commit: c930f744bdb0774ccf7c00e23637f54b8e71f0b6 [7/9] ath10k: implement 
channel switching

>> drivers/net/wireless/ath/ath10k/mac.c:2745:5-11: preceding lock on line 2663

git remote add ath6kl git://github.com/kvalo/ath
git remote update ath6kl
git checkout c930f744bdb0774ccf7c00e23637f54b8e71f0b6
vim +2745 drivers/net/wireless/ath/ath10k/mac.c

5e3dd157 Kalle Valo        2013-06-12  2657  {
5e3dd157 Kalle Valo        2013-06-12  2658     struct ath10k *ar = hw->priv;
5e3dd157 Kalle Valo        2013-06-12  2659     struct ath10k_vif *arvif = 
ath10k_vif_to_arvif(vif);
5e3dd157 Kalle Valo        2013-06-12  2660     int ret = 0;
226a339b Bartosz Markowski 2013-09-26  2661     u32 vdev_param, pdev_param;
5e3dd157 Kalle Valo        2013-06-12  2662  
5e3dd157 Kalle Valo        2013-06-12 @2663     mutex_lock(&ar->conf_mutex);
5e3dd157 Kalle Valo        2013-06-12  2664  
5e3dd157 Kalle Valo        2013-06-12  2665     if (changed & BSS_CHANGED_IBSS)
5e3dd157 Kalle Valo        2013-06-12  2666             
ath10k_control_ibss(arvif, info, vif->addr);
5e3dd157 Kalle Valo        2013-06-12  2667  
5e3dd157 Kalle Valo        2013-06-12  2668     if (changed & 
BSS_CHANGED_BEACON_INT) {
5e3dd157 Kalle Valo        2013-06-12  2669             arvif->beacon_interval 
= info->beacon_int;
6d1506e7 Bartosz Markowski 2013-09-26  2670             vdev_param = 
ar->wmi.vdev_param->beacon_interval;
6d1506e7 Bartosz Markowski 2013-09-26  2671             ret = 
ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param,
5e3dd157 Kalle Valo        2013-06-12  2672                                     
        arvif->beacon_interval);
60c3daa8 Kalle Valo        2013-09-08  2673             
ath10k_dbg(ATH10K_DBG_MAC,
60c3daa8 Kalle Valo        2013-09-08  2674                        "mac vdev %d 
beacon_interval %d\n",
60c3daa8 Kalle Valo        2013-09-08  2675                        
arvif->vdev_id, arvif->beacon_interval);
60c3daa8 Kalle Valo        2013-09-08  2676  
5e3dd157 Kalle Valo        2013-06-12  2677             if (ret)
5e3dd157 Kalle Valo        2013-06-12  2678                     
ath10k_warn("Failed to set beacon interval for VDEV: %d\n",
5e3dd157 Kalle Valo        2013-06-12  2679                                 
arvif->vdev_id);
5e3dd157 Kalle Valo        2013-06-12  2680     }
5e3dd157 Kalle Valo        2013-06-12  2681  
5e3dd157 Kalle Valo        2013-06-12  2682     if (changed & 
BSS_CHANGED_BEACON) {
60c3daa8 Kalle Valo        2013-09-08  2683             
ath10k_dbg(ATH10K_DBG_MAC,
60c3daa8 Kalle Valo        2013-09-08  2684                        "vdev %d set 
beacon tx mode to staggered\n",
60c3daa8 Kalle Valo        2013-09-08  2685                        
arvif->vdev_id);
60c3daa8 Kalle Valo        2013-09-08  2686  
226a339b Bartosz Markowski 2013-09-26  2687             pdev_param = 
ar->wmi.pdev_param->beacon_tx_mode;
226a339b Bartosz Markowski 2013-09-26  2688             ret = 
ath10k_wmi_pdev_set_param(ar, pdev_param,
5e3dd157 Kalle Valo        2013-06-12  2689                                     
        WMI_BEACON_STAGGERED_MODE);
5e3dd157 Kalle Valo        2013-06-12  2690             if (ret)
5e3dd157 Kalle Valo        2013-06-12  2691                     
ath10k_warn("Failed to set beacon mode for VDEV: %d\n",
5e3dd157 Kalle Valo        2013-06-12  2692                                 
arvif->vdev_id);
5e3dd157 Kalle Valo        2013-06-12  2693     }
5e3dd157 Kalle Valo        2013-06-12  2694  
b70727e8 John W. Linville  2013-06-13  2695     if (changed & 
BSS_CHANGED_BEACON_INFO) {
5e3dd157 Kalle Valo        2013-06-12  2696             arvif->dtim_period = 
info->dtim_period;
5e3dd157 Kalle Valo        2013-06-12  2697  
60c3daa8 Kalle Valo        2013-09-08  2698             
ath10k_dbg(ATH10K_DBG_MAC,
60c3daa8 Kalle Valo        2013-09-08  2699                        "mac vdev %d 
dtim_period %d\n",
60c3daa8 Kalle Valo        2013-09-08  2700                        
arvif->vdev_id, arvif->dtim_period);
60c3daa8 Kalle Valo        2013-09-08  2701  
6d1506e7 Bartosz Markowski 2013-09-26  2702             vdev_param = 
ar->wmi.vdev_param->dtim_period;
6d1506e7 Bartosz Markowski 2013-09-26  2703             ret = 
ath10k_wmi_vdev_set_param(ar, arvif->vdev_id, vdev_param,
5e3dd157 Kalle Valo        2013-06-12  2704                                     
        arvif->dtim_period);
5e3dd157 Kalle Valo        2013-06-12  2705             if (ret)
5e3dd157 Kalle Valo        2013-06-12  2706                     
ath10k_warn("Failed to set dtim period for VDEV: %d\n",
5e3dd157 Kalle Valo        2013-06-12  2707                                 
arvif->vdev_id);
5e3dd157 Kalle Valo        2013-06-12  2708     }
5e3dd157 Kalle Valo        2013-06-12  2709  
5e3dd157 Kalle Valo        2013-06-12  2710     if (changed & BSS_CHANGED_SSID 
&&
5e3dd157 Kalle Valo        2013-06-12  2711         vif->type == 
NL80211_IFTYPE_AP) {
5e3dd157 Kalle Valo        2013-06-12  2712             arvif->u.ap.ssid_len = 
info->ssid_len;
5e3dd157 Kalle Valo        2013-06-12  2713             if (info->ssid_len)
5e3dd157 Kalle Valo        2013-06-12  2714                     
memcpy(arvif->u.ap.ssid, info->ssid, info->ssid_len);
5e3dd157 Kalle Valo        2013-06-12  2715             arvif->u.ap.hidden_ssid 
= info->hidden_ssid;
5e3dd157 Kalle Valo        2013-06-12  2716     }
5e3dd157 Kalle Valo        2013-06-12  2717  
5e3dd157 Kalle Valo        2013-06-12  2718     if (changed & 
BSS_CHANGED_BSSID) {
5e3dd157 Kalle Valo        2013-06-12  2719             if 
(!is_zero_ether_addr(info->bssid)) {
60c3daa8 Kalle Valo        2013-09-08  2720                     
ath10k_dbg(ATH10K_DBG_MAC,
60c3daa8 Kalle Valo        2013-09-08  2721                                "mac 
vdev %d create peer %pM\n",
60c3daa8 Kalle Valo        2013-09-08  2722                                
arvif->vdev_id, info->bssid);
60c3daa8 Kalle Valo        2013-09-08  2723  
5e3dd157 Kalle Valo        2013-06-12  2724                     ret = 
ath10k_peer_create(ar, arvif->vdev_id,
5e3dd157 Kalle Valo        2013-06-12  2725                                     
         info->bssid);
5e3dd157 Kalle Valo        2013-06-12  2726                     if (ret)
479398b0 Ben Greear        2013-11-04  2727                             
ath10k_warn("Failed to add peer %pM for vdev %d when changin bssid: %i\n",
479398b0 Ben Greear        2013-11-04  2728                                     
    info->bssid, arvif->vdev_id, ret);
5e3dd157 Kalle Valo        2013-06-12  2729  
5e3dd157 Kalle Valo        2013-06-12  2730                     if (vif->type 
== NL80211_IFTYPE_STATION) {
5e3dd157 Kalle Valo        2013-06-12  2731                             /*
5e3dd157 Kalle Valo        2013-06-12  2732                              * this 
is never erased as we it for crypto key
5e3dd157 Kalle Valo        2013-06-12  2733                              * 
clearing; this is FW requirement
5e3dd157 Kalle Valo        2013-06-12  2734                              */
c930f744 Michal Kazior     2014-01-23  2735                             
memcpy(arvif->bssid, info->bssid, ETH_ALEN);
5e3dd157 Kalle Valo        2013-06-12  2736  
60c3daa8 Kalle Valo        2013-09-08  2737                             
ath10k_dbg(ATH10K_DBG_MAC,
60c3daa8 Kalle Valo        2013-09-08  2738                                     
   "mac vdev %d start %pM\n",
60c3daa8 Kalle Valo        2013-09-08  2739                                     
   arvif->vdev_id, info->bssid);
60c3daa8 Kalle Valo        2013-09-08  2740  
5e3dd157 Kalle Valo        2013-06-12  2741                             ret = 
ath10k_vdev_start(arvif);
c930f744 Michal Kazior     2014-01-23  2742                             if 
(ret) {
c930f744 Michal Kazior     2014-01-23  2743                                     
ath10k_warn("failed to start vdev: %d\n",
c930f744 Michal Kazior     2014-01-23  2744                                     
            ret);
c930f744 Michal Kazior     2014-01-23 @2745                                     
return;
c930f744 Michal Kazior     2014-01-23  2746                             }
c930f744 Michal Kazior     2014-01-23  2747  
c930f744 Michal Kazior     2014-01-23  2748                             
arvif->is_started = true;

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild

Reply via email to