[ Are device->resource->req_lock and connection->resource->req_lock the same lock? ]
Hi Andreas, FYI, there are new smatch warnings show up in tree: git://git.drbd.org/linux-drbd.git for-3.15-p2 head: 2457b6d5ee1a9ff8a3c15ea8eaa5bc195a47d326 commit: 0500813fe0c9a617ace86d91344e36839050dad6 [40/63] drbd: Move conf_mutex from connection to resource drivers/block/drbd/drbd_req.c:1401 request_timer_fn() warn: inconsistent returns spin_lock:&connection->resource->req_lock: locked (1359, 1368) unlocked (1401) drivers/block/drbd/drbd_req.c:1401 request_timer_fn() warn: inconsistent returns spin_lock:&device->resource->req_lock: locked (1401) unlocked (1359, 1368) git remote add drdb git://git.drbd.org/linux-drbd.git git remote update drdb git checkout 0500813fe0c9a617ace86d91344e36839050dad6 vim +1401 drivers/block/drbd/drbd_req.c ba280c09 Lars Ellenberg 2012-04-25 1385 * to expire twice (worst case) to become effective. Good enough. ba280c09 Lars Ellenberg 2012-04-25 1386 */ ba280c09 Lars Ellenberg 2012-04-25 1387 if (ent && req->rq_state & RQ_NET_PENDING && ba280c09 Lars Ellenberg 2012-04-25 1388 time_after(now, req->start_time + ent) && bde89a9e Andreas Gruenbacher 2011-05-30 1389 !time_in_range(now, connection->last_reconnect_jif, connection->last_reconnect_jif + ent)) { d0180171 Andreas Gruenbacher 2011-07-03 1390 drbd_warn(device, "Remote failed to finish a request within ko-count * timeout\n"); b30ab791 Andreas Gruenbacher 2011-07-03 1391 _drbd_set_state(_NS(device, conn, C_TIMEOUT), CS_VERBOSE | CS_HARD, NULL); 7fde2be9 Philipp Reisner 2011-03-01 1392 } b30ab791 Andreas Gruenbacher 2011-07-03 1393 if (dt && req->rq_state & RQ_LOCAL_PENDING && req->w.device == device && ba280c09 Lars Ellenberg 2012-04-25 1394 time_after(now, req->start_time + dt) && b30ab791 Andreas Gruenbacher 2011-07-03 1395 !time_in_range(now, device->last_reattach_jif, device->last_reattach_jif + dt)) { d0180171 Andreas Gruenbacher 2011-07-03 1396 drbd_warn(device, "Local backing device failed to meet the disk-timeout\n"); b30ab791 Andreas Gruenbacher 2011-07-03 1397 __drbd_chk_io_error(device, DRBD_FORCE_DETACH); dfa8bedb Philipp Reisner 2011-06-29 1398 } ba280c09 Lars Ellenberg 2012-04-25 1399 nt = (time_after(now, req->start_time + et) ? now : req->start_time) + et; 0500813f Andreas Gruenbacher 2011-07-07 1400 spin_unlock_irq(&connection->resource->req_lock); b30ab791 Andreas Gruenbacher 2011-07-03 @1401 mod_timer(&device->request_timer, nt); 7fde2be9 Philipp Reisner 2011-03-01 1402 } --- 0-DAY kernel build testing backend Open Source Technology Center http://lists.01.org/mailman/listinfo/kbuild Intel Corporation _______________________________________________ kbuild mailing list kbuild@lists.01.org https://lists.01.org/mailman/listinfo/kbuild