Not really new. This code won't move out of staging until these are
fixed.
regards,
dan carpenter
On Fri, Feb 14, 2014 at 10:54:35AM +0800, kbuild test robot wrote:
> TO: Dave Jones <da...@redhat.com>
> CC: "Greg Kroah-Hartman" <gre...@linuxfoundation.org>
>
>
> Hi Dave,
>
> FYI, there are new smatch warnings show up in
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> staging-next
> head: 84f7a542f9e0191b6f7ab87881a050889576a5c4
> commit: 79f99494892c8bd7e7464ee273d8a43fc08c406d [124/151] staging/bcm: move
> IOCTL_BCM_BUFFER_DOWNLOAD_START case out to its own function.
> :::::: branch date: 5 hours ago
> :::::: commit date: 6 hours ago
>
> New smatch warnings:
> drivers/staging/bcm/Bcmchar.c:816 bcm_char_ioctl_buffer_download_start()
> warn: inconsistent returns sem:&Adapter->NVMRdmWrmLock: locked (798 [(-16)])
> unlocked (791 [(-13)], 811 [s32min-(-1),1-s32max], 816 [0])
>
> Old smatch warnings:
> drivers/staging/bcm/Bcmchar.c:839 bcm_char_ioctl() warn: bitwise AND
> condition is false here
> drivers/staging/bcm/Bcmchar.c:935 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:943 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:949 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:954 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:964 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:988 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:1004 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:1019 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
> drivers/staging/bcm/Bcmchar.c:1054 bcm_char_ioctl() error: double unlock
> 'sem:&Adapter->fw_download_sema'
>
> git remote add staging
> git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> git remote update staging
> git checkout 79f99494892c8bd7e7464ee273d8a43fc08c406d
> vim +816 drivers/staging/bcm/Bcmchar.c
>
> 79f99494 Dave Jones 2014-02-13 800 Adapter->bBinDownloaded = false;
> 79f99494 Dave Jones 2014-02-13 801
> Adapter->fw_download_process_pid = current->pid;
> 79f99494 Dave Jones 2014-02-13 802 Adapter->bCfgDownloaded = false;
> 79f99494 Dave Jones 2014-02-13 803 Adapter->fw_download_done =
> false;
> 79f99494 Dave Jones 2014-02-13 804 netif_carrier_off(Adapter->dev);
> 79f99494 Dave Jones 2014-02-13 805 netif_stop_queue(Adapter->dev);
> 79f99494 Dave Jones 2014-02-13 806 Status =
> reset_card_proc(Adapter);
> 79f99494 Dave Jones 2014-02-13 807 if (Status) {
> 79f99494 Dave Jones 2014-02-13 808 pr_err(PFX "%s:
> reset_card_proc Failed!\n", Adapter->dev->name);
> 79f99494 Dave Jones 2014-02-13 809
> up(&Adapter->fw_download_sema);
> 79f99494 Dave Jones 2014-02-13 810
> up(&Adapter->NVMRdmWrmLock);
> 79f99494 Dave Jones 2014-02-13 811 return Status;
> 79f99494 Dave Jones 2014-02-13 812 }
> 79f99494 Dave Jones 2014-02-13 813 mdelay(10);
> 79f99494 Dave Jones 2014-02-13 814
> 79f99494 Dave Jones 2014-02-13 815 up(&Adapter->NVMRdmWrmLock);
> 79f99494 Dave Jones 2014-02-13 @816 return Status;
> 79f99494 Dave Jones 2014-02-13 817 }
> 79f99494 Dave Jones 2014-02-13 818
> 0566ee95 Dave Jones 2014-02-13 819
> 9f1c75ac Arnd Bergmann 2010-09-30 820 static long bcm_char_ioctl(struct
> file *filp, UINT cmd, ULONG arg)
> f8942e07 Stephen Hemminger 2010-09-08 821 {
> 774bea83 Kevin McKinney 2012-05-26 822 struct bcm_tarang_data *pTarang
> = filp->private_data;
> ada692b0 Stephen Hemminger 2010-11-01 823 void __user *argp = (void
> __user *)arg;
> 2979460d Kevin McKinney 2012-05-26 824 struct bcm_mini_adapter
> *Adapter = pTarang->Adapter;
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild Intel Corporation
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
