Hello Tejun Heo,
This is a semi-automatic email about new static checker warnings.
The patch 3eef34ad7dc3: "kernfs: implement kernfs_get_parent(),
kernfs_name/path() and friends" from Feb 7, 2014, leads to the
following Smatch complaint:
fs/kernfs/dir.c:1298 kernfs_rename_ns()
error: we previously assumed 'new_name' could be null (see line 1289)
fs/kernfs/dir.c
1288 kn->ns = new_ns;
1289 if (new_name) {
^^^^^^^^
Check.
1290 if (!(kn->flags & KERNFS_STATIC_NAME))
1291 old_name = kn->name;
1292 kn->flags &= ~KERNFS_STATIC_NAME;
1293 kn->name = new_name;
1294 }
1295
1296 spin_unlock_irq(&kernfs_rename_lock);
1297
1298 kn->hash = kernfs_name_hash(new_name, new_ns);
^^^^^^^^
Dereference.
1299 kernfs_link_sibling(kn);
1300
regards,
dan carpenter
_______________________________________________
kbuild mailing list
kbuild@lists.01.org
https://lists.01.org/mailman/listinfo/kbuild
