Re: [kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-08 Thread Brendan J Simon
Kai Germaschewski wrote: You must be missing some of the changes (My first push to bkbits was incomplete, since I did inadvertently edit Makefile without checking it out, I do that mistake all the time...). It's fixed in the current repo. Can't bitkeeper be setup to have readonly files for

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-07 Thread Xavier Bestel
Le jeu 03/10/2002 à 04:59, Kai Germaschewski a écrit : Hi, I'd appreciate to get comments on the appended patch. It's mostly cleanups and the like, but the interesting part is the last cset, which is actually fairly small: 14 files changed, 64 insertions(+), 47 deletions(-) The

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-07 Thread Xavier Bestel
Le jeu 03/10/2002 à 16:56, Kai Germaschewski a écrit : This would avoid recursive make, which isn't really a good idea (even if it's used widely). Here is a good agument about that: http://www.cse.iitb.ac.in/~soumen/teach/cs699a1999/make.html I think I heard that before, but I would

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-07 Thread Kai Germaschewski
On Thu, 3 Oct 2002, Sam Ravnborg wrote: -obj-$(CONFIG_ACPI_INTERPRETER) := $(patsubst %.c,%.o,$(wildcard *.c)) +obj-y := dsfield.o dsmthdat.o dsopcode.o dswexec.o dswscope.o \ +dsmethod.o dsobject.o dsutils.o dswload.o dswstate.o Should that have been:

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-07 Thread Kai Germaschewski
On Thu, 3 Oct 2002, Sam Ravnborg wrote: On Thu, Oct 03, 2002 at 10:01:20PM +0200, Sam Ravnborg wrote: Now it's testing time.. [...] You must be missing some of the changes (My first push to bkbits was incomplete, since I did inadvertently edit Makefile without checking it out, I do that

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-07 Thread Kai Germaschewski
On 3 Oct 2002, Xavier Bestel wrote: Could you do instead: include subdir/Makefile ? It's not quite that easy, unfortunately ;( This would avoid recursive make, which isn't really a good idea (even if it's used widely). Here is a good agument about that:

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-04 Thread Sam Ravnborg
On Thu, Oct 03, 2002 at 03:38:22PM -0500, Kai Germaschewski wrote: You must be missing some of the changes (My first push to bkbits was incomplete, since I did inadvertently edit Makefile without checking it out, I do that mistake all the time...). It's fixed in the current repo. Did a pull

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-03 Thread Sam Ravnborg
On Wed, Oct 02, 2002 at 09:59:00PM -0500, Kai Germaschewski wrote: Hi, I'd appreciate to get comments on the appended patch. It's mostly cleanups and the like, but the interesting part is the last cset, which is actually fairly small: Tried out what I pulled from linux-2.5.make 1)

Re: [kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-03 Thread Sam Ravnborg
On Thu, Oct 03, 2002 at 09:26:18PM +0200, Sam Ravnborg wrote: Hmmm, was the stuff present at bkbits incomplete? Just checked, yes the attached patch was never. And fixes I think all the above. A new round of testing needed Sam

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-03 Thread Sam Ravnborg
On Wed, Oct 02, 2002 at 09:59:00PM -0500, Kai Germaschewski wrote: Hi, I'd appreciate to get comments on the appended patch. -obj-$(CONFIG_ACPI_INTERPRETER) := $(patsubst %.c,%.o,$(wildcard *.c)) +obj-y := dsfield.o dsmthdat.o dsopcode.o dswexec.o dswscope.o \ + dsmethod.o

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-03 Thread Peter Samuelson
[Sam Ravnborg] +ifdef list-multi +$(warning kbuild: list-multi ($(list-multi)) is obsolete in 2.5. Please fix!) +endif Since kbuild no longer support list-multi this should be $(error ) Except that it is harmless. list-multi is a hint which the kbuild system no longer needs. Code

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-03 Thread Sam Ravnborg
On Thu, Oct 03, 2002 at 10:01:20PM +0200, Sam Ravnborg wrote: Now it's testing time.. 1) In order to make it link I had to change the following in rules.make: # If the list of objects to link is empty, just create an empty O_TARGET cmd_link_o_target = $(if $(strip $(obj-y)),\ -

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-03 Thread Sam Ravnborg
On Thu, Oct 03, 2002 at 03:38:22PM -0500, Kai Germaschewski wrote: On Thu, 3 Oct 2002, Sam Ravnborg wrote: On Thu, Oct 03, 2002 at 10:01:20PM +0200, Sam Ravnborg wrote: Now it's testing time.. [...] You must be missing some of the changes (My first push to bkbits was incomplete,

[kbuild-devel] Re: RfC: Don't cd into subdirs during kbuild

2002-10-02 Thread Andreas Dilger
On Oct 02, 2002 21:59 -0500, Kai Germaschewski wrote: The build process remains recursive, but it changes the recursion from make -C subdir to make -f subdir/Makefile i.e. the current working directory remains the top dir for all times. So gcc/ld/.. are now called from the