https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #50 from Omar Amin ---
Sure.
I'll max tomorrow send you a list of screenshots with the colors for feedback,
I've found a side effect from my patch and i'm working on it and will get back
to you soon.
Omar
--
You are receiving this mail be
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #98977|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #46 from Omar Amin ---
Dear Mr Gilles,
I'm sorry for the last comment, it seems that i don't have the previlledge to
delete this comment.
The updates:
1- Now each theme has a customizable color for the background of grouped images
when ex
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #99001|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #44 from Omar Amin ---
Created attachment 99001
--> https://bugs.kde.org/attachment.cgi?id=99001&action=edit
patch3 grouped images, fitting grouped borders
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #43 from Omar Amin ---
Dear Mr Gilles, Mr Jens,
I've attached a draft patch for testing and getting your feedback, what is
supposed to be fixed in this patch:
1- The images are enclosed in the thumbnails border, not outside (i did so
throug
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #42 from Omar Amin ---
Created attachment 98977
--> https://bugs.kde.org/attachment.cgi?id=98977&action=edit
Not final patch, just a trial for feedback
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #39 from Omar Amin ---
Dear Mr Gilles,
I've attached three images for the three problems i'm currently addressing:
1- Group border was transparent so when the theme is changed to black
background, the border is visible, but i think it can b
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #38 from Omar Amin ---
Created attachment 98939
--> https://bugs.kde.org/attachment.cgi?id=98939&action=edit
Group images highlighted when group is expanded
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #37 from Omar Amin ---
Created attachment 98938
--> https://bugs.kde.org/attachment.cgi?id=98938&action=edit
progress in ensure the image border doesn't go outside the thumbnail border,
temp solution
--
You are receiving this mail becaus
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #36 from Omar Amin ---
Created attachment 98937
--> https://bugs.kde.org/attachment.cgi?id=98937&action=edit
Black background theme, group bordered is filled
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #34 from Omar Amin ---
Now i understand the requirements, i'll finish it ASAP and get back to you.
Thanks you
Omar
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #32 from Omar Amin ---
if we need to use the rotated borders, we can adjust the border for each image
at different thumbnail sizes differently that will make us able to fit the
rotated borders at different thumbnail sizes entirely inside the
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #31 from Omar Amin ---
Dear Mr Gilles and Mr Jens,
I made this simple stack just for confirming if that's what we need or not?, i
made it on a separate project to make the compilation quicker, that's why not
all digKam image info is shown n
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #30 from Omar Amin ---
Created attachment 98715
--> https://bugs.kde.org/attachment.cgi?id=98715&action=edit
stack proposal
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #26 from Omar Amin ---
(In reply to caulier.gilles from comment #25)
> Note : LightRoom groupped items is called "Image Stacked". It's explained
> here :
>
> http://valeriegoettsch.com/lightroom-grid-view-icons/
>
> Excepted the icon+numbe
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #22 from Omar Amin ---
Dear Mr Gilles,
I'm sorry for being late, attached the new patch containing the modifications
needed for centring the thumbnail inside the group borders, If we have time I
can work on the other needed modifications (g
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #98455|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #17 from Omar Amin ---
Hello,
I've fixed the centring issue for the thumbnail and have attached a sample for
3 different groups, please let me know if you think they're still not
symmetrical.
Regarding the large thumbnail support, I've tri
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #98456|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #15 from Omar Amin ---
Dear Mr Gilles,
I'm sorry for being late, I'll start today on it, and also tomorrow will be
working on it the whole day, and will send a patch tomorrow max.
Mr Jens, yes for sure i can, I'll also try to do the groupe
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #12 from Omar Amin ---
Thanks Mr Gilles for the feedback.
I'll make another patch taking into consideration the points you mentioned and
get back to you.
Thanks for your time.
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #10 from Omar Amin ---
Created attachment 98456
--> https://bugs.kde.org/attachment.cgi?id=98456&action=edit
Screenshot of the new grouped images border
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #9 from Omar Amin ---
Created attachment 98455
--> https://bugs.kde.org/attachment.cgi?id=98455&action=edit
Group border modification patch
This patch is for grouped images border new background
--
You are receiving this mail because:
Y
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #7 from Omar Amin ---
Hi Mr Gilles,
I'll look into it during this week, and will finish it by next Friday, Please
let me know if you need it finished earlier.
Regards,
Omar
--
You are receiving this mail because:
You are watching all bu
25 matches
Mail list logo
