https://bugs.kde.org/show_bug.cgi?id=361691
--- Comment #12 from Stephen Kelly ---
Your benchmark is only for the case of the searched string being empty. In
other benchmarks here, the two perform the same.
That isn't a good reason for clazy to recommend something that 1)
https://bugs.kde.org/show_bug.cgi?id=361691
Stephen Kelly changed:
What|Removed |Added
Resolution|INVALID |---
https://bugs.kde.org/show_bug.cgi?id=361691
--- Comment #9 from Stephen Kelly ---
Upstreamed: https://bugreports.qt.io/browse/QTBUG-52617
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361691
--- Comment #4 from Stephen Kelly ---
I also tried with larger strings. The fact that the QLatin1String overload is
slower is suspect. It could be due to the test string being very small, but
that's what I expect is the primary
https://bugs.kde.org/show_bug.cgi?id=361691
--- Comment #3 from Stephen Kelly ---
I tried to replicate your result unsuccessfully. Do you still have your
benchmark? I tried Qt 5.4.2 and some recent git branch.
#include
class StringBenchmark : public QObject
{
Q_OBJECT
https://bugs.kde.org/show_bug.cgi?id=361691
--- Comment #2 from Stephen Kelly ---
That sounds like a bug in QString, right?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=352369
Stephen Kelly changed:
What|Removed |Added
Latest Commit||http://commits.kde.org/kite
https://bugs.kde.org/show_bug.cgi?id=352369
Stephen Kelly changed:
What|Removed |Added
Assignee|kdelibs-b...@kde.org|steve...@gmail.com
--
You
https://bugs.kde.org/show_bug.cgi?id=354883
--- Comment #13 from Stephen Kelly ---
Hi Rhys,
Ok, thanks for the response. So in terms of realistic expections, I shouldn't
expect valgrind with Qt5 to work on OSX for now.
Thanks for the update.
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=354883
--- Comment #11 from Stephen Kelly ---
(In reply to Stephen Kelly from comment #10)
> Hi am trying to run valgrind on OSX and I think I am hitting the same
> problem.
>
> I have this embarrassingly simple Qt 5 program:
>
> cat
https://bugs.kde.org/show_bug.cgi?id=354883
Stephen Kelly changed:
What|Removed |Added
CC||steve...@gmail.com
---
https://bugs.kde.org/show_bug.cgi?id=359572
--- Comment #3 from Stephen Kelly ---
I guess we currently just let cmake do whatever it does by default here. What
does cmake do regarding windows here?
--
You are receiving this mail because:
You are watching all bug changes.
12 matches
Mail list logo