[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Nate Graham changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #12 from Nate Graham --- So the root cause of the issue here is that we're using the wrong UI element for Discover's sidebar (see Bug 390928). We use a Kirigami GlobalDrawer for the sidebar, which is problematic because the

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Nate Graham changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #11 from Nate Graham --- Right, I wasn't suggesting that as a real fix, just as something that illustrates with the issue is and how we might work around it if necessary (yes, we'd use gridUnits). -- You are receiving this

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #10 from Christoph Feck --- relative to font size == font height in pixels, not points. -- You are receiving this mail because: You are watching all bug changes.

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #9 from Christoph Feck --- Please do not use absolute pixel sizes. The number of pixels could be computed relative to the font size. I think using the Plasma grid units does exactly that. -- You are receiving this mail

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #8 from Nate Graham --- Created attachment 110796 --> https://bugs.kde.org/attachment.cgi?id=110796=edit Discover with the sidebar forced to 280 pixels -- You are receiving this mail because: You are watching all bug

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #7 from Nate Graham --- Yep, that's it. In src/controls/GlobalDrawer.qml, root.parent.width is getting set to an absurdly low value, so it falls back to the minimum value of Units.gridUnit * 20 (which I believe works out to

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #6 from Nate Graham --- I think this might be the problem: https://cgit.kde.org/kirigami.git/tree/src/controls/GlobalDrawer.qml#n215 -- You are receiving this mail because: You are watching all bug changes.

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Nate Graham changed: What|Removed |Added CC||now.im@gmail.com ---

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 matheus4...@hotmail.com changed: What|Removed |Added CC||matheus4...@hotmail.com -- You are

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Nate Graham changed: What|Removed |Added Keywords||usability -- You are

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #4 from Nate Graham --- Actually I tried reducing the width of the SVG by 25%, but it was just scaled up to match the original width of the sidebar, so I don't think the width of the header graphic alone is what's

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Nate Graham changed: What|Removed |Added Status|RESOLVED|REOPENED

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Aleix Pol changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 Dr. Chapatin changed: What|Removed |Added CC||bugsefor...@gmx.com --

[Discover] [Bug 385992] Discover's sidebar is too wide by default

https://bugs.kde.org/show_bug.cgi?id=385992 --- Comment #1 from Nate Graham --- Created attachment 108478 --> https://bugs.kde.org/attachment.cgi?id=108478=edit Mockup of proposed new design -- You are receiving this mail because: You are watching all bug changes.