[clazy] [Bug 367484] reserve-candidate warnings for QVarLengthArray

2016-08-21 Thread Sergio Martins via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367484 Sergio Martins changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|

[clazy] [Bug 367484] reserve-candidate warnings for QVarLengthArray

2016-08-19 Thread Mathias Hasselmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367484 --- Comment #4 from Mathias Hasselmann --- I also understand your approach to just use reserve(), and it makes sense, still clazy should avoid overly defensive warnings: Clazy will be much more useful for team hygiene when it receives the _perception_ t

[clazy] [Bug 367484] reserve-candidate warnings for QVarLengthArray

2016-08-19 Thread Sergio Martins via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367484 Sergio Martins changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED

[clazy] [Bug 367484] reserve-candidate warnings for QVarLengthArray

2016-08-19 Thread Mathias Hasselmann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367484 --- Comment #2 from Mathias Hasselmann --- (In reply to Sergio Martins from comment #1) > Wouldn't a reserve make sense in that example ? Not at all. The purpose of QVarLengthArray is to save the reserve, or rather to do it right on the stack - therefor

[clazy] [Bug 367484] reserve-candidate warnings for QVarLengthArray

2016-08-19 Thread Sergio Martins via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367484 --- Comment #1 from Sergio Martins --- Wouldn't a reserve make sense in that example ? How do you know FooLast - FooFirst isn't bigger than 160 ? -- You are receiving this mail because: You are watching all bug changes.