https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #87 from caulier.gil...@gmail.com ---
Jens,
For a reason that i don't know, the digiKam 5.6.0 bundles and tarball still in
pending queue to be published on KDE download server. Typically it must be
published one week ago. Nothing happen,
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Version Fixed In||5.7.0
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=361047
Jens changed:
What|Removed |Added
Resolution|--- |FIXED
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #85 from caulier.gil...@gmail.com ---
No this idea is not implemented. This can be interesting effectively...
Q: Why this bug is still open as patch was applied to git/master ? As the
original idea is implemented in current 5.6.0 version, i
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #84 from Jens ---
Is the transparency / opacity patch already applied to git master? See comment
76, idea 2.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #83 from caulier.gil...@gmail.com ---
Anyway, yesterday i recompiled the AppImage. It do not have teh last commit
from Maik, but all the rest is already inside. It's at usual place in GDrive
repository.
Gilles Caulier
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #82 from caulier.gil...@gmail.com ---
I will recompile the AppImage this week end as well...
Gilles Caulier
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #81 from Jens ---
I would really like to see/review this change. Is there a chance to replace 1-2
compiled files in the appimage (libraries etc) or will you compile new
appimages anyway in a few days?
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #80 from Maik Qualmann ---
Git commit 5cd5b23b6ddb9eab927f1e7a68e593c138c7c538 by Maik Qualmann.
Committed on 23/03/2017 at 20:18.
Pushed by mqualmann into branch 'master'.
draw grouped border only if the group
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #79 from Simon ---
Currently the "grouping indication" (rotated frames in background) are visible
whether the group is expanded or not. I think it should only be visible when
the group is not expanded.
--
You are
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #78 from Maik Qualmann ---
Git commit 2a54e446e2a9cf04d9b79360d1d12405a188a2c3 by Maik Qualmann.
Committed on 20/03/2017 at 19:49.
Pushed by mqualmann into branch 'master'.
apply visual patch for grouped images
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #77 from caulier.gil...@gmail.com ---
Maik,
I like the "mouse over with 50% transparency" idea. What do you think about ?
Gilles
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #76 from Jens ---
How about we visually (!) treat an opened group like a subalbum at the
respective position in the list of images? the master image should then also be
in the subalbum and must still be
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #75 from caulier.gil...@gmail.com ---
MAik,
Look also that an enum must be used here, about background color :
+if (isSelected)
+{
+backgroundtype = 1;
+}
+else if (isGroupExpanded)
+{
+
https://bugs.kde.org/show_bug.cgi?id=361047
Maik Qualmann changed:
What|Removed |Added
Attachment #104642|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #74 from Maik Qualmann ---
Created attachment 104647
--> https://bugs.kde.org/attachment.cgi?id=104647=edit
patch version 7
- visual appearance of non-grouped thumbnails is now unchanged
- geolocalization icon at
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #73 from Maik Qualmann ---
No, the patch is not ready yet. The geolocation icon position is not yet
correct. I know why, but I want to optimize some things.
Maik
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #72 from caulier.gil...@gmail.com ---
Simon, Maik,
If this patch do not introduce dysfunctions for you, it can be applied to
git/master and proposed to end users as testing through pre-release bundles.
Gilles
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #71 from Maik Qualmann ---
Git commit b425579e132fd21cb3be963bea50e5ab30678316 by Maik Qualmann.
Committed on 19/03/2017 at 09:46.
Pushed by mqualmann into branch 'master'.
fix small size from the globe icon
M +2
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #70 from caulier.gil...@gmail.com ---
Maik,
Same problem with patch applied. The position of GPS icon overlay is a little
bit different too...
https://www.flickr.com/photos/digikam/33396556291
Gilles
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #69 from caulier.gil...@gmail.com ---
Maik,
Outside the current patch, the git/master implementation has a problem with GPS
icon overlay. It do not follow the thumbnail size as other icon overlay
(rotate, selection, etc).
This problem do
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #68 from caulier.gil...@gmail.com ---
Simon,
The patch version 6 work well. We near to finalize it.
Maik,
Please test with all icon view options enabled. Change thumbnails size and look
if all items info still displayed as expected.
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #104371|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #66 from caulier.gil...@gmail.com ---
Hi Simon,
I agree that no performance issue is visible with grouped frame pixmap. The
cache is well used...
But look well in patch :
if (!d->ratingRect.isNull())
{
-drawRating(p,
https://bugs.kde.org/show_bug.cgi?id=361047
Simon changed:
What|Removed |Added
Attachment #104161|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #64 from caulier.gil...@gmail.com ---
Hi Jens,
Not for the moment. I'm not at home without all my VM. Please weait next week.
We need also to fix some problem with icon overlays before. As well it's not
suitbale if some thumbnails options
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #62 from caulier.gil...@gmail.com ---
Jens,
I updated the patch to be compilable with current implementation from
git/Master. I don't introduce the SVG idea.
The result is not too bad. There are some problems with icons overlays, as
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Component|Usability |AlbumsView-Group
--
You are
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #98630|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Attachment #99002|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #60 from Jens ---
My originally suggested "rotated" frame can well be precomputed and just added
around the image as a border. I wasn't implying the frame should be recomputed
on every image (although this
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #59 from Wolfgang Scheffner ---
Quite nice, that one!
What I was talking about is not an additional icon but a stacked frame *like*
the icon. Might be easier than a rotated frame.
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #58 from Jens ---
I think modifying the thumbnail is essential here, otherwise it's not obvious
that this is actually a group. An additional icon or *only* the background will
not do.
But if the thumbnail
https://bugs.kde.org/show_bug.cgi?id=361047
Wolfgang Scheffner changed:
What|Removed |Added
CC|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #56 from caulier.gil...@gmail.com ---
Jens,
Nothing for the moment. It still in my TODO list.
If you want to take a look in the patch, in fact the main implementation is
already done, but the visual rendering need to be rewritten.
In fact
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #55 from Jens ---
Any news here? Anything I can do to help? Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Severity|normal |wishlist
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #54 from Jens B. Benecke ---
OK, no hurry. .)
Anything I can do to help (non-coder)? I have some more time now.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #53 from caulier.gil...@gmail.com ---
The patch is not yet integrated because Its not visually suitable and do not
work yet in all conditions. The basis is here but GUI code need to be rewrites.
Gilles caulier
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #52 from Jens B. Benecke ---
I just updated to Digikam 5.3 and this patch does not seem to be applied to it
yet. Is there something I need to configure to have this functionality?
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Ever confirmed|0 |1
Status|RESOLVED
https://bugs.kde.org/show_bug.cgi?id=361047
andreas changed:
What|Removed |Added
Resolution|--- |INVALID
https://bugs.kde.org/show_bug.cgi?id=361047
Maik Qualmann changed:
What|Removed |Added
CC||metzping...@gmail.com
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #50 from Omar Amin ---
Sure.
I'll max tomorrow send you a list of screenshots with the colors for feedback,
I've found a side effect from my patch and i'm working on it and will get back
to you soon.
Omar
--
You
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #49 from Jens B. Benecke ---
Right now, I do not have the chance to compile KDE or Digikam, but I will
happily review and comment any screenshots. Sorry ... maybe in two weeks time.
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #48 from caulier.gil...@gmail.com ---
Jens,
Did you test the last Omar patch against current implementation from git/master
? Any feedback ?
Gilles Caulier
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #98977|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #42 from Omar Amin ---
Created attachment 98977
--> https://bugs.kde.org/attachment.cgi?id=98977=edit
Not final patch, just a trial for feedback
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #41 from caulier.gil...@gmail.com ---
Omar,
If you update you patch, Jens will be able to test last version of your code
(if he work with current implementation from git/master)...
Gilles Caulier
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #40 from Jens B. Benecke ---
Some comments from my side since I opened the original bug:
I like the progress and I am really thankful that there is so much effort
invested in this feature!
I think the
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #39 from Omar Amin ---
Dear Mr Gilles,
I've attached three images for the three problems i'm currently addressing:
1- Group border was transparent so when the theme is changed to black
background, the border is
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #38 from Omar Amin ---
Created attachment 98939
--> https://bugs.kde.org/attachment.cgi?id=98939=edit
Group images highlighted when group is expanded
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #37 from Omar Amin ---
Created attachment 98938
--> https://bugs.kde.org/attachment.cgi?id=98938=edit
progress in ensure the image border doesn't go outside the thumbnail border,
temp solution
--
You are
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #36 from Omar Amin ---
Created attachment 98937
--> https://bugs.kde.org/attachment.cgi?id=98937=edit
Black background theme, group bordered is filled
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #35 from caulier.gil...@gmail.com ---
Any progress here ?
Gilles Caulier
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #33 from caulier.gil...@gmail.com ---
In your stack proposal has the stack icon over the thumb. This one is already
outside the thumb because it's clickable to open/close the stack. If you move
it over the thumb, as the thumb is also
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #32 from Omar Amin ---
if we need to use the rotated borders, we can adjust the border for each image
at different thumbnail sizes differently that will make us able to fit the
rotated borders at different thumbnail
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #31 from Omar Amin ---
Dear Mr Gilles and Mr Jens,
I made this simple stack just for confirming if that's what we need or not?, i
made it on a separate project to make the compilation quicker, that's why not
all
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #30 from Omar Amin ---
Created attachment 98715
--> https://bugs.kde.org/attachment.cgi?id=98715=edit
stack proposal
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #29 from caulier.gil...@gmail.com ---
Also take a care of color theme used with DK. Look in settings menu for
details.
If you render the border frame inside the thumbs, take a care about thumbs
color content.
I think that we must to render
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #28 from caulier.gil...@gmail.com ---
No. The LR screenshot is just to indicate how pro application do the job. It
just informative.
LR do no make better than us... That all.
The information in DK about grouped items is already here and at
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #26 from Omar Amin ---
(In reply to caulier.gilles from comment #25)
> Note : LightRoom groupped items is called "Image Stacked". It's explained
> here :
>
> http://valeriegoettsch.com/lightroom-grid-view-icons/
>
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #25 from caulier.gil...@gmail.com ---
Note : LightRoom groupped items is called "Image Stacked". It's explained here
:
http://valeriegoettsch.com/lightroom-grid-view-icons/
Excepted the icon+number of items in the stack, no specify frames
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #24 from caulier.gil...@gmail.com ---
Screenshot :
https://www.flickr.com/photos/digikam/26086592624/in/dateposted-public/
https://www.flickr.com/photos/digikam/26086592554/in/dateposted-public/
Gilles Caulier
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #23 from caulier.gil...@gmail.com ---
The new patch do not work better in HD thumb size.
1/ the frame go outside the icon border.
2/ with black color theme, frame is invisible.
3/ The side-effects are less visible with small thumb size, but
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #22 from Omar Amin ---
Dear Mr Gilles,
I'm sorry for being late, attached the new patch containing the modifications
needed for centring the thumbnail inside the group borders, If we have time I
can work on the
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #98455|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #20 from caulier.gil...@gmail.com ---
So i'm waiting new patch to review...
Gilles Caulier
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #19 from Mohamed ---
Hi,
I tried to adjust the thumbnail size to 512 on my 32" screen, and I see no
problem.
Mohamed Anwer
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #18 from caulier.gil...@gmail.com ---
HD thumbnails option permit to use largest thumbs (> 256 pixels)
Use silder on statusbar to change icon thumbs size. You can increase it over
256 until 512 .
Note : For me the screenshot look good.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #17 from Omar Amin ---
Hello,
I've fixed the centring issue for the thumbnail and have attached a sample for
3 different groups, please let me know if you think they're still not
symmetrical.
Regarding the large
https://bugs.kde.org/show_bug.cgi?id=361047
Omar Amin changed:
What|Removed |Added
Attachment #98456|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #15 from Omar Amin ---
Dear Mr Gilles,
I'm sorry for being late, I'll start today on it, and also tomorrow will be
working on it the whole day, and will send a patch tomorrow max.
Mr Jens, yes for sure i can, I'll
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #14 from caulier.gil...@gmail.com ---
Omar,
Did you work on a new patch ?
Gilles Caulier
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #13 from Jens B. Benecke ---
This looks great! Thank you for implementing!
One little request .. can you make the grouped border a little darker? I think
it would be better visible. Or does it depend on
https://bugs.kde.org/show_bug.cgi?id=361047
--- Comment #11 from caulier.gil...@gmail.com ---
Thanks Omar for you patch.
1/ code cosmetic :
* Always add a space after a coma, especially with methods arguments.
* Try to always align code with multi-lines
* Wrap code with bracket after if/else
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Version|4.14.0 |5.0.0
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=361047
caulier.gil...@gmail.com changed:
What|Removed |Added
Summary|Wishlist: make grouped |Wishlist: make grouped
78 matches
Mail list logo