[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-15 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #30 from Maik Qualmann --- I have already restored the setting "Show Progress Indicator" to save in the config file. Will work again in the next pre-release bundles. Maik -- You are receiving this mail because: You are watching all bug

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #29 from griffiths_a...@icloud.com --- F2 to show the prefs works OK. Could you now please address the persistence of the 'Show Progress Indicator' setting? That's what I originally wanted looking at so that I don't need to change settings

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-15 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #28 from griffiths_a...@icloud.com --- (In reply to Maik Qualmann from comment #27) > Git commit a6dff862e40beb4460bd0bade01746fbb96601df by Maik Qualmann. > Committed on 14/04/2020 at 20:33. > Pushed by mqualmann into branch 'master'. > >

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-14 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #27 from Maik Qualmann --- Git commit a6dff862e40beb4460bd0bade01746fbb96601df by Maik Qualmann. Committed on 14/04/2020 at 20:33. Pushed by mqualmann into branch 'master'. add the F2 key as a workaround to show the settings The F2 key is

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-04 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #26 from griffiths_a...@icloud.com --- Hi Nghia, Thanks for agreeing to have a look at my issue. I agree, the use of a hotkey does seem like it will be a confusing thing, and not obvious unless referenced in documentation, which of course

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-03 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #25 from Minh Nghia Duong --- (In reply to griffiths_andy from comment #22) > Since the slideshow preferences have moved in 7.0.0-beta3 to within the > slideshow screen itself as part of the progress indicator buttons, it is > observed that

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-03 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #24 from Minh Nghia Duong --- Hello, Yes, sure. I will try -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #23 from caulier.gil...@gmail.com --- Hi Nghia, If you can provide a small patch for the Andy comment #22, it will be great. Thanks in advance Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-04-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 griffiths_a...@icloud.com changed: What|Removed |Added CC||griffiths_a...@icloud.com ---

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-21 Thread Maik Qualmann
https://bugs.kde.org/show_bug.cgi?id=414055 Maik Qualmann changed: What|Removed |Added Version Fixed In||7.0.0 Latest Commit|

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #20 from caulier.gil...@gmail.com --- Maik, I applied all patches from Nghia about this entry (81 commits). All the coding style, implementations, analysis are in top level. You can judge yourself :

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-14 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #19 from caulier.gil...@gmail.com --- Thanks a lots Nghia, I review your patch today for a final integration in git/master Best Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-14 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #18 from Minh Nghia Duong --- Hello, I have completed the plugin slideshow and here is the link to my merge request: https://invent.kde.org/kde/digikam/-/merge_requests/11 Thank you in advance for reviewing it for me. Nghia -- You are

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-10 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #17 from caulier.gil...@gmail.com --- Mingh, Look well : SlideShow::toogleTag(int) function is used... at just one place : in TagsActionMngr class :

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-10 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #16 from Minh Nghia Duong --- I am adding these updating functionalities to setItemInfo of DBInfoIface but one thing a little bit weird appears to me. It is that the method toggleTag of SlideShow is used nowhere. This method only emit a

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-10 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #15 from caulier.gil...@gmail.com --- Minh, There is a glitch in patch : /home/gilles/Documents/GIT/7.x/core/dplugins/generic/view/slideshow/common/slideshowloader.cpp: In member function ‘void

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #14 from caulier.gil...@gmail.com --- >Could you take a look at the patch and help me reverify these functionalities? >>If they haven't existed, can I have permission to add it to the code base of >>DInfoInterface? Yes, typically,

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-09 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #13 from caulier.gil...@gmail.com --- I take a loo while this morning and give you a feedback Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-09 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 Minh Nghia Duong changed: What|Removed |Added Attachment #126428|0 |1 is obsolete|

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #11 from caulier.gil...@gmail.com --- great thanks... Gilles -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-06 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #10 from Minh Nghia Duong --- Hello Gilles, I am finalizing it. I will deliver to you the patch tomorrow. -- You are receiving this mail because: You are watching all bug changes.

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #9 from caulier.gil...@gmail.com --- Nghia, We are close to have a finalized patch. Please update it while this week end if possible, i would to review and include code for next 7.0.0 beta 3 planed at 16 march. Tomorrow i teach all the

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-03-01 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #8 from caulier.gil...@gmail.com --- Hi Nghia, 1/ If you want to uderstand how to work the plugin architecture, take a look first in the test CLI tool for generic plugins:

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-02-29 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #7 from Minh Nghia Duong --- Thanks Gilles, It has been clearer to me. Could you point me to the function or the file where the slideshow is initiated from the main interface? Because I have only found codes in app/view/stack where some

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-02-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #6 from caulier.gil...@gmail.com --- SlideshowBuilder is just a class to parse album recursively. It's only used by digiKam, not shwofoto, as this one do not support albums. Slideshow tool can be started from digiKam, and only digiKam in

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-02-29 Thread Minh Nghia Duong
https://bugs.kde.org/show_bug.cgi?id=414055 --- Comment #5 from Minh Nghia Duong --- Gilles, Actually Yes, It's still unclear to me how the information is passed between DInfoIterfaces and what is the link of classes SlideShowBuilder and SlideShow except that they use SlideShowSettings in

[digikam] [Bug 414055] Port Slideshow tool to plugin architecture [patch]

2020-02-29 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=414055 caulier.gil...@gmail.com changed: What|Removed |Added Summary|Port Slideshow tool to |Port Slideshow tool to