https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #241 from Maik Qualmann ---
Yes, I agree.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #240 from caulier.gil...@gmail.com ---
I think we can plan to release the 7.2.0 beta1 soon.
It's fine for you?
Gilles
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=426175
Maik Qualmann changed:
What|Removed |Added
Version Fixed In||7.2.0
Status|REPORTED
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #238 from Maik Qualmann ---
The reported problems in libpgf are almost negligible. And yes, I've never seen
anything like the clang-tidy patch for pass by value in a Qt project.
Maik
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #237 from caulier.gil...@gmail.com ---
Maik,
about the clang-tidy patch for pass by value in constructor, you can forget it.
It make the code less clear than before.
Gilles
--
You are receiving this mail because:
You are watching all bug
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #236 from caulier.gil...@gmail.com ---
Maik,
cppcheck and clang-scan reports now parse libpgf. Look the results:
https://www.digikam.org/reports/cppcheck/master/
https://www.digikam.org/reports/clang/master/
Gilles
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #235 from caulier.gil...@gmail.com ---
Git commit 11bd6030db6497f4ecf3be05daa10c64743e8750 by Gilles Caulier.
Committed on 03/10/2020 at 08:02.
Pushed by cgilles into branch 'master'.
enable static analyzer reports for libpgf to check if
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #234 from caulier.gil...@gmail.com ---
Maik,
About your fix in libpgf, well seen. This is a good candidate for an UPSTREAM
report, but i think we can do more.
All static analyzers ignore libpgf errors and warnings. There is a rule in
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #233 from Marcel ---
The test runs now for 12 hours without a crash. Good job Maik and Gilles. Thank
you for fixing that. I will continue the run to see if it finishes without a
crash but I guess we can close this issue.
--
You are
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #232 from Maik Qualmann ---
Git commit 4f16275e2d2c19b59f991d087e98af707daf0ae8 by Maik Qualmann.
Committed on 03/10/2020 at 05:20.
Pushed by mqualmann into branch 'master'.
we can optimize this due to changes in setStatus()
M +4-22
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #231 from Maik Qualmann ---
Git commit 28697b87b1ea439425711eec490df15ab8e089e9 by Maik Qualmann.
Committed on 02/10/2020 at 19:24.
Pushed by mqualmann into branch 'master'.
fix internal libpgf, do not use realloc() when memory was
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #230 from Maik Qualmann ---
The problem is clear, memory was created with new. It is necessary to increase
the memory, now realloc() is used. We should report this to libpgf as a bug. I
will patch our internal libpgf.
Maik
--
You are
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #229 from Marcel ---
Created attachment 132064
--> https://bugs.kde.org/attachment.cgi?id=132064=edit
asan error in CPGFMemoryStream
Maik, the test run for a long time. I original error did not occur. Instead
this one was shown after
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #228 from Maik Qualmann ---
I'll have to read it through tomorrow, the patch looks strange to me...
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #227 from caulier.gil...@gmail.com ---
Created attachment 132054
--> https://bugs.kde.org/attachment.cgi?id=132054=edit
threadimageio clang-tidy patch about pass by value
Maik,
clang-tidy provide also fixes about pass by value arguments
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #226 from Marcel ---
Maik, the version now looks very promising. It already works for hours without
a crash. I saw you reverted most changes (even the typo fix :-) ). In your
commit message are you writing "test this small change". What
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #225 from Maik Qualmann ---
Git commit e2be75c6cf36a6a8252a353679b2a871103d6116 by Maik Qualmann.
Committed on 01/10/2020 at 10:39.
Pushed by mqualmann into branch 'master'.
after revert to the old code, we test this small change
M +11
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #224 from Maik Qualmann ---
Git commit 0e2cc57c29f218cb0e9002d0b852aca4c0e25bf2 by Maik Qualmann.
Committed on 30/09/2020 at 20:48.
Pushed by mqualmann into branch 'master'.
use QMap again
M +12 -12
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #223 from Maik Qualmann ---
Git commit 92cfeba3a750ba95b4665a4c2e3e8ccfe0dee627 by Maik Qualmann.
Committed on 30/09/2020 at 20:44.
Pushed by mqualmann into branch 'master'.
remove only one listener
M +1-1
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #222 from Marcel ---
No look, it still crashes, at least with asan enabled.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #221 from Marcel ---
Maik, I tried it with your commit
https://invent.kde.org/graphics/digikam/-/commit/a296fd327a98a5d5ffbf6690cec4eb5b85de0330
but it again crashed after a few minutes.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #220 from Maik Qualmann ---
Git commit 84779e8dca5c96503a77a127874a0f13b37894d4 by Maik Qualmann.
Committed on 30/09/2020 at 18:10.
Pushed by mqualmann into branch 'master'.
do not return a pointer from QCache, it can be deleted
M +18
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #219 from Maik Qualmann ---
Hi Marcel,
it would be good if you could test the last change.
Maik
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #218 from Maik Qualmann ---
Git commit a296fd327a98a5d5ffbf6690cec4eb5b85de0330 by Maik Qualmann.
Committed on 30/09/2020 at 06:04.
Pushed by mqualmann into branch 'master'.
drastic change to the image cache lock
M +0-1
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #217 from caulier.gil...@gmail.com ---
Git commit edbd8d5d2f401f6c4bbda134749fa092d76b565e by Gilles Caulier.
Committed on 30/09/2020 at 03:43.
Pushed by cgilles into branch 'master'.
apply clang tidy override modernize C++11 patch
M +4
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #216 from caulier.gil...@gmail.com ---
Git commit e331ff2d3241ce4fec690ddd67a7ffbff1ac587c by Gilles Caulier.
Committed on 30/09/2020 at 03:40.
Pushed by cgilles into branch 'master'.
apply clang tidy override modernize C++11 patch
M +4
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #215 from Maik Qualmann ---
Git commit e73d3b37b565081d6768cc22f75464befa7e4ded by Maik Qualmann.
Committed on 29/09/2020 at 17:31.
Pushed by mqualmann into branch 'master'.
apply the clang tidy patches
M +1-1
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #214 from caulier.gil...@gmail.com ---
Marcel,
Read this (:=)))
https://stackoverflow.com/questions/53032915/clang-tidy-inserts-multiple-override-specifiers-when-fixing
Gilles
--
You are receiving this mail because:
You are watching all
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #213 from caulier.gil...@gmail.com ---
Hi Marcel,
Yes i seen too the double "override" keyword. Why clang-tidy do that, i don't
know. This is why it's very important to review patch created by non human.
Gilles
--
You are receiving this
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #212 from Marcel ---
Feedback about patch:
only one override
+~ActionJob() override override;
+~ActionThreadBase() override override;
+~DynamicThread() override override;
+~ThreadManager() override override;
+
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #211 from caulier.gil...@gmail.com ---
Created attachment 132003
--> https://bugs.kde.org/attachment.cgi?id=132003=edit
clang tidy patch for override fixes in theads
Maik, please review the 2 patches generated by cland-tidy modernize C++
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #210 from caulier.gil...@gmail.com ---
Created attachment 132002
--> https://bugs.kde.org/attachment.cgi?id=132002=edit
clang tidy patch for override fixes in theadimageio
Generated following this note:
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #209 from Maik Qualmann ---
Git commit 85c6c8c4585bcf3e7e779daaf9b17bfa386fab1a by Maik Qualmann.
Committed on 28/09/2020 at 19:01.
Pushed by mqualmann into branch 'master'.
we switch to a QHash for testing
M +2-2
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #208 from Marcel ---
Created attachment 131985
--> https://bugs.kde.org/attachment.cgi?id=131985=edit
Again address Sanitizer error on PreviewLoadingTask
I tested the face detection feature again. This time with YOLO and clang
compiler
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #207 from caulier.gil...@gmail.com ---
Marcel,
Don't forget to install at least asan and lsan devel packages. First one is to
check address in uses sanitizer and second one is memory leak sanitizer.
Gilles
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #206 from Marcel ---
Gilles, thank you very much for this detailed explanation. I really appreciate
that. So it definitely makes sense as it is :-)
@Maik, does it help to upload some resent backtraces and address sanitizer
errors or do you
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #205 from caulier.gil...@gmail.com ---
Git commit a2b9c9b54eacdc0b5fc66b4b740d4f5b629e9556 by Gilles Caulier.
Committed on 26/09/2020 at 08:03.
Pushed by cgilles into branch 'master'.
Faces Engine stage 4: remove another legacy unused class
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #204 from caulier.gil...@gmail.com ---
Hi Marcel,
Sorry for my late response but i'm very busy in my office.
>Should I run Digikam with the address sanitizer enabled?
Both. First without, and in second if it continue to crash, with ASAN.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #203 from caulier.gil...@gmail.com ---
Git commit 3bcd5d8a28bf10acd0710805b2fa5f8ed2ad42a2 by Gilles Caulier.
Committed on 26/09/2020 at 06:46.
Pushed by cgilles into branch 'master'.
FacesEngine: cleanup stage 3 : move usused FunnelReal
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #202 from Marcel ---
Gilles,
thank you for your effort. I will test the code now again. Should I run Digikam
with the address sanitizer enabled?
In my opinion we could close this huge bug and open new bugs for new problems,
is that all
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #201 from caulier.gil...@gmail.com ---
Marcel,
I cleaned all dead code in face engine, typically all legacy algorithms not
based on DNN.
I'm not sure if this will have an effect at run time, but at least, now the
implementations are more
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #200 from caulier.gil...@gmail.com ---
Git commit b6a240f95754eaa188f3aa97c59fdbd9785daa91 by Gilles Caulier.
Committed on 25/09/2020 at 05:38.
Pushed by cgilles into branch 'master'.
Face Engine: remove dead code stage 2: Switch
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #199 from caulier.gil...@gmail.com ---
Git commit 880c377630be3393779185e1d1297e4957ff595b by Gilles Caulier.
Committed on 25/09/2020 at 04:15.
Pushed by cgilles into branch 'master'.
Face Engine: move dead code not exported and only used
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #198 from caulier.gil...@gmail.com ---
Git commit 65c9aa3d4fa6eea92409f786a0ba786332777682 by Gilles Caulier.
Committed on 25/09/2020 at 04:05.
Pushed by cgilles into branch 'master'.
Face Engine: remove dead code aka flandmarkaligner
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #197 from caulier.gil...@gmail.com ---
Git commit c8721ba35c4b99cfed8696d2f7a01f2a8a66bac2 by Gilles Caulier.
Committed on 25/09/2020 at 03:42.
Pushed by cgilles into branch 'master'.
Face engine: remove dead codes aka Eigen face
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #196 from Maik Qualmann ---
I specifically debugged this WorkerObject class. Even if the analysis tools
report an error here, everything in the order of destruction is OK. Right, the
derived class is destroyed first. But then the
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #195 from caulier.gil...@gmail.com ---
Right Maik,
I fixed some this-> entry in source code in the pass after a large cppcheck
report about dynamic binding problem. This one is a fix by me.
You are right, instead to use this->, we must use
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #194 from Maik Qualmann ---
Yes, calling virtual functions in the constructor / destructor can cause
problems. I also think that "this->aboutToDeactivate()" now never calls the
derived class through "this". I'm testing it out tonight. I
https://bugs.kde.org/show_bug.cgi?id=426175
Scott changed:
What|Removed |Added
CC|scottie...@yahoo.co.uk |
--
You are receiving this mail because:
You are
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #193 from caulier.gil...@gmail.com ---
Maik,
I experiment the clang-tidy "linter" like analyzer with digiKam code and i
found this report :
clang-tidy -header-filter=^/home/gilles/Documents/GIT/7.x/build/.*
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #192 from caulier.gil...@gmail.com ---
Git commit 7ed7c3ae44b23e1f5f5da0fe7bf195bf2b325fe1 by Gilles Caulier.
Committed on 24/09/2020 at 02:15.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #191 from caulier.gil...@gmail.com ---
Git commit 04ca7557c15c4c7ce2cca005d054301d6d192562 by Gilles Caulier.
Committed on 24/09/2020 at 02:04.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #190 from caulier.gil...@gmail.com ---
Git commit cd1b6f82957813746a3f44a0251c1decab4790d7 by Gilles Caulier.
Committed on 24/09/2020 at 01:56.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #189 from caulier.gil...@gmail.com ---
Git commit 7600efe92d5979545189649229f01b4568361485 by Gilles Caulier.
Committed on 23/09/2020 at 15:54.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #188 from caulier.gil...@gmail.com ---
Git commit f08d194f50b41c6d68fbb0855db20f807e5e7bfd by Gilles Caulier.
Committed on 23/09/2020 at 10:10.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #187 from caulier.gil...@gmail.com ---
Git commit 8b8aae7b266b94181239ed6e559deef4a4512f6c by Gilles Caulier.
Committed on 23/09/2020 at 09:27.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #186 from caulier.gil...@gmail.com ---
Git commit 1ac2776d8ccee771a09dcb4ee4ec1699d7eaf65a by Gilles Caulier.
Committed on 23/09/2020 at 09:12.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #185 from caulier.gil...@gmail.com ---
Git commit d0cf9690e91b59a98e152985535912516eb1e392 by Gilles Caulier.
Committed on 23/09/2020 at 09:00.
Pushed by cgilles into branch 'master'.
This class is just a static methods container. No need
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #184 from caulier.gil...@gmail.com ---
Git commit 5ca5eb5260994a4b4200c1626a31b78aeef02858 by Gilles Caulier.
Committed on 23/09/2020 at 08:55.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #183 from caulier.gil...@gmail.com ---
Git commit 1f11358b3918a16d7576f6f8a80b644544784975 by Gilles Caulier.
Committed on 23/09/2020 at 08:46.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #182 from caulier.gil...@gmail.com ---
Git commit 8333a8f06f714950729d7a85d87c9eb9d0cc4a6c by Gilles Caulier.
Committed on 23/09/2020 at 05:53.
Pushed by cgilles into branch 'master'.
We can disable copy constructor and equality operator
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #181 from Maik Qualmann ---
Git commit 9f89a5264d45d9cffdd331b7a5d98a4dbde45b51 by Maik Qualmann.
Committed on 22/09/2020 at 19:21.
Pushed by mqualmann into branch 'master'.
preview loading tasks with new stop logic
M +20 -51
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #180 from caulier.gil...@gmail.com ---
Git commit d4b496877424462cc01c1860bf2bbc544cdb9585 by Gilles Caulier.
Committed on 22/09/2020 at 14:49.
Pushed by cgilles into branch 'master'.
add default contructor and destructor
move
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #179 from caulier.gil...@gmail.com ---
Hi Marcel,
This is interresting, because my change are pure cosmetic for the moment.
Typically i moved all class method implementation from headers to cpp files,
and append missing default
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #178 from Marcel ---
Created attachment 131868
--> https://bugs.kde.org/attachment.cgi?id=131868=edit
Address Sanitizer error on PreviewLoadingTask
Gilles, I just checked your changes on the PreviewLoadingTask. I got an error
on the
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #177 from caulier.gil...@gmail.com ---
Git commit 5ce6276093c8a636d6844b060cb9020f01c20f18 by Gilles Caulier.
Committed on 22/09/2020 at 13:12.
Pushed by cgilles into branch 'master'.
move all implmentations to cpp files. Header must
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #176 from caulier.gil...@gmail.com ---
Git commit 51e1ccaa60e71f253bb7c760a3f5c678f3cbc902 by Gilles Caulier.
Committed on 22/09/2020 at 05:33.
Pushed by cgilles into branch 'master'.
move all implmentations to cpp files. Header must
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #175 from Marcel ---
Created attachment 131853
--> https://bugs.kde.org/attachment.cgi?id=131853=edit
heap-use-after-free error
I run Digikam with the address sanitizer
(fbf127ecf30867613d3fe247be85b4f09533e046). Indeed there was an
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #174 from caulier.gil...@gmail.com ---
Git commit a2f03025488e56fc2c1ae2f3f2e48388b09c0e0f by Gilles Caulier.
Committed on 22/09/2020 at 03:39.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #173 from caulier.gil...@gmail.com ---
Git commit aa1de72a075ef92c753b90021488e555b246ae42 by Gilles Caulier.
Committed on 22/09/2020 at 03:38.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #172 from caulier.gil...@gmail.com ---
Git commit 198dc96fe39c17c038b4b0782fca81cc199bbdc7 by Gilles Caulier.
Committed on 22/09/2020 at 03:52.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #171 from caulier.gil...@gmail.com ---
Git commit 464c7cf5d10f84bacfbbe98fe4fa6193e1d64773 by Gilles Caulier.
Committed on 22/09/2020 at 03:09.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #170 from Maik Qualmann ---
Git commit c12a37ca883329d746c74fa54b94cd39eb8324c9 by Maik Qualmann.
Committed on 21/09/2020 at 20:55.
Pushed by mqualmann into branch 'master'.
remove the created thumbnails threads because they are unused
M
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #169 from caulier.gil...@gmail.com ---
Marcel,
yes sure a patch is always welcome.
Gilles
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #168 from Maik Qualmann ---
Git commit 090bfe8ffd2ec534a0f2a100e4e2e4c3083e300b by Maik Qualmann.
Committed on 21/09/2020 at 19:47.
Pushed by mqualmann into branch 'master'.
reduce sent face packets
M +1-1
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #167 from Marcel ---
Gilles, thank you for this tip with htop. Great to know about such debug
possibilities. Unfortunately the name of about half of the QThread's have the
name "Thread (pooled)".
About the asan. It now works on my
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #166 from caulier.gil...@gmail.com ---
QThread object name visible as Linux process : the explaination are there :
https://stackoverflow.com/questions/19854932/is-there-a-portable-way-to-give-thread-name-with-qt
Gilles
--
You are
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #165 from caulier.gil...@gmail.com ---
Marcel,
In htop, you can setup to turn on the thread names. This can help to identify
the thread functions (i hope that all QThread instances are explicitly
identified with Linux Kernel. Typically, the
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #164 from Marcel ---
Created attachment 131836
--> https://bugs.kde.org/attachment.cgi?id=131836=edit
Face detection process in htop
I tested it on my system and it worked for more than 5 hours. After that
Digikam was killed by another
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #163 from Marcel ---
I now included the changes from Maik as well. My test runs now for over 40
minutes. Hey, it didn't crash and I can't see any significant increase in
memory. Probably the last changes from Maik finally solved this bug.
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #162 from Marcel ---
Bug news, on my test with clang the bad old error occurred again after a few
minutes of scanning:
Thread 47 "Thread (pooled)" received signal SIGSEGV, Segmentation fault.
#1 0x76a852b5 in
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #161 from Maik Qualmann ---
Git commit edcab64cdca0ae1800bab455724b9753dffd000c by Maik Qualmann.
Committed on 21/09/2020 at 06:05.
Pushed by mqualmann into branch 'master'.
for a test, remove myself from the loading listener beforehand
M
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #160 from caulier.gil...@gmail.com ---
Marcel,
This morning i append ASAN support. There is a new cmake compilation option:
https://invent.kde.org/graphics/digikam/-/blob/master/Mainpage.dox#L461
You need to install libasan-devel for
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #159 from Marcel ---
I run the face detection over night and run out of memory again, but it's
definitely not the seg fault from the Preview process that crashes to program.
This part is solved. Thank you Gilles.
It's true, I'm just
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #158 from caulier.gil...@gmail.com ---
Git commit ef51f605528649e9f509bd37d2710409f3bf83f0 by Gilles Caulier.
Committed on 20/09/2020 at 21:32.
Pushed by cgilles into branch 'master'.
Add new compilation option to enable compiler sanitizers
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #157 from caulier.gil...@gmail.com ---
Git commit 2b8a165d227d8cb9f90c21db745bc699d254ce44 by Gilles Caulier.
Committed on 20/09/2020 at 20:53.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #156 from Maik Qualmann ---
Git commit cd24540e6da7170b56e6a2b9a2de3138d0769969 by Maik Qualmann.
Committed on 20/09/2020 at 20:01.
Pushed by mqualmann into branch 'master'.
check if DImg data equal
M +4-1
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #155 from Minh Nghia Duong ---
(In reply to caulier.gilles from comment #154)
Yes, only one FaceExtractor is allocated at the init sequence of digikam. After
that, the multi-threading only envoked in the recognition process.
--
You are
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #154 from caulier.gil...@gmail.com ---
Nghia,
i think Marcel only play with face detection, not face recognition for the
moment. FaceExtractor in only relevant with face recognition workflow, right ?
Gilles
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #153 from Minh Nghia Duong ---
(In reply to caulier.gilles from comment #151)
> Marcel,
>
> You lost memory a little bit, but the infamous crash in Preview thread
> disappear. Right ?
>
> If yes, we will trying to discover the source of
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #152 from caulier.gil...@gmail.com ---
Git commit a8f47f320928428f102df5ff40a86c3d41184c89 by Gilles Caulier.
Committed on 20/09/2020 at 18:16.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #151 from caulier.gil...@gmail.com ---
Marcel,
You lost memory a little bit, but the infamous crash in Preview thread
disappear. Right ?
If yes, we will trying to discover the source of the problem for this memory.
Next stage for me is to
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #150 from Marcel ---
(In reply to caulier.gilles from comment #145)
> Marcel,
>
> I patched all DMetadata/MetaEngine instance to use heap instead stack to
> prevent stack overflow.
>
> This will improve the stability on your computer ?
>
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #149 from caulier.gil...@gmail.com ---
Git commit 3f17d2d4ee8f2877ae6036387ad1360beac1ca84 by Gilles Caulier.
Committed on 20/09/2020 at 16:10.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #148 from caulier.gil...@gmail.com ---
Git commit 10e2ecab81ecc4f45989f82987021a34dbb3558d by Gilles Caulier.
Committed on 20/09/2020 at 15:58.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #147 from caulier.gil...@gmail.com ---
Git commit b4589b0d2a0e31cb709da3554c0190c8d71f7b89 by Gilles Caulier.
Committed on 20/09/2020 at 15:49.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #146 from caulier.gil...@gmail.com ---
Git commit e79a1a3bd23e886cbb230395b588470dfd04c236 by Gilles Caulier.
Committed on 20/09/2020 at 14:30.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #145 from caulier.gil...@gmail.com ---
Marcel,
I patched all DMetadata/MetaEngine instance to use heap instead stack to
prevent stack overflow.
This will improve the stability on your computer ?
Gilles
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #144 from caulier.gil...@gmail.com ---
Git commit fc1026412d461c3922f430ab3b800323d2df98c7 by Gilles Caulier.
Committed on 20/09/2020 at 12:36.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
https://bugs.kde.org/show_bug.cgi?id=426175
--- Comment #143 from caulier.gil...@gmail.com ---
Git commit 115956282471cb03a45ea61a821da26a0df2d698 by Gilles Caulier.
Committed on 20/09/2020 at 12:32.
Pushed by cgilles into branch 'master'.
Use heap to create MetaEngine instance to prevent stack
1 - 100 of 240 matches
Mail list logo
