[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #23 from Christoph Cullmann --- Could you try if https://phabricator.kde.org/D10145 improves that? It includes the qCeil you wanted + includes the font leading. -- You are receiving this mail because: You are watching

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #22 from RJVB --- I still use m_fontHeight = qMax(1, qCeil(height)); on Mac, stock code on Linux, and that's perfectly satisfactory to me. Maybe you should accept that there are subtle platform differences in font

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 Christoph Cullmann changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #20 from RJVB --- What kind of news are you hoping for? I'm currently using the patch below with 5.29.0 on Mac and that works well enough. I should maybe try the patch on Linux too (not sure why I never did) because I

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #19 from Dominik Haumann --- So we have not made any decisiton. Rene, any news? -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #18 from Christoph Cullmann --- I think the issue with ceil was that you get space between lines that is not painted correctly. Perhaps we should just start to use float's for the height... -- You are receiving this mail

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #17 from RJVB --- I'd say that the most important aspect here is that behaviour is as much the same as possible across platforms. In this case that would mean that they all have a sufficient line spacing, and that a

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #16 from Dominik Haumann --- > I would be fine with changing that to ceil, floor > is a bad idea, no clue why we/I did not use ceil :/ Interestingly, I wondered why you changed if from ceil to floor, but I trusted you

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #15 from RJVB --- Did you compare the spacing with qCeil and qFloor on Linux and/or MS Windows? I find the line spacing just fine on Linux, and would regret it getting significantly more ample *). Maybe it can be tied

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #14 from Christoph Cullmann --- I would be fine with changing that to ceil, floor is a bad idea, no clue why we/I did not use ceil :/ -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #13 from RJVB --- Yes, that seems to have about the same effect as my tweak. `qCeil(1.005f * height)` is too much though (I tried that too, tuning down the extra space that was obtained in the original code). -- You

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #12 from Dominik Haumann --- What about this in ::updateFontHeight? -m_fontHeight = qMax(1, qFloor(height)); +m_fontHeight = qMax(1, qCeil(height)); Is this better? -- You are receiving this mail because: You

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #11 from RJVB --- What other OSes have you tried? I guess it must have something to do with the font engine, an observation that I think is supported by the fact that the adjustment isn't required when I use the

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #10 from Christoph Cullmann --- Hmm, any idea why we need that adjust? Seems strange, given no problem on other operating systems. -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #9 from RJVB --- FWIW, this seems to work acceptably for me: ```C++ void KateRenderer::updateFontHeight() { // use height of font + round down, ensure we have at least one pixel // we round down to avoid

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #8 from RJVB --- (In reply to RJVB from comment #4) > This commit? 4c83bac52716a08a549dca50a76be8aa47c11ca3 Clearly not only that commit. Reverting just that makes line spacing too generous (total text height

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #7 from RJVB --- (In reply to RJVB from comment #4) > This commit? 4c83bac52716a08a549dca50a76be8aa47c11ca3 Clearly not only that commit. Reverting just that makes line spacing too generous (total text height

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 RJVB changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #6 from RJVB --- Created attachment 102308 --> https://bugs.kde.org/attachment.cgi?id=102308=edit better line spacing with 5.24.0 -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #5 from RJVB --- Created attachment 102307 --> https://bugs.kde.org/attachment.cgi?id=102307=edit touching lines with 5.27.0 -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #4 from RJVB --- Hah, well, that misfired then, at least on OS X. I didn't check if 5.24.0 does worse with the FreeType font engine. This commit? 4c83bac52716a08a549dca50a76be8aa47c11ca3 -- You are receiving this

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 Christoph Cullmann changed: What|Removed |Added CC||cullm...@kde.org ---

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #2 from RJVB --- Created attachment 102305 --> https://bugs.kde.org/attachment.cgi?id=102305=edit no clipping with v5.24.0 -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 372629] [OS X] line height too low issue(s)

https://bugs.kde.org/show_bug.cgi?id=372629 --- Comment #1 from RJVB --- Created attachment 102304 --> https://bugs.kde.org/attachment.cgi?id=102304=edit glyph clipping in v5.2.7; Macintosh native style -- You are receiving this mail because: You are watching all bug