[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-16 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #31 from Nate Graham --- Git commit 2b23256b0a47526715e98352fe3a12db520c306f by Nate Graham. Committed on 16/10/2019 at 14:50. Pushed by ngraham into branch 'master'. [KCM] Limit scale factor increment to 6.25% on X11 Summary: Because of

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-02 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #30 from Christoph Cullmann --- fillRect bug with anti-aliasing reported here https://bugreports.qt.io/browse/QTBUG-78964 -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-02 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #29 from Christoph Cullmann --- I created bugs for the clipping issues found here and in Konsole. https://bugreports.qt.io/browse/QTBUG-78962 https://bugreports.qt.io/browse/QTBUG-78963 -- You are receiving this mail because: You are

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-02 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 Christoph Cullmann changed: What|Removed |Added Latest Commit||https://commits.kde.org/kte

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #27 from Christoph Cullmann --- And with stuff like 1.1 and some font sizes, you will still get sometimes a small artifact line ever xx lines. That's just the bad scaling of the rounding. But I think with that on can live. With some sane

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #26 from Christoph Cullmann --- I still want to get rid of factors like 1.1, as they still have lots of small glitches everywhere as you round the whole time, unlike for 1/16 or so. But at least with these hacks it not that bad. I added

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #25 from Christoph Feck --- That's what I meant, thanks! -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 Christoph Cullmann changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #23 from Christoph Cullmann --- Git commit 2d6c8f17f5e040ac05ea43ba1726c13c38e806a3 by Christoph Cullmann. Committed on 01/10/2019 at 20:02. Pushed by cullmann into branch 'master'. next rendering artifact goes away if you adjust the clip

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #22 from Christoph Cullmann --- Git commit 165a7a3b526ca70635e36e036e2f9cdd4b5947ce by Christoph Cullmann. Committed on 01/10/2019 at 19:40. Pushed by cullmann into branch 'master'. avoid the font choosing magic and turn of anti aliasing

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-10-01 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 Christoph Cullmann changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-09-29 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #20 from Christoph Cullmann --- There is nothing to round in virtual pixel. e.g. if the font is 10 virtual pixel high, you get real 12.5 real pixel if you scale with 1.25. KTextEditor will not at all see this and we will get some ugly lines

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-09-29 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #19 from Christoph Feck --- That looks like a hack indeed. I always assumed the bounding box used for clearing/background rendering wasn't correctly rounded to whole pixels, see Konsole's attempt at bug 373232 comment 31. Top/Left need to

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-09-29 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 Christoph Cullmann changed: What|Removed |Added Version Fixed In||5.63 -- You are receiving this mail

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-09-29 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 Christoph Cullmann changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-09-29 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #17 from Christoph Cullmann --- I have some potential fix, that works at least if you use scaling factors that are proper floating points like 1.25, 1.5, ... https://cgit.kde.org/ktexteditor.git/log/?h=hidpi-font-fixes Could somebody give

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-09-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=390451 andreas.sturmlech...@gmail.com changed: What|Removed |Added CC||andreas.sturmlechner@gmail.

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #16 from Christoph Cullmann --- Beside, please try the QT_SCALE_FACTOR=1.1 kwrite variant. For even the menu has maximal ugly repaint artifacts between the boundaries of the menu entries if I move over them (and they get selected) and I

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #15 from Christoph Cullmann --- Not really. The rounding errors add up, you will always end up with issues. Even the start position of the view is already then on some fraction of a pixel. I actually would more like that Qt would forbid

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-24 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #14 from Nate Graham --- For those cases, could we just round up or down a bit? Vertical mis-alignment would be preferable to these ugly horizontal lines IMO. -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-24 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #13 from Christoph Cullmann --- After more code inspection, I think we can improve here a bit, but not really fix that for 1.1. We need some non-fractional line height, both in "logic" and "real" coordinates. That means all is fine for

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-23 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #12 from Christoph Cullmann --- I play around with this some hours. The issue are rounding problems using QPainter in paintEvent. We loop over all lines, move each time the painter via translate(...) the line height down. Even though in

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-23 Thread Christoph Cullmann
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #11 from Christoph Cullmann --- I can reproduce this, too. -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=390451 --- Comment #10 from lukebe...@hotmail.com --- I can reproduce this on KDevelop, kate, and kwrite with: QT_SCALE_FACTOR=1.1 kwrite -- You are receiving this mail because: You are watching all bug changes.

[frameworks-ktexteditor] [Bug 390451] Horizontal Lines with Fractional Scaling on Apps that use KTextEditor framework

2019-08-22 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=390451 lukebe...@hotmail.com changed: What|Removed |Added Summary|Horizontal Lines with |Horizontal Lines with