[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-29 Thread Simon Andric
https://bugs.kde.org/show_bug.cgi?id=384471 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-12 Thread Leslie Zhai
https://bugs.kde.org/show_bug.cgi?id=384471 Leslie Zhai changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-11 Thread Thomas Schmitt
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #5 from Thomas Schmitt --- Hi, the new commit looks good to me. If we do not jump into the adventure of verifying the implicit assumptions about media types and write modes, then this bug report can be closed. Have a

[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-10 Thread Leslie Zhai
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #4 from Leslie Zhai --- Git commit 5051e3b80f66d4dc1308a8bbef54b845b8c54559 by Leslie Zhai. Committed on 11/09/2017 at 02:26. Pushed by lesliezhai into branch 'master'. Update comment. M +3-1

[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-08 Thread Thomas Schmitt
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #3 from Thomas Schmitt --- Hi, looks ok for me, besides another mistake by me: K3b::WritingAppCdrdao is not a complete criterion for the need for CD. The criterion in the code is distributed over two if-statements. As

[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-07 Thread Leslie Zhai
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #2 from Leslie Zhai --- Git commit e2a5e4d95c228cda313ad6dadffb23648c05081a by Leslie Zhai. Committed on 08/09/2017 at 03:05. Pushed by lesliezhai into branch 'master'. Thomas please review it. M +18 -21

[k3b] [Bug 384471] Media type selection for Image burning is partly wrong, comments are very wrong

2017-09-07 Thread Thomas Schmitt
https://bugs.kde.org/show_bug.cgi?id=384471 --- Comment #1 from Thomas Schmitt --- Hi, already the first bug in my bug report. Implemented decision 5 is indeed: 5. If not decided yet: DVD and BD media types. This seems to assume that all CD use cases are completely covered