https://bugs.kde.org/show_bug.cgi?id=377918

            Bug ID: 377918
           Summary: native dialogs: to use or not to use
           Product: kdevplatform
           Version: unspecified
          Platform: Compiled Sources
                OS: All
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: shell
          Assignee: kdevelop-bugs-n...@kde.org
          Reporter: rjvber...@gmail.com
  Target Milestone: ---

Created attachment 104682
  --> https://bugs.kde.org/attachment.cgi?id=104682&action=edit
introduce compile-time selection of the file dialog implementation

I think this topic has come up on the ML already, but it caught my attention
again:

KDevPlatform currently uses the KDE_FULL_SESSION variable to determine whether
or not it should use KDE file dialogs instead of "native" ones (read: Qt's
implementation of actual native dialogs).

I find this a bit silly for several reasons:
- both types of dialogs have their pros and cons, with the KDE dialogs having
considerable advantages for developers over the native Mac dialogs, in my
experience. KDevelop users ought to be perfectly capable of making their own
informed choice which they prefer. See also
https://bugs.kde.org/show_bug.cgi?id=371525#c1 .
- the main platforms for which the distinction was probably introduced both
allow users to set that env. variable (this is what makes the implementation
silly in my opinion).

I'd propose 2 alternative solutions:
- make it a build-time choice via a CMake option with the default set to match
the current behaviour. That's the simplest option which basically turns runtime
ifs into compile-time #ifdefs.
- make it a runtime user choice, with an option in the "User Interface" config
panel. Not unheard of esp. in complex, multipurpose workhorses (you'll find
such an option in Open/LibreOffice).

I'll attach a patch for the 1st alternative and am willing to look into the
2nd.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to