[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Latest Commit|http://commits.kde.org/kons

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Status|CONFIRMED |RESOLVED

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #13 from Martin Sandsmark --- He is very active reviewing patches, he'll probably get to this very soon. -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #12 from Antonio Russo --- I really appreciate your getting back to me. Thank you. I cannot "publish" the patch without it having a "review"---and I don't think I am allowed to review it myself (?). The first

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #11 from Martin Sandsmark --- Reviewboard isn't very good with series of patches, though you can mark patches as dependent on others I haven't really figured out the details. FWIW I don't seem to have access to

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #10 from Antonio Russo --- I am glad that the patch works for others. Sorry if this is turning into spam. I made a review request https://git.reviewboard.kde.org/r/128390/ but since I have a series of patches

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #9 from Martin Sandsmark --- The patches works for me, I get the correct strikethrough/overline, and the last one is invisible. The first one is with the normal color, the three remaining are in the faint color

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 Martin Sandsmark changed: What|Removed |Added CC|

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #7 from Antonio Russo --- The revised patchset has support for all default color schemes. There should be no issues using these color schemes. -- You are receiving this mail because: You are watching all bug

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #6 from Antonio Russo --- Created attachment 99927 --> https://bugs.kde.org/attachment.cgi?id=99927=edit Revised complete patchset tar.gz of 6 patches -- You are receiving this mail because: You are watching

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #5 from Antonio Russo --- The patch depends on a color style to implement the "faint" intensities for each color. I did this specifically for Linux.colorscheme (and it should is included in the patch) but did not

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 Kurt Hindenburg changed: What|Removed |Added Ever confirmed|0 |1

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #3 from Antonio Russo --- The attachment should be a tar.gz with 7 patches. On my debian machine it extracts with tar -xf . I've been using a version of konsole with these patches applied for about a month now,

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #2 from Kurt Hindenburg --- What is this attachment? gz or bz2? -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 362171] Patch review requested for implementation SGR 2/8/9/53 (dim/conceal/strikeout/overline)

https://bugs.kde.org/show_bug.cgi?id=362171 --- Comment #1 from Antonio Russo --- Created attachment 98546 --> https://bugs.kde.org/attachment.cgi?id=98546=edit SGR Implementation -- You are receiving this mail because: You are watching all bug changes.