https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #14 from Nate Graham ---
The user won't experience it 100% reproducibly (or at all) because the user
doesn't have asserts turned on.
I believe Martin said he was working on a change that fixes the assert without
regressing selection.
--
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #13 from Kurt Hindenburg ---
I agree stable should not caused regressions; however, a crash is far, far
worse as it will take out all the tabs. I can get it to crash at will. Now
for the user, which is more likely to happen and cause more
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #12 from Martin Sandsmark ---
I couldn't agree more. And +1 for an autotest for this, the selection code is
... above average in complexity, so it's not very comfortable to work on.
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #11 from Nate Graham ---
Yeah, I'll take my lumps if I made the wrong decision here. :) In the future
I'll wait before reverting.
We should also make sure we exhaustively test everything that goes into the
stable branch too. Feature
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #10 from Martin Sandsmark ---
I think I have a proper fix in the martin/cleanupfindwordendstart branch.
But bypassing the maintainer and rushing out a patch is not the correct way to
handle this, especially when we knowingly re-introduce a
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #9 from Nate Graham ---
I did, on the basis that the fix caused a highly visible 100% reproducible
user-facing regression of the type that erodes trust in the software between
minor versions of the stable branch (.0 -> .1). The whole reason
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #8 from Martin Sandsmark ---
the crash is 100% reproducible with asserts turned on, without asserts it
depends on the gods (and what random memory you hit).
who acked the revert?
--
You are receiving this mail because:
You are watching
https://bugs.kde.org/show_bug.cgi?id=403117
--- Comment #7 from Nate Graham ---
Well, both are bad to be sure. But breaking a feature on a stable branch is
always verboten. Also the crash does not seem to be 100% reproducible for
everyone or it would have more dupes (I can't reproduce it for
https://bugs.kde.org/show_bug.cgi?id=403117
Martin Sandsmark changed:
What|Removed |Added
CC||martin.sandsm...@kde.org
--- Comment #6
https://bugs.kde.org/show_bug.cgi?id=403117
Andrey Upshinskiy changed:
What|Removed |Added
CC|egib...@gmail.com |
--
You are receiving this mail because:
https://bugs.kde.org/show_bug.cgi?id=403117
Nate Graham changed:
What|Removed |Added
CC||aro...@archlinux.org,
|
https://bugs.kde.org/show_bug.cgi?id=403117
Nate Graham changed:
What|Removed |Added
Version Fixed In||18.12.2
Latest Commit|
https://bugs.kde.org/show_bug.cgi?id=403117
Nate Graham changed:
What|Removed |Added
Version|master |18.12.1
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=403117
Nate Graham changed:
What|Removed |Added
Severity|grave |critical
Priority|NOR
https://bugs.kde.org/show_bug.cgi?id=403117
Facundo Batista changed:
What|Removed |Added
CC||facu...@taniquetil.com.ar
--- Comment #2
https://bugs.kde.org/show_bug.cgi?id=403117
Andrey Upshinskiy changed:
What|Removed |Added
CC||egib...@gmail.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=403117
Dmitry Ulyanin changed:
What|Removed |Added
CC||ulyanin1...@gmail.com
--
You are receiving
https://bugs.kde.org/show_bug.cgi?id=403117
Rooty changed:
What|Removed |Added
CC||zy...@gmx.us
--- Comment #1 from Rooty ---
(In reply
18 matches
Mail list logo
