https://bugs.kde.org/show_bug.cgi?id=457951
Friedrich W. H. Kossebau changed:
What|Removed |Added
Latest Commit||https://invent.kde.org/game
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #15 from Friedrich W. H. Kossebau ---
Git commit fc9adcdd5eb843bc3024aa71787ea5de5950a14d by Friedrich W. H.
Kossebau.
Committed on 17/08/2022 at 10:30.
Pushed by kossebau into branch 'release/22.08'.
Fix handling of invalid theme ids,
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #14 from Friedrich W. H. Kossebau ---
Thanks again for testing.
(In reply to Duncan from comment #10)
> (In reply to Friedrich W. H. Kossebau from comment #9)
> > https://invent.kde.org/games/libkdegames/-/merge_requests/20.diff
>
> Good
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #13 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Duncan from comment #12)
> What makes kpat's Egyptian different so it won't take it?
User mistake. I didn't read the tabs and was changing card decks instead of
game themes, not
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #12 from Duncan <1i5t5.dun...@cox.net> ---
Yikes! The patch breaks kpat's Egyptian theme (at least with my existing
kpatrc). In the kpat case, however, it *does* revert to something else
(default?) instead of blanking, as I proposed for
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #11 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Duncan from comment #10)
> [H]ow difficult would it be to code up a "this entry
> doesn't make sense, ignore it and use/rewrite the default" solution?
... maybe with a warning, to
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #10 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Friedrich W. H. Kossebau from comment #9)
> https://invent.kde.org/games/libkdegames/-/merge_requests/20.diff
Good and bad news:
Good: The relative style ksudokurc theme entry works
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #9 from Friedrich W. H. Kossebau ---
Thanks for getting and showing that log. Okay, that should back up the working
theory about the cause :)
If you like to help more, please give the meanwhile created bug fix proposal as
reported before
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #8 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Friedrich W. H. Kossebau from comment #6)
> Please try the attached patch for libkdegames
> Interesting will be all the log output starting with "THEMELOADING"
For clarity this is at
https://bugs.kde.org/show_bug.cgi?id=457951
Bug Janitor Service changed:
What|Removed |Added
Status|REPORTED|ASSIGNED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #6 from Friedrich W. H. Kossebau ---
Please try the attached patch for libkdegames: apply, build, install. then
start ksudoku on the commandline. Interesting will be all the log output
starting with "THEMELOADING", should be something like
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #5 from Friedrich W. H. Kossebau ---
Created attachment 151355
--> https://bugs.kde.org/attachment.cgi?id=151355=edit
Debug logging patch for libkdegames master
(c5848c0d673cebc67eb280d54081ca69efeb28b0)
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #4 from Duncan <1i5t5.dun...@cox.net> ---
(In reply to Friedrich W. H. Kossebau from comment #3)
> Then it generates the theme id by first turning the desktop file path
> to a canonical version
That rings a bell. My system has a
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #3 from Friedrich W. H. Kossebau ---
>From a first look for potential culprit code, it seems the issue is how the
theme id is generated in the libkdegames classes used in the new code
(KgThemeProvider):
`KgThemeProvider::rediscoverThemes()`
https://bugs.kde.org/show_bug.cgi?id=457951
--- Comment #2 from Friedrich W. H. Kossebau ---
Hi, thanks for reporting the issue. Cannot remember I ran into such errors
(though been some time) when I tested the change, and trying locally right now
I also only get relative path with the new code
https://bugs.kde.org/show_bug.cgi?id=457951
Duncan <1i5t5.dun...@cox.net> changed:
What|Removed |Added
CC||kosse...@kde.org
--- Comment #1
16 matches
Mail list logo