https://bugs.kde.org/show_bug.cgi?id=433112

            Bug ID: 433112
           Summary: plasma-pass assumes the gnupg version by the
                    executable name
           Product: plasma-pass
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: REPORTED
          Severity: normal
          Priority: NOR
         Component: General
          Assignee: dvra...@kde.org
          Reporter: p...@kde.org
  Target Milestone: ---

Looking at plugin/providerbase.cpp in plasma-pass 1.2.0, I see the following:

    bool isGpg2 = true;
    auto gpgExe = QStandardPaths::findExecutable(QStringLiteral("gpg2"));
    if (gpgExe.isEmpty()) {
        gpgExe = QStandardPaths::findExecutable(QStringLiteral("gpg"));
        isGpg2 = false;
    }

This is semi-incorrect, as newer distributions (at least Debian since few
years) tend to ship GnuPG 2.x as "gpg", with the old GnuPG 1.x as "gpg1". IMHO
there ought to be a proper version check based on the executable itself, i.e.
parsing the output of `$gpgExe --version`.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to