[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Resolution|--- |FIXED

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102921|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #41 from Ralf Habacker --- Git commit 9ed47597b5506956e1ca9f4bced7ece3efe12d3e by Ralf Habacker, on behalf of Carsten Clever. Committed on 21/12/2016 at 14:15. Pushed by habacker into branch 'master'. Fix coverity

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #40 from clush...@gmx.net --- Created attachment 102921 --> https://bugs.kde.org/attachment.cgi?id=102921=edit Fix NULL pointer derefences found by Coverity - CIDs 173354 and 173353. -- You are receiving this mail because: You are

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #39 from Ralf Habacker --- At https://mail.kde.org/pipermail/umbrello-devel/2016-December/020658.html it looks that coverity detected implementation issues with your code (see CID 173354 and 173353). It would be

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #38 from clush...@gmx.net --- (In reply to Ralf Habacker from comment #36) This is not straight forward to fix because for Ports, the parent widget is not set at the required point in time. A PortWidget first creates its parent PinPortBase,

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #37 from Ralf Habacker --- Git commit f389d9d163d5755fb57db9a834e28d4e3b8bd9fa by Ralf Habacker. Committed on 08/12/2016 at 20:06. Pushed by habacker into branch 'master'. Local fix for using deprecated Qt5 method

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #36 from Ralf Habacker --- Comparing the new implementation with the old one from 2.20 shows a little remaining issue: In the old implementation the position of the pin/port been added depends on the current

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #34 from Ralf Habacker --- I just tried to connect a pin on an activity diagram with another activity. The result is that one end of the connection ends on the "another activity", the other end does *not* ends on

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Blocks||373249 Referenced

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #33 from clush...@gmx.net --- Thank you for accepting and committing the changes. I can continue to work on this topic including refactorings. For actual fixes of differences between Components and Activities, I would need further insight

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #32 from Ralf Habacker --- (In reply to Ralf Habacker from comment #31) > From a internet research I got the impression that ports are used used with > Components (https://en.wikipedia.org/wiki/Component_diagram)

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #31 from Ralf Habacker --- (In reply to clushkou from comment #20) > I tried to fulfill your request in comment #17, but do not understand how to > achieve this. I applied your first approach to git master. Thanks

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102602|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #29 from Ralf Habacker --- Created attachment 102602 --> https://bugs.kde.org/attachment.cgi?id=102602=edit Turn PinPortBase into child widget. BUG:371990 -- You are receiving this mail because: You are

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102601|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #27 from Ralf Habacker --- Created attachment 102601 --> https://bugs.kde.org/attachment.cgi?id=102601=edit Turn PinPortBase into real child widget. CCBUG:371990 -- You are receiving this mail because: You are

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102527|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102312|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #25 from Ralf Habacker --- Git commit 703b25a024380dcb81895c9700c3a8d4d72cfb74 by Ralf Habacker. Committed on 03/12/2016 at 17:00. Pushed by habacker into branch 'master'. Turn PinPortBase into real child widget.

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #24 from Ralf Habacker --- (In reply to Ralf Habacker from comment #22) >... The in-memory > representation changes this behavior by adding a direct association former > with m_pow and now this QGraphicsItem child

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #23 from Ralf Habacker --- (In reply to Ralf Habacker from comment #22) > I see. For the record: umbrello uses saveToXMI and loadFromXMI() to handle > xmi file save/load, object (de)serialisation on copy/paste

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #22 from Ralf Habacker --- (In reply to clushkou from comment #20) > I tried to fulfill your request in comment #17, but do not understand how to > achieve this. If I simply move the calls to ComponentWidget, I get

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #21 from clush...@gmx.net --- Created attachment 102527 --> https://bugs.kde.org/attachment.cgi?id=102527=edit Another patch proposal. CompoentWidget::loadFromXmi and ::saveToXmi adapted, but crashing. -- You are receiving this mail

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #20 from clush...@gmx.net --- I tried to fulfill your request in comment #17, but do not understand how to achieve this. If I simply move the calls to ComponentWidget, I get a crash on undo because restoring of child element does not work.

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102311|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #18 from Ralf Habacker --- Git commit c7250ebcb0886f47f4e694a6b4d2ea369adc0a89 by Ralf Habacker, on behalf of Carsten Clever. Committed on 26/11/2016 at 22:07. Pushed by habacker into branch 'Applications/16.12'.

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #17 from Ralf Habacker --- Comment on attachment 102312 --> https://bugs.kde.org/attachment.cgi?id=102312 Turn PinPortBase into real child widget. A quick look shows that the following code +

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #16 from clush...@gmx.net --- I could reproduce the crash. It's due to remove undo not restoring the child widgets. Subsequent undo commands assume the child widget exists and access a deleted widget. I've splitted and updated the patch to

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 clush...@gmx.net changed: What|Removed |Added Attachment #102196|0 |1 is obsolete|

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #14 from clush...@gmx.net --- Created attachment 102311 --> https://bugs.kde.org/attachment.cgi?id=102311=edit Restrict write access to UMLScene::widgetList to track NULL-pointer list entries. (1/2) PinPortBase as child widget: Restrict

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #13 from Ralf Habacker --- Comment on attachment 102196 --> https://bugs.kde.org/attachment.cgi?id=102196 Turn PinPortBase into child item I checked if this it works using the following use cases: 1. Add

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Resolution|FIXED |---

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102037|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #11 from clush...@gmx.net --- Created attachment 102196 --> https://bugs.kde.org/attachment.cgi?id=102196=edit Turn PinPortBase into child item Attached patch cleans up m_pOw in PinPortBase, and fixes all issues arising due to this

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Resolution|--- |FIXED Latest

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #101978|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #8 from clush...@gmx.net --- Created attachment 102037 --> https://bugs.kde.org/attachment.cgi?id=102037=edit Patch to fix crash: Remove PinPortBase objects when owner is removed - rebased -- You are receiving this mail because: You are

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #7 from clush...@gmx.net --- Thank's for commit the first part already. I've rebased and retested the fix for the crash, and found another issue when selecting both component and attached pin. That's fixed as well with the new patch. I tried

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Attachment #102013|0 |1 is

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #5 from Ralf Habacker --- Git commit 2ed4f7baedb1766452a5b08ffaf882ab09dcdbcf by Ralf Habacker, on behalf of Carsten Clever. Committed on 04/11/2016 at 07:42. Pushed by habacker into branch 'Applications/16.08'.

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #4 from clush...@gmx.net --- Created attachment 102013 --> https://bugs.kde.org/attachment.cgi?id=102013=edit Enforce valid baseType -- You are receiving this mail because: You are watching all bug changes.

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #3 from clush...@gmx.net --- Regarding 1.: I'm not sure how much effort it will be, but it's definitely better than the current approach. I'll give it a try, but might take some days. Regarding 2.: You're right. I've created a separate patch

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 Ralf Habacker changed: What|Removed |Added CC|

[umbrello] [Bug 371990] Crash when removing pin widgets after owning component has been removed before

https://bugs.kde.org/show_bug.cgi?id=371990 --- Comment #1 from clush...@gmx.net --- Created attachment 101978 --> https://bugs.kde.org/attachment.cgi?id=101978=edit Patch to fix crash: Remove PinPortBase objects when owner is removed. -- You are receiving this mail because: You are watching