https://bugs.kde.org/show_bug.cgi?id=428909
Paul Floyd changed:
What|Removed |Added
Status|CONFIRMED |RESOLVED
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #23 from Bart Van Assche ---
On 12/3/20 6:54 AM, Paul Floyd wrote:
> https://bugs.kde.org/show_bug.cgi?id=428909
>
> --- Comment #22 from Paul Floyd ---
> (In reply to Mark Wielaard from comment #20)
>>
>> Normally I would agree with
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #22 from Paul Floyd ---
(In reply to Mark Wielaard from comment #20)
> I find the logic in the previous patch much easier to follow. The configure
> tests look complex/fragile. Also I am not sure the first
> ac_thread_fns_only_in_libc=yes
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #21 from Paul Floyd ---
(In reply to Mark Wielaard from comment #19)
> Shouldn't that first #if defined(VGO_darwin) in drd_pthread_intercepts.c be
> #if defined(VG_WRAP_THREAD_FUNCTION_LIBPTHREAD_ONLY) ?
>
> Otherwise looks good.
> This
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #20 from Mark Wielaard ---
(In reply to Paul Floyd from comment #18)
> Created attachment 133799 [details]
> Add configure time checking
>
> This patch now uses configure. The tests are fairly complicated, but seem to
> work OK for Fedora
https://bugs.kde.org/show_bug.cgi?id=428909
Mark Wielaard changed:
What|Removed |Added
Status|REPORTED|CONFIRMED
Ever confirmed|0
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #18 from Paul Floyd ---
Created attachment 133799
--> https://bugs.kde.org/attachment.cgi?id=133799=edit
Add configure time checking
This patch now uses configure. The tests are fairly complicated, but seem to
work OK for Fedora 33,
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #17 from Paul Floyd ---
> Please change this into configure tests that verify whether pthreads
> functions exist in libpthread, libc or in both.
Hi Bart
That's a good idea, but the devil is in the details. I have two fairly big
https://bugs.kde.org/show_bug.cgi?id=428909
Bart Van Assche changed:
What|Removed |Added
CC||bvanass...@acm.org
--- Comment #16 from Bart
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #15 from Paul Floyd ---
Forgot to say. the testing that I did for this. No change on any platform.
Fedora 33 amd64
Alpine Linux (for MUSL) - all Helgrind tests are failing anyway, but at least
it builds OK
Solaris 11.3
OS X 10.7.5 - again
https://bugs.kde.org/show_bug.cgi?id=428909
Paul Floyd changed:
What|Removed |Added
Attachment #133548|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #13 from Mark Wielaard ---
OK, I think I finally understand your patch, the alias is needed as
declaration, but then you still need to define the implementation. In drd the
implementation is done by calling one of the arguments of the
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #12 from Mark Wielaard ---
So one issue I had missed is that VG_Z_LIBPTHREAD_SONAME is defined as libcZdZa
(libc.*) is the source of the problem with MUSL because when we duplicate the
wrappers for VG_Z_LIBPTHREAD_SONAME and
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #11 from Mark Wielaard ---
Hi Paul,
(In reply to Paul Floyd from comment #10)
> I'll attempt to add as many explanations as possible.
Thanks, sorry for being so slow.
It doesn't really help (IMHO) that we are trying to fix an issue with
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #10 from Paul Floyd ---
I'll attempt to add as many explanations as possible.
First, the true nature of the problem on Fedora 33. For some very bizarre
reason, pthread_cond_destroy is no longer in libpthread:
paulf> nm
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #9 from Mark Wielaard ---
I must admit that I don't understand how the weak alias trick works.
Why does the same trick not work for musl?
And how is solaris different?
BTW. I think it would be nice to make this 2 commits (maybe even bugs),
https://bugs.kde.org/show_bug.cgi?id=428909
Paul Floyd changed:
What|Removed |Added
Attachment #133507|0 |1
is obsolete|
https://bugs.kde.org/show_bug.cgi?id=428909
Stacy changed:
What|Removed |Added
Attachment #133454|0 |1
is obsolete||
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #6 from Stacy ---
Thanks Paul - this is exactly what I was looking for!
Stacy
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=428909
Paul Floyd changed:
What|Removed |Added
Attachment #133454|Add libc aliases for|Add libc aliases for
description|helgreind
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #5 from Paul Floyd ---
Created attachment 133454
--> https://bugs.kde.org/attachment.cgi?id=133454=edit
Add libc aliases for helgreind wrappers
In the end I found a better approach. I just added weak aliases for all of the
pthread
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #4 from Paul Floyd ---
I'm not sure about the history. DRD is more factored (but a bit less efficient
as a result, at least in terms of redundant code). Helgrind hs quite a few
special cases for non-Linux OSes.
I'll try to post a first
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #3 from Stacy ---
> that there are two possible approaches: change Helgrind to be like DRD so
> that the macro can generate wrappers for both libpthread and libc or add
> another macro for libc.
If the second approach needs to be done
https://bugs.kde.org/show_bug.cgi?id=428909
--- Comment #2 from Paul Floyd ---
I'll take a look at this - I upgraded from 32 to 33 over the weekend.
Currently Helgrind and DRD have slightly different approaches to the PTH_FUNC
macro. The DRD version also generates both functions declaration and
https://bugs.kde.org/show_bug.cgi?id=428909
Paul Floyd changed:
What|Removed |Added
CC||pa...@free.fr
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=428909
Mark Wielaard changed:
What|Removed |Added
CC||m...@klomp.org
--- Comment #1 from Mark
26 matches
Mail list logo
