https://bugs.kde.org/show_bug.cgi?id=419209
Bug ID: 419209
Summary: Duplicate buffer copy
Product: xdg-desktop-portal-kde
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: normal
Priority: NOR
Component: general
Assignee: jgrul...@redhat.com
Reporter: kkartalt...@gmail.com
Target Milestone: ---
SUMMARY
After downloading the buffer [1] it is copied an additional time [2]
before being passed to passed to pipewire. If the goal is to support standard
protocols they shouldnt be needless kneecapped like this (downloading a frame
at all is already slow enough without doing it twice). Mutter implementation
downloads directly into the pw buffer avoiding the additional copy [3].
[1]
https://github.com/KDE/xdg-desktop-portal-kde/blob/master/src/waylandintegration.cpp#L635
[2]
https://github.com/KDE/xdg-desktop-portal-kde/blob/master/src/screencaststream.cpp#L518
[3]
https://github.com/GNOME/mutter/blob/mainline/src/backends/meta-screen-cast-stream-src.c#L470
OBSERVED RESULT
Performance is worse than mutter
EXPECTED RESULT
Performance should be on par with mutter when both implementations are passing
around cpu buffers.
SOFTWARE/OS VERSIONS
Code reviewed on github master. Its unclear if there is an alternative
repository more up to date.
ADDITIONAL INFORMATION
--
You are receiving this mail because:
You are watching all bug changes.
