[plasmashell] [Bug 375535] New: Global Menu Bar widget does not open menus on hover

2017-01-25 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=375535

Bug ID: 375535
   Summary: Global Menu Bar widget does not open menus on hover
   Product: plasmashell
   Version: master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Global Menu
  Assignee: k...@privat.broulik.de
  Reporter: fab...@ritter-vogt.de
CC: plasma-b...@kde.org
  Target Milestone: 1.0

With the in-application menu bar, you can click on "Help" to open a menu and
then move the cursor to "File" to open that menu instead.

With the plasma widget you need to click on "File" for it to open.

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 373178] Blurry scaling on HiDPI

2017-01-20 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=373178

--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to cs from comment #4)
> - Does anyone know a way to start gwenview completely unscaled in a scaled
> plasma environment, ignoring the scaling value set in system settings? This
> does not solve the problem but would be a first workaround, because the
> images would look nice and sharp and I don't care much for the UI of
> Gwenview and could tolerate it being very small.

QT_AUTO_SCREEN_SCALE_FACTOR=0 QT_SCREEN_SCALE_FACTORS=1 gwenview

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376632] [Regression] Cascading folder view closes on hover

2017-02-20 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376632

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |DUPLICATE
 Status|NEEDSINFO   |RESOLVED

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---


*** This bug has been marked as a duplicate of bug 374291 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 374291] regression: folder view popup disappears when touched by mouse cursor

2017-02-20 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374291

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
*** Bug 376632 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376858] New: [Regression] Execution prompt shown for desktop files in desktop subfolders

2017-02-23 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376858

Bug ID: 376858
   Summary: [Regression] Execution prompt shown for desktop files
in desktop subfolders
   Product: plasmashell
   Version: 5.8.6
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Folder
  Assignee: k...@privat.broulik.de
  Reporter: fab...@ritter-vogt.de
CC: fa...@kde.org, h...@kde.org, plasma-b...@kde.org
  Target Milestone: 1.0

While https://phabricator.kde.org/D4534 "[Folder View] Don't show script
execution prompt on desktop:/" fixed the prompt for executable .desktop files
on the desktop directly, it breaks again when those files are in a subfolder on
the desktop and accessed through the cascading view.

Maybe the check should be successful for all paths starting from desktop:/
without ".."?

This probably needs some discussion first...

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376632] New: [Regression] Cascading folder view closes on hover

2017-02-18 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376632

Bug ID: 376632
   Summary: [Regression] Cascading folder view closes on hover
   Product: plasmashell
   Version: 5.8.5
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: Folder
  Assignee: h...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: plasma-b...@kde.org
  Target Milestone: 1.0

When opening a subfolder in folder view it disappears when the cursor touches
the subfolder view. That makes it unusuable.

Reverting bfee2b093a2e3f926f9d6de59fae5c64dedb7cf8 '[Folder View] Clear hover
state when mouse leaves view' (https://phabricator.kde.org/D3593) fixes it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376632] [Regression] Cascading folder view closes on hover

2017-02-18 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376632

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376394] org.kde.plasma.private.systemtray.appdata.xml is invalid - missing

2017-02-18 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376394

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
This seems to be fixed in kpackage:

https://phabricator.kde.org/D4398 Don't generate appdata if it's marked as
NoDisplay

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames

2017-02-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376365

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
I made a review request with a fix for this in plasma-integration:
https://phabricator.kde.org/D4579

However, IMO the API needs to be changed to be less ambiguous.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 376394] New: org.kde.plasma.private.systemtray.appdata.xml is invalid - missing

2017-02-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376394

Bug ID: 376394
   Summary: org.kde.plasma.private.systemtray.appdata.xml is
invalid - missing 
   Product: plasmashell
   Version: 5.9.1
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Task Manager
  Assignee: h...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Due to $SUBJECT our package manager tells us on every update that "System Tray"
gets uninstalled as invalid appdata gets stripped from our packages.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kajongg] [Bug 376303] New: Does not build due to too long file names

2017-02-10 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376303

Bug ID: 376303
   Summary: Does not build due to too long file names
   Product: kajongg
   Version: unspecified
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: grave
  Priority: NOR
 Component: general
  Assignee: wolfg...@rohdewald.de
  Reporter: fab...@ritter-vogt.de
CC: kde-games-b...@kde.org
  Target Milestone: ---

(Using git master)

[   72s] CMake Warning (dev) at cmake-modules/KDEPython.cmake:51
(add_custom_target):
[   72s]   Policy CMP0037 is not set: Target names should not be reserved and
should
[   72s]   match a validity pattern.  Run "cmake --help-policy CMP0037" for
policy
[   72s]   details.  Use the cmake_policy command to set the policy and
suppress this
[   72s]   warning.
[   72s] 
[   72s]   The target name
[   72s]  
"src__home_abuild_rpmbuild_BUILD_kajongg-17.03.60git.20170205T040205~88f5711_build_src___pycache___permutations.cpython-35.pyc"
[   72s]   is reserved or not valid for certain CMake features, such as
generator
[   72s]   expressions, and may result in undefined behavior.
[   72s] Call Stack (most recent call first):
[   72s]   cmake-modules/KDEPython.cmake:89 (python_install)
[   72s]   CMakeLists.txt:119 (KDE_INSTALL_PYTHON_FILES)

Results in:

[   73s] -- Configuring done
[   73s] CMake Error: Cannot open file for write:
/home/abuild/rpmbuild/BUILD/kajongg-17.03.60git.20170205T040205~88f5711/build/CMakeFiles/_home_abuild_rpmbuild_BUILD_kajongg-17.03.60git.20170205T040205~88f5711_build_src__home_abuild_rpmbuild_BUILD_kajongg-17.03.60git.20170205T040205~88f5711_build__home_abuild_rpmbuild_BUILD_kajongg-17.03.60git.20170205T040205~88f5711_build_src___pycache___kdepaths.cpython-35.pyc.dir/build.make.tmp
[   73s] CMake Error: : System Error: File name too long

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames

2017-02-13 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376365

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit e70f8134a2bc4b3647e245c05f469aeed462a246 by Fabian Vogt.
Committed on 13/02/2017 at 15:11.
Pushed by fvogt into branch 'Plasma/5.8'.

Do not treat filename in selection as URL

Summary:
KFileWidget::setSelection(QString &) accepts either absolute URLs
or relative paths. If the filename contains a :, it gets treated
as a URL and gets rejected. This forces setSelection to parse
it as URL.

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4579

M  +1-1src/platformtheme/kdeplatformfiledialoghelper.cpp

https://commits.kde.org/plasma-integration/e70f8134a2bc4b3647e245c05f469aeed462a246

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 376365] New: KFileWidget does not support : in filenames

2017-02-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376365

Bug ID: 376365
   Summary: KFileWidget does not support : in filenames
   Product: frameworks-kio
   Version: 5.29.0
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: fa...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: kdelibs-b...@kde.org
  Target Milestone: ---

KFileWidget treats filenames as complete urls, which causes
https://github.com/openSUSE/kmozillahelper/issues/7 ('Save file dialog does not
prefill filename when title have "xxx : xxx"')

This quick snippet has a default filename filled in without the KDE platform
theme but with it, the filename input is empty and this message appears:

"this is a test with a colon : hi.file"  is not a correct argument for
setSelection!
"this is a test with a colon : hi.file"  is not a correct argument for
setSelection!

#include 
#include 

int main(int argc, char *argv[])
{
QApplication a(argc, argv);
QUrl defaultUrl = QUrl::fromLocalFile("file:///tmp/this is a test with
a colon : hi.file");
QFileDialog dialog(nullptr, "Broken", defaultUrl.path());
// Does not work
dialog.selectFile(defaultUrl.fileName());
// Does not work either
//dialog.selectUrl(defaultUrl);
dialog.show();
return a.exec();
}

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames

2017-02-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376365

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Workaround is to use

dialog.selectFile(QUrl::toPercentEncoding(defaultUrl.fileName()));

but that unfortunately breaks with non-KDE dialogs and also after this bug is
fixed...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kirigami] [Bug 375344] Wrong(?) license of kirigami/src/desktopicon.h

2017-01-20 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=375344

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de
   Severity|major   |grave

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Raising priority to grave as this makes it impossible for us to include
kirigami 2 in openSUSE.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 348789] kscreenlocker_greet not grabbing input

2017-03-01 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=348789

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/ksc
   ||reenlocker/f8043de10b5dd94b
   ||9b931a92f3aa7167188786c9
 Status|CONFIRMED   |RESOLVED

--- Comment #9 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit f8043de10b5dd94b9b931a92f3aa7167188786c9 by Fabian Vogt.
Committed on 01/03/2017 at 17:48.
Pushed by fvogt into branch 'Plasma/5.8'.

Implement manual focus on click

Summary:
Currently only the first created screenlock window gets focus.
On clicks, no focus events are sent, which makes it impossible to input
passwords. This patch now makes it possible to focus to a different
screenlock window (on a different monitor, for example) using a mouse
button press.
This should also fix newly created screenlock windows stealing the focus
of already displayed ones as only the first window gains automatic focus.
Related: bug 374289

Test Plan:
Locked the screen, now I can use the password input on the secondary screen
as well.

Reviewers: #plasma, graesslin, broulik

Reviewed By: #plasma, graesslin

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4821

M  +0-1greeter/greeterapp.cpp
M  +24   -2x11locker.cpp
M  +2-0x11locker.h

https://commits.kde.org/kscreenlocker/f8043de10b5dd94b9b931a92f3aa7167188786c9

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 374289] multiscreen locks stealing focus

2017-03-01 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374289

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/ksc
   ||reenlocker/f8043de10b5dd94b
   ||9b931a92f3aa7167188786c9
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit f8043de10b5dd94b9b931a92f3aa7167188786c9 by Fabian Vogt.
Committed on 01/03/2017 at 17:48.
Pushed by fvogt into branch 'Plasma/5.8'.

Implement manual focus on click

Summary:
Currently only the first created screenlock window gets focus.
On clicks, no focus events are sent, which makes it impossible to input
passwords. This patch now makes it possible to focus to a different
screenlock window (on a different monitor, for example) using a mouse
button press.
This should also fix newly created screenlock windows stealing the focus
of already displayed ones as only the first window gains automatic focus.
Related: bug 348789

Test Plan:
Locked the screen, now I can use the password input on the secondary screen
as well.

Reviewers: #plasma, graesslin, broulik

Reviewed By: #plasma, graesslin

Subscribers: hein, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4821

M  +0-1greeter/greeterapp.cpp
M  +24   -2x11locker.cpp
M  +2-0x11locker.h

https://commits.kde.org/kscreenlocker/f8043de10b5dd94b9b931a92f3aa7167188786c9

-- 
You are receiving this mail because:
You are watching all bug changes.

[Akonadi] [Bug 371570] Duplicate entry in CollectionTable when creating database in a new installation

2016-10-26 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=371570

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 371720] New: Discover does not display anything when PackageKit transaction fails

2016-10-26 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=371720

Bug ID: 371720
   Summary: Discover does not display anything when PackageKit
transaction fails
   Product: Discover
   Version: 5.8.2
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: PackageKit
  Assignee: aleix...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

When the zypper PackageKit backend cannot open the database because it's
currently in use, it reports this to the application:

Transaction error:  "System management is locked by the application with pid
11584 (/usr/lib/YaST2/bin/y2base).\nClose this application before trying
again." PackageKit::Transaction(0x2b9d790)

However, discover seems to ignore this and just displays no applications and an
empty settings page.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 366451] "display scaling" on hidpi screen results in poor font quality

2016-10-27 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=366451

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 372476] New: Kickoff loses keyboard focus forever after closing with meta

2016-11-14 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372476

Bug ID: 372476
   Summary: Kickoff loses keyboard focus forever after closing
with meta
   Product: plasmashell
   Version: 5.8.2
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Panel
  Assignee: plasma-b...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: 1.0

Likely affects applets other than kickoff as well.

To reproduce:

- Open Kickoff
- Type some letters -> Entered into search field
- Press Meta to close the launcher
- Open Kickoff by clicking on the icon
- Type some letters -> NOT entered into search field

Focus can only be restored by pressing Meta.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] Present Windows lags when closing window

2016-11-22 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

--- Comment #6 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Fabian Vogt from comment #5)
> (In reply to Martin Gräßlin from comment #4)
> > Created attachment 102271 [details]
> > Possible workaround
> > 
> > Attached a workaround with which I am no longer able to trigger the freeze.
> 
> Still works fine here, hasn't caused any nuclear meltdown yet. From my side
> that's good enough ;-)

Meh, I have to correct that: Occasionally I can see the close icon for a few
frames after the effect is over.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372876] Dock widgets cannot be moved

2016-11-24 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372876

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 373033] New: Empty WiFi icon not easily visible

2016-11-28 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=373033

Bug ID: 373033
   Summary: Empty WiFi icon not easily visible
   Product: Breeze
   Version: 5.8.4
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Icons
  Assignee: visual-des...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: kain...@gmail.com
  Target Milestone: ---

As can be seen on http://i.imgur.com/DLGjpO0.png , the contrast for the "no
WiFi network connected" icon is not high enough. It works fine for the dark
plasma theme.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372573] Full repaints on cursor moves when panel has auto-hide enabled

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372573

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Gräßlin from comment #1)
> do you have minimized windows?

No.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] Present Windows lags when closing window

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
Found a workaround: LIBGL_DRI3_DISABLE=1 kwin_x11 --replace
Unfortunately it causes lots of weird rendering glitches, so not usable...

Some resources:
https://bugs.freedesktop.org/show_bug.cgi?id=84252
https://bugs.freedesktop.org/show_bug.cgi?id=94108

Seems to be a bug in libxcb/Mesa or the combination with Qt...

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372573] Full repaints on cursor moves when panel has auto-hide enabled

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372573

--- Comment #4 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Gräßlin from comment #3)
> then I'm not able to reproduce the issue. I only get repaints for minimized
> windows with auto hiding panels.
> 
> Or could it be that something in the panel would be animating? E.g. a
> progress bar on the task bar, maybe even something which reacts on mouse
> motion?

It seems to be xeyes (not minimized but behind other windows) that triggers
this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] New: Present Windows lags when closing window

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

Bug ID: 372576
   Summary: Present Windows lags when closing window
   Product: kwin
   Version: 5.8.3
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: effects-present-windows
  Assignee: kwin-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

When using the close button provided by the effect, the frame rate drops to 0
fps for multiple seconds.
It seems to only affect X11 platforms.

Likely related, but not quite the same: bug 371731

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372573] New: Full repaints on cursor moves when panel has auto-hide enabled

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372573

Bug ID: 372573
   Summary: Full repaints on cursor moves when panel has auto-hide
enabled
   Product: kwin
   Version: 5.8.3
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: kwin-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

When a plasma panel has auto-hide enabled, the whole desktop flickers with the
redraw visualization effect on cursor moves.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372573] Full repaints on cursor moves when panel has auto-hide enabled

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372573

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

--- Comment #6 from Fabian Vogt <fab...@ritter-vogt.de> ---
I still consider this a bug as it only happens with auto-hide enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372573] Full repaints on cursor moves when panel has auto-hide enabled

2016-11-17 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372573

--- Comment #8 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Gräßlin from comment #7)
> I don't understand. xeyes triggers repaints, whether it is behind windows or
> not. That triggers a repaint in the compositor, which is also expected. So
> what should be wrong here?

If auto-hide is disabled I only get a full repaint every second or so.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] Present Windows lags when closing window

2016-11-21 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Gräßlin from comment #4)
> Created attachment 102271 [details]
> Possible workaround
> 
> Attached a workaround with which I am no longer able to trigger the freeze.

Still works fine here, hasn't caused any nuclear meltdown yet. From my side
that's good enough ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

2016-11-03 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #4 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Pali Rohár from comment #3)
> Hi Fabian Vogt! Can you cleanup your patch and post it to
> git.reviewboard.kde.org to kopete group?

I can do that, but I never tried to use it with linphone. If anyone can confirm
that it still works, I'll submit it for review.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kopete] [Bug 368340] Build fails with mediastreamer 2.14

2016-11-03 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=368340

--- Comment #6 from Fabian Vogt <fab...@ritter-vogt.de> ---
Ok, I made a review request on https://git.reviewboard.kde.org/r/129325/

-- 
You are receiving this mail because:
You are watching all bug changes.

[gwenview] [Bug 373178] New: Blurry scaling on HiDPI

2016-12-02 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=373178

Bug ID: 373178
   Summary: Blurry scaling on HiDPI
   Product: gwenview
   Version: Other (add details in bug description)
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: gwenview-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: myr...@kde.org
  Target Milestone: ---

On Gwenview 16.08.3 images shown on a HiDPI (QT_SCALE_FACTOR=2) display are
pixelated. Easily reproducible by calling "QT_SCALE_FACTOR=2 gwenview" with an
image that has sharp edges.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 374572] Ark runs shell scripts when assiociated applications are used

2017-01-06 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374572

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #4 from Fabian Vogt <fab...@ritter-vogt.de> ---
Thanks for fixing!

However, I'm not sure whether this is the right approach.
What about a dialog that tells the user that it is an executable file and it
should only be run if it's trusted and also that it may need the archive to be
extraced somewhere? It's the approach that's used on Windows as well.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 374572] Ark runs shell scripts when assiociated applications are used

2017-01-06 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374572

--- Comment #6 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #5)
> (In reply to Fabian Vogt from comment #4)
> > Thanks for fixing!
> > 
> > However, I'm not sure whether this is the right approach.
> > What about a dialog that tells the user that it is an executable file and it
> > should only be run if it's trusted and also that it may need the archive to
> > be extraced somewhere? It's the approach that's used on Windows as well.
> 
> Well we could do that, but only on master. Stable branches can do with my
> fix above.

I haven't tested the fix yet, what happens now if the user clicks on the file,
is it opened in a text editor, so as-if the file weren't executable?
If nothing happens at all, I'd consider it as a regression, even.

> Anyway, I'm not sure if we can check the executable bit before extraction.
> What Ark currently does is extracting the selected entry to a temporary
> folder, then KRun is called over that url. So the dialog would only ask "you
> are about to run this file, do you trust it?"

Couldn't you test the executable flag between extraction and execution?

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 374572] New: Ark runs shell scripts when assiociated applications are used

2017-01-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374572

Bug ID: 374572
   Summary: Ark runs shell scripts when assiociated applications
are used
   Product: ark
   Version: 16.08.3
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: elvis.angelac...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: rthoms...@gmail.com
  Target Milestone: ---

Created attachment 103204
  --> https://bugs.kde.org/attachment.cgi?id=103204=edit
Gzipped tar for demonstration

When an archive includes an executable shell script and the user chose to open
files in their associated applications, clicking on those scripts runs them.

As there is no indication (except the small icon in some cases) of the file
being executable, this is highly misleading and even dangerous.

The attachment shows the issue, the LICENSE file gets executed when opening it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 374572] Ark runs shell scripts when assiociated applications are used

2017-01-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374572

--- Comment #9 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #8)
> Actually there is another issue with the dialog approach: if there is no
> associated application (e.g. the file is a binary executable), then KRun
> shows another dialog:
> 
> "The file file:///xxx is an executable program. For safety it will not be
> started."
> 
> So this scenario would be a bit annoying:
> - select binary executable and click Open
> - ark asks: "this is an exe, do you trust it"? (1st dialog)
> - user chooses No
> - KRun says: "The file ... is an executable program. For safety it will not
> be started." (2nd dialog)

In that case it's probably the best if clicking on No aborts the whole process
instead, if KRun::isExecutable returns true for the mime type.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 374420] New: Various kioslaves do not write correct dates

2017-01-01 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374420

Bug ID: 374420
   Summary: Various kioslaves do not write correct dates
   Product: frameworks-kio
   Version: 5.28.0
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: fa...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: kdelibs-b...@kde.org
  Target Milestone: ---

> $ kioclient5 copy "http://kde.org; /tmp/file
> $ LANG=C stat /tmp/file
>   File: '/tmp/file'
>   Size: 27932   Blocks: 56 IO Block: 4096   regular file
> Device: 26h/38d Inode: 42361390Links: 1
> Access: (0644/-rw-r--r--)  Uid: ( 1000/  fabian)   Gid: (  100/   users)
> Access: 2017-01-01 14:25:07.0 +0100
> Modify: 2106-02-07 07:28:15.0 +0100
> Change: 2017-01-01 14:25:08.032913190 +0100
>  Birth: -

The mtime is wrong here.

> $ kioclient5 copy "ftp://upload.kde.org/README; /tmp/file
> $ stat /tmp/file 
>   File: '/tmp/file'
>   Size: 594 Blocks: 8  IO Block: 4096   regular file
> Device: 26h/38d Inode: 42366998Links: 1
> Access: (0644/-rw-r--r--)  Uid: ( 1000/  fabian)   Gid: (  100/   users)
> Access: 2106-02-07 07:28:15.0 +0100
> Modify: 2013-04-27 00:00:00.0 +0200
> Change: 2017-01-01 14:27:14.582228552 +0100
> Birth: -

Same for there access date here.

Those timestamps are all 0x, which is invalid.
I've also seen "4442051-11-19 02:36:00" as access date once,
so it may be the result of an uninitialized read.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 374420] Various kioslaves do not write correct dates

2017-01-01 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374420

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Forgot to mention, this works fine with kioclient instead of kioclient5, so
it's a regression.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 374027] Does not build for i686

2016-12-23 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374027

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
Found the issue: moc does not define __GNUC__, so the

#if defined __GNUC__ && __GNUC__ >= 2

check does not pass inside glibc.

I reported it as https://bugreports.qt.io/browse/QTBUG-57796

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-nm] [Bug 374026] New: Captive Portal login does not work

2016-12-22 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374026

Bug ID: 374026
   Summary: Captive Portal login does not work
   Product: plasma-nm
   Version: master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: lu...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: jgrul...@redhat.com
  Target Milestone: ---

plasma-nm opens https://kde.org when clicking on the login button after
captive-portal detection, but most captive portals only work with http.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 374027] New: Does not build for i686

2016-12-22 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=374027

Bug ID: 374027
   Summary: Does not build for i686
   Product: plasmashell
   Version: master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: Icon Applet
  Assignee: plasma-b...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: 1.0

Same as https://bugs.kde.org/show_bug.cgi?id=371721 , but for plasma-workspace

Core issue seems to me that moc does not -D _REDIRECT, so glibc uses an evil

#define open open64

which results in

moc_iconapplet_FERWDM656PUOUJ.cpp:128:21: error: 'class IconApplet' has no
member named 'open64'; did you mean 'open'?

IMO this needs to be fixed in Qt, but as everything else works on i686 (except
kget, same issue), this is doing something differently.
Maybe other components #include different headers that fix it by #undef open?

(Feel free to close as WONTFIX if it's too ugly to work around in plasma)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2017-03-24 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=356479

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #119 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Dmitriy from comment #118)
> Well, they say it was fixed:
> https://phabricator.kde.org/R120:749f60b89f4a166833fb64a5b593a801f63f9615
> 
> but in which Plasma release we'll get that patch - I don't know.
> According to tags in the link above, it's gonna be next releases:
> 
> v5.9.4, v5.9.3, v5.9.2, v5.9.1, v5.9.0, v5.8.95
> 
> So, stay tuned !

The patch is part of 5.8.6 and it does apparently not help:

https://bugzilla.opensuse.org/show_bug.cgi?id=1016920

IMO that's enough confirmation to reopen this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 378276] New: Impossible to tell whether password field shows plaintext with empty content

2017-03-30 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378276

Bug ID: 378276
   Summary: Impossible to tell whether password field shows
plaintext with empty content
   Product: frameworks-kwidgetsaddons
   Version: 5.32.0
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: cf...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: kdelibs-b...@kde.org
  Target Milestone: ---

In an application with a password input, like

kdialog --password password

enter a password, enable to show the plaintext and erase the password again.
Now the password input is in the plaintext state, but that is not visibly
indicated. Now everything typed into the field appears in plaintext.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 378277] New: Impossible to tell whether password field shows plaintext with empty content

2017-03-30 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378277

Bug ID: 378277
   Summary: Impossible to tell whether password field shows
plaintext with empty content
   Product: frameworks-plasma
   Version: unspecified
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: components
  Assignee: notm...@gmail.com
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

In an application with a password input, like the screenlocker, enter a
password, enable to show the plaintext and erase the password again.
Now the password input is in the plaintext state, but that is not visibly
indicated. Now everything typed into the field appears in plaintext.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 378276] Impossible to tell whether password field shows plaintext with empty content

2017-03-30 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378276

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||elvis.angelac...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 378276] Impossible to tell whether password field shows plaintext with empty content

2017-03-30 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378276

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Christoph Feck from comment #1)
> Which would make more sense: reset password visibility to "invisible",
> whenever all text is removed, or always show the icon with its state, even
> for empty strings?

As I do not use the button most of the time, it would just be in the way.
I'd say a combination is the best: Always show the button if it's set to
plaintext.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377648] Ark does not show some folders in RPM

2017-03-31 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377648

--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #3)
> Can you attache the debug output when you open that archive?
> (QT_LOGGING_RULES="ark.*.debug=true" ark)

Does not look too interesting:

ark.main: Trying to open
QUrl("file:///home_priv/fabian/Downloads/shared-mime-info-1.8-1.1.x86_64.rpm")
ark.part: Attempting to open archive
"/home_priv/fabian/Downloads/shared-mime-info-1.8-1.1.x86_64.rpm"
ark.kerfuffle: Going to create archive
"/home_priv/fabian/Downloads/shared-mime-info-1.8-1.1.x86_64.rpm"
ark.kerfuffle: Checking plugin "kerfuffle_libarchive_readonly"
ark.kerfuffle: Created read-only interface for
"/home_priv/fabian/Downloads/shared-mime-info-1.8-1.1.x86_64.rpm"
ark.kerfuffle: Created read-write interface for
"/home_priv/fabian/Downloads/shared-mime-info-1.8-1.1.x86_64.rpm"
ark.libarchive: Initializing libarchive plugin
ark.libarchive: Loaded libarchive read-only plugin
ark.kerfuffle: Successfully loaded plugin "kerfuffle_libarchive_readonly"
ark.kerfuffle: Created archive instance
ark.kerfuffle: LoadJob created
ark.libarchive: Listing archive contents
ark.libarchive: Detected compression filter: lzma
ark.libarchive: Detected format for first entry: ASCII cpio (SVR4 with no CRC)
ark.main: Entering application loop
ark.part: Showing columns:  (0, 1, 10)
ark.part: Trailing slash appended to entry: QVariant(QString,
"usr/share/doc/packages/shared-mime-info/")
ark.kerfuffle: Job finished, result: true , time: 64 ms

(In reply to Christoph Feck from comment #4)
> If you can provide the information requested in comment #3, please add it.

Hm, somehow I did not get a mail for the reply...

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377648] New: Ark does not show some folders in RPM

2017-03-15 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377648

Bug ID: 377648
   Summary: Ark does not show some folders in RPM
   Product: ark
   Version: 16.12.2
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: elvis.angelac...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: rthoms...@gmail.com
  Target Milestone: ---

Created attachment 104585
  --> https://bugs.kde.org/attachment.cgi?id=104585=edit
Example RPM

The attached RPM shows only the packages/ subfolder under /usr/share/mime, but
"rpm -qlp" shows many many more.

Might also be a bug in karchive, but I don't know how to verify that...

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377648] Ark does not show some folders in RPM

2017-03-15 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377648

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #1)
> Seems to work fine here, I can also see the /etc folder and all the other
> /usr subfolders. What's your version of libarchive?

/usr/lib64/libarchive.so.13.2.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kpackage] [Bug 378529] New: KPackage does not ignore warnings during appdata generation

2017-04-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378529

Bug ID: 378529
   Summary: KPackage does not ignore warnings during appdata
generation
   Product: frameworks-kpackage
   Version: 5.32.0
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: default
  Assignee: notm...@gmail.com
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

Due to $SUBJECT building various parts of Plasma 5.8 which use the removed
Plasma/PopupApplet service type do not build correctly. The bug is in
KF5PackageMacros.cmake, around line 53:


execute_process(COMMAND ${kpackagetool_cmd} --appstream-metainfo
${CMAKE_CURRENT_SOURCE_DIR}/${dir} OUTPUT_FILE ${APPDATAFILE} ERROR_VARIABLE
appstreamerror RESULT_VARIABLE result)
if(appstreamerror)
if (NOT result EQUAL 0)
message(WARNING "couldn't generate metainfo for ${component}:
${appstreamerror}")
endif ()
else()
install(FILES ${APPDATAFILE} DESTINATION
${KDE_INSTALL_METAINFODIR})
endif()

In the failing case appstreamerror is not empty, as it emits warnings, but the
file is still generated successfully, result is 0.
This means that:

* No error or warning is printed

* The file is generated but not installed

This needs to be fixed like this, IMO:

execute_process(COMMAND ${kpackagetool_cmd} --appstream-metainfo
${CMAKE_CURRENT_SOURCE_DIR}/${dir} OUTPUT_FILE ${APPDATAFILE} ERROR_VARIABLE
appstreamerror RESULT_VARIABLE result)
if (NOT result EQUAL 0)
message(WARNING "couldn't generate metainfo for ${component}:
${appstreamerror}")
else()
if(appstreamerror)
message(WARNING "warnings during generation of metainfo for
${component}: ${appstreamerror}")

install(FILES ${APPDATAFILE} DESTINATION
${KDE_INSTALL_METAINFODIR})
endif()

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kpackage] [Bug 378529] KPackage does not ignore warnings during appdata generation

2017-04-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378529

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kpa
   ||ckage/a0da2bd735d01155667ce
   ||21e87d553bcb69e3a6a

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit a0da2bd735d01155667ce21e87d553bcb69e3a6a by Fabian Vogt.
Committed on 07/04/2017 at 09:20.
Pushed by fvogt into branch 'master'.

Ignore warnings during appdata generation

Summary:
The Plasma/PopupApplet service type for example got deprecated and removed,
but is still used by various parts of Plasma 5.8.
This causes kpackagetool to emit warnings, but it still succeeds. However,
this case is handled incorrectly as any stderr output is assumed to be critical
and the file is not installed. As result is 0, no warning message is printed.

This commit fixes this by ignoring the stderr output and using result to
indicate
success. Warning messages are printed if applicable.

Major issue is that kpackagetool5 does not exit with an error if it encounters
an error, so this installs a broken appdata file in some circumstances.

Test Plan:
Built Plasma 5.8 with this patch. Works fine now.
As warnings are now printed, it uncovered some little issues as well.

Reviewers: mart, apol

Reviewed By: mart

Subscribers: #frameworks

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D5328

M  +6-4KF5PackageMacros.cmake

https://commits.kde.org/kpackage/a0da2bd735d01155667ce21e87d553bcb69e3a6a

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 378276] Impossible to tell whether password field shows plaintext with empty content

2017-04-05 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378276

--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #3)
> Created attachment 104893 [details]
> kdialog with echo-mode button always visible in plaintext mode
> 
> Unfortunately KPasswordDialog uses the clear button, so leaving the
> echo-mode button visible results in wasted space. Is this acceptable?

I would say yes, but that should be coordinated with the fix for bug 378277

(In reply to Elvis Angelaccio from comment #4)
> On the other hand, if we reset the visibility status we get the same level
> of "safety" without this visual glitch.

Yes, but that might be less useful for those with a virtual keyboard who
probably need the functionality the most.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377648] Ark does not show some folders in RPM

2017-04-05 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377648

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

   See Also||https://github.com/libarchi
   ||ve/libarchive/issues/899

--- Comment #11 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #10)
> (In reply to Fabian Vogt from comment #9)
> > (In reply to Elvis Angelaccio from comment #8)
> > > Yes it's the gnome archiver. I asked you to try because they also use
> > > libarchive for rpm files and that would tell us whether the bug is in ark 
> > > or
> > > in libarchive. (fwiw, if I open it with file-roller it shows all the
> > > folders, as does ark).
> > 
> > Ok, tried it: Same issue. So it's in libarchive and there's nothing ark can
> > do, right?
> 
> Unfortunately yes. Try to report it upstream at
> https://github.com/libarchive/libarchive (and maybe link this report there)

Ok: https://github.com/libarchive/libarchive/issues/899

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kwidgetsaddons] [Bug 378276] Impossible to tell whether password field shows plaintext with empty content

2017-04-05 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378276

--- Comment #7 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #6)
> Ok, it's a bit ugly but I think it's possible to work-around the empty space
> in my previous screenshot. Can you expand on the virtual keyboard argument?
> Why if I'm uisng a virtual keyboard I would want to always see the
> visibility icon in "plaintext" mode?

Not that, but you would not want to reset to hidden status after clearing the
input field.

> About the QML line edit, at least in the lock screen there is no clear
> button. No idea about other usages...

Just checked in plasma-nm, no clear button either.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377648] Ark does not show some folders in RPM

2017-04-05 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377648

--- Comment #9 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #8)
> Yes it's the gnome archiver. I asked you to try because they also use
> libarchive for rpm files and that would tell us whether the bug is in ark or
> in libarchive. (fwiw, if I open it with file-roller it shows all the
> folders, as does ark).

Ok, tried it: Same issue. So it's in libarchive and there's nothing ark can do,
right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde] [Bug 379087] New: plasma-browser-integration modifies XML documents before displaying

2017-04-22 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=379087

Bug ID: 379087
   Summary: plasma-browser-integration modifies XML documents
before displaying
   Product: kde
   Version: Git
  Platform: Other
   URL: https://build.opensuse.org/configuration.xml
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@privat.broulik.de
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

With plasma-browser-extension activated, the extension inserts a rogue 

[frameworks-plasma] [Bug 378277] Impossible to tell whether password field shows plaintext with empty content

2017-04-21 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=378277

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
This now got fixed in KWidgetsAddons with https://phabricator.kde.org/D5530
so plasma-framework should be adjusted to behave the same way, for consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames

2017-03-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376365

--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to David Faure from comment #4)
> Thanks for fixing the bug, it can be closed now, right?

IMO not quite:

> However, IMO the API needs to be changed to be less ambiguous.

A QString as argument that accepts both URLs and filenames can't ever work as
valid URLs are also valid filesystem paths.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kio] [Bug 376365] KFileWidget does not support : in filenames

2017-03-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=376365

--- Comment #7 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to David Faure from comment #6)
> Oh, indeed, I hadn't seen that. I completely agree, the same API with a
> QString can't be for relative paths and for URLs, "a:b" is both.
> 
> How about we add a KFileWidget::setSelectedUrl(const QUrl& url)?
> Then we can get rid of this ugly .toString() (QUrl -> QString -> QUrl).

Sounds good to me!

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] Present Windows lags when closing window

2017-03-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

--- Comment #11 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Fabian Vogt from comment #10)
> Created attachment 104509 [details]
> Other possible workaround
> 
> I made a different workaround that is less hacky than the one attached by
> mgraesslin and it seems to work reliably here.

Just confirmed what I feared: Does not work on wayland as it should. As the bug
only happens on X, maybe the workaround can be used depending on the platform?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] Present Windows lags when closing window

2017-03-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

--- Comment #10 from Fabian Vogt <fab...@ritter-vogt.de> ---
Created attachment 104509
  --> https://bugs.kde.org/attachment.cgi?id=104509=edit
Other possible workaround

I made a different workaround that is less hacky than the one attached by
mgraesslin and it seems to work reliably here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377515] New: Ark quits after drag/dropping single file

2017-03-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377515

Bug ID: 377515
   Summary: Ark quits after drag/dropping single file
   Product: ark
   Version: 16.12.2
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: elvis.angelac...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: rthoms...@gmail.com
  Target Milestone: ---

When the "Quit after extract" option is set, ark also quits after dropping a
single file in dolphin, for example.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 372576] Present Windows lags when closing window

2017-03-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=372576

--- Comment #13 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Gräßlin from comment #12)
> > Just confirmed what I feared: Does not work on wayland as it should.
> 
> I assume the problem is the mask not working?

Correct, the close button stays visible after closing the effect.

> > As the bug
> > only happens on X, maybe the workaround can be used depending on the
> > platform?
> 
> Difficult, the effects don't have the windowing system exposed yet.

I found this, wouldn't a test like this work:

>KWayland::Server::Display *display = effects->waylandDisplay();
>if (display) {
>display->createSlideManager(this)->create();
>}

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 377332] New: Placeholder face icon is not themed

2017-03-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377332

Bug ID: 377332
   Summary: Placeholder face icon is not themed
   Product: plasmashell
   Version: master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: Application Launcher (Kickoff)
  Assignee: k...@davidedmundson.co.uk
  Reporter: fab...@ritter-vogt.de
CC: plasma-b...@kde.org
  Target Milestone: 1.0

The workaround for bug 370362
(https://cgit.kde.org/plasma-desktop.git/commit/?id=52ba0122ebeb6aa21d23936d0fbef20f7d9f208f)
not only uses an icon that does not fit the plasma theme now, it also does not
use the same theme as sddm anymore.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 377332] Placeholder face icon is not themed

2017-03-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377332

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to David Edmundson from comment #1)
> It's a symptom of the fact that we have 2 icon themes (plasma and non
> plasma) with icons looking different where we want them to look the same. 
> 
> I don't think my thing was a workaround or wrong but maybe in the wrong
> place.

IMO it should be fixed in kde-user-manager instead to use the themed icon.

> I should have just deleted the plasma icon.

No, please not. The non-plasma icon really does not fit to breeze dark or
breeze.

-- 
You are receiving this mail because:
You are watching all bug changes.

[ark] [Bug 377648] Ark does not show some folders in RPM

2017-04-05 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=377648

--- Comment #7 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Elvis Angelaccio from comment #6)
> What if you open the archive with file-roller?

What is that? The gnome app? I do not have that installed here and I don't want
to.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 383004] kdeconnect delays Plasma start by over a minute

2017-08-02 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=383004

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
I debugged a bit further and found the issue.

Both /etc/xdg/autostart/kdeconnect.desktop org.kde.plasmashell.desktop are
autostart phase 0, so they might be started in either order. If plasmashell is
started first, it triggers the dbus-activation and kdeconnect is started by the
session dbus-daemon. Then ksmserver starts
/etc/xdg/autostart/kdeconnect.desktop, which locks up as it found that
org.kde.kdeconnectd is already registered.
Deleting /etc/xdg/autostart/kdeconnect.desktop helps and is likely the right
solution here.

However, this doesn't solve the problem entirely, as now kdeconnectd hangs
inside the experimental bluetooth code:

#0  0x7f1ca5a1d5dd in pthread_cond_wait@@GLIBC_2.3.2 () from
/lib64/libpthread.so.0
#1  0x7f1ca9c0504b in QWaitCondition::wait(QMutex*, unsigned long) () from
/usr/lib64/libQt5Core.so.5
#2  0x7f1ca88dc83b in QDBusPendingCallPrivate::waitForFinished() () from
/usr/lib64/libQt5DBus.so.5
#3  0x7f1ca837aab4 in isBluez5 () at bluez/bluez5_helper.cpp:74
#4  0x7f1ca838d5d8 in
QBluetoothServiceInfoPrivate::QBluetoothServiceInfoPrivate
(this=0x560b034100a0)
at qbluetoothserviceinfo_bluez.cpp:180
#5  0x7f1ca835894e in QBluetoothServiceInfo::QBluetoothServiceInfo
(this=0x560b03411b50) at qbluetoothserviceinfo.cpp:345
#6  0x7f1cabc5411f in BluetoothLinkProvider::BluetoothLinkProvider() ()
from /usr/lib64/libkdeconnectcore.so.1
#7  0x7f1cabc73042 in Daemon::Daemon(QObject*, bool) () from
/usr/lib64/libkdeconnectcore.so.1
#8  0x560b01aff1a5 in ?? ()
#9  0x7f1ca96a in __libc_start_main () from /lib64/libc.so.6
#10 0x560b01aff24a in _start ()

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382340] Notifications are often as 1px vertical line

2017-08-02 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382340

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 383114] New: Non-deterministic ordering of modules

2017-08-04 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=383114

Bug ID: 383114
   Summary: Non-deterministic ordering of modules
   Product: systemsettings
   Version: unspecified
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-b...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

Sometimes the "Icons" module is above "Fonts", sometimes below.

Found by openQA:

https://openqa.opensuse.org/tests/461785#step/systemsettings5/5
https://openqa.opensuse.org/tests/461693#step/systemsettings5/5

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-integration] [Bug 383191] Mismatch of default font settings and default kcm_fonts selection

2017-08-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=383191

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/pla
   ||sma-integration/1b21b5977c2
   ||068c5bd30c9f9f641f60bdba9ea
   ||8e
 Resolution|--- |FIXED

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e by Fabian Vogt.
Committed on 11/08/2017 at 09:14.
Pushed by fvogt into branch 'master'.

Also specify a default StyleName for fonts

Summary:
When saving, kcm_fonts adds the default selected StyleName,
so it needs to specified here as well to avoid mismatches.

Test Plan:
Ran pkcon install with no kdeglobals.
Without this change: Bold title in the auth dialog
With this change:  Normal title in the auth dialog

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7160

M  +8-7src/platformtheme/kfontsettingsdata.cpp
M  +1-0src/platformtheme/kfontsettingsdata.h

https://commits.kde.org/plasma-integration/1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 383004] kdeconnect delays Plasma start by over a minute

2017-08-14 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=383004

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Albert Vaca from comment #2)
> If kdeconnect is already running, launching kdeconnectd again should just
> exit immediately. I'm not sure why this is not happening. Can you check if,
> while your desktop is already up, running kdeconnectd by hand also hangs? Or
> it does just exit as intended? I'm trying to understand if this happens
> always under your setup or just while the desktop is starting.

It hangs as well, as expected.

I rechecked, it's actually solely the bluetooth support's fault.
Due to the blocking wait in BluetoothLinkProvider::BluetoothLinkProvider() the
first instance does not answer to the pings sent by the second instance in
time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 383004] kdeconnect delays Plasma start by over a minute

2017-08-14 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=383004

--- Comment #5 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Albert Vaca from comment #4)
> Why the heck is Bluetooth enabled is Suse packages?

Only in the KDE:Unstable:Extra repositories for testing - which is a good thing
as otherwise this bug wouldn't have been found :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 381592] plasmashell uses 100% cpu in multiple processes. (no taskbar animations)

2017-07-07 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=381592

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de

--- Comment #6 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to David Edmundson from comment #1)
> That shows all threads idling.
> 
> *** This bug has been marked as a duplicate of bug 378010 ***

Four of those threads are not idling, they're currently in baloo, looking for
matches in lmdb.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382263] New: Links in notifications not clickable (5.10 regression)

2017-07-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382263

Bug ID: 382263
   Summary: Links in notifications not clickable (5.10 regression)
   Product: plasmashell
   Version: master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Notifications
  Assignee: k...@privat.broulik.de
  Reporter: fab...@ritter-vogt.de
CC: plasma-b...@kde.org
  Target Milestone: 1.0

The MouseArea introduced by eb0991bc8387b521370c7ce6eb0aee0d865541bd catches
all events before they reach the TextView.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 382243] Does not sanitize HTML in device names

2017-07-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382243

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Made a patch: https://phabricator.kde.org/D6640

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 381982] SDDM KCM shows session files with Hidden=true

2017-07-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=381982

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/sdd
   ||m-kcm/992143c4bf5ad5219a20c
   ||c7c56efea5c941ef79b
 Resolution|--- |FIXED

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 992143c4bf5ad5219a20cc7c56efea5c941ef79b by Fabian Vogt.
Committed on 11/07/2017 at 11:15.
Pushed by fvogt into branch 'Plasma/5.8'.

Session file parser: Support sections and respect the Hidden property

Summary:
Some desktop files have multiple sections, but for now we're only
interested in [Desktop Entry]. Without this patch, every entry was seen
as part of the [Desktop Entry] session, resulting in values getting
overwritten.

Additionally, the Hidden=true property specifies that the desktop file
needs to be treated like it was non-existant.

Same as https://github.com/sddm/sddm/pull/821 for sddm.

Test Plan:
Installed the KCM, now there are no duplicate sessions and the right
Name is shown for icewm-session.desktop.

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: davidedmundson, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6626

M  +20   -2src/sessionmodel.cpp

https://commits.kde.org/sddm-kcm/992143c4bf5ad5219a20cc7c56efea5c941ef79b

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 381982] SDDM KCM shows session files with Hidden=true

2017-07-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=381982

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

  Latest Commit|https://commits.kde.org/sdd |https://commits.kde.org/sdd
   |m-kcm/992143c4bf5ad5219a20c |m-kcm/65dc9de7c45d5ea4affaa
   |c7c56efea5c941ef79b |6bf9e6601a000c3e321

--- Comment #4 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 65dc9de7c45d5ea4affaa6bf9e6601a000c3e321 by Fabian Vogt.
Committed on 11/07/2017 at 11:07.
Pushed by fvogt into branch 'Plasma/5.10'.

Session file parser: Support sections and respect the Hidden property

Summary:
Some desktop files have multiple sections, but for now we're only
interested in [Desktop Entry]. Without this patch, every entry was seen
as part of the [Desktop Entry] session, resulting in values getting
overwritten.

Additionally, the Hidden=true property specifies that the desktop file
needs to be treated like it was non-existant.

Same as https://github.com/sddm/sddm/pull/821 for sddm.

Test Plan:
Installed the KCM, now there are no duplicate sessions and the right
Name is shown for icewm-session.desktop.

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6626

M  +20   -2src/sessionmodel.cpp

https://commits.kde.org/sddm-kcm/65dc9de7c45d5ea4affaa6bf9e6601a000c3e321

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 381982] SDDM KCM shows session files with Hidden=true

2017-07-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=381982

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1
Summary|system settings - sddm -|SDDM KCM shows session
   |session - duplicate 'plasma |files with Hidden=true
   |5' option   |
 CC||fab...@ritter-vogt.de

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
The duplicate "Plasma 5" session is caused by downstream adding a
"default.desktop" symlink in /usr/share/xsessions. The sddm kcm does not handle
this case, it should probably get shown as "(System Default)" or similar.
Anyway, that needs to be fixed downstream first.

I see a second issue though, desktop files with Hidden=true are still shown
although the spec says they need to be ignored completely. This part needs to
be fixed in kcm_sddm indeed, so setting CONFIRMED and adjusting the subject.

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 381982] SDDM KCM shows session files with Hidden=true

2017-07-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=381982

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Fabian Vogt from comment #1)
> I see a second issue though, desktop files with Hidden=true are still shown
> although the spec says they need to be ignored completely. This part needs
> to be fixed in kcm_sddm indeed, so setting CONFIRMED and adjusting the
> subject.

I made a patch for the second issue: https://phabricator.kde.org/D6626

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-knewstuff] [Bug 382136] KWin script KCM does not refresh after uninstalling scripts

2017-07-09 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382136

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Flöser from comment #1)
> This looks to me like a problem in knewstuff. KWin has the following piece
> of code:
> 
> connect(ui->ghnsButton, ::Button::dialogFinished, this,
> [this](const KNS3::Entry::List ) {
> if (!changedEntries.isEmpty()) {
> updateListViewContents();
> }
> });
> 
> Which means the list is empty when removing a script and thus the update is
> not executed.

It looks to me more like KPluginSelector does not allow removal of entries

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 382243] New: Does not sanitize HTML in device names

2017-07-11 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382243

Bug ID: 382243
   Summary: Does not sanitize HTML in device names
   Product: kdeconnect
   Version: 1.5
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: common
  Assignee: albertv...@gmail.com
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

By calling my device "BIG FONT" and sending unauthorized pings to
other devices, they parse and display it as HTML. Works with img, a, etc. as
well.

This affects every place where the label is displayed (notification, label in
the kcm, plasmoid), except the list of available devices in the kcm.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382136] New: KWin script KCM does not refresh after uninstalling scripts

2017-07-08 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382136

Bug ID: 382136
   Summary: KWin script KCM does not refresh after uninstalling
scripts
   Product: kwin
   Version: 5.10.3
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: scripting
  Assignee: kwin-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

- Open kwin script kcm
- Install a new script using GHNS
- Close the GHNS dialog -> new script shown
- Uninstall the script again
- Close the GHNS dialog -> new script still shown

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdeconnect] [Bug 382243] Does not sanitize HTML in device names

2017-07-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382243

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
  Latest Commit||https://commits.kde.org/kde
   ||connect-kde/5641d818dc6875e
   ||df82b1b4e91d861997c3ecfc1

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 5641d818dc6875edf82b1b4e91d861997c3ecfc1 by Fabian Vogt.
Committed on 12/07/2017 at 09:33.
Pushed by fvogt into branch '1.x'.

Treat device names as plaintext, not rich text

Summary:
Notifications, QML Text and QLabel accept a HTML subset,
which does not make sense for device names.

Test Plan:
Sent a pair request and accepted it, device name
now shown as plain text everywhere.

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: #kde_connect

Differential Revision: https://phabricator.kde.org/D6640

M  +1-1daemon/kdeconnectd.cpp
M  +3-0kcm/kcm.ui
M  +1-0plasmoid/package/contents/ui/DeviceDelegate.qml

https://commits.kde.org/kdeconnect-kde/5641d818dc6875edf82b1b4e91d861997c3ecfc1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Plasma SDK] [Bug 382275] New: Cuttlefish installs two appdata files for the same application

2017-07-12 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382275

Bug ID: 382275
   Summary: Cuttlefish installs two appdata files for the same
application
   Product: Plasma SDK
   Version: Git
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: cuttlefish
  Assignee: plasma-b...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: giorgos.tsiapalio...@kde.org
  Target Milestone: ---

org.kde.plasma.cuttlefish.appdata.xml and
org.kde.cuttlefish.appdata.xml

One of those should be enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 381130] Notifications are sometimes misplaced in the left upper corner

2017-07-15 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=381130

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 CC||fab...@ritter-vogt.de,
   ||notm...@gmail.com

--- Comment #36 from Fabian Vogt <fab...@ritter-vogt.de> ---
As plasma-framework 5.34 works, I tried some reverts on top of v5.35.0 and it
looks like reverting fd2e850156ac7aa9c9dc2cf46652b2a1f1fc3a07 ("recreate
plasmashellsurf on exposed, destoy on hidden") fixes it.

Adding author of the patch to CC.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-browser-integration] [Bug 382445] When I close chromium, the process takes 100% CPU

2017-07-18 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382445

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/pla
   ||sma-browser-integration/4c2
   ||a3b16803677fe9a7f22e3cda725
   ||5cfd140815

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
Git commit 4c2a3b16803677fe9a7f22e3cda7255cfd140815 by Fabian Vogt.
Committed on 18/07/2017 at 08:35.
Pushed by fvogt into branch 'master'.

Check for HUP/ERR/NVAL conditions on stdin

Summary:
While Qt's event loop checks for POLLHUP, it
treats it exactly like POLLIN and it's not possible
to retrieve that information from Qt. So in the
Connection read handler it needs to be checked for
again.

Test Plan:
Before this patch plasma-browser-integration-host
consumed 100% CPU after exiting the browser, 100% reproducible.
Now it quits gracefully.

Reviewers: #plasma, broulik, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6711

M  +19   -0host/connection.cpp

https://commits.kde.org/plasma-browser-integration/4c2a3b16803677fe9a7f22e3cda7255cfd140815

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382692] Auto-Hide is broken for plasmashell 5.8.7

2017-07-25 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382692

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

Version|master  |5.8.7
 CC||fab...@ritter-vogt.de

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
Works fine here, with Plasma 5.8.7 and Frameworks 5.32.
Only a single screen though.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kinfocenter] [Bug 382627] New: Wrong OpenGL version shown

2017-07-23 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382627

Bug ID: 382627
   Summary: Wrong OpenGL version shown
   Product: kinfocenter
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: OpenGL
  Assignee: hubn...@gmail.com
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

The OpenGL KCM only shows the version of the compatibility profile, which is
3.0. It should instead show the version of the core profile, which can be >
3.0.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382789] New: Certain Xwayland applications do not have a window title

2017-07-27 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382789

Bug ID: 382789
   Summary: Certain Xwayland applications do not have a window
title
   Product: kwin
   Version: git master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: wayland-generic
  Assignee: kwin-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

Applications like "glxgears" and "xterm" have an empty window title, although
WM_NAME is set correctly (the name of the binary).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382789] Certain Xwayland applications do not have a window title

2017-07-27 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382789

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Flöser from comment #1)
> WM_NAME is not used for window title.

glxgears has only two properties that have the value "glxgears", which is shown
as a window title in a pure X11 session:

> WM_ICON_NAME(STRING) = "glxgears"
> WM_NAME(STRING) = "glxgears"

So I'm not sure where else the title/caption would come from.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-plasma] [Bug 382843] New: Reliably crashes on wayland when clicking logout button

2017-07-28 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382843

Bug ID: 382843
   Summary: Reliably crashes on wayland when clicking logout
button
   Product: frameworks-plasma
   Version: unspecified
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: tooltips
  Assignee: notm...@gmail.com
  Reporter: fab...@ritter-vogt.de
CC: k...@davidedmundson.co.uk
  Target Milestone: ---

I get this backtrace 100% reproducible:

#0  0x7f87f15baa90 in raise () from /lib64/libc.so.6
#1  0x7f87f15bc0f6 in abort () from /lib64/libc.so.6
#2  0x7f87f05af41f in ?? ()
#3  0x7f87f05ab4dd in wl_proxy_marshal_array_constructor_versioned () from
/usr/lib64/libwayland-client.so.0
#4  0x7f87f05ab5ec in wl_proxy_marshal () from
/usr/lib64/libwayland-client.so.0
#5  0x7f87e4714188 in
QtWaylandClient::QWaylandWlShellSurface::updateTransientParent(QWindow*) ()
from /usr/lib64/libQt5WaylandClient.so.5
#6  0x7f87e47124fb in QtWaylandClient::QWaylandWindow::initWindow() () from
/usr/lib64/libQt5WaylandClient.so.5
#7  0x7f87e4712b0d in QtWaylandClient::QWaylandWindow::setVisible(bool) ()
from /usr/lib64/libQt5WaylandClient.so.5
#8  0x7f874fdf9cf4 in QtWaylandClient::QWaylandEglWindow::setVisible(bool)
() from
/usr/lib64/qt5/plugins/wayland-graphics-integration-client/libwayland-egl.so
#9  0x7f87f2790c9d in QWindow::setVisible(bool) () from
/usr/lib64/libQt5Gui.so.5
#10 0x7f87f7a5c0cd in PlasmaQuick::Dialog::setVisible (this=0x556ed82ce3c0,
visible=) at
/usr/src/debug/plasma-framework-5.36.0git.20170727T045342~8125fbcbf/src/plasmaquick/dialog.cpp:1369
#11 0x7f87450f4d9f in ToolTip::showToolTip (this=0x556edc1c0ae0) at
/usr/src/debug/plasma-framework-5.36.0git.20170727T045342~8125fbcbf/src/declarativeimports/core/tooltip.cpp:160
#12 0x7f87f1f6035c in QMetaObject::activate(QObject*, int, int, void**) ()
from /usr/lib64/libQt5Core.so.5
#13 0x7f87f1f6c6a7 in QTimer::timeout(QTimer::QPrivateSignal) () from
/usr/lib64/libQt5Core.so.5
#14 0x7f87f1f6c9d8 in QTimer::timerEvent(QTimerEvent*) () from
/usr/lib64/libQt5Core.so.5
#15 0x7f87f1f60bfb in QObject::event(QEvent*) () from
/usr/lib64/libQt5Core.so.5
#16 0x7f87f2f4193c in QApplicationPrivate::notify_helper(QObject*, QEvent*)
() from /usr/lib64/libQt5Widgets.so.5
#17 0x7f87f2f48cb4 in QApplication::notify(QObject*, QEvent*) () from
/usr/lib64/libQt5Widgets.so.5
#18 0x7f87f1f32d48 in QCoreApplication::notifyInternal2(QObject*, QEvent*)
() from /usr/lib64/libQt5Core.so.5
#19 0x7f87f1f87c3e in QTimerInfoList::activateTimers() () from
/usr/lib64/libQt5Core.so.5
#20 0x7f87f1f88389 in ?? () from /usr/lib64/libQt5Core.so.5
#21 0x7f87ec69eb67 in g_main_context_dispatch () from
/usr/lib64/libglib-2.0.so.0
#22 0x7f87ec69ed98 in ?? () from /usr/lib64/libglib-2.0.so.0
#23 0x7f87ec69ee2c in g_main_context_iteration () from
/usr/lib64/libglib-2.0.so.0
#24 0x7f87f1f8868f in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib64/libQt5Core.so.5
#25 0x7f87f1f3135a in
QEventLoop::exec(QFlags) () from
/usr/lib64/libQt5Core.so.5
#26 0x7f87f1f39be4 in QCoreApplication::exec() () from
/usr/lib64/libQt5Core.so.5
#27 0x556ed356cd9b in ?? ()
#28 0x7f87f15a646a in __libc_start_main () from /lib64/libc.so.6
#29 0x556ed356d11a in _start ()

This is printed on stderr: "error marshalling arguments for set_transient
(signature oiiu): null value passed for arg 0"

Not sure whether this is a bug in plasma-framework or Qt 5.9.1.

Workaround:

[PlasmaToolTips]
Delay=0

in ~/.config/plasmarc

-- 
You are receiving this mail because:
You are watching all bug changes.

[dolphin] [Bug 382848] New: Broken kxmlgui initialization

2017-07-28 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382848

Bug ID: 382848
   Summary: Broken kxmlgui initialization
   Product: dolphin
   Version: unspecified
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: critical
  Priority: NOR
 Component: general
  Assignee: dolphin-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
CC: elvis.angelac...@kde.org
  Target Milestone: ---

https://commits.kde.org/dolphin/cf273cd8a90178460c29b97b115a876fbef10295 is
broken as resources from static libraries are not loaded automatically: 
https://wiki.qt.io/QtResources#Q_INIT_RESOURCE
This results in half of the UI missing:
https://openqa.opensuse.org/tests/457381#step/dolphin/5

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382748] New: XWayland rendering artifacts with KWIN_COMPOSE=Q

2017-07-26 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382748

Bug ID: 382748
   Summary: XWayland rendering artifacts with KWIN_COMPOSE=Q
   Product: kwin
   Version: git master
  Platform: openSUSE RPMs
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: wayland-generic
  Assignee: kwin-bugs-n...@kde.org
  Reporter: fab...@ritter-vogt.de
  Target Milestone: ---

With KWIN_COMPOSE=Q, Xwayland windows seem to be drawn at a size different from
the native pixmap. They appear squashed and do not fill the window borders.
Screenshot attached, the konsole on the top is an X window, the konsole in the
background a native wayland client.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382748] XWayland rendering artifacts with KWIN_COMPOSE=Q

2017-07-26 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382748

--- Comment #1 from Fabian Vogt <fab...@ritter-vogt.de> ---
Created attachment 106873
  --> https://bugs.kde.org/attachment.cgi?id=106873=edit
Screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 380972] Overlapping labels on front page

2017-07-26 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=380972

Fabian Vogt <fab...@ritter-vogt.de> changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1

--- Comment #2 from Fabian Vogt <fab...@ritter-vogt.de> ---
Still happens if the words are fairly long. There just needs to me more space
between the icons, like in the icon view.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 382748] XWayland rendering artifacts with KWIN_COMPOSE=Q

2017-07-26 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382748

--- Comment #3 from Fabian Vogt <fab...@ritter-vogt.de> ---
(In reply to Martin Flöser from comment #2)
> is it also scaled down? I mean if you move the mouse over the menu does it
> highlight at the correct positions?

It's only the drawing that's wrong, if I try xeyes, the offset between cursor
and eye increases the further away the cursor is from (0/0), the top left.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-networkmanager-qt] [Bug 382051] New: Does not build with NetworkManager-1.0

2017-07-06 Thread Fabian Vogt
https://bugs.kde.org/show_bug.cgi?id=382051

Bug ID: 382051
   Summary: Does not build with NetworkManager-1.0
   Product: frameworks-networkmanager-qt
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: jgrul...@redhat.com
  Reporter: fab...@ritter-vogt.de
CC: lamar...@kde.org, lukas.ti...@merlin.cz
  Target Milestone: ---

Created attachment 106459
  --> https://bugs.kde.org/attachment.cgi?id=106459=edit
Patch

Despite CMakeLists.txt claiming that it builds with NetworkManager-1.0 as well,
it does not.

[   76s] In file included from
/home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/utils.h:31:0,
[   76s]  from
/home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/utils.cpp:22:
[   76s]
/home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:57:28:
error: 'NM_SETTING_WIRELESS_POWERSAVE_DEFAULT' was not declared in this scope
[   76s]  PowerSaveDefault = NM_SETTING_WIRELESS_POWERSAVE_DEFAULT,
[   76s] ^
[   76s]
/home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:58:27:
error: 'NM_SETTING_WIRELESS_POWERSAVE_IGNORE' was not declared in this scope
[   76s]  PowerSaveIgnore = NM_SETTING_WIRELESS_POWERSAVE_IGNORE,
[   76s]^
[   76s]
/home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:59:28:
error: 'NM_SETTING_WIRELESS_POWERSAVE_DISABLE' was not declared in this scope
[   76s]  PowerSaveDisable = NM_SETTING_WIRELESS_POWERSAVE_DISABLE,
[   76s] ^
[   76s]
/home/abuild/rpmbuild/BUILD/networkmanager-qt-5.36.0git.20170630T235743~a885ae7/src/settings/wirelesssetting.h:60:27:
error: 'NM_SETTING_WIRELESS_POWERSAVE_ENABLE' was not declared in this scope
[   76s]  PowerSaveEnable = NM_SETTING_WIRELESS_POWERSAVE_ENABLE

A patch that fixes the issue is attached.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   8   9   10   >