[kwin] [Bug 394245] New: Glide effect suffers from perspective distortions

2018-05-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394245

Bug ID: 394245
   Summary: Glide effect suffers from perspective distortions
   Product: kwin
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: effects-various
  Assignee: kwin-bugs-n...@kde.org
  Reporter: vladz...@gmail.com
  Target Milestone: ---

If a window is off-center, it'll be distorted(more precisely, skewed).

Steps to reproduce:

- On a multiple monitor setup

  - Enable Glide effect
  - Open a new window

- On a single monitor setup

  - Enable Glide effect
  - Open a new window
  - Move it to a off-center location
  - Close it

Expected results:
No skews, etc.

Actual results:
Windows are skewed.

Fixes:
One of possible fixes:
https://github.com/zzag/kwin-effects-appear1/issues/1#issuecomment-388640833

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-06 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #19 from Vlad Zagorodniy  ---
Created attachment 113108
  --> https://bugs.kde.org/attachment.cgi?id=113108=edit
Half pixel correction

(In reply to Fabian Vogt from comment #18)
> What about fixing the texture bleeding instead?
> 
> AFAICT it is the half-pixel issue. If you can give me a pointer where to
> look I can give it a try.

See the attached patch. I hope it will help you.

What I don't like about that approach is that if there is mipmapping,
it won't help pretty much.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-06 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #20 from Vlad Zagorodniy  ---
Created attachment 113109
  --> https://bugs.kde.org/attachment.cgi?id=113109=edit
Zoom with half pixel correction

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395179] Global menu getting outside of screen

2018-06-09 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395179

Vlad Zagorodniy  changed:

   What|Removed |Added

  Component|effects-window-management   |appmenu
 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

--- Comment #11 from Vlad Zagorodniy  ---
(In reply to Vlad Zagorodniy from comment #10)
> FWIW, blur effect in KWin 5.13.1 should work fine on multiple monitor
> setups. :-)

Sorry, I was BSing. It only includes HiDPI fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395350] KWin hang on desktop grid

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395350

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #3 from Vlad Zagorodniy  ---
Does KWin crash when using present windows effect?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

--- Comment #6 from Vlad Zagorodniy  ---
(In reply to Christian Muehlhaeuser from comment #5)
> Afraid I don't have the capability to screen record here right now. May I
> ask what you're looking for?

I want to see what's wrong because I can't reproduce this bug. When I move or
resize Konsole, background behind it is still blurred. (With transparency
effect, window will be slightly transparent but background is still blurred)

The only issue that blur effect has in KWin 5.13 is that it doesn't work on
multiple monitor setups. Alex Nemeth(the author of the new blur effect) fixed
it already.

So, it would be great if you provide more details on how to reproduce this bug
because as I said previously: I can't reproduce it.

> The result when moving and resizing (with the exception of Konsole)
> is the same as with only the translucency effect enabled on <5.13.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

--- Comment #7 from Vlad Zagorodniy  ---
** it doesn't work correctly on multiple monitor setups

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395494] The new blur effect should be applied faster

2018-06-16 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395494

Vlad Zagorodniy  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE
 CC||vladz...@gmail.com

--- Comment #1 from Vlad Zagorodniy  ---
Blur effect doesn't blur behind transformed windows (wobbly windows effect
transforms/deformates windows). That's because blur effect operates on
rectangular regions.

*** This bug has been marked as a duplicate of bug 391819 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 391819] The blur effect should work during animations.

2018-06-16 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=391819

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||tyx...@gmail.com

--- Comment #20 from Vlad Zagorodniy  ---
*** Bug 395494 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395493] Random Kwin crashes

2018-06-16 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395493

--- Comment #4 from Vlad Zagorodniy  ---
(In reply to Jesus from comment #3)
> I only submitted because the crash dialog said it could be useful. But I
> could try compiling with debugging symbols if it's needed.

Here's how you can get KWin with debug symbols:
* download PKGBUILD from
https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/kwin
* add -DCMAKE_BUILD_TYPE=RelWithDebInfo to the cmake command line arguments
* run makepkg -i (if brave enough and don't want to add gpg keys, add
--skippgpcheck)
* after you submitted a backtrace with debug symbols, run: sudo pacman -S
extra/kwin

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395494] The new blur effect should be applied faster

2018-06-16 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395494

--- Comment #3 from Vlad Zagorodniy  ---
(In reply to Filip from comment #2)
> You're absolutely correct, this happens because of Wobbly Windows. However,
> when I was using the old blur and forced it everywhere with Kvantum  it
> didn't have this issue IIRC, it blurred instantly. But that might be because
> the blurring method was very different?
> 
> Could a workaround be possibly made that detects if a user has Wobbly
> Windows on and then implements the gradual blurring that the new screen
> locker has? Although this may open other problems, of course.

That would still produce visual problems. See
https://bugs.kde.org/show_bug.cgi?id=391819#c8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395493] Random Kwin crashes

2018-06-16 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395493

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #2 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #1)
> Unfortunately the backtrace is lacking debug symbols. If you are able to
> reproduce please install debug packages and attach a new backtrace.

I'm afraid that reporter can't provide a backtrace with debug symbols. There is
no debug packages in Arch Linux.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

Vlad Zagorodniy  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|UNCONFIRMED |RESOLVED

--- Comment #9 from Vlad Zagorodniy  ---
(In reply to Christian Muehlhaeuser from comment #8)
> Well, as mentioned Konsole at least works. It's all the other apps where it
> has no effect.

OK, I've got what you're talking about. Those apps then should tell KWin what
regions to blur. KWin doesn't blur behind all transparent windows.

Konsole tells KWin what to blur so KWin blurs background.

> I do have several monitors connected to the system indeed, so that's
> probably the issue.

No, it doesn't have anything to do with multiple monitor setups. I thought that
blur doesn't work for Konsole.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

--- Comment #10 from Vlad Zagorodniy  ---
FWIW, blur effect in KWin 5.13.1 should work fine on multiple monitor setups.
:-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395377] New "Slide" effect moves panels by default; not configurable in "Virtual desktop" menu

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395377

--- Comment #2 from Vlad Zagorodniy  ---
> When switching virtual desktops with the old "slide" effect enabled, panels 
> would not slide with them.  The rewritten slide effect however slides the 
> panels together with the windows, only to end up with the same panel.

Panels slide for two reasons:
* fix issues with full screen windows, see https://phabricator.kde.org/D9638;
* as I said in the diff, panels are also sliding to separate each virtual
desktop as much as possible. 

> I consider this is bad from an UI perspective: particularly when switching 
> desktops using the Pager or the taskbar plasmoid, these applets move away 
> from under your mouse cursor.

Well, it's not possible to cover every possible use-case.

> The relevant commit, AFAICS, is ddd406dfd91cc085a . From a quick glance on 
> the code, it seems like the method 
> `SlideEffect::shouldForceBackgroundContrast()` is to blame, since it the 
> check for `w->isDock() || w->keepAbove()` was removed.

shouldForceBackgroundContrast has nothing to do with sliding of panels as its
name suggests. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395377] New "Slide" effect moves panels by default; not configurable in "Virtual desktop" menu

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395377

--- Comment #3 from Vlad Zagorodniy  ---
Could you please update the bug report so it concerns only one
issue(non-configurable slide effect in virtual desktops kcm)?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395377] New "Slide" effect moves panels by default; not configurable in "Virtual desktop" menu

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395377

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|kwin-bugs-n...@kde.org  |vladz...@gmail.com
 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-browser-integration] [Bug 395393] When playing a playlist on YouTube, Media Player shows wrong title sometimes

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395393

Vlad Zagorodniy  changed:

   What|Removed |Added

   Platform|Other   |Archlinux Packages

--- Comment #1 from Vlad Zagorodniy  ---
Window title for each of those videos looks fine in the task manager.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-browser-integration] [Bug 395393] When playing a playlist on YouTube, Media Player sometimes shows wrong title

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395393

Vlad Zagorodniy  changed:

   What|Removed |Added

Summary|When playing a playlist on  |When playing a playlist on
   |YouTube, Media Player shows |YouTube, Media Player
   |wrong title sometimes   |sometimes shows wrong title

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasma-browser-integration] [Bug 395393] New: When playing a playlist on YouTube, Media Player shows wrong title sometimes

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395393

Bug ID: 395393
   Summary: When playing a playlist on YouTube, Media Player shows
wrong title sometimes
   Product: plasma-browser-integration
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Firefox
  Assignee: k...@privat.broulik.de
  Reporter: vladz...@gmail.com
  Target Milestone: ---

Window title in Media Player is a little bit stochastic, for example

* Go to
https://www.youtube.com/watch?v=vjVkXlxsO8Q=PLgwUvJ_atkZIzs0-MA5KVEh9YtwdCRQ5C
* Listen to Papercut
* Take a look at what currently playing video is (Papercut)
https://imgur.com/a/4G9s6zA
* Wait for One Step Closer
* Take a look at what currently playing video is (Papercut)
https://imgur.com/a/bBmwszS
* Wait for With You
* Take a look at what currently playing video is (One Step Closer)
https://imgur.com/a/42EMWfA

Sometimes, it shows title from previous video. Sometimes, it shows title for
current video.

(I don't use Google Chrome so I don't know whether that's a general bug or a
bug specific to Firefox)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395399] New: Content of popups sometimes is not updated

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395399

Bug ID: 395399
   Summary: Content of popups sometimes is not updated
   Product: plasmashell
   Version: master
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: vladz...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Created attachment 113331
  --> https://bugs.kde.org/attachment.cgi?id=113331=edit
Demonstration of the bug

Steps to reproduce:
See the attached video.

(I disabled morphing popups effect, but this bug is still reproducible with
morphing popups being enabled)

Expected results:
* When the arrow is hovered, the popup displays "Show hidden icons".
* When the clock is hovered, the popup displays current day.

Actual results:
The popup contains artifacts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 395399] Content of popups sometimes is not updated correctly

2018-06-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395399

Vlad Zagorodniy  changed:

   What|Removed |Added

Summary|Content of popups sometimes |Content of popups sometimes
   |is not updated  |is not updated correctly

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

2018-06-17 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=185710

--- Comment #23 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #22)
> KWin core (VirtualDesktopManager) has the information. Maybe we need to add
> signals like desktopAboutToSwitchToLeft.

I've been thinking about something similar:

Emit currentDesktopAboutToBeChanged(const DesktopChangedData ),
struct DesktopChangedData {
uint old;
uint new;
bool wrapped;
EffectWindow *movingWindow;
};

or just emit desktopChanged(const DesktopChangedData ), so
Slide effect would use a different wrap function, which is more
"aggressive" with respect to wrapping, if data.wrapped is true.
Same with cube slide effect.

Yet, I'm not sure if it's possible to implement such "behavior".

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395377] "Slide" effect not configurable in "Virtual desktop" menu

2018-06-17 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395377

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/kwi
   ||n/586460dbfcd0591b74d4ce299
   ||6e2634c10eb4ee8
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Vlad Zagorodniy  ---
Git commit 586460dbfcd0591b74d4ce2996e2634c10eb4ee8 by Vlad Zagorodniy.
Committed on 17/06/2018 at 16:38.
Pushed by vladz into branch 'master'.

[kcmkwin/kwindesktop] Make Slide effect configurable

Summary:
Even though the Slide effect has a KCM, it's not possible to configure
it [slide effect] from the virtual desktops KCM.

This change addresses the problem above.

### Before

{F5912774, layout=center, size=full}

### After

{F5912775, layout=center, size=full}

Reviewers: #kwin, davidedmundson

Reviewed By: #kwin, davidedmundson

Subscribers: davidedmundson, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13544

M  +12   -2kcmkwin/kwindesktop/main.cpp

https://commits.kde.org/kwin/586460dbfcd0591b74d4ce2996e2634c10eb4ee8

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #1 from Vlad Zagorodniy  ---
Are you using wobbly windows? Could you please post output of

qdbus org.kde.kwin /KWin supportInformation

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

--- Comment #2 from Vlad Zagorodniy  ---
qdbus org.kde.KWin /KWin supportInformation

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 395545] Blur effect doesn't apply when moving windows

2018-06-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=395545

--- Comment #4 from Vlad Zagorodniy  ---
Other windows should tell KWin what regions to blur. Konsole does that.

Could you please also record your screen to demonstrate the bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 391659] FrameSVG not rendering edges with compositing off

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=391659

--- Comment #11 from Vlad Zagorodniy  ---
https://phabricator.kde.org/D13215

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #11 from Vlad Zagorodniy  ---
https://phabricator.kde.org/D13215

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382324] Translucent lines at some places after update to 5.36 frameworks

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=382324

--- Comment #12 from Vlad Zagorodniy  ---
https://phabricator.kde.org/D13215

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 354741] Cancelling quick tile causes window to flicker

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=354741

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 354486] MagicLampEffect triggers empty subquad assert from makeGrid -> makeSubQuad

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=354486

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #4 from Vlad Zagorodniy  ---
Martin, is this bug still relevant?

I think https://phabricator.kde.org/D11015 fixed this bug too.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #6 from Vlad Zagorodniy  ---
*** Bug 393149 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 393149] Transformed windows have gray line between contents and borders

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=393149

Vlad Zagorodniy  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Vlad Zagorodniy  ---


*** This bug has been marked as a duplicate of bug 360549 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 245988] KWin Blur plugin has bleeding issues when moving/redrawing frame-less windows

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=245988

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #10 from Vlad Zagorodniy  ---
Is this still the case? I can't reproduce this bug. (I use the new blur)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 246058] When blur enabled kwin cpu goes from 0 to 5->6% and stays

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=246058

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #16 from Vlad Zagorodniy  ---
It's been ~4 years since last comment, does the problem still persist?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 321897] Sheet effect doesn't set WindowClosedGrabRole and collides with fade effect on close for different duration

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=321897

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 340009] Background contrast geometry is not updated

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=340009

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #4 from Vlad Zagorodniy  ---
It's been ~4 years since last comment, does this bug still persist?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-04 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #7 from Vlad Zagorodniy  ---
Isn't it related to 178508?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 307112] Blur effect: doCachedBlur() is broken for non opaque windows (at least)

2018-06-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=307112

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #47 from Vlad Zagorodniy  ---
Is this bug still relevant? Blur effect is no longer doing doCachedBlur.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 185710] wrong direction in "slide" plugin

2018-06-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=185710

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #21 from Vlad Zagorodniy  ---
For technical reasons, that's a little bit challenging for effects like Slide
or Desktop Cube Animation
to figure out whether they should "roll desktops" when the number of rows or
columns in the virtual
desktop grid is equal to 2.

Why is it challenging? Let's imagine a setup with 2 virtual desktops. Now,
let's consider two cases:

(a) Current virtual desktop is "Desktop 1" and user switches one desktop to
right(i.e. to "Desktop 2").
In this case, desktopChanged(int old, int current) signal will be emitted,
where old=1, and current=2.

(b) Current virtual desktop is "Desktop 1" and user switches one desktop to
left(i.e. to "Desktop 2").
In this case, desktopChanged(int old, int current) signal will be emitted,
where old=1, and current=2.

As you see, in both cases, old=1, and current=2. That's too ambiguous.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390366] Cube Slide does not work on wayland

2018-06-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390366

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 256469] Animate moving windows between desktops with keyboard and slide

2018-06-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=256469

Vlad Zagorodniy  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED
 CC||vladz...@gmail.com

--- Comment #1 from Vlad Zagorodniy  ---
(In reply to Todd from comment #0)
> Version:   unspecified (using KDE 4.5.3) 
> OS:Linux
> 
> When you use a keyboard shortcut to move windows between desktops with the
> slide effect enabled, the desktop changes and the window just appears on the
> other desktop about halfway through the animation.  So the window slides off
> the desktop for about half the animation then slides back on for the other
> half.  I think it would be better if the window stayed stationary and the
> desktop slid underneath it, so it was like you were grabbing the window and
> dragging it with you while you moved desktops.

Already implemented: https://phabricator.kde.org/D9487
FWIW, "the new" slide effect doesn't have such problems.

> Better yet, it shrink a little bit (to make it seem as though it were rising
> off the screen), then the desktop could slide underneath of it, then it
> would return to its original size (so it seems as though it were settling
> back down).  This would also allow you to see the desktop moving for
> maximized windows, since the desktop would become visible around the edges
> of the window.

I'd tried implementing such thing. For technical reasons, that's a little bit
challenging to get this kind of animation right.
https://phabricator.kde.org/D9638#185606

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 213847] windows that are moved to another desktop should be treated as sticky windows

2018-06-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=213847

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com
 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Vlad Zagorodniy  ---
https://phabricator.kde.org/D9487 fixed this bug.

Also, FWIW, "the new" slide effect doesn't have such problems.
(https://phabricator.kde.org/D9638)

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

Vlad Zagorodniy  changed:

   What|Removed |Added

   Platform|Other   |Archlinux Packages
Version|unspecified |5.12.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] New: Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

Bug ID: 394963
   Summary: Spinboxes look flat
   Product: Breeze
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: QStyle
  Assignee: hugo.pereira.da.co...@gmail.com
  Reporter: vladz...@gmail.com
  Target Milestone: ---

Created attachment 113020
  --> https://bugs.kde.org/attachment.cgi?id=113020=edit
The spinbox doesn't have outline and overall it looks super flat

System Info:
* Distro: Arch Linux
* Qt style: Breeze
* Qt version: 5.11
* KDE Plasma version: 5.12.5

breezerc:
```
[Common]
ShadowColor=0,0,0
ShadowSize=ShadowVeryLarge
ShadowStrength=222

[Windeco]
DrawBackgroundGradient=false
```

IIRC, I started noticing that spinboxes look really flat after
recent Qt update(from 5.10 to 5.11).

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #1 from Vlad Zagorodniy  ---
Created attachment 113021
  --> https://bugs.kde.org/attachment.cgi?id=113021=edit
Other controls

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #4 from Vlad Zagorodniy  ---
Created attachment 113022
  --> https://bugs.kde.org/attachment.cgi?id=113022=edit
Oxygen controls

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #3 from Vlad Zagorodniy  ---
(In reply to Hugo Pereira Da Costa from comment #2)
> Hi Vlad,

Hi, Hugo! :)

> Is this the case for _all_ spinboxes ? Or only in some applications ? 

No, that's the case for all QWidget apps. Kirigami apps seems don't have
such problem.

FWIW, that's also the case for Oxygen and MS Windows 9x. Spinboxes with
the Fusion widget style look OK.

> the code for rendering spinboxes have not changed in years, and if this is
> for all spinboxes, I cannot reproduce it with breeze from master here, with
> Qt-5.10
> So that would point to some change in Qt-5.11 indeed. 
> I might be able to investigate but might take some time to switch to Qt-5.11
> on my side.
> Now if you on the other hand, can run the same version of breeze against
> Qt-5.10 and Qt-5.11 and toggle the issue by switching version, then you
> might want to file a bug report against Qt. 

Not sure if I can help with it, it takes eternity to compile Qt on my laptop.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #6 from Vlad Zagorodniy  ---
After taking a look at Fusion widget style source code, here's a patch
to "fix" this bug in some part:

```
>From 8a1b11a4ed6fdd639259d7eea1c04bc926b78483 Mon Sep 17 00:00:00 2001
From: Vlad Zagorodniy 
Date: Sat, 2 Jun 2018 23:42:38 +0300
Subject: [PATCH] Fix SpinBox frame rendering with Qt 5.11

---
 kstyle/breezestyle.cpp | 6 ++
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/kstyle/breezestyle.cpp b/kstyle/breezestyle.cpp
index 28746216..88042362 100644
--- a/kstyle/breezestyle.cpp
+++ b/kstyle/breezestyle.cpp
@@ -6200,13 +6200,11 @@ namespace Breeze
 const auto& palette( option->palette );
 const auto& rect( option->rect );

-
-if( option->subControls & SC_SpinBoxFrame )
+if( spinBoxOption->frame )
 {

 // detect flat spinboxes
-bool flat( !spinBoxOption->frame );
-flat |= ( rect.height() < 2*Metrics::Frame_FrameWidth +
Metrics::SpinBox_ArrowButtonWidth );
+const bool flat = ( rect.height() < 2*Metrics::Frame_FrameWidth +
Metrics::SpinBox_ArrowButtonWidth );
 if( flat )
 {

-- 
2.17.1

```

Also, Fusion checks whether it should draw arrows or plus/minus as follows:
if (spinBox->buttonSymbols == QAbstractSpinBox::PlusMinus) { ... }
else if (spinBox->buttonSymbols == QAbstractSpinBox::UpDownArrows) { ... }

I hope this will help you.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #7 from Vlad Zagorodniy  ---
https://code.woboq.org/qt5/qtbase/src/widgets/styles/qfusionstyle.cpp.html#2027

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #8 from Vlad Zagorodniy  ---
(In reply to Hugo Pereira Da Costa from comment #5)
> (In reply to Vlad Zagorodniy from comment #3)
> > (In reply to Hugo Pereira Da Costa from comment #2)
> > > Hi Vlad,
> > 
> > Hi, Hugo! :)
> > 
> > > Is this the case for _all_ spinboxes ? Or only in some applications ? 
> > 
> > No, that's the case for all QWidget apps. Kirigami apps seems don't have
> > such problem.
> > 
> > FWIW, that's also the case for Oxygen and MS Windows 9x. Spinboxes with
> > the Fusion widget style look OK.
> > 
> 
> Thanks. That's useful. I'll have a look, and if you by chance can compile
> breeze locally, I'll probably have some patches for you to test.

Sure, I can.

> There is a flag "isFlat" for spinboxes, to allow for rendering frameless
> spinboxes in e.g. listviews. It seems that for some reason, and some widget
> styles, this flag is set to true in cases where it should not. That's what
> I'll investigate. 
> I'd be curious to know if "editable" comboboxes show the same issue. 
> Example of editable comboboxes can be found in "oxygen-demo5" or in any
> "save" dialog. Can you check ?

Everything is okay.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #9 from Vlad Zagorodniy  ---
Created attachment 113023
  --> https://bugs.kde.org/attachment.cgi?id=113023=edit
Editable combobox

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #9 from Vlad Zagorodniy  ---
(In reply to Fabian Vogt from comment #8) 
> ... XRender.

Well, that wasn't my point.

Anyway, I suggest to move this bug to scene-opengl component because
zoom effect(and pretty much all other effects that scale/rotate windows)
does nothing wrong.

I think what we see is the texture bleeding (decorations are stored in
a texture atlas with 1px gap, IIRC).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #11 from Vlad Zagorodniy  ---
(In reply to Fabian Vogt from comment #10)
> Maybe - it's not clear from the screenshots whether the edges are sharp or
> blurry. If they are sharp, it's that the vertices don't have the same
> coordinates, if not, it's bleeding.

Here's example window quads:

contents: left = 4 top = 29 right = 885 bottom = 632
decoration: left = 0 top = 29 right = 4 bottom = 632
decoration: left = 0 top = 0 right = 889 bottom = 29
decoration: left = 885 top = 29 right = 889 bottom = 632
decoration: left = 0 top = 632 right = 889 bottom = 636
shadow: left = -93 top = -59 right = 99 bottom = 133
shadow: left = 99 top = -59 right = 790 bottom = 133
shadow: left = 790 top = -59 right = 982 bottom = 133
shadow: left = 790 top = 133 right = 982 bottom = 571
shadow: left = 790 top = 571 right = 982 bottom = 763
shadow: left = 99 top = 571 right = 790 bottom = 763
shadow: left = -93 top = 571 right = 99 bottom = 763
shadow: left = -93 top = 133 right = 99 bottom = 571

as you see vertices are totally fine (if we scale a window
the quads will stay the same).

Anyway, I still suggest to move this bug to scene-opengl component.

> My initial suspicion was the usual OpenGL half-pixel issue: The center of a
> pixel is at (x+0.5|y+0.5).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #12 from Vlad Zagorodniy  ---
Created attachment 113096
  --> https://bugs.kde.org/attachment.cgi?id=113096=edit
Texture bleeding in all its glory

Yep, that's texture bleeding (I've slightly changed
decoration renderer so it initially fills the texture
atlas with red color).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #14 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #13)
> I would keep the bug in this component. I doubt the scene can do anything
> about it. But the effect could by rendering the unzoomed window into an fbo
> and then zoom the fbo texture. That should prevent the bleading issue I
> think.

So, it would work like the Magnifier effect, right?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 264276] Extenders can be brought up twice when quickly clicking them

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=264276

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #2 from Vlad Zagorodniy  ---
(In reply to Thomas Lübking from comment #1)
> Looking at the effect, it needs some overhaul (two different animation
> lists, QHash::operator[] abuse) but if (as i assume) plasma doesn't keep and
> unmap the notification window but actually closes and reopens it, this will
> likely not fix (easily).

On X11, that's indeed the case:
windowAdded(KWin::EffectWindowImpl(0x562922dd79f0))
windowClosed(KWin::EffectWindowImpl(0x562922dd79f0))
windowAdded(KWin::EffectWindowImpl(0x562922c87210))
windowClosed(KWin::EffectWindowImpl(0x562922c87210))
windowAdded(KWin::EffectWindowImpl(0x562922e2d550))
windowClosed(KWin::EffectWindowImpl(0x562922e2d550))
windowAdded(KWin::EffectWindowImpl(0x562922e31050))
windowClosed(KWin::EffectWindowImpl(0x562922e31050))
windowAdded(KWin::EffectWindowImpl(0x562922259a30))
windowClosed(KWin::EffectWindowImpl(0x562922259a30))
windowAdded(KWin::EffectWindowImpl(0x562922e2a130))
windowClosed(KWin::EffectWindowImpl(0x562922e2a130))

It would be great to know whether that's the case for Wayland.

> The client would require  a unique tag (maybe alongside the present property
> data?) so the direction can be toggled based on this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 179275] Magic Lamp animation looks wrong when minimizing to a vertical panel

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=179275

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #19 from Vlad Zagorodniy  ---
Martin, shouldn't it be marked as resolved?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 360549] Visible 1px space between window content and title bar when zooming

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=360549

--- Comment #16 from Vlad Zagorodniy  ---
(In reply to Martin Flöser from comment #15)
> Does magnifier use fbo? I know looking glass does.

Well, yeah, as far as I understand it uses blitFromFramebuffer
to magnify a portion of the screen (size of the source rect is
smaller than size of the destination rect + linear filter).

So, maybe, we could do something similar in zoom effect?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 339564] Maximize Effect miscalculate the position when dragging to maximize/restore

2018-06-05 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=339564

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #2 from Vlad Zagorodniy  ---
I think this bug is no longer actual.

Also, looks like the video is corrupted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 391659] FrameSVG not rendering edges with compositing off

2018-06-06 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=391659

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/dce258bee3da8
   ||54980b6f2430b26f7025752a505
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #12 from Vlad Zagorodniy  ---
Git commit dce258bee3da854980b6f2430b26f7025752a505 by Vlad Zagorodniy.
Committed on 06/06/2018 at 17:52.
Pushed by vladz into branch 'master'.

FrameSvg: Recache maskFrame if enabledBorders has been changed

Summary:
In some cases, when rendering frame svg background, measures & margins
do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
but the bottom border is disabled. This causes visual artifacts like this

{F5878318, layout=center, size=full}

//Pay close attention to the bottom of the Task switcher. It has a transparent
strip at the bottom, which shouldn't be there.//

The cause of this problem is that FrameSVGPrivate::alphaMask doesn't take
enabledBorders
into account when it's making decision whether it should update maskFrame.

Just for reference, this is "after"

{F5878319, layout=center, size=full}
Related: bug 382324, bug 390632

Test Plan:
* Triggered the Breeze task switcher (with compositing on and off)
* Didn't see any transparent strips

---

* Tried running FrameSvgTest, still passes

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, aseigo, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13215

M  +16   -10   src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/dce258bee3da854980b6f2430b26f7025752a505

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

2018-06-06 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390632

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/dce258bee3da8
   ||54980b6f2430b26f7025752a505
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #12 from Vlad Zagorodniy  ---
Git commit dce258bee3da854980b6f2430b26f7025752a505 by Vlad Zagorodniy.
Committed on 06/06/2018 at 17:52.
Pushed by vladz into branch 'master'.

FrameSvg: Recache maskFrame if enabledBorders has been changed

Summary:
In some cases, when rendering frame svg background, measures & margins
do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
but the bottom border is disabled. This causes visual artifacts like this

{F5878318, layout=center, size=full}

//Pay close attention to the bottom of the Task switcher. It has a transparent
strip at the bottom, which shouldn't be there.//

The cause of this problem is that FrameSVGPrivate::alphaMask doesn't take
enabledBorders
into account when it's making decision whether it should update maskFrame.

Just for reference, this is "after"

{F5878319, layout=center, size=full}
Related: bug 382324, bug 391659

Test Plan:
* Triggered the Breeze task switcher (with compositing on and off)
* Didn't see any transparent strips

---

* Tried running FrameSvgTest, still passes

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, aseigo, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13215

M  +16   -10   src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/dce258bee3da854980b6f2430b26f7025752a505

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382324] Translucent lines at some places after update to 5.36 frameworks

2018-06-06 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=382324

Vlad Zagorodniy  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/pla
   ||sma-framework/dce258bee3da8
   ||54980b6f2430b26f7025752a505
 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #13 from Vlad Zagorodniy  ---
Git commit dce258bee3da854980b6f2430b26f7025752a505 by Vlad Zagorodniy.
Committed on 06/06/2018 at 17:52.
Pushed by vladz into branch 'master'.

FrameSvg: Recache maskFrame if enabledBorders has been changed

Summary:
In some cases, when rendering frame svg background, measures & margins
do not correspond to `enabledBorders`. I.e. `bottomHeight` may be equal to 5,
but the bottom border is disabled. This causes visual artifacts like this

{F5878318, layout=center, size=full}

//Pay close attention to the bottom of the Task switcher. It has a transparent
strip at the bottom, which shouldn't be there.//

The cause of this problem is that FrameSVGPrivate::alphaMask doesn't take
enabledBorders
into account when it's making decision whether it should update maskFrame.

Just for reference, this is "after"

{F5878319, layout=center, size=full}
Related: bug 390632, bug 391659

Test Plan:
* Triggered the Breeze task switcher (with compositing on and off)
* Didn't see any transparent strips

---

* Tried running FrameSvgTest, still passes

Reviewers: #plasma, #frameworks, mart

Reviewed By: #plasma, mart

Subscribers: abetts, mart, aseigo, broulik, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D13215

M  +16   -10   src/plasma/framesvg.cpp

https://commits.kde.org/plasma-framework/dce258bee3da854980b6f2430b26f7025752a505

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390632

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|k...@davidedmundson.co.uk|vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #10 from Vlad Zagorodniy  ---
I fixed it. I'll push fix soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 391659] FrameSVG not rendering edges with compositing off

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=391659

Vlad Zagorodniy  changed:

   What|Removed |Added

   Assignee|plasma-b...@kde.org |vladz...@gmail.com
 CC||vladz...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 382324] Translucent lines at some places after update to 5.36 frameworks

2018-05-30 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=382324

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #11 from Vlad Zagorodniy  ---
Marco, is it okay if I take this bug?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 394963] Spinboxes look flat

2018-06-02 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=394963

--- Comment #11 from Vlad Zagorodniy  ---
(In reply to Hugo Pereira Da Costa from comment #10)
> Ok. Fix looks "sensible", but if I read the patch right, it would indicate 
> that SC_SpinBoxFrame has become deprecated, in the sense that it is never
> set as option subcontrols anymore. Correct ? 

I'm not sure about that. I suggest to ask Qt folks first. Maybe it's not
deprecated
and what we are facing is a bug in Qt.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 396055] Multiscreen Wayland: Blur effect broken

2018-07-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=396055

Vlad Zagorodniy  changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #3 from Vlad Zagorodniy  ---
Please attach output of
qdbus org.kde.KWin /KWin supportInformation

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 396055] Multiscreen Wayland: Blur effect broken

2018-07-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=396055

--- Comment #7 from Vlad Zagorodniy  ---
Created attachment 113686
  --> https://bugs.kde.org/attachment.cgi?id=113686=edit
Kate and Dolphin behind Konsole

Do normal windows look okay behind Konsole? (like on the attached screenshot)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 396055] Multiscreen Wayland: Blur effect broken

2018-07-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=396055

--- Comment #6 from Vlad Zagorodniy  ---
kamil@kamil-pc:~ :-)qdbus org.kde.KWin /KWin supportInformation
Informacje o wsparciu dla KWin:
Pytając  na np. http://forum.kde.orgużyj wyświetlanych tu danych.
Dostarczają one informacji o obecnie uruchomionym wystąpieniu, o opcjach, które
są używane,
o używanym sterowniku OpenGL i o włączonych efektach.
Proszę wysłać te informacje, pod tekstem wprowadzenia, przy użyciu usługi paste
bin
takiej jak http://paste.kde.org, aby nie zaśmiecać wątku.

==

Version
===
KWin version: 5.13.2
Qt Version: 5.11.1
Qt compile version: 5.11.1
XCB compile version: 1.13

Operation Mode: Xwayland

Build Options
=
KWIN_BUILD_DECORATIONS: yes
KWIN_BUILD_TABBOX: yes
KWIN_BUILD_ACTIVITIES: yes
HAVE_DRM: yes
HAVE_GBM: yes
HAVE_X11_XCB: yes
HAVE_EPOXY_GLX: yes
HAVE_WAYLAND_EGL: yes

X11
===
Vendor: The X.Org Foundation
Vendor Release: 11906000
Protocol Version/Revision: 11/0
SHAPE: yes; Version: 0x11
RANDR: yes; Version: 0x14
DAMAGE: yes; Version: 0x11
Composite: yes; Version: 0x4
RENDER: yes; Version: 0xb
XFIXES: yes; Version: 0x50
SYNC: yes; Version: 0x31
GLX: yes; Version: 0x0

Decoration
==
Plugin: org.kde.breeze
Theme: 
Blur: 0
onAllDesktopsAvailable: true
alphaChannelSupported: true
closeOnDoubleClickOnMenu: false
decorationButtonsLeft: 0, 2
decorationButtonsRight: 6, 3, 4, 5
borderSize: 3
gridUnit: 10
font: Lato,10,-1,5,50,0,0,0,0,0,Regular
smallSpacing: 2
largeSpacing: 10

Platform
==
Name: DRM
Active: true
Atomic Mode Setting: true

Options
===
focusPolicy: 0
nextFocusPrefersMouse: false
clickRaise: true
autoRaise: false
autoRaiseInterval: 0
delayFocusInterval: 0
shadeHover: false
shadeHoverInterval: 250
separateScreenFocus: false
placement: 4
focusPolicyIsReasonable: true
borderSnapZone: 10
windowSnapZone: 10
centerSnapZone: 0
snapOnlyWhenOverlapping: false
rollOverDesktops: true
focusStealingPreventionLevel: 1
legacyFullscreenSupport: false
operationTitlebarDblClick: 5000
operationMaxButtonLeftClick: 5000
operationMaxButtonMiddleClick: 5015
operationMaxButtonRightClick: 5014
commandActiveTitlebar1: 0
commandActiveTitlebar2: 30
commandActiveTitlebar3: 2
commandInactiveTitlebar1: 4
commandInactiveTitlebar2: 30
commandInactiveTitlebar3: 2
commandWindow1: 7
commandWindow2: 8
commandWindow3: 8
commandWindowWheel: 31
commandAll1: 10
commandAll2: 3
commandAll3: 14
keyCmdAllModKey: 16777251
showGeometryTip: false
condensedTitle: false
electricBorderMaximize: true
electricBorderTiling: true
electricBorderCornerRatio: 0.25
borderlessMaximizedWindows: false
killPingTimeout: 5000
hideUtilityWindowsForInactive: true
inactiveTabsSkipTaskbar: false
autogroupSimilarWindows: false
autogroupInForeground: true
compositingMode: 1
useCompositing: true
compositingInitialized: true
hiddenPreviews: 1
glSmoothScale: 2
xrenderSmoothScale: false
maxFpsInterval: 1666
refreshRate: 0
vBlankTime: 600
glStrictBinding: false
glStrictBindingFollowsDriver: true
glCoreProfile: true
glPreferBufferSwap: 101
glPlatformInterface: 2
windowsBlockCompositing: false

Screen Edges

desktopSwitching: false
desktopSwitchingMovingClients: false
cursorPushBackDistance: 1x1
timeThreshold: 150
reActivateThreshold: 350
actionTopLeft: 0
actionTop: 0
actionTopRight: 0
actionRight: 0
actionBottomRight: 0
actionBottom: 0
actionBottomLeft: 0
actionLeft: 0

Screens
===
Multi-Head: no
Active screen follows mouse:  no
Number of Screens: 2

Screen 0:
-
Name: PHL VGA-1-PHL 223V5/UK0134500133
Geometry: 1920,0,1920x1080
Scale: 1
Refresh Rate: 60

Screen 1:
-
Name: BNQ HDMI-A-1-BenQ DL2215/33E01198SL0
Geometry: 0,0,1920x1080
Scale: 1
Refresh Rate: 60


Compositing
===
Compositing is active
Compositing Type: OpenGL
OpenGL vendor string: Intel Open Source Technology Center
OpenGL renderer string: Mesa DRI Intel(R) Ivybridge Mobile 
OpenGL version string: 4.2 (Core Profile) Mesa 18.1.3
OpenGL platform interface: EGL
OpenGL shading language version string: 4.20
Driver: Intel
GPU class: IvyBridge
OpenGL version: 4.2
GLSL version: 4.20
Mesa version: 18.1.3
Linux kernel version: 4.17.3
Direct rendering: Requires strict binding: no
GLSL shaders:  yes
Texture NPOT support:  yes
Virtual Machine:  no
OpenGL 2 Shaders are used
Painting blocks for vertical retrace:  no

Loaded Effects:
---
zoom
kwin4_effect_frozenapp
kwin4_effect_windowaperture
kwin4_effect_login
kwin4_effect_translucency
kwin4_effect_dialogparent
kwin4_effect_maximize
kwin4_effect_logout
kwin4_effect_morphingpopups
kwin4_effect_fade
slidingpopups
slide
screenshot
minimizeanimation
desktopgrid
colorpicker
presentwindows
highlightwindow
blur
contrast
startupfeedback
screenedge
kscreen

Currently Active Effects:
-
kwin4_effect_fade
blur
contrast

Effect Settings:

zoom:
zoomFactor: 1.2
mousePointer: 0
mouseTracking: 0
enableFocusTracking: false
followFocus: true
focusDelay: 350
moveFactor

[kwin] [Bug 396055] Multiscreen Wayland: Blur effect broken

2018-07-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=396055

Vlad Zagorodniy  changed:

   What|Removed |Added

  Flags||Wayland+, X11-

--- Comment #12 from Vlad Zagorodniy  ---
I think this bug is caused by

const int yTranslate = effects->virtualScreenSize().height() - screen.height()
- screen.y();

it essentially "pulls" screen content down. Still, I'm not sure why this bug is
not reproducible when launching windowed kwin_wayland.

Interesting.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 396055] Multiscreen Wayland: Blur effect broken

2018-07-01 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=396055

--- Comment #13 from Vlad Zagorodniy  ---
Created attachment 113692
  --> https://bugs.kde.org/attachment.cgi?id=113692=edit
Demo to my previous comment

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390479] New: Wrong stacking order when a window has been moved to another virtual desktop

2018-02-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390479

Bug ID: 390479
   Summary: Wrong stacking order when a window has been moved to
another virtual desktop
   Product: kwin
   Version: 5.12.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: core
  Assignee: kwin-bugs-n...@kde.org
  Reporter: vladz...@gmail.com
  Target Milestone: ---

Sometimes, when a window has been moved to another virtual desktop, it is below
other windows.

Steps to reproduce:
* have a shortcut to send a window to another virtual desktop
* switch to the second virtual desktop, open konsole
* switch back to the first virtual desktop, open konsole
* move konsole to the second virtual desktop by using a shortcut

also, you may have to repeat it several times to reproduce this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390479] Wrong stacking order when a window has been moved to another virtual desktop

2018-02-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390479

--- Comment #2 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110672
  --> https://bugs.kde.org/attachment.cgi?id=110672=edit
expected behaviour

... and sometimes stacking order is fine

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390479] Wrong stacking order when a window has been moved to another virtual desktop

2018-02-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390479

--- Comment #4 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Vlad Zagorodniy from comment #3)
> If you can reproduce bug as stated in the first comment, try to maximize
> konsole on the second virtual desktop.

can't

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390479] Wrong stacking order when a window has been moved to another virtual desktop

2018-02-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390479

--- Comment #3 from Vlad Zagorodniy <vladz...@gmail.com> ---
If you can reproduce bug as stated in the first comment, try to maximize
konsole on the second virtual desktop.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390479] Wrong stacking order when a window has been moved to another virtual desktop

2018-02-14 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390479

--- Comment #1 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110670
  --> https://bugs.kde.org/attachment.cgi?id=110670=edit
bug demonstration

Google Chrome should be above Konsole

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390479] Wrong stacking order when a window has been moved to another virtual desktop

2018-02-15 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390479

--- Comment #7 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Nate Graham from comment #6)
> Does that match the user expectation, ...?

Definitely not!

(In reply to Martin Flöser from comment #5)
> The stacking order in KWin is global and not per virtual desktop.

I've "always" been wondering why KWin has a global stacking order. Is there a
reason why it should be global? (I'm just curious)

> Sending a window to another desktop does not affect the stacking order.

Is it on purpose?

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] New: Breeze task switcher has a transparent rectangle at the bottom

2018-02-17 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390632

Bug ID: 390632
   Summary: Breeze task switcher has a transparent rectangle at
the bottom
   Product: plasmashell
   Version: 5.12.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: k...@davidedmundson.co.uk
  Reporter: vladz...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Created attachment 110758
  --> https://bugs.kde.org/attachment.cgi?id=110758=edit
Look at the bottom

Breeze task switcher has a transparent rectangle at the bottom(see the attached
screenshot). Also, it seems like tiny portion of the right border of the task
switcher is not blurred.


Look and Feel: Breeze
Desktop theme: Breeze Dark

(even though the task switcher is called Breeze, this bug is related to plasma
shell, right?)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390829] Window shadows do not take into account decorations

2018-02-20 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390829

Vlad Zagorodniy <vladz...@gmail.com> changed:

   What|Removed |Added

 CC||vladz...@gmail.com

--- Comment #1 from Vlad Zagorodniy <vladz...@gmail.com> ---
Shadows are provided by breeze. Shadows have some offset on the top
https://github.com/KDE/breeze/blob/master/kdecoration/breezedecoration.cpp#L711

So, that's intentional.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390827] New: Add a window button to enter fullscreen mode

2018-02-20 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390827

Bug ID: 390827
   Summary: Add a window button to enter fullscreen mode
   Product: kwin
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: decorations
  Assignee: kwin-bugs-n...@kde.org
  Reporter: vladz...@gmail.com
  Target Milestone: ---

Created attachment 110864
  --> https://bugs.kde.org/attachment.cgi?id=110864=edit
[Mockup] buttons: close, minimize, maximize, full screen

It would be great to have a window button which triggers a window to enter full
screen mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390829] Window shadows do not take into account decorations

2018-02-20 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390829

--- Comment #2 from Vlad Zagorodniy <vladz...@gmail.com> ---
* and they have some offset on the top:

Sorry, I'm writing from mobile. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #9 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110803
  --> https://bugs.kde.org/attachment.cgi?id=110803=edit
There is still present aliasing

This is not a silver bullet. There is still little aliasing.
+ I think it would have "slight" impact on performance.
+ Is it possible to force MSAA only for a specific window?

Another way would be to render a window into offscreen texture, extend it a
little bit(do nothing if it has shadow), set linear filter and render it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #5 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Martin Flöser from comment #4)
> Back when I started working on KWin and introduced the first 3d effects I
> also observed this problem and tried to fix it. It failed in a horrible way:
> the fonts got affected by it. The jigsaw is less an issue than what
> antialising does to fonts.

Yes, that's why I'm proposing to enable multisampling only for windows which
really need this. For example, do we really need pixel perfect text in flip
switch? (maybe that question is dumb because I haven't seen how much text is
blurred with multisampling)

>  On the other hand that is ten years ago and gpus changed. We have shaders
> instead of fixed functionality. So maybe today it is possible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #8 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110801
  --> https://bugs.kde.org/attachment.cgi?id=110801=edit
Comparison of different cases with/without MSAA

Top row: without MSAA
Bottom row: with MSAA
Left column: without shadows
Right column: with shadows

The number of samples: 4

Surprisingly, text on the MSAA sample looks pretty good. (maybe I did something
wrong)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390632] Breeze task switcher has a transparent rectangle at the bottom

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390632

--- Comment #2 from Vlad Zagorodniy <vladz...@gmail.com> ---
... So, who sets blur region?

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #7 from Vlad Zagorodniy <vladz...@gmail.com> ---
I think this issue should be revised. Windows Vista and Windows 7 had smooth(as
far as I remember) edges in the Flip 3D effect a long time ago.

--

Offtopic: Martin, did you give any talks or have articles about KWin
architecture? I wish I could help somehow but my current level of knowledge of
KWin is slightly low.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] New: Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

Bug ID: 390698
   Summary: Edges of transformed windows are jaggy
   Product: kwin
   Version: 5.12.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: scene-opengl
  Assignee: kwin-bugs-n...@kde.org
  Reporter: vladz...@gmail.com
  Target Milestone: ---

Most effects, which transform windows, suffer from jaggy window edges(see
attached pictures below).

Step to reproduce:
* enable opengl compositor
* activate effects like Flip switch, Cover switch, Fall apart, Magic lamp
* take closer look at window edges

Expected:
smooth window edges

Possible fixes:
(a) Introduce new flag in KWin::Effect: PAINT_WINDOW_MULTISAMPLE
SceneOpenGL2Window enables multisampling when it sees the flag above

(b) SceneOpenGL2Windows enables multisampling by checking whether window quad
list has been modified(by calling smoothNeeded?)

_Please note that I don't know exactly how KWin renders windows._

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #3 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110792
  --> https://bugs.kde.org/attachment.cgi?id=110792=edit
the same with cover switch(also it has problems with window decorations)

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #1 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110790
  --> https://bugs.kde.org/attachment.cgi?id=110790=edit
Left edge of google chrome is very jaggy

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-18 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #2 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110791
  --> https://bugs.kde.org/attachment.cgi?id=110791=edit
Top & bottom edges of windows in flip switch are jaggy too

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390827] Add a window button to enter fullscreen mode

2018-02-21 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390827

Vlad Zagorodniy <vladz...@gmail.com> changed:

   What|Removed |Added

 Resolution|--- |LATER
 Status|UNCONFIRMED |RESOLVED

--- Comment #4 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Kai Uwe Broulik from comment #3)
> For example, if I full screen my browser
> through KWin it keeps its address bar as it doesn't expect to end up in full
> screen by external means.

Oh, I see.

Maybe, in the future, the situation with full screen windows would be better. I
close it for now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390827] Add a window button to enter fullscreen mode

2018-02-21 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390827

--- Comment #2 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Martin Flöser from comment #1)
> From UI perspective I'm not sure whether it is a good button as it is one
> way. One cannot exit fullscreen in the same way.

There are several ways to solve this:

(a) show titlebar when mouse cursor is near the top of the screen

Pros:
  - good UX/UI
Cons:
  - requires a lot changes to KWin
  - it may not match the "Plasma look"

(b) use shortcuts("Make Window Fullscreen" under "System
Settings/Shortcuts/Global Shortcuts/KWin")

Pros:
  - small amount of changes
Cons:
  - bad UX/UI


Also, there is no way to determine whether a window is fullscreenable, right?
(except by using
some heuristics)

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390864] Notifications have cropped images

2018-02-21 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390864

--- Comment #1 from Vlad Zagorodniy <vladz...@gmail.com> ---
Created attachment 110881
  --> https://bugs.kde.org/attachment.cgi?id=110881=edit
Full screen shot

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390864] New: Notifications have cropped images

2018-02-21 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390864

Bug ID: 390864
   Summary: Notifications have cropped images
   Product: plasmashell
   Version: 5.12.2
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Notifications
  Assignee: k...@privat.broulik.de
  Reporter: vladz...@gmail.com
CC: plasma-b...@kde.org
  Target Milestone: 1.0

Created attachment 110880
  --> https://bugs.kde.org/attachment.cgi?id=110880=edit
A notification with cropped screen shot.

Steps to reproduce:
* take a screen shot with spectacle

Expected:
* thumbnail of the screen shot with preserved aspect ratio

It makes sense to crop an image when its height is way bigger than width, but
not with aspect ratios 4:3 or 16:9.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kwin] [Bug 390698] Edges of transformed windows are jaggy

2018-02-20 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390698

--- Comment #11 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Martin Flöser from comment #10)
> The general design of the compositor is described in scene.cpp,
> but I fear it's too high level to be of much help.

Thank you for pointing out. After digging the source code,
I have basic understanding how KWin works:

<-- the part with ApplicationX11/ApplicationWayland is omitted -->

- Application creates an instance of Workspace

- Workspace creates a bunch of objects, setups different connections,
  starts listening for new clients, etc.
  One of those objects it creates is Compositor

- Because Compositor is constructed in the constructor of Workspace
  class, it delays its "full initialization"(Workspace::self() is
  undefined). Compositor initializaton code does several things:
* picks scene plugin to use
* chooses refresh rate
* creates EffectsHandlerImpl(not really, it is provided by a platform)
* schedules performCompositing to be called every fpsInterval(not really,
  it can be adjusted)

<-- PERFORM_PAINTING -->

performCompositing does several things:
* first, it makes a copy of the stacking order
* moves elevated windows to the top of the copied stacking order 
* calls Scene::paint()
* makes bookkeeping stuff
* schedules itself

- Scene::paint() is implemented by a scene plugin(scene plugins live inside of
  plugins/scenes/ directory) and it is supposed to call paintScreen.

paintScreen in turn:
* gets the time diff between the last frame and the current frame
* sets painting region
* calls EffectsHandler::paintScreen
<-- at this point screen is painted -->
* calls EffectsHandler::postPaintWindow for each window

Effects in KWin are implemented as a chain. So, by calling
EffectHandler::paintScreen
we "activate" the first effect, that one would activate the second, and so on.
In the
end, finalPaintScreen is called which would call either paintGenericScreen or 
paintSimpleScreen(it is optimized). paintGenericScreen and paintSimpleScreen
share
some logic:
 for each window w in the stacking order
 - call prePaintWindow

 call EffectsHandler::paintWindow if w should be painted

 the effect chain is traversed and at some point Scene::finalPaintWindow()
is called

 Scene::finalPaintWindow calls EffectsHander::drawWindow

 it traverses the effect chain, again; in the end, Scene::finalDrawWindow
is called

 Scene::finalDrawWindow calls Scene::Window::performPaint

- Scene::Window::performPaint is implemented by a scene plugin and does actual
painting.

<-- compositeTimer ticked, go to PERFORM_PAINTING -->

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 390864] Notifications have cropped images

2018-02-22 Thread Vlad Zagorodniy
https://bugs.kde.org/show_bug.cgi?id=390864

--- Comment #5 from Vlad Zagorodniy <vladz...@gmail.com> ---
(In reply to Kai Uwe Broulik from comment #2)
> This was done on purpose, I didn't want padding around it

Images have fixed height, right? Why don't make the height dynamic and if it
exceeds some threshold(like width, for example, i.e. aspect ratio < 1) then
crop.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   8   9   10   >