[konsole] [Bug 386643] Profile changing escape sequence resets font size changed with a keyboard shortcut

2017-11-14 Thread Bartosz Marcinkowski
https://bugs.kde.org/show_bug.cgi?id=386643

--- Comment #6 from Bartosz Marcinkowski <bm371...@gmail.com> ---
Another effect of the same mechanism: if you change font size with a shortcut
and then, in the profile editing window, hover over another colour scheme, the
font size change is lost.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 386643] Profile changing escape sequence resets font size changed with a keyboard shortcut

2017-11-08 Thread Bartosz Marcinkowski
https://bugs.kde.org/show_bug.cgi?id=386643

--- Comment #4 from Bartosz Marcinkowski <bm371...@gmail.com> ---
> Hmmm, so an escape sequence emitted in one profile effects all other
> terminal windows that use the same profile? Doesn't sound good either. Or I
> fundamentally misunderstand something.

If you split view to have two views of the same session and type

echo -en '\e]50;CursorShape=1\x7'

both are changed - so the answer is yes if I understand it right. That's why I
figured it would be acceptable for shortcuts to work the same way.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 386643] Profile changing escape sequence resets font size changed with a keyboard shortcut

2017-11-08 Thread Bartosz Marcinkowski
https://bugs.kde.org/show_bug.cgi?id=386643

--- Comment #1 from Bartosz Marcinkowski <bm371...@gmail.com> ---
I looked into source code, and the problem seems to be that escape sequences
modify font in one place(profile), but the keyboard shortcut modifies it in
another object (TerminalDisplay). If you change the profile object with an
escape sequence, it will pick the unchanged font in profile and overwrite the
changed font in TerminalDisplay. A simple solution would be to make the
shortcuts modify font in profile, as it happens if you modify font size with an
escape sequence. Would that be ok?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 386643] Profile changing escape sequence resets font size changed with a keyboard shortcut

2017-11-08 Thread Bartosz Marcinkowski
https://bugs.kde.org/show_bug.cgi?id=386643

Bartosz Marcinkowski <bm371...@gmail.com> changed:

   What|Removed |Added

 CC||bm371...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 386643] New: Profile changing escape sequence resets font size changed with a keyboard shortcut

2017-11-08 Thread Bartosz Marcinkowski
https://bugs.kde.org/show_bug.cgi?id=386643

Bug ID: 386643
   Summary: Profile changing escape sequence resets font size
changed with a keyboard shortcut
   Product: konsole
   Version: master
  Platform: Manjaro
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: konsole-de...@kde.org
  Reporter: bm371...@gmail.com
  Target Milestone: ---

If you increase font size with a keyboard shortcut and then execute 

echo -en '\e]50;CursorShape=1\x7'

the font goes back to the original size.

-- 
You are receiving this mail because:
You are watching all bug changes.