[krita] [Bug 485707] Crash on startup on Android x86_64 platform

2024-04-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=485707

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/ea024e0 |hics/krita/-/commit/3d9c732
   |96e4a4fcf4886cd77d31cdf6dfa |adb2aed26dd1dba95a8bfcaa56c
   |295502  |81555f

--- Comment #4 from Dmitry Kazakov  ---
Git commit 3d9c732adb2aed26dd1dba95a8bfcaa56c81555f by Dmitry Kazakov, on
behalf of Sharaf Zaman.
Committed on 25/04/2024 at 12:09.
Pushed by dkazakov into branch 'krita/5.2'.

Fix issue with appbundle builder using libs.xml from arm64-v8a

We want to merge the xmls from other architecture builds now that we
have architecture name in Qt's new "multiarch" build.

M  +13   -0build-tools/ci-scripts/build-android-appbundle.py
M  +8-0build-tools/ci-scripts/build-android-package.py
A  +51   -0build-tools/ci-scripts/merge-libs-xml.py

https://invent.kde.org/graphics/krita/-/commit/3d9c732adb2aed26dd1dba95a8bfcaa56c81555f

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 485707] Crash on startup on Android x86_64 platform

2024-04-25 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=485707

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/ea024e0
   ||96e4a4fcf4886cd77d31cdf6dfa
   ||295502

--- Comment #3 from Dmitry Kazakov  ---
Git commit ea024e096e4a4fcf4886cd77d31cdf6dfa295502 by Dmitry Kazakov, on
behalf of Sharaf Zaman.
Committed on 25/04/2024 at 12:08.
Pushed by dkazakov into branch 'master'.

Fix issue with appbundle builder using libs.xml from arm64-v8a

We want to merge the xmls from other architecture builds now that we
have architecture name in Qt's new "multiarch" build.

M  +13   -0build-tools/ci-scripts/build-android-appbundle.py
M  +8-0build-tools/ci-scripts/build-android-package.py
A  +51   -0build-tools/ci-scripts/merge-libs-xml.py

https://invent.kde.org/graphics/krita/-/commit/ea024e096e4a4fcf4886cd77d31cdf6dfa295502

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 485689] Vector layer incorrect transform result when both scaled and sheared

2024-04-24 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=485689

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/72446d9
   ||edcc45d183ffb769353cef89138
   ||73cab5
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 72446d9edcc45d183ffb769353cef8913873cab5 by Dmitry Kazakov, on
behalf of stuffins lastname.
Committed on 24/04/2024 at 12:02.
Pushed by dkazakov into branch 'master'.

Fix Vector layer scale+shear transforms

Removed transform worker's shearOrigin, updated KisImage::shearImpl since it
was the only place using it without finding a compensating translation
afterward, and fixed KisTransformWorker::transform() to correspond to the
actual transform applied.

Also removed the unused out parameter from
KisTransformUtils::createTransformWorker.

M  +6-8libs/image/kis_image.cc
M  +1-1libs/image/kis_paint_device.cc
M  +6-17   libs/image/kis_transform_worker.cc
M  +3-17   libs/image/kis_transform_worker.h
M  +2-2libs/image/processing/kis_mirror_processing_visitor.cpp
M  +0-7libs/image/processing/kis_transform_processing_visitor.cpp
M  +1-2libs/image/processing/kis_transform_processing_visitor.h
M  +2-2libs/image/tests/kis_processings_test.cpp
M  +0-18   libs/image/tests/kis_transform_worker_test.cpp
M  +1-1libs/ui/KisImageThumbnailStrokeStrategy.cpp
M  +2-2libs/ui/kis_file_layer.cpp
M  +2-2plugins/tools/tool_smart_patch/kis_inpaint.cpp
M  +8-10   plugins/tools/tool_transform2/kis_transform_utils.cpp
M  +1-2plugins/tools/tool_transform2/kis_transform_utils.h
M  +1-2   
plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp
M  +1-2   
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/72446d9edcc45d183ffb769353cef8913873cab5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 436419] Incremental brush tips do not increment predictably with geometric drawing tools.

2024-04-24 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=436419

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/c5b532a |hics/krita/-/commit/9171e91
   |6f518146a297465ae9b59bd423f |d8356a69f0dd1e1e503d46c2512
   |6a1a8e  |1a2aba

--- Comment #8 from Dmitry Kazakov  ---
Git commit 9171e91d8356a69f0dd1e1e503d46c25121a2aba by Dmitry Kazakov.
Committed on 24/04/2024 at 08:24.
Pushed by dkazakov into branch 'krita/5.2'.

Fix sequence of imagepipe brushes when used in the line tool

We should update parasites **before** actually selecting the brush,
because the freehand brush may have multiple brush resources, which
could have been set up for different sequence numbers


(cherry picked from commit c5b532a6f518146a297465ae9b59bd423f6a1a8e)

M  +13   -3libs/brush/kis_brushes_pipe.h
M  +8-14   libs/brush/kis_imagepipe_brush.cpp
M  +2-2libs/brush/kis_text_brush.cpp

https://invent.kde.org/graphics/krita/-/commit/9171e91d8356a69f0dd1e1e503d46c25121a2aba

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 436419] Incremental brush tips do not increment predictably with geometric drawing tools.

2024-04-24 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=436419

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/c5b532a
   ||6f518146a297465ae9b59bd423f
   ||6a1a8e

--- Comment #7 from Dmitry Kazakov  ---
Git commit c5b532a6f518146a297465ae9b59bd423f6a1a8e by Dmitry Kazakov.
Committed on 24/04/2024 at 08:24.
Pushed by dkazakov into branch 'master'.

Fix sequence of imagepipe brushes when used in the line tool

We should update parasites **before** actually selecting the brush,
because the freehand brush may have multiple brush resources, which
could have been set up for different sequence numbers

M  +13   -3libs/brush/kis_brushes_pipe.h
M  +8-14   libs/brush/kis_imagepipe_brush.cpp
M  +2-2libs/brush/kis_text_brush.cpp

https://invent.kde.org/graphics/krita/-/commit/c5b532a6f518146a297465ae9b59bd423f6a1a8e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480718] [master] Opening documents always selects the Background layer

2024-04-10 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480718

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/1079c7f |hics/krita/-/commit/4ded66b
   |1f7e32aace1fcf7a5155d2841ca |083057cb4e574f2f21159a19279
   |25ab7e  |d7da49

--- Comment #7 from Dmitry Kazakov  ---
Git commit 4ded66b083057cb4e574f2f21159a19279d7da49 by Dmitry Kazakov.
Committed on 10/04/2024 at 16:12.
Pushed by dkazakov into branch 'krita/5.2'.

Fix activation of the node on opening .kra document

Since KisDummiesFacadeBase::setImage() is now executed asyncronously
the node activation that used to happen in KisView::slotLoadingFinished()
now doesn't work anymore. Hence we should just instruct
KisDummiesFacadeBase::setImage() itself, which node it should activate
at the end of image loading into dummies graph.


(cherry picked from commit 1079c7f1f7e32aace1fcf7a5155d2841ca25ab7e)

M  +2-2libs/ui/KisDocument.cpp
M  +1-1libs/ui/KisDocument.h
M  +0-11   libs/ui/KisView.cpp
M  +10   -1libs/ui/flake/kis_dummies_facade_base.cpp
M  +2-1libs/ui/flake/kis_dummies_facade_base.h
M  +2-2libs/ui/flake/kis_shape_controller.cpp
M  +2-1libs/ui/flake/kis_shape_controller.h
M  +22   -2libs/ui/tests/kis_dummies_facade_base_test.cpp
M  +1-0libs/ui/tests/kis_dummies_facade_base_test.h
M  +3-4plugins/impex/kra/kra_import.cpp
M  +2-4plugins/impex/ora/ora_import.cc

https://invent.kde.org/graphics/krita/-/commit/4ded66b083057cb4e574f2f21159a19279d7da49

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480718] [master] Opening documents always selects the Background layer

2024-04-10 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480718

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/1079c7f
   ||1f7e32aace1fcf7a5155d2841ca
   ||25ab7e
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #6 from Dmitry Kazakov  ---
Git commit 1079c7f1f7e32aace1fcf7a5155d2841ca25ab7e by Dmitry Kazakov.
Committed on 10/04/2024 at 15:34.
Pushed by dkazakov into branch 'master'.

Fix activation of the node on opening .kra document

Since KisDummiesFacadeBase::setImage() is now executed asyncronously
the node activation that used to happen in KisView::slotLoadingFinished()
now doesn't work anymore. Hence we should just instruct
KisDummiesFacadeBase::setImage() itself, which node it should activate
at the end of image loading into dummies graph.

M  +2-2libs/ui/KisDocument.cpp
M  +1-1libs/ui/KisDocument.h
M  +0-11   libs/ui/KisView.cpp
M  +10   -1libs/ui/flake/kis_dummies_facade_base.cpp
M  +2-1libs/ui/flake/kis_dummies_facade_base.h
M  +2-2libs/ui/flake/kis_shape_controller.cpp
M  +2-1libs/ui/flake/kis_shape_controller.h
M  +22   -2libs/ui/tests/kis_dummies_facade_base_test.cpp
M  +1-0libs/ui/tests/kis_dummies_facade_base_test.h
M  +3-4plugins/impex/kra/kra_import.cpp
M  +2-4plugins/impex/ora/ora_import.cc

https://invent.kde.org/graphics/krita/-/commit/1079c7f1f7e32aace1fcf7a5155d2841ca25ab7e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 484699] Missing button tooltips in animation curves docker

2024-04-08 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=484699

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/1ea5ce5
   ||a0b73c3fc5b6cca7e7fb79d0fec
   ||6f622c
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 1ea5ce5a0b73c3fc5b6cca7e7fb79d0fec6f622c by Dmitry Kazakov, on
behalf of Agata Cacko.
Committed on 08/04/2024 at 12:02.
Pushed by dkazakov into branch 'master'.

Add missing tooltips to Anim Curves docker widgets

Before this commit, some of the widgets in the Animation Curves
docker didn't have tooltips. Some of them were difficult to understand
just based on the icon. This commit adds the tooltips to make the
purpose of those widgets more clear.

M  +3-0plugins/dockers/animation/KisAnimCurvesDocker.cpp

https://invent.kde.org/graphics/krita/-/commit/1ea5ce5a0b73c3fc5b6cca7e7fb79d0fec6f622c

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 482378] recorder docker works perfectly except for no auto-start (have box checked)

2024-04-08 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=482378

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/a7f9813
   ||7d9ec042b6599444f55ce6c94fb
   ||b9c232
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Dmitry Kazakov  ---
Git commit a7f98137d9ec042b6599444f55ce6c94fbb9c232 by Dmitry Kazakov, on
behalf of Freya Lupen.
Committed on 08/04/2024 at 11:51.
Pushed by dkazakov into branch 'master'.

Fix automatic timelapse recording

Avoid calling setup() twice, so a check for that doesn't
trigger a stop().

M  +6-5plugins/dockers/recorder/recorderdocker_dock.cpp

https://invent.kde.org/graphics/krita/-/commit/a7f98137d9ec042b6599444f55ce6c94fbb9c232

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 485053] Document.refreshProjection()/.waitForDone() doesn't wait for transform masks to complete

2024-04-08 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=485053

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/d782198
   ||63dc37ec7ddd5af6d051bc9cdbf
   ||0c78fa

--- Comment #3 from Dmitry Kazakov  ---
Git commit d78219863dc37ec7ddd5af6d051bc9cdbf0c78fa by Dmitry Kazakov, on
behalf of Agata Cacko.
Committed on 08/04/2024 at 11:29.
Pushed by dkazakov into branch 'master'.

Fix waitForDone() not waiting for transform mask update

Before this commit, if you had a very slow transform mask in an image
and you used a script to enable it, then running waitForDone() wasn't
enough to ensure that the transform mask stopped updating before
running any other code.
This commit ensures that it does wait until all the updates are done.

Test file can be just a simple document with one transform mask attached to
a paint layer with a scribble. The transform mask should heavily use Liquify
transform, since it is the slowest one at the moment.

Steps to reproduce:
1. Create test file
2. Disable the transform mask (so there will be some updates)
3. Run the script

Example test script (use in Scripter):
(comes from the bug report)

'''
from krita import *

doc = Krita.instance().activeDocument()
doc.activeNode().setVisible(True)

 #doc.refreshProjection()
doc.activeNode().setBlendingMode(doc.activeNode().blendingMode())
doc.waitForDone()

try:
doc.setBatchmode(True)
exportParameters = InfoObject()
exportParameters.setProperty("alpha", True)
exportParameters.setProperty("compression", 6)  # 0-9
exportParameters.setProperty("indexed", False)
if not doc.exportImage('/path/to/file/test485053.png', exportParameters):
dialog = QMessageBox()
dialog.setText("Error exporting")
dialog.exec()
finally:
doc.setBatchmode(False)
'''

M  +1-0libs/libkis/Document.cpp

https://invent.kde.org/graphics/krita/-/commit/d78219863dc37ec7ddd5af6d051bc9cdbf0c78fa

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 484889] Artifacts with rectangular grid

2024-04-04 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=484889

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5d5719a |hics/krita/-/commit/fca9989
   |bba4717019d2ed6491431672b10 |8de4472ca2bd41498f568072fb1
   |8a0d98  |ef9349

--- Comment #2 from Dmitry Kazakov  ---
Git commit fca99898de4472ca2bd41498f568072fb1ef9349 by Dmitry Kazakov, on
behalf of Grum 999.
Committed on 04/04/2024 at 12:34.
Pushed by dkazakov into branch 'krita/5.2'.

Fix grids glitches when subdivision style is solid

Bug has been introduced with commit 764719791a4ce6887aedc9d92777f3c4a03198c6
(to fix bug 461912)

>From Qt's documentation, setDashOffset() method implicitly converts the style
of the pen to Qt::CustomDashLine.
When current line style is solid, it seems the custom dash line is not soid
anymore and this generate glitches.

To avoid the problem, need to to check if style is solid or not before updating
dash offset (update only if not solid).

In addition, the original commit only 'fixed' dash offset problem for
subdivision but not for main grid division; this commit fix both (main &
subdivision) grids lines.


(cherry picked from commit 5d5719abba4717019d2ed6491431672b108a0d98)

M  +13   -3libs/ui/canvas/kis_grid_decoration.cpp

https://invent.kde.org/graphics/krita/-/commit/fca99898de4472ca2bd41498f568072fb1ef9349

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 484889] Artifacts with rectangular grid

2024-04-04 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=484889

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/5d5719a
   ||bba4717019d2ed6491431672b10
   ||8a0d98
 Resolution|--- |FIXED

--- Comment #1 from Dmitry Kazakov  ---
Git commit 5d5719abba4717019d2ed6491431672b108a0d98 by Dmitry Kazakov, on
behalf of Grum 999.
Committed on 04/04/2024 at 12:34.
Pushed by dkazakov into branch 'master'.

Fix grids glitches when subdivision style is solid

Bug has been introduced with commit 764719791a4ce6887aedc9d92777f3c4a03198c6
(to fix bug 461912)

>From Qt's documentation, setDashOffset() method implicitly converts the style
of the pen to Qt::CustomDashLine.
When current line style is solid, it seems the custom dash line is not soid
anymore and this generate glitches.

To avoid the problem, need to to check if style is solid or not before updating
dash offset (update only if not solid).

In addition, the original commit only 'fixed' dash offset problem for
subdivision but not for main grid division; this commit fix both (main &
subdivision) grids lines.

M  +13   -3libs/ui/canvas/kis_grid_decoration.cpp

https://invent.kde.org/graphics/krita/-/commit/5d5719abba4717019d2ed6491431672b108a0d98

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 484066] Crash when pasting/changing? font name in multiple text objects

2024-04-01 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=484066

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/49dc9e0 |hics/krita/-/commit/012ab13
   |50aeb05f7a313f5766c5edd2d56 |a68d5dd10cc12eec5b1695c434c
   |38a6b7  |7e7a44

--- Comment #5 from Dmitry Kazakov  ---
Git commit 012ab13a68d5dd10cc12eec5b1695c434c7e7a44 by Dmitry Kazakov, on
behalf of Igor Danilets.
Committed on 01/04/2024 at 11:11.
Pushed by dkazakov into branch 'krita/5.2'.

Fix crash when pasting font family in TextEditor

Problem:

Pasting a new font famyly and hitting Save or Discard while the
FontFamilyComboBox is still in editing focus crashes.
After pasting font family, the font is also not applied until you
press enter or change focus.

Solution:

Write the validator of the font familyies.
Validator is triggered whenever the text is changed (including pasting),
and if font famyly is correct, the font changes immediately.
So, there are no conditions that provoke a crash.


(cherry picked from commit 49dc9e050aeb05f7a313f5766c5edd2d5638a6b7)

6762569e Fix crash when pasting font family in TextEditor
86af950d Fix crash when pasting font family in TextEditor
4dd9100b Fix crash when pasting font family in TextEditor

M  +1-0libs/widgetutils/CMakeLists.txt
A  +41   -0libs/widgetutils/KisFontFamilyValidator.cpp [License:
GPL(v3.0+)]
A  +27   -0libs/widgetutils/KisFontFamilyValidator.h [License:
GPL(v3.0+)]
M  +15   -0libs/widgetutils/kis_font_family_combo_box.cpp
M  +3-0libs/widgetutils/kis_font_family_combo_box.h

https://invent.kde.org/graphics/krita/-/commit/012ab13a68d5dd10cc12eec5b1695c434c7e7a44

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 484066] Crash when pasting/changing? font name in multiple text objects

2024-03-29 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=484066

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/49dc9e0
   ||50aeb05f7a313f5766c5edd2d56
   ||38a6b7

--- Comment #4 from Dmitry Kazakov  ---
Git commit 49dc9e050aeb05f7a313f5766c5edd2d5638a6b7 by Dmitry Kazakov, on
behalf of Igor Danilets.
Committed on 29/03/2024 at 11:10.
Pushed by dkazakov into branch 'master'.

Fix crash when pasting font family in TextEditor

Problem:

Pasting a new font famyly and hitting Save or Discard while the
FontFamilyComboBox is still in editing focus crashes.
After pasting font family, the font is also not applied until you
press enter or change focus.

Solution:

Write the validator of the font familyies.
Validator is triggered whenever the text is changed (including pasting),
and if font famyly is correct, the font changes immediately.
So, there are no conditions that provoke a crash.

M  +1-0libs/widgetutils/CMakeLists.txt
A  +41   -0libs/widgetutils/KisFontFamilyValidator.cpp [License:
GPL(v3.0+)]
A  +27   -0libs/widgetutils/KisFontFamilyValidator.h [License:
GPL(v3.0+)]
M  +15   -0libs/widgetutils/kis_font_family_combo_box.cpp
M  +3-0libs/widgetutils/kis_font_family_combo_box.h

https://invent.kde.org/graphics/krita/-/commit/49dc9e050aeb05f7a313f5766c5edd2d5638a6b7

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 484622] Forcing GDS mitigation for older CPUs on Linux makes krita crash

2024-03-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=484622

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
I actually wonder if there any use in trying to paint in Krita with AVX
disabled...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475737] Exporting CMYK32 to PNG leaves vertical lines

2024-03-27 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475737

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/03349d2 |hics/krita/-/commit/df9b50f
   |5a2f745dfc8d05feafca7ce4f0f |e00dbf8cd66cc2789b787865864
   |3b58dd  |579f9b

--- Comment #3 from Dmitry Kazakov  ---
Git commit df9b50fe00dbf8cd66cc2789b787865864579f9b by Dmitry Kazakov, on
behalf of Rasyuqa A. H..
Committed on 27/03/2024 at 16:54.
Pushed by dkazakov into branch 'krita/5.2'.

PNG: prevent multiple color conversions


(cherry picked from commit 03349d25a2f745dfc8d05feafca7ce4f0f3b58dd)

M  +23   -27   libs/ui/kis_png_converter.cpp

https://invent.kde.org/graphics/krita/-/commit/df9b50fe00dbf8cd66cc2789b787865864579f9b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475737] Exporting CMYK32 to PNG leaves vertical lines

2024-03-27 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475737

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/03349d2
   ||5a2f745dfc8d05feafca7ce4f0f
   ||3b58dd

--- Comment #2 from Dmitry Kazakov  ---
Git commit 03349d25a2f745dfc8d05feafca7ce4f0f3b58dd by Dmitry Kazakov, on
behalf of Rasyuqa A. H..
Committed on 27/03/2024 at 16:53.
Pushed by dkazakov into branch 'master'.

PNG: prevent multiple color conversions

M  +23   -27   libs/ui/kis_png_converter.cpp

https://invent.kde.org/graphics/krita/-/commit/03349d25a2f745dfc8d05feafca7ce4f0f3b58dd

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 483170] appmenu (global menu) doesn't work with krita on plasma 6

2024-03-14 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=483170

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5dfe491 |hics/krita/-/commit/a6fa805
   |8fa178a5870b2320e4c04bef346 |6b442b1b9efc07f7b89f3e3e0bd
   |d87c08  |325aff

--- Comment #9 from Dmitry Kazakov  ---
Git commit a6fa8056b442b1b9efc07f7b89f3e3e0bd325aff by Dmitry Kazakov, on
behalf of Halla Rempt.
Committed on 14/03/2024 at 11:35.
Pushed by dkazakov into branch 'krita/5.2'.

Re-enable the workaround for plasma global menu


(cherry picked from commit 5dfe4918fa178a5870b2320e4c04bef346d87c08)

M  +12   -3libs/ui/opengl/KisOpenGLModeProber.cpp

https://invent.kde.org/graphics/krita/-/commit/a6fa8056b442b1b9efc07f7b89f3e3e0bd325aff

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 483069] Memory leak in KRITA in CONFYUI

2024-03-10 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=483069

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #6 from Dmitry Kazakov  ---
Hi, all!

I'm afraid Krita developers have no responsibility for the bugs in ConfyUI
plugin. The plugin is developed by a separate team, please report this bug to
them. We do not provide any maintenance for external plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 447108] Timeline docker missing lock icon

2024-03-10 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=447108

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/0c865a8
   ||90d8988181dbd9fd81ff257bc8c
   ||1571aa
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Dmitry Kazakov  ---
Git commit 0c865a890d8988181dbd9fd81ff257bc8c1571aa by Dmitry Kazakov, on
behalf of Reinold Rojas.
Committed on 10/03/2024 at 10:38.
Pushed by dkazakov into branch 'master'.

Add lock functionality to animation dockers

M  +1-0libs/ui/CMakeLists.txt
M  +5-0libs/ui/KisMainWindow.cpp
M  +83   -21   libs/ui/widgets/kis_utility_title_bar.cpp
M  +7-1libs/ui/widgets/kis_utility_title_bar.h
A  +46   -0libs/ui/widgets/kis_utility_title_bar_p.h  *

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/graphics/krita/-/commit/0c865a890d8988181dbd9fd81ff257bc8c1571aa

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 482166] problem with space key

2024-03-01 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=482166

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, trolinotrolowaty!

Could you please try an updated version of Krita 5.2.2? I remember I fixed some
issues in this area since 5.1.5

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 472700] Fill tool in color label reference mode is affected by layers contained in hidden group layers

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=472700

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/9432789 |hics/krita/-/commit/44f0d93
   |15682af369ef76cdc24c83f4f98 |ef6fa3c8e46d23af53346c4854b
   |da4530  |63ac45

--- Comment #3 from Dmitry Kazakov  ---
Git commit 44f0d93ef6fa3c8e46d23af53346c4854b63ac45 by Dmitry Kazakov, on
behalf of Deif Lou.
Committed on 28/02/2024 at 12:34.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix issues generating reference image in KisMergeLabeledLayersCommand
Related: bug 471896

M  +113  -35   libs/image/commands_new/KisMergeLabeledLayersCommand.cpp
M  +4-5libs/image/commands_new/KisMergeLabeledLayersCommand.h

https://invent.kde.org/graphics/krita/-/commit/44f0d93ef6fa3c8e46d23af53346c4854b63ac45

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478225] Crash when undoing "New layer from visible" if it's animated

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478225

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5daea56 |hics/krita/-/commit/426f996
   |3abf05caf0bb96f4522393f3d40 |38a1fa712a6d8ded0eb9a523ef1
   |f09cdb  |60551b

--- Comment #8 from Dmitry Kazakov  ---
Git commit 426f99638a1fa712a6d8ded0eb9a523ef160551b by Dmitry Kazakov.
Committed on 28/02/2024 at 12:55.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix a crash when quickly undo/redo new-from-visible+visibility-change

This patch introduce multiple changes to fix the original bug:

1) KisSynchronizedConnection no longer behaves as if it were
an auto-connection. Instead, **all** signals are now linearized
via the qApp events queue. This fixes the reordering issue when two
actions are undone/redone too quickly and one action is a legacy
action that executes in the GUI thread (e.g. visibility change) and
the other action is a "processing" action that executes in a worker
thread (e.g. new-from-visible). "Auto"-style connection would reorder
the actions on the basis of their execution thread.

2) Unittests still explicitly activate the "auto"-style connection,
because they don't have KisApplication and the corresponding handler
for KisSynchronizedConnectionEvent.

3) Fixes a bug in KisDummiesFacadeBase that caused double addition
of the dummies on loading of the document. It could happen that
two setImage() calls were called in the GUI thread **before** the
addDummyImpl() had a chance to execute.

M  +14   -1libs/global/KisSynchronizedConnection.cpp
M  +11   -0libs/global/KisSynchronizedConnection.h
M  +1-1libs/store/tests/CMakeLists.txt
M  +10   -12   libs/ui/flake/kis_dummies_facade_base.cpp
M  +21   -11   plugins/dockers/animation/timeline_node_list_keeper.cpp
M  +1-1plugins/dockers/animation/timeline_node_list_keeper.h
M  +2-0sdk/tests/kistest.h
M  +2-0sdk/tests/simpletest.h

https://invent.kde.org/graphics/krita/-/commit/426f99638a1fa712a6d8ded0eb9a523ef160551b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/9778839 |hics/krita/-/commit/bd8fdd2
   |e48e0857828429b11a887dcc47d |43a3ba864f2c0d1d99ffc8b4d7a
   |745847  |fc0ff6

--- Comment #9 from Dmitry Kazakov  ---
Git commit bd8fdd243a3ba864f2c0d1d99ffc8b4d7afc0ff6 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:56.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix transform masks being broken after duplication

M  +1-0   
plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/bd8fdd243a3ba864f2c0d1d99ffc8b4d7afc0ff6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475927] Colorize tool: missing canvas updates on Edit key strokes and Show coloring

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475927

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/1dbc7bd |hics/krita/-/commit/eeffa12
   |563cabf7691123ac407a0cc5345 |dddb1d373e6550ba7078565407b
   |52ca4d  |bae41a

--- Comment #3 from Dmitry Kazakov  ---
Git commit eeffa12dddb1d373e6550ba7078565407bbae41a by Dmitry Kazakov.
Committed on 28/02/2024 at 12:54.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Don't skip updates on colorize mask props change

When we change visibility of any colorize mask's plane, we should
issue an update to make sure the new state of the layer is visible

M  +0-2libs/image/commands/kis_node_property_list_command.cpp

https://invent.kde.org/graphics/krita/-/commit/eeffa12dddb1d373e6550ba7078565407bbae41a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481099] Inserted hold frame(s) will never update in the cache and halts playback (git 3ad80aa)

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481099

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/f022351 |hics/krita/-/commit/7411566
   |37f409b1b42545f790b49f7852c |d1c3b43e7976c2c614c2d6c6417
   |46bca0  |55a6ec

--- Comment #4 from Dmitry Kazakov  ---
Git commit 7411566d1c3b43e7976c2c614c2d6c641755a6ec by Dmitry Kazakov.
Committed on 28/02/2024 at 13:01.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix cache being stuck whe adding hold frames

When a hold frame is inserted we should just extend the existing
cached frame duration to cover this period of time.

The patch implements that in a form of a gluer that extends/glues the
frames on the next dirty frame generation.

M  +2-0libs/ui/dialogs/KisAsyncAnimationCacheRenderDialog.cpp
M  +99   -0libs/ui/kis_animation_frame_cache.cpp
M  +2-0libs/ui/kis_animation_frame_cache.h
A  +26   -0libs/ui/kis_animation_frame_cache_p.h [License: GPL(v2.0+)]
M  +236  -0libs/ui/tests/kis_animation_frame_cache_test.cpp
M  +3-0libs/ui/tests/kis_animation_frame_cache_test.h

https://invent.kde.org/graphics/krita/-/commit/7411566d1c3b43e7976c2c614c2d6c641755a6ec

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478986] Fails to find xsimd 12 for the build

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478986

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/b55362d |hics/krita/-/commit/6d71b70
   |4279dcaddb6e3d6484235536236 |0a5cbe49567307895ed33825926
   |c1ea74  |0fa1a4

--- Comment #3 from Dmitry Kazakov  ---
Git commit 6d71b700a5cbe49567307895ed338259260fa1a4 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:53.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Support xsimd 12

M  +6-1CMakeLists.txt

https://invent.kde.org/graphics/krita/-/commit/6d71b700a5cbe49567307895ed338259260fa1a4

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480331] Opening multiple documents crashes krita

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480331

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/65f81bb |hics/krita/-/commit/c31de7f
   |d15ca309d1780de146d3b7eb313 |eae1df5790b4ffc8be51e893d33
   |0c3474  |88390a

--- Comment #4 from Dmitry Kazakov  ---
Git commit c31de7feae1df5790b4ffc8be51e893d3388390a by Dmitry Kazakov.
Committed on 28/02/2024 at 12:56.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix a crash when trying to open multiple files with one D

KisShapeController::rootDummy() can return null right after the
setImage() call, because the addition of the dummies to the graph
happens via synchronized connection, which happens only after
returning to the event loop.

M  +6-0libs/ui/flake/kis_dummies_facade_base.h
M  +4-0libs/ui/flake/kis_node_dummies_graph.h
M  +7-0libs/ui/flake/kis_shape_controller.h
M  +8-2libs/ui/kis_node_model.cpp
M  +5-1plugins/dockers/animation/timeline_node_list_keeper.cpp

https://invent.kde.org/graphics/krita/-/commit/c31de7feae1df5790b4ffc8be51e893d3388390a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 471896] Fill tool on tagged layers doesn't work as expected with filter layers

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=471896

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/9432789 |hics/krita/-/commit/44f0d93
   |15682af369ef76cdc24c83f4f98 |ef6fa3c8e46d23af53346c4854b
   |da4530  |63ac45

--- Comment #3 from Dmitry Kazakov  ---
Git commit 44f0d93ef6fa3c8e46d23af53346c4854b63ac45 by Dmitry Kazakov, on
behalf of Deif Lou.
Committed on 28/02/2024 at 12:34.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix issues generating reference image in KisMergeLabeledLayersCommand
Related: bug 472700

M  +113  -35   libs/image/commands_new/KisMergeLabeledLayersCommand.cpp
M  +4-5libs/image/commands_new/KisMergeLabeledLayersCommand.h

https://invent.kde.org/graphics/krita/-/commit/44f0d93ef6fa3c8e46d23af53346c4854b63ac45

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478225] Crash when undoing "New layer from visible" if it's animated

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478225

--- Comment #7 from Dmitry Kazakov  ---
Git commit c49291363eaf981fb4306b9f1f34da2e7aca7ce0 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:55.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix a crash when undoing "new from visible" of an animated layer

M  +1-0plugins/dockers/animation/timeline_node_list_keeper.cpp

https://invent.kde.org/graphics/krita/-/commit/c49291363eaf981fb4306b9f1f34da2e7aca7ce0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 456731] transform mask animation seems to only interpolate translation with integer values.

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=456731

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/3acce3f |hics/krita/-/commit/10d1ef8
   |9d368c2911994149f7a80c571a5 |f65115c9fd85eac7d5bea644ccd
   |42c901  |1af023

--- Comment #5 from Dmitry Kazakov  ---
Git commit 10d1ef8f65115c9fd85eac7d5bea644ccd1af023 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:42.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix rounding in animated transform masks with translation

M  +11   -1libs/image/kis_perspectivetransform_worker.cpp
M  +4-0libs/image/kis_perspectivetransform_worker.h
M  +4-1libs/image/kis_transform_mask.cpp
M  +3-1libs/image/kis_transform_mask_params_interface.h
M  +11   -0libs/image/kis_transform_worker.cc
M  +4-0libs/image/kis_transform_worker.h
M  +5-0   
plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp
M  +2-0   
plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.h
M  +2-2plugins/tools/tool_transform2/kis_transform_mask_adapter.cpp
M  +1-1plugins/tools/tool_transform2/kis_transform_mask_adapter.h
M  +8-4plugins/tools/tool_transform2/kis_transform_utils.cpp
M  +2-1plugins/tools/tool_transform2/kis_transform_utils.h
M  +5-0sdk/tests/KisDumbAnimatedTransformMaskParamsHolder.cpp
M  +2-0sdk/tests/KisDumbAnimatedTransformMaskParamsHolder.h
M  +2-1sdk/tests/KisDumbTransformMaskParams.cpp
M  +1-1sdk/tests/KisDumbTransformMaskParams.h

https://invent.kde.org/graphics/krita/-/commit/10d1ef8f65115c9fd85eac7d5bea644ccd1af023

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478448] [Animation curves] Wrong position when creating a frame in the beginning

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478448

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/256f7fa |hics/krita/-/commit/c7f4dbc
   |ed4b6dd7a4ae91ef5e87e8954b7 |1e45d91dc522fdb18190a2e5c86
   |bdae09  |304ef3

--- Comment #3 from Dmitry Kazakov  ---
Git commit c7f4dbc1e45d91dc522fdb18190a2e5c86304ef3 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:53.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix creation of keyframes **before** the first frame for scalar channels

M  +19   -4plugins/dockers/animation/KisAnimUtils.cpp

https://invent.kde.org/graphics/krita/-/commit/c7f4dbc1e45d91dc522fdb18190a2e5c86304ef3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 473853] Artifacts when dragging a layer under a filter that produces new pixels outside the paint layer contents rect

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=473853

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/67c02bc |hics/krita/-/commit/a0951dd
   |306dcb16165e2e8475239cc02c5 |434346fe96ef4f6afdfaa9d4d7b
   |e1a3cc  |f41187

--- Comment #3 from Dmitry Kazakov  ---
Git commit a0951dd434346fe96ef4f6afdfaa9d4d7bf41187 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:37.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

[not for 5.2.0] Fix artifacts when moving a layer under a blur adjustment layer

Basically, KisRefreshSubtreeWalker should explicitly reset change rect
**only** when used in standalone mode. Inside KisFullRefreshWalker
mode the change rect is calculated in advance by the parent walker.

M  +1-1libs/image/kis_full_refresh_walker.h
M  +5-2libs/image/kis_refresh_subtree_walker.h

https://invent.kde.org/graphics/krita/-/commit/a0951dd434346fe96ef4f6afdfaa9d4d7bf41187

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478966] Krita transform mask moves initial position of a tween curve (Nightly git master build (git dfe4f31))

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478966

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/b034513 |hics/krita/-/commit/09eef58
   |065a7f7a1001cb7626904d7a4c1 |0b009e2bc5563fe1101d1c67ab1
   |0dfb9a  |a89992

--- Comment #5 from Dmitry Kazakov  ---
Git commit 09eef580b009e2bc5563fe1101d1c67ab1a89992 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:52.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix transform mask offsets after running a transform tool on that

When args.originalCenter() changes (due to transform mask initialization
or a change in the parent layer) we should update all the channel to take
these changes into account. Our transformation in the transform mask is
actually **relative** even though we store absolute offsets in the mask.

M  +24   -2   
plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/09eef580b009e2bc5563fe1101d1c67ab1a89992

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

--- Comment #8 from Dmitry Kazakov  ---
Git commit 1aed1cd5b4233324acc71bc6aaf8ef2c890c5621 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:56.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix transform mask updates triggered by transform tool in-stroke

When transform mask changes the options of the transform mask
it shouldn't trigger static updates when the stroke is running,
because the cache is overridden.

M  +5-3libs/image/kis_transform_mask.cpp

https://invent.kde.org/graphics/krita/-/commit/1aed1cd5b4233324acc71bc6aaf8ef2c890c5621

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 479664] [Animation curves] "Add scalar keyframe" doesn't interpolate

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=479664

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/fdb6ede |hics/krita/-/commit/5a470a5
   |cf81262fade4b3f4c0257a161dd |9d2b1af03ef7e14e3315595f6a0
   |333231  |0ef66a

--- Comment #2 from Dmitry Kazakov  ---
Git commit 5a470a59d2b1af03ef7e14e3315595f6a00ef66a by Dmitry Kazakov.
Committed on 28/02/2024 at 12:54.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix new scalar frames to use interpolated values

M  +1-1plugins/dockers/animation/KisAnimCurvesDocker.cpp
M  +1-1plugins/dockers/animation/KisAnimUtils.cpp

https://invent.kde.org/graphics/krita/-/commit/5a470a59d2b1af03ef7e14e3315595f6a00ef66a

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 444791] Abnormal undo function when using the Transform tool

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=444791

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/b7364f3 |hics/krita/-/commit/f5657e1
   |b14ad4d798178f6f922d2d70309 |c97564dfe811b66e8d8a462454a
   |b6ece0  |620bba

--- Comment #7 from Dmitry Kazakov  ---
Git commit f5657e1c97564dfe811b66e8d8a462454a620bba by Dmitry Kazakov.
Committed on 28/02/2024 at 12:42.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix extra in-stroke undo step when using Transform and Move tools

M  +12   -6libs/ui/tool/KisToolChangesTracker.cpp
M  +4-1libs/ui/tool/KisToolChangesTracker.h
M  +5-3plugins/tools/basictools/kis_tool_move.cc
M  +6-5plugins/tools/tool_transform2/kis_tool_transform.cc

https://invent.kde.org/graphics/krita/-/commit/f5657e1c97564dfe811b66e8d8a462454a620bba

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476317] after install 2261 my animation slice up on 5.3

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476317

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/b24a348 |hics/krita/-/commit/7f31527
   |8cf23baa6ad0e41b8aef76cdf07 |98a08615d41e4e7cd6e0390b6cc
   |87af87  |67c0e1

--- Comment #5 from Dmitry Kazakov  ---
Git commit 7f3152798a08615d41e4e7cd6e0390b6cc67c0e1 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:49.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix an offset when opening files with animated transform masks

Our curves should be centered againt the rotation center.

The current implementation still has a bug that the curve value
is **not** the position of the rotation center, but (position -
rotationCenterOffset), which is a completely nonsensial value.
But since it is baked into .kra format, we should keep it this
way for now.

M  +43   -2   
plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/7f3152798a08615d41e4e7cd6e0390b6cc67c0e1

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

--- Comment #7 from Dmitry Kazakov  ---
Git commit 9ea99d4ab11f4ecd5f5d40c4d298fe4a07e1ce70 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:56.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix artifacts when changing transform mask continuously

The patch implements multiple things:

1) Makes static cache storage in the transform mask thread-safe
   and encapsulated in a single structure.

2) Makes sure that KisRecalculateTransformMaskJob::run() cannot run
   twice for the same parameters. Now it is governed by
   m_mask->staticImageCacheIsValid() check in the beginnig of the
   function.

   The multiple invocations could happen due to concurrent calls to
   KisTransformMask::slotDelayedStaticUpdate() (by the timer) and
   KisTransformMask::threadSafeForceStaticImageUpdate() (by an
   undo command). That could happen in the beginning of the
   transformation stroke. Now the two calls will be compressed by
   the cache validity check.

3) InplaceTransformStrokeStrategy does a better job in maintaining
   updates for the final lod0 update of the lodN stroke.

4) Implements a unittest for testing the inplace stroke strategy. Alas
   its results are not very stable, so it is marked as broken for now.

M  +1-0libs/image/CMakeLists.txt
A  +10   -0libs/image/KisTransformMaskTestingInterface.cpp [License:
GPL(v2.0+)]
A  +25   -0libs/image/KisTransformMaskTestingInterface.h [License:
GPL(v2.0+)]
M  +8-1libs/image/kis_recalculate_transform_mask_job.cpp
M  +2-1libs/image/kis_recalculate_transform_mask_job.h
M  +197  -64   libs/image/kis_transform_mask.cpp
M  +11   -1libs/image/kis_transform_mask.h
M  +9-2   
plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp
M  +5-0plugins/tools/tool_transform2/tests/CMakeLists.txt
A  +627  -0   
plugins/tools/tool_transform2/tests/TransformStrokeStrategyTest.cpp
[License: GPL(v2.0+)]
A  +24   -0   
plugins/tools/tool_transform2/tests/TransformStrokeStrategyTest.h [License:
GPL(v2.0+)]
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod0-cancelled/inplace-lod0-cancelled_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod0-continue-and-cancel/inplace-lod0-continue-and-cancel_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod0/inplace-lod0_autobrush_300px.kpp_indirect_finished_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod2-cancelled/inplace-lod2-cancelled_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod2-continue-and-cancel/inplace-lod2-continue-and-cancel_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod2/inplace-lod2_autobrush_300px.kpp_indirect_finished_internal.png
M  +23   -2sdk/tests/stroke_testing_utils.cpp
M  +4-0sdk/tests/stroke_testing_utils.h

https://invent.kde.org/graphics/krita/-/commit/9ea99d4ab11f4ecd5f5d40c4d298fe4a07e1ce70

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 474416] arrow keys defer to alternate window

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=474416

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/9e37869 |hics/krita/-/commit/a7d1677
   |75eb3ad4ec4ac5a202c41bbb5ed |3fbf7e52e0dbcda6a5659a39205
   |bd98fe  |867ee0

--- Comment #3 from Dmitry Kazakov  ---
Git commit a7d16773fbf7e52e0dbcda6a5659a39205867ee0 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:38.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Make sure that tool-related shortcuts have priority over canvas actions

All tool actions that come via ToolFactory are marked with "tool_action"
property, so we can distinguish them from the global actions, hence we
can give them a bit of priority.

M  +31   -1libs/flake/KoToolProxy.cpp
M  +2-0libs/flake/KoToolProxy.h
M  +1-0libs/flake/KoToolProxy_p.h
M  +1-0libs/ui/input/kis_input_manager.cpp
M  +16   -1libs/ui/input/kis_shortcut_matcher.cpp
M  +5-0libs/ui/input/kis_shortcut_matcher.h
M  +38   -0libs/ui/input/kis_single_action_shortcut.cpp
M  +5-0libs/ui/input/kis_single_action_shortcut.h

https://invent.kde.org/graphics/krita/-/commit/a7d16773fbf7e52e0dbcda6a5659a39205867ee0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478225] Crash when undoing "New layer from visible" if it's animated

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478225

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/61d78cc |hics/krita/-/commit/5daea56
   |9288f9a575e6d3ba4c6fd4d3874 |3abf05caf0bb96f4522393f3d40
   |92dd04  |f09cdb

--- Comment #6 from Dmitry Kazakov  ---
Git commit 5daea563abf05caf0bb96f4522393f3d40f09cdb by Dmitry Kazakov.
Committed on 28/02/2024 at 12:55.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix restoring layer's properties after new-layer-from-visible action

M  +63   -4libs/image/kis_layer_utils.cpp

https://invent.kde.org/graphics/krita/-/commit/5daea563abf05caf0bb96f4522393f3d40f09cdb

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 476033] Wave filter is missing from the filter mask and filter layer list

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=476033

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/5b03819 |hics/krita/-/commit/633f60e
   |7ffa56f3362f78599d3840add45 |042cbdc2afcb94b120cc22c387b
   |10b18e  |44ce19

--- Comment #2 from Dmitry Kazakov  ---
Git commit 633f60e042cbdc2afcb94b120cc22c387b44ce19 by Dmitry Kazakov.
Committed on 28/02/2024 at 12:44.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Make wave filter allowed in filter masks/layers

The filter just needed a proper neededRect() method

M  +6-1plugins/filters/wavefilter/wavefilter.cpp
M  +1-0plugins/filters/wavefilter/wavefilter.h

https://invent.kde.org/graphics/krita/-/commit/633f60e042cbdc2afcb94b120cc22c387b44ce19

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475334] Artifacting when flattening animation layer + transform mask

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475334

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/b5b72a6 |hics/krita/-/commit/b545fc4
   |de27d5d2b4236265ad6b14d255a |f4e9f3b5c95b47d5af6ba92ce61
   |fb09d7  |d3ea0e

--- Comment #3 from Dmitry Kazakov  ---
Git commit b545fc4f4e9f3b5c95b47d5af6ba92ce61d3ea0e by Dmitry Kazakov.
Committed on 28/02/2024 at 12:42.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

Fix artifacts when flattening animated transform mask

In forceUpdateTimedNode() we should rerender the transform mask
in case the cache is not valid due to the time change.

M  +12   -2libs/image/kis_transform_mask.cpp

https://invent.kde.org/graphics/krita/-/commit/b545fc4f4e9f3b5c95b47d5af6ba92ce61d3ea0e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475385] Pasting a transform mask crashes Krita immediately

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475385

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/fd4b9fe |hics/krita/-/commit/d454ef3
   |47e67f91858d846f93d9ace5341 |cc9f2704122239a109d26d9512f
   |9d94eb  |f127bc

--- Comment #3 from Dmitry Kazakov  ---
Git commit d454ef3cc9f2704122239a109d26d9512ff127bc by Dmitry Kazakov.
Committed on 28/02/2024 at 12:40.
Pushed by dkazakov into branch 'kazakov/for-5.2'.

WIP: Refactor transform masks not to discard keyframe channels on every change

The patch fixes the weird design of the transform masks. Before the patch
KisAnimatedTransformMaskParameters were replaced on every transform mask
change, which also replaced the keyframe channels. Which means that
every undo operation would just **delete** the keyframe channels
linked inside the node itself.

In the new design KisAnimatedTransformMaskParameters is never replaced
(it is actually planned to rename it into KisTransformMaskParametersHolder
or something like that). The holder just stores keyframe channels and
the params and just returnes the proper paraps when requested (by fetching
some information from the keyframe channels).

A  +111  -0libs/command/KisChangeValueCommand.h  *
M  +1-0libs/image/CMakeLists.txt
A  +70   -0   
libs/image/commands_new/KisLazyCreateTransformMaskKeyframesCommand.cpp
[License: GPL(v2.0+)]
A  +26   -0   
libs/image/commands_new/KisLazyCreateTransformMaskKeyframesCommand.h
[License: GPL(v2.0+)]
M  +40   -14   libs/image/commands_new/KisSimpleModifyTransformMaskCommand.cpp
M  +10   -2libs/image/commands_new/KisSimpleModifyTransformMaskCommand.h
M  +34   -0libs/image/kis_keyframe_channel.cpp
M  +2-0libs/image/kis_keyframe_channel.h
M  +20   -0libs/image/kis_lod_capable_layer_offset.h
M  +89   -53   libs/image/kis_transform_mask.cpp
M  +2-0libs/image/kis_transform_mask.h
M  +2-17   libs/image/kis_transform_mask_params_factory_registry.cpp
M  +4-7libs/image/kis_transform_mask_params_factory_registry.h
M  +0-9libs/image/kis_transform_mask_params_interface.cpp
M  +23   -9libs/image/kis_transform_mask_params_interface.h
M  +1-1libs/image/processing/kis_transform_processing_visitor.cpp
M  +15   -9libs/libkis/TransformMask.cpp
M  +16   -19   libs/ui/tool/strokes/move_stroke_strategy.cpp
M  +4-1plugins/impex/libkra/kis_kra_load_visitor.cpp
M  +0-1plugins/tools/tool_transform2/CMakeLists.txt
M  +189  -356 
plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp
M  +13   -32  
plugins/tools/tool_transform2/kis_animated_transform_parameters.h
D  +0-70  
plugins/tools/tool_transform2/kis_modify_transform_mask_command.cpp
D  +0-41  
plugins/tools/tool_transform2/kis_modify_transform_mask_command.h
M  +0-13   plugins/tools/tool_transform2/kis_transform_mask_adapter.cpp
M  +0-3plugins/tools/tool_transform2/kis_transform_mask_adapter.h
M  +23   -36  
plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp
M  +25   -34  
plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp
M  +10   -15  
plugins/tools/tool_transform2/tests/test_animated_transform_parameters.cpp

The files marked with a * at the end have a non valid license. Please read:
https://community.kde.org/Policies/Licensing_Policy and use the headers which
are listed at that page.


https://invent.kde.org/graphics/krita/-/commit/d454ef3cc9f2704122239a109d26d9512ff127bc

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 477909] Transform Tool in Wrap Around mode is destructive (changes the layer)

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=477909

Dmitry Kazakov  changed:

   What|Removed |Added

Summary|Moving layers in Wrap   |Transform Tool in Wrap
   |Around mode is destructive  |Around mode is destructive
   |(changes the layer) |(changes the layer)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 477909] Moving layers in Wrap Around mode is destructive (changes the layer)

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=477909

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---

--- Comment #3 from Dmitry Kazakov  ---
Opinion from IRC:

 dmitryK: the move tool thing is a red herring. What the user
wants is for the transform tool to interact properly with wraparound mode,
which it doesn't.
 See
https://mega.nz/file/g8pBABYC#rizdApUUlzBGQA47rE6jeuB00tukzF8M4fnhAprK0fg
 I would expect the smiley I selected to rotate, but instead it
only rotates the bit that exists on the original canvas. The move tool is not
the culprit evidently, since I didn't even use it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 477753] Cursor and stroke delay on transparent (empty) canvas at the end of each stroke

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=477753

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 477909] Moving layers in Wrap Around mode is destructive (changes the layer)

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=477909

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #2 from Dmitry Kazakov  ---
Hi, Katie!

I'm afraid that is exactly how Move Tool is expected to work. Could you explain
a bit what is your usecase/pipeline? Why do you want to layer to be unchanged
after moving it? Do you expect the layer to jump back into the original
position right when you disable Wraparound mode? What is the expected behavior
for you?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480710] Frames error

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480710

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, Miar!

Could you check if this bug happens right after you **paused** playback (in
contrast to stopping the playback)? If it happens only after pausing the
playback, then try stopping instead or try to use this nightly build of Krita
that has this issue fixed:

https://invent.kde.org/graphics/krita/-/jobs/1609911/artifacts/browse

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481913] My wacom pen will not align with the canvas. The pen works fine on every other part of the program but as soon as I hover it above the canvas it completely misaligns. I know the p

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481913

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||dimul...@gmail.com
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, Ronny!

Could you please tell what operating system you are on, Windows or Linux? And
what exact model of the tablet you have?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480973] Layers getting blurred after transform other layer when "accurate instant preview" is enabled

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480973

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481635] Crash (ASSERT failure) while pasting objects

2024-02-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481635

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #6 from Dmitry Kazakov  ---
Thank you for the information! :) I will close the bug, if you happen to see it
again, please reopen it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481099] Inserted hold frame(s) will never update in the cache and halts playback (git 3ad80aa)

2024-02-27 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481099

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/f022351
   ||37f409b1b42545f790b49f7852c
   ||46bca0

--- Comment #3 from Dmitry Kazakov  ---
Git commit f02235137f409b1b42545f790b49f7852c46bca0 by Dmitry Kazakov.
Committed on 27/02/2024 at 14:46.
Pushed by dkazakov into branch 'master'.

Fix cache being stuck whe adding hold frames

When a hold frame is inserted we should just extend the existing
cached frame duration to cover this period of time.

The patch implements that in a form of a gluer that extends/glues the
frames on the next dirty frame generation.

M  +2-0libs/ui/dialogs/KisAsyncAnimationCacheRenderDialog.cpp
M  +99   -0libs/ui/kis_animation_frame_cache.cpp
M  +2-0libs/ui/kis_animation_frame_cache.h
A  +26   -0libs/ui/kis_animation_frame_cache_p.h [License: GPL(v2.0+)]
M  +236  -0libs/ui/tests/kis_animation_frame_cache_test.cpp
M  +3-0libs/ui/tests/kis_animation_frame_cache_test.h

https://invent.kde.org/graphics/krita/-/commit/f02235137f409b1b42545f790b49f7852c46bca0

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481006] Can't resize in Transform Tool with the drawing tablet

2024-02-27 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481006

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 CC||dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478537] Animation exporting in a higher FPS when using audio

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478537

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||dimul...@gmail.com

--- Comment #4 from Dmitry Kazakov  ---
Hi, konstrukto!

Could you please check the latest nightly build if the problem is still there?

https://invent.kde.org/graphics/krita/-/jobs/1608468/artifacts/browse

I think I have fixed the bug as a part of bug 481388. Though I'm not very sure.
The bug I fixed made loading audio to stop taking the framerate into account
while **playback**. It shouldn't affect exporting though. Bug from the
bugreport and KA thread it is not very clear if the problem is in actual export
operation or in playback only.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481146] Utilize Right-Clicks on toolbars, menus and toolboxes more for better UIX

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481146

Dmitry Kazakov  changed:

   What|Removed |Added

   Severity|grave   |wishlist
Summary|most Right-Click options|Utilize Right-Clicks on
   |are Blank/Empty |toolbars, menus and
   ||toolboxes more for better
   ||UIX
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Vinces!

Thank you for the suggestion. We should definitely think about utilizing
right-clicks more :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480759] onion skin doesn't reappear after scrubbing

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480759

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Hi, Ben!

I think I have fixed the issue in bug 481244. Could you please check the
nightly build from the link below (when the job completes) and check if the bug
is really solved?

https://invent.kde.org/graphics/krita/-/jobs/1608468

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481865] Transform Mask: Mesh mode: rendered incorectly

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481865

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||dimul...@gmail.com
 Resolution|--- |FIXED

--- Comment #1 from Dmitry Kazakov  ---
Hi, Alex!

The bug is fixed in Krita-master! Please try the nightly builds :)

https://invent.kde.org/graphics/krita/-/jobs/1607957/artifacts/browse/_packaging/

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480530] Every time I try to play my animation test from my animation timeline it glitches and shows pieces of two frames cut off in the centre of the drawing at the same time... it even s

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480530

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Hi, Loeva!

Thank you for the report! I have just fixed the issue! :)

*** This bug has been marked as a duplicate of bug 481244 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481244] Drawing after pausing animation will edit the wrong frame and cause visual artifacts (git 3ad80aa)

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481244

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||loevadunl...@gmail.com

--- Comment #4 from Dmitry Kazakov  ---
*** Bug 480530 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481244] Drawing after pausing animation will edit the wrong frame and cause visual artifacts (git 3ad80aa)

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481244

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/9b38692 |hics/krita/-/commit/ad35adb
   |174bc46a54bc8ddc88b9cf866de |f834ef85f9742d95238164bd523
   |762a6d  |fb03a3

--- Comment #3 from Dmitry Kazakov  ---
Git commit ad35adbf834ef85f9742d95238164bd523fb03a3 by Dmitry Kazakov.
Committed on 26/02/2024 at 16:58.
Pushed by dkazakov into branch 'krita/5.2'.

Fix artifacts when drawing on a paused animation

M  +1-1libs/ui/KisPlaybackEngineQT.cpp

https://invent.kde.org/graphics/krita/-/commit/ad35adbf834ef85f9742d95238164bd523fb03a3

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481244] Drawing after pausing animation will edit the wrong frame and cause visual artifacts (git 3ad80aa)

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481244

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/9b38692
   ||174bc46a54bc8ddc88b9cf866de
   ||762a6d
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Kazakov  ---
Git commit 9b38692174bc46a54bc8ddc88b9cf866de762a6d by Dmitry Kazakov.
Committed on 26/02/2024 at 16:58.
Pushed by dkazakov into branch 'master'.

Fix artifacts when drawing on a paused animation

M  +1-1libs/ui/KisPlaybackEngineQT.cpp

https://invent.kde.org/graphics/krita/-/commit/9b38692174bc46a54bc8ddc88b9cf866de762a6d

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481244] Drawing after pausing animation will edit the wrong frame and cause visual artifacts (git 3ad80aa)

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481244

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|REPORTED|ASSIGNED
 Ever confirmed|0   |1
   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
I can confirm the issue

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481196] Imported audio is not audible.

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481196

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||dimul...@gmail.com
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, Izzy!

Do you use the Appimage version of Krita from the official site or some
distribution build? Please try to use the AppImage, if not. Only the next
versions of Krita will support audio in distribution packages.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481388] Frame rate settings reset after closing project

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481388

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/8ece4ac |hics/krita/-/commit/5ed90ba
   |c96f8b8226660e4cb16c99b |a010f578c6894d310ca48a52c53
   |4b7e88  |e7c28b

--- Comment #3 from Dmitry Kazakov  ---
Git commit 5ed90baa010f578c6894d310ca48a52c53e7c28b by Dmitry Kazakov.
Committed on 26/02/2024 at 14:42.
Pushed by dkazakov into branch 'krita/5.2'.

Fix framerate issue when adding audio to the image

M  +3-0libs/ui/KisPlaybackEngineMLT.cpp

https://invent.kde.org/graphics/krita/-/commit/5ed90baa010f578c6894d310ca48a52c53e7c28b

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481388] Frame rate settings reset after closing project

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481388

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/8ece4ac
   ||c96f8b8226660e4cb16c99b
   ||4b7e88

--- Comment #2 from Dmitry Kazakov  ---
Git commit 8ece4acc96f8b8226660e4cb16c99b4b7e88 by Dmitry Kazakov.
Committed on 26/02/2024 at 14:40.
Pushed by dkazakov into branch 'master'.

Fix framerate issue when adding audio to the image

M  +3-0libs/ui/KisPlaybackEngineMLT.cpp

https://invent.kde.org/graphics/krita/-/commit/8ece4acc96f8b8226660e4cb16c99b4b7e88

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481388] Frame rate settings reset after closing project

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481388

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481388] Frame rate settings reset after closing project

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481388

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Dmitry Kazakov  ---
I can confirm the issue. The bug also happens when one attaches audio to the
image. It resets internal FPS value back to 24.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 470109] Moving the timeline with the bar makes the zoom function on the timeline engage for some reason

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=470109

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #8 from Dmitry Kazakov  ---
Hi, nunya!

The bottom scrollbar of the timeline docker is supposed to zoom the timeline
when you move it into up or down direction. It happens with both mouse and
tablet. This scrollbar is a combination of zoom and scroll by design. Is it the
problem you are trying to report?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481507] Program freezes whenever importing an image using layer or tool

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481507

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, Nadine!

Could you share the file that you try to import into the image? Or does it
happen with any type of file? I cannot reproduce the issue here locally. I can
import files with both options you listed.

Could you also attach a crashlog to this report? The crashlog should be
avaialble in %LOCALAPPDATA%\kritacrash.log location on your harddrive.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481572] [Wayland+Plasma6] All actions delayed in Krita after opening document

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481572

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
Summary|All actions delayed in  |[Wayland+Plasma6] All
   |Krita after opening |actions delayed in Krita
   |document|after opening document

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481599] The Transform Mask does not work while animating.

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481599

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Dmitry Kazakov  ---
Hi, Hank!

Could you please try the nightly builds of Krita? I have rewritten the animated
transform masks engine since them and it should resolve most of the issues :)

https://invent.kde.org/graphics/krita/-/jobs/1607958/artifacts/browse

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481557] Krita 5.2.2 text tool cuts off last character

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481557

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Dmitry Kazakov  ---
Hi, connorpickett!

Could you please check with the released AppImage version from the official
Krita site?

https://krita.org/en/download/

I cannot reproduce the issue here, it might be that the version from Fedore
uses a different version of Harfbuzz, which causes this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481617] Drag n dropped image from web will not open

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481617

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Needcomp!

Yes, we had some issues with drag-and-drop features during early versions of
Krita 5.2 branch, but they seem to be resolved now. At least I cannot reproduce
the issue with the provided links with Krita 5.2.2 released version :(

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481635] Crash (ASSERT failure) while pasting objects

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481635

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Dmitry Kazakov  ---
Hi, Matt!

Do you use any custom tools to extend functionality of your clipboard, like
clipboard managers? I cannot seem to reproduce this bug, neither in 5.2.2 nor
in nightlies...

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481651] Krita5.2.2 crashes occasionally when using animation and transform masks.

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481651

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, Kazuma!

The undo with Transform Masks is known to be broken in Krita 5.2. Please try
the nightly builds, the transform masks engine is rewritten there:
https://invent.kde.org/graphics/krita/-/jobs/1607958/artifacts/browse

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480705] UI switches between HDR and SDR each time 2-3 seconds passes after mouse cursor stops moving

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480705

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Dmitry Kazakov  ---
Hi, Matej!

Could you clarify, do you have both modes enabled, "HDR" and "Night Light"
modes at the same time?

When enabling both modes here I cannot reproduce the issue. Though the average
screen brightness gets lower when I draw with extremely bright values. That is
now Display HDR 400 technology works. But the dimming happens almost right when
I paint, not after two seconds.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480751] problems with hotkeys

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480751

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #11 from Dmitry Kazakov  ---
waiting for info

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480751] problems with hotkeys

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480751

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #10 from Dmitry Kazakov  ---
Hi, janapanova2008!

Are you sure you are using the latest version of Krita, that is, Krita 5.2.2? I
have a feeling like I have solved a bug like that some time recently :)

Could you also check if the presence of the bug depends on the keyboard layout
you use while drawing? Does the bug appear if you use English layout all the
time, without switching to the Russian one?

We had a bug when shortcuts like Ctrl+Z in the Russian layout caused the Ctrl
key to be stuck. Though I guess I have fixed it some time ago.

As a temporary workaround, if you happen to have this bug again, try pressing
Ctrl key several time or Alt+Tab twice. It should reset internal Krita's
keyboard state.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481705] The pencil paints somewhere else where I'm pressing, but it only happens on the canvas

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481705

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|FIXED   |WAITINGFORINFO

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481705] The pencil paints somewhere else where I'm pressing, but it only happens on the canvas

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481705

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com
 Resolution|--- |FIXED
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Dmitry Kazakov  ---
Hi, santiagomd3110!

Could you please try to reset the tablet api from WinTab to WinInk in Krita
settings (or vice versa)? After switching the API you need to restart Krita.

If it doesn't help, please tell what exact model of the tablet you use.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481724] Cannot zoom/drag/move manually. Must use the bars instead of the hand.

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481724

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, bevilacqua!

Could you tell what OS/Platform you use? Windows or Android?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481789] Application frequently crashing due to access violation

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481789

--- Comment #2 from Dmitry Kazakov  ---
Hi, bigben!

Could you please attach the crashlog file? It is located at
%LOCLAPPDATA%\kritacrash.log

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 481789] Application frequently crashing due to access violation

2024-02-26 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=481789

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REPORTED|NEEDSINFO
 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Hi, bigben!

Could you please attach the crashlog file? It is located at
%LOCLAPPDATA%\kritacrash.log

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 474122] Warning logged when undoing Flatten Layer

2024-02-13 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=474122

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/e0d1ae3
   ||c174fbb05880b65d58ff4a35c68
   ||d642aa
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Dmitry Kazakov  ---
Git commit e0d1ae3c174fbb05880b65d58ff4a35c68d642aa by Dmitry Kazakov.
Committed on 13/02/2024 at 09:15.
Pushed by dkazakov into branch 'master'.

Fix a warning on undoing flattening a group

When updates are issued in the middle of layer addition/removal
it may happen that some updates will never reach the root node,
which is a bug. And the warning told us about that.

The patch moves the updates into a separate command that emits them
in a batch **after** all node modifications are finished.

M  +1-0libs/image/CMakeLists.txt
A  +101  -0libs/image/commands/KisBatchUpdateLayerModificationCommand.cpp  
  [License: GPL(v2.0+)]
A  +52   -0libs/image/commands/KisBatchUpdateLayerModificationCommand.h
[License: GPL(v2.0+)]
M  +1-1libs/image/commands/kis_image_command.h
M  +54   -35   libs/image/kis_layer_utils.cpp
M  +13   -0libs/image/kis_layer_utils.h

https://invent.kde.org/graphics/krita/-/commit/e0d1ae3c174fbb05880b65d58ff4a35c68d642aa

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480331] Opening multiple documents crashes krita

2024-02-06 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480331

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/65f81bb
   ||d15ca309d1780de146d3b7eb313
   ||0c3474

--- Comment #3 from Dmitry Kazakov  ---
Git commit 65f81bbd15ca309d1780de146d3b7eb3130c3474 by Dmitry Kazakov.
Committed on 06/02/2024 at 09:21.
Pushed by dkazakov into branch 'master'.

Fix a crash when trying to open multiple files with one D

KisShapeController::rootDummy() can return null right after the
setImage() call, because the addition of the dummies to the graph
happens via synchronized connection, which happens only after
returning to the event loop.

M  +6-0libs/ui/flake/kis_dummies_facade_base.h
M  +4-0libs/ui/flake/kis_node_dummies_graph.h
M  +7-0libs/ui/flake/kis_shape_controller.h
M  +8-2libs/ui/kis_node_model.cpp
M  +5-1plugins/dockers/animation/timeline_node_list_keeper.cpp

https://invent.kde.org/graphics/krita/-/commit/65f81bbd15ca309d1780de146d3b7eb3130c3474

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-02-02 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/9778839
   ||e48e0857828429b11a887dcc47d
   ||745847
 Resolution|--- |FIXED

--- Comment #6 from Dmitry Kazakov  ---
Git commit 9778839e48e0857828429b11a887dcc47d745847 by Dmitry Kazakov.
Committed on 02/02/2024 at 17:10.
Pushed by dkazakov into branch 'master'.

Fix transform masks being broken after duplication

M  +1-0   
plugins/tools/tool_transform2/KisAnimatedTransformMaskParamsHolder.cpp

https://invent.kde.org/graphics/krita/-/commit/9778839e48e0857828429b11a887dcc47d745847

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-02-02 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

--- Comment #5 from Dmitry Kazakov  ---
Git commit b005afc5b03c160e504116798a99e1caa7ba4cb6 by Dmitry Kazakov.
Committed on 02/02/2024 at 17:10.
Pushed by dkazakov into branch 'master'.

Fix artifacts when changing transform mask continuously

The patch implements multiple things:

1) Makes static cache storage in the transform mask thread-safe
   and encapsulated in a single structure.

2) Makes sure that KisRecalculateTransformMaskJob::run() cannot run
   twice for the same parameters. Now it is governed by
   m_mask->staticImageCacheIsValid() check in the beginnig of the
   function.

   The multiple invocations could happen due to concurrent calls to
   KisTransformMask::slotDelayedStaticUpdate() (by the timer) and
   KisTransformMask::threadSafeForceStaticImageUpdate() (by an
   undo command). That could happen in the beginning of the
   transformation stroke. Now the two calls will be compressed by
   the cache validity check.

3) InplaceTransformStrokeStrategy does a better job in maintaining
   updates for the final lod0 update of the lodN stroke.

4) Implements a unittest for testing the inplace stroke strategy. Alas
   its results are not very stable, so it is marked as broken for now.

M  +1-0libs/image/CMakeLists.txt
A  +10   -0libs/image/KisTransformMaskTestingInterface.cpp [License:
GPL(v2.0+)]
A  +25   -0libs/image/KisTransformMaskTestingInterface.h [License:
GPL(v2.0+)]
M  +8-1libs/image/kis_recalculate_transform_mask_job.cpp
M  +2-1libs/image/kis_recalculate_transform_mask_job.h
M  +197  -64   libs/image/kis_transform_mask.cpp
M  +11   -1libs/image/kis_transform_mask.h
M  +9-2   
plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp
M  +5-0plugins/tools/tool_transform2/tests/CMakeLists.txt
A  +627  -0   
plugins/tools/tool_transform2/tests/TransformStrokeStrategyTest.cpp
[License: GPL(v2.0+)]
A  +24   -0   
plugins/tools/tool_transform2/tests/TransformStrokeStrategyTest.h [License:
GPL(v2.0+)]
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod0-cancelled/inplace-lod0-cancelled_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod0-continue-and-cancel/inplace-lod0-continue-and-cancel_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod0/inplace-lod0_autobrush_300px.kpp_indirect_finished_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod2-cancelled/inplace-lod2-cancelled_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod2-continue-and-cancel/inplace-lod2-continue-and-cancel_autobrush_300px.kpp_indirect_cancelled_internal.png
A  +---   
plugins/tools/tool_transform2/tests/data/inplace-lod2/inplace-lod2_autobrush_300px.kpp_indirect_finished_internal.png
M  +23   -2sdk/tests/stroke_testing_utils.cpp
M  +4-0sdk/tests/stroke_testing_utils.h

https://invent.kde.org/graphics/krita/-/commit/b005afc5b03c160e504116798a99e1caa7ba4cb6

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-02-02 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

--- Comment #4 from Dmitry Kazakov  ---
Git commit c7a825451c110dd7524be053801c0af74a47f957 by Dmitry Kazakov.
Committed on 02/02/2024 at 17:10.
Pushed by dkazakov into branch 'master'.

Fix transform mask updates triggered by transform tool in-stroke

When transform mask changes the options of the transform mask
it shouldn't trigger static updates when the stroke is running,
because the cache is overridden.

M  +5-3libs/image/kis_transform_mask.cpp

https://invent.kde.org/graphics/krita/-/commit/c7a825451c110dd7524be053801c0af74a47f957

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 461869] [Recorder] "Input FPS" option accidentally influences the 'Duration' of end result/result preview

2024-01-31 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=461869

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/a8f6ca2
   ||1b04af5e58fa7cc29d8a1ddf9b0
   ||967f4e
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Dmitry Kazakov  ---
Git commit a8f6ca21b04af5e58fa7cc29d8a1ddf9b0967f4e by Dmitry Kazakov, on
behalf of Reinold Rojas.
Committed on 31/01/2024 at 08:44.
Pushed by dkazakov into branch 'master'.

Fixed recorder export being sped up by input fps

Before this commit if a number higher than 30 was put for
INPUT_FPS it would speed up the preview, preview transition,
and extended result. This commit fixes the ffmpeg profiles
so they properlly take into account the INPUT_FPS.

M  +23   -23   plugins/dockers/recorder/recorder_export_config.cpp

https://invent.kde.org/graphics/krita/-/commit/a8f6ca21b04af5e58fa7cc29d8a1ddf9b0967f4e

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 453738] Please add the missing items in the Layer-New menu.

2024-01-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=453738

Dmitry Kazakov  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||dimul...@gmail.com
 Resolution|--- |FIXED

--- Comment #1 from Dmitry Kazakov  ---
Fixed in this MR: https://invent.kde.org/graphics/krita/-/merge_requests/2039

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 475745] Crash while working on many raster layers with a transform mask each

2024-01-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=475745

--- Comment #2 from Dmitry Kazakov  ---
Hi, Dynline!

Could you please check if you have a **crash** in the recent nightly builds?

https://binary-factory.kde.org/job/Krita_Nightly_Windows_Build/

I cannot reproduce the crash itself, though I can reproduce a weird offset
issue caused by duplicating a layer with its mask. I'm going to fix the offset
part of the issue, but for the crash I need more info.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480520] Krita does not compile with LTO enabled

2024-01-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480520

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/e33c7d7 |hics/krita/-/commit/2c4dd04
   |d533d5289c3a37007f8cf574af5 |2df1518d67c117ced08c5a2f372
   |bc7102  |9c3193

--- Comment #5 from Dmitry Kazakov  ---
Git commit 2c4dd042df1518d67c117ced08c5a2f3729c3193 by Dmitry Kazakov.
Committed on 30/01/2024 at 14:32.
Pushed by dkazakov into branch 'krita/5.2'.

Possibly fix ODR violation in the transform tool strategies


(cherry picked from commit e33c7d7d533d5289c3a37007f8cf574af5bc7102)

M  +2-0plugins/tools/tool_transform2/kis_free_transform_strategy.cpp
M  +2-1   
plugins/tools/tool_transform2/kis_perspective_transform_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/2c4dd042df1518d67c117ced08c5a2f3729c3193

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480520] Krita does not compile with LTO enabled

2024-01-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480520

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/e33c7d7
   ||d533d5289c3a37007f8cf574af5
   ||bc7102
 Status|REPORTED|RESOLVED

--- Comment #4 from Dmitry Kazakov  ---
Git commit e33c7d7d533d5289c3a37007f8cf574af5bc7102 by Dmitry Kazakov.
Committed on 30/01/2024 at 14:31.
Pushed by dkazakov into branch 'master'.

Possibly fix ODR violation in the transform tool strategies

M  +2-0plugins/tools/tool_transform2/kis_free_transform_strategy.cpp
M  +2-1   
plugins/tools/tool_transform2/kis_perspective_transform_strategy.cpp

https://invent.kde.org/graphics/krita/-/commit/e33c7d7d533d5289c3a37007f8cf574af5bc7102

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480520] Krita does not compile with LTO enabled

2024-01-30 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480520

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #3 from Dmitry Kazakov  ---
Thank you for the report! It sounds as a nice isseu :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 480440] [Windows] Krita should use OpenGL as the default renderer for AMD GPUs

2024-01-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=480440

Dmitry Kazakov  changed:

   What|Removed |Added

 CC||dimul...@gmail.com

--- Comment #1 from Dmitry Kazakov  ---
Last time I tried Krita on AMD GPU (February 2022), it performed perfectly well
on ANGLE. So, I guess, it is just a regression we should fix in the Angle
backend.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478987] Fails to build against libjxl 0.9

2024-01-28 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478987

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/ace7edc |hics/krita/-/commit/0213896
   |ca6ad322581ab39620f21ccf3ff |37e50638b096c7227cf5c06e644
   |bd3b5a  |4cef89

--- Comment #3 from Dmitry Kazakov  ---
Git commit 021389637e50638b096c7227cf5c06e6444cef89 by Dmitry Kazakov, on
behalf of Timo Gurr.
Committed on 28/01/2024 at 10:13.
Pushed by dkazakov into branch 'krita/5.2'.

Fix build with libjxl 0.9.0

Fix build with libjxl 0.9.0

Test Plan
-

* Upgrade to libjxl 0.9.0
* Apply patch from MR and build krita (5.2.2)
* Open/Display a sample image e.g. https://jpegxl.info/test-page/red-room.jxl

Formalities Checklist
- 

- [x] I confirmed this builds.
- [x] I confirmed Krita ran and the relevant functions work (Could successfully
open/display a sample image https://jpegxl.info/test-page/red-room.jxl).
- [ ] I tested the relevant unit tests and can confirm they are not broken. (If
not possible, don't hesitate to ask for help!)
- [x] I made sure my commits build individually and have good descriptions as
per [KDE guidelines](https://community.kde.org/Policies/Commit_Policy).
- [x] I made sure my code conforms to the standards set in the HACKING file.
- [x] I can confirm the code is licensed and attributed appropriately, and that
unattributed code is mine, as per [KDE Licensing
Policy](https://community.kde.org/Policies/Licensing_Policy).

_**Reminder: the reviewer is responsible for merging the patch, this is to
ensure at the least two people can build the patch. In case a patch breaks the
build, both the author and the reviewer should be contacted to fix the
build.**_
_**If this is not possible, the commits shall be reverted, and a notification
with the reasoning and any relevant logs shall be sent to the mailing list,
kimages...@kde.org.**_

M  +14   -1plugins/impex/jxl/JPEGXLImport.cpp

https://invent.kde.org/graphics/krita/-/commit/021389637e50638b096c7227cf5c06e6444cef89

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478225] Crash when undoing "New layer from visible" if it's animated

2024-01-19 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478225

Dmitry Kazakov  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap
   |hics/krita/-/commit/8dc9714 |hics/krita/-/commit/61d78cc
   |4531e42055a2d31918c4674e30e |9288f9a575e6d3ba4c6fd4d3874
   |1a7026  |92dd04

--- Comment #5 from Dmitry Kazakov  ---
Git commit 61d78cc9288f9a575e6d3ba4c6fd4d387492dd04 by Dmitry Kazakov.
Committed on 19/01/2024 at 09:19.
Pushed by dkazakov into branch 'master'.

Fix restoring layer's properties after new-layer-from-visible action

M  +63   -4libs/image/kis_layer_utils.cpp

https://invent.kde.org/graphics/krita/-/commit/61d78cc9288f9a575e6d3ba4c6fd4d387492dd04

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478225] Crash when undoing "New layer from visible" if it's animated

2024-01-19 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478225

Dmitry Kazakov  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/krita/-/commit/8dc9714
   ||4531e42055a2d31918c4674e30e
   ||1a7026
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Dmitry Kazakov  ---
Git commit 8dc97144531e42055a2d31918c4674e30e1a7026 by Dmitry Kazakov.
Committed on 19/01/2024 at 09:19.
Pushed by dkazakov into branch 'master'.

Fix a crash when quickly undo/redo new-from-visible+visibility-change

This patch introduce multiple changes to fix the original bug:

1) KisSynchronizedConnection no longer behaves as if it were
an auto-connection. Instead, **all** signals are now linearized
via the qApp events queue. This fixes the reordering issue when two
actions are undone/redone too quickly and one action is a legacy
action that executes in the GUI thread (e.g. visibility change) and
the other action is a "processing" action that executes in a worker
thread (e.g. new-from-visible). "Auto"-style connection would reorder
the actions on the basis of their execution thread.

2) Unittests still explicitly activate the "auto"-style connection,
because they don't have KisApplication and the corresponding handler
for KisSynchronizedConnectionEvent.

3) Fixes a bug in KisDummiesFacadeBase that caused double addition
of the dummies on loading of the document. It could happen that
two setImage() calls were called in the GUI thread **before** the
addDummyImpl() had a chance to execute.

M  +14   -1libs/global/KisSynchronizedConnection.cpp
M  +11   -0libs/global/KisSynchronizedConnection.h
M  +1-1libs/store/tests/CMakeLists.txt
M  +10   -12   libs/ui/flake/kis_dummies_facade_base.cpp
M  +21   -11   plugins/dockers/animation/timeline_node_list_keeper.cpp
M  +1-1plugins/dockers/animation/timeline_node_list_keeper.h
M  +2-0sdk/tests/kistest.h
M  +2-0sdk/tests/simpletest.h

https://invent.kde.org/graphics/krita/-/commit/8dc97144531e42055a2d31918c4674e30e1a7026

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 478225] Crash when undoing "New layer from visible" if it's animated

2024-01-16 Thread Dmitry Kazakov
https://bugs.kde.org/show_bug.cgi?id=478225

Dmitry Kazakov  changed:

   What|Removed |Added

   Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com
 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   8   9   10   >