[krita] [Bug 408204] Layer stack behavior changed since 4.1.7

2019-06-02 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=408204

--- Comment #3 from Dmitry Utkin  ---
Here is the MR: https://invent.kde.org/kde/krita/merge_requests/35

By some reason when I use MR template provided the label "Needs Review" is not
set, while template contains "/label ...". Probably, because I don't have
permissions to set labels.. 

And please tell me, who is responsible to close issues here? I mean shall I
changed issue status to RESOLVED once it gets merged to the master?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408204] Layer stack behavior changed since 4.1.7

2019-06-02 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=408204

--- Comment #1 from Dmitry Utkin  ---
Created attachment 120492
  --> https://bugs.kde.org/attachment.cgi?id=120492=edit
Screen record of the changed behavior (4.3.0 git)

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408204] New: Layer stack behavior changed since 4.1.7

2019-06-02 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=408204

Bug ID: 408204
   Summary: Layer stack behavior changed since 4.1.7
   Product: krita
   Version: git master
  Platform: Appimage
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Layer Stack
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

When upgrading from 4.1.7 to 4.2.0 and 4.3.0 (git) I faced with two issues with
layer stack. It's likely to be in the same piece of the code and because of
that I didn't fill two bugs.


First is related to clicks to thumbnail. In 4.1.7 when you click to group layer
thumbnail it gets folded and unfolded, which is convenient and I always used
this. Now (since 4.2.0) you can only fold/unfold layer by clicking the very
small area to the right of thumbnail. It's hard to click to it with the pen
actually. 


The second bug (4.3.0 git master) is related to layer creating and traversing
layer box by the keyboard. When you do one of the actions, below, the layer
group is expecting to be unfolded (as in 4.1.7), but it doesn't:
1. surround a layer by group (Ctrl+G)
2. create layer mask
3. navigating with Page Up/Page Down.


Guess the first bug was introduced due to some change in logic of layer
selection, maybe adding the feature to select non-transparent layer area by
+Click to thumbnail, and some related effect of this was fixed in
e775a0e82501633b5769e17263fa7ad5d036a29e but the thumbnail-click behavior
wasn't restored.


I believe that the second bug is introduced in
c475619ef738854bf40d6b6844510c13da1357dc, when the last "else" block was added.
the "setCurrentIndex" is never called in this case and because of that
automating unfolding doesn't work. (Also the code analyzer is claiming about
misusing the "hasCorrectModifier" and "action" variables).


I will try to fix it on free time.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408044] No icon for Paste Reference Image From System Clipboard

2019-05-28 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=408044

--- Comment #2 from Dmitry Utkin  ---
MR: https://invent.kde.org/kde/krita/merge_requests/34

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 408044] New: No icon for Paste Reference Image From System Clipboard

2019-05-28 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=408044

Bug ID: 408044
   Summary: No icon for Paste Reference Image From System
Clipboard
   Product: krita
   Version: git master
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Tools/Reference Images
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Created attachment 120362
  --> https://bugs.kde.org/attachment.cgi?id=120362=edit
Screenshot with button with no icon

I was testing a new feature "Paste Reference Image From System Clipboard"
introduced in commit 00d3e6d939f05b28fd85eaa574ba94dd1f818c21 . It works
perfectly, in exception the "paste" button has no icon and therefore looks
absent (but still clickable if you have image in clipboard).

It's reproducible in version krita-4.3.0-prealpha-755c59f-x86_64.appimage


STEPS TO REPRODUCE
1. Copy an image to clipboard
2. Activate "References image tool"
3. Look on the Tool Options dock

OBSERVED RESULT

There is no button to paste, but it you hover the pointer between "Add
Reference Image" and "Load Reference Images Set", a hint "Paste Reference Image
>From System Clipboard" will appear and the empty button is clickable.


EXPECTED RESULT
There should be a button with "paste" icon.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Ubuntu 18.04


ADDITIONAL INFORMATION


I have fixed it in my fork, may I create a merge request?

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability

2019-05-27 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=400357

--- Comment #16 from Dmitry Utkin  ---
Thanks for help, I managed to create the account. Here is the MR:

https://invent.kde.org/kde/krita/merge_requests/33

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability

2019-05-26 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=400357

--- Comment #14 from Dmitry Utkin  ---
Dear @wolthera, I'd like to create a fork and Merge Request, but could you
please help me with login to gitlab?

Looks like it should use the same account as here, but I cannot login with it:
"Invalid credentials". I tried with "KDE identity" and "Standard" options.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 400357] [layer-stack] Renaming layers has not a consistent usability

2019-05-25 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=400357

--- Comment #12 from Dmitry Utkin  ---
Created attachment 120311
  --> https://bugs.kde.org/attachment.cgi?id=120311=edit
Disable updating layer name upon thumbnail update

I had some debug session today and found the reason of the bug. It comes from
the timer which updates the thumbnail which drops to
"LayerBox::updateThumbnail()" -> "NodeView::updateNode()" ->
"NodeView::dataChanged(...)" -> "NodeDelegate::setEditorData(...)". 

There is no reason to update layer name in edit box every time when that signal
is emitted, actually, it's sufficient enough to update it for the first time
only when the layer name is to be put to the editbox, because of the second and
further signals are came from "updateThumbnail".

I didn't find an other simple way to fix it, but this patch works reliable
enough and do not revert layer name any more.

Please consider this patch, it fixes the bug, but I'm not sure if it is the
correct way to go.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405310] Layer renaming after painting

2019-03-11 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=405310

--- Comment #3 from Dmitry Utkin  ---
On a heavy project with 150-200 layers and some filters, it may come again
after 2-3 seconds. 

It's easier to reproduce like this:
1. Create a new project, 4Kx4K texture
2. Add filter layer "Unsharp mask", radius 10
3. Draw single stroke for few seconds (2-3 is pretty enough)
4. Press F2 and try to enter a new layer name without stopping - it gets
re-written few times until your stroke is fully rendered.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 405310] New: Layer renaming after painting

2019-03-10 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=405310

Bug ID: 405310
   Summary: Layer renaming after painting
   Product: krita
   Version: 4.1.7
  Platform: Appimage
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Usability
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

When you try to rename a layer immediately after painting, the name of
currently editing layer gets replaced with the old one (and text selection
lost).

How to reproduce:
1. draw a stroke for a second-two
2. immediately press F2 to rename active layer (or in my general case: insert
to create a new layer, then F2 rename it)
3. start typing new layer name - it gets rewritten by an old layer name after a
second or two


SOFTWARE/OS VERSIONS
Linux Ubuntu 14.04, 16.04, 18.04. Gnome 3, Unity 8 


ADDITIONAL INFORMATION
This bug persists in any known old versions, latest
krita-4.1.7.101-55a1810-x86_64 and in krita-4.2.0-pre-alpha-d2edbba-x86_64 as
well.

It's related to, but not quite the same:
https://bugs.kde.org/show_bug.cgi?id=365739




Krita
  Version: 4.1.7.101 (git 55a1810)

Qt
  Version (compiled): 5.10.0
  Version (loaded): 5.10.0

OS Information
  Build ABI: x86_64-little_endian-lp64
  Build CPU: x86_64
  CPU: x86_64
  Kernel Type: linux
  Kernel Version: 4.15.0-43-generic
  Pretty Productname: Ubuntu 18.04.2 LTS
  Product Type: ubuntu
  Product Version: 18.04

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 390587] New: Freeze when enabling onion skins

2018-02-16 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=390587

Bug ID: 390587
   Summary: Freeze when enabling onion skins
   Product: krita
   Version: 4.0.0-beta.1
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Animation
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Krita freezes when you try to enable onion skins.

Create a frame. Draw something so light bulb button appear near the layer name
(or to the left of time line). Press the light bulb button. Krita freezes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 390472] New: Vector layer is always visible upon export

2018-02-14 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=390472

Bug ID: 390472
   Summary: Vector layer is always visible upon export
   Product: krita
   Version: 4.0.0-beta.1
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: File formats
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Created attachment 110665
  --> https://bugs.kde.org/attachment.cgi?id=110665=edit
test .kra project and result

Upon export, vector layer is exported as visible even if it's invisible.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 389770] Transparency mask after layer transformation

2018-02-03 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=389770

--- Comment #2 from Dmitry Utkin <loen...@gmail.com> ---
Thank you for response,

I understand the technical complexity, but it is really inconvenient how it
works now. You have to switch to the mask and re-fill the emptied region. When
you do complex transformations, you have to repaint the whole mask, because it
become impossible to fix. This involves more time to complete the work.
Often when developing software you have to write exceptions and hacks for some
scenarios to make software work smoothly for the end user (at least this is my
experience of developing software for the last ten years :).

Well.. if it's not possible at all or too much work to to fill the cleaned area
with opaque, it's still usable. Thanks again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 389770] New: Transparency mask after layer transformation

2018-02-01 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=389770

Bug ID: 389770
   Summary: Transparency mask after layer transformation
   Product: krita
   Version: 4.0.0-beta.1
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: Filter Layers
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

This is not a serious problem (if it's a problem at all) but quite annoying.

When you have a layer with transparency mask and then apply a transformation
using transform tool, the region on mask where old raster was lying become
fully transparent (black). This is discouraged because when you try to draw
over the old region, you see nothing - mask makes it fully transparent.
Ire-fill that region with white (when I forgot to lock the mask)

Can you consider to fill the old region with opaque (white)?

Here is a small screencast for the problem:

https://drive.google.com/file/d/1BYuoauxa69OgqKag44aKC57OhQyxBIz9/view?usp=sharing

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 389720] Crash when export to png/jpg and "Sign with Author profile Data" selected

2018-02-01 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=389720

--- Comment #4 from Dmitry Utkin <loen...@gmail.com> ---
Checked with the steps you described. It does not crash if the project has only
two default layers.

If you add a new layer it crashes (when "Sign with Author profile Data" option
is active).

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 389720] Crash when export to png/jpg and "Sign with Author profile Data" selected

2018-02-01 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=389720

--- Comment #3 from Dmitry Utkin <loen...@gmail.com> ---
Created attachment 110295
  --> https://bugs.kde.org/attachment.cgi?id=110295=edit
my authorinfo

loentar.authorinfo is only the one file within that dir, please see it in
attach.




Here is a stack trace obtained with gdb:


[New Thread 0x7fffc5e2b700 (LWP 31811)]
QFileInfo::absolutePath: Constructed with empty filename
[New Thread 0x7fffb3fff700 (LWP 31816)]
[Thread 0x7fffb3fff700 (LWP 31816) exited]
[New Thread 0x7fffb3fff700 (LWP 31817)]

Thread 12 "Thread (pooled)" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffb3fff700 (LWP 31817)]
0x776a052b in KisPNGConverter::buildFile(QIODevice*, QRect const&,
double, double, KisSharedPtr,
QTypedArrayData<KisSharedPtr >::iterator,
QTypedArrayData<KisSharedPtr >::iterator, KisPNGOptions,
KisMetaData::Store*) () from ../lib/libkritaui.so.16
(gdb) bt
#0  0x776a052b in KisPNGConverter::buildFile(QIODevice*, QRect const&,
double, double, KisSharedPtr,
QTypedArrayData<KisSharedPtr >::iterator,
QTypedArrayData<KisSharedPtr >::iterator, KisPNGOptions,
KisMetaData::Store*) () from ../lib/libkritaui.so.16
#1  0x7fffc451858a in ?? () from
/tmp/krita_unpacked/usr/lib/kritaplugins/kritapngexport.so
#2  0x7787ee87 in KisImportExportManager::doExportImpl(QString const&,
QSharedPointer,
KisPinnedSharedPtr) () from ../lib/libkritaui.so.16
#3  0x7787ef88 in KisImportExportManager::doExport(QString const&,
QSharedPointer,
KisPinnedSharedPtr, bool) () from
../lib/libkritaui.so.16
#4  0x77881a2b in ?? () from ../lib/libkritaui.so.16
#5  0x70efdc6d in ?? () from ../lib/libQt5Core.so.5
#6  0x70f00c89 in ?? () from ../lib/libQt5Core.so.5
#7  0x7fffef3f86ba in start_thread (arg=0x7fffb3fff700) at
pthread_create.c:333
#8  0x702ed41d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 389721] New: Partial blur filter causes invalid transparency upon export

2018-01-31 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=389721

Bug ID: 389721
   Summary: Partial blur filter causes invalid transparency upon
export
   Product: krita
   Version: 4.0.0-beta.1
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: File formats
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Created attachment 110269
  --> https://bugs.kde.org/attachment.cgi?id=110269=edit
Archive with KRA and exported(broken) and expected results

Regression in Krita 4. Krita 3 works correctly.

When you apply blur filter and fill part of the filter layer to apply the
filter partially, it appear as expected but causes transparency errors upon
export.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 389720] New: Crash when export to png/jpg and "Sign with Author profile Data" selected

2018-01-31 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=389720

Bug ID: 389720
   Summary: Crash when export to png/jpg and "Sign with Author
profile Data" selected
   Product: krita
   Version: 4.0.0-beta.1
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: crash
  Priority: NOR
 Component: File formats
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Crash when export to png/jpg and "Sign with Author profile Data" selected.

Author is set in preferences

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378241] New: Layer rendered with offset when using liquify tool and zoom

2017-03-29 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=378241

Bug ID: 378241
   Summary: Layer rendered with offset when using liquify tool and
zoom
   Product: krita
   Version: 3.1.2
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: transform
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Created attachment 104796
  --> https://bugs.kde.org/attachment.cgi?id=104796=edit
screencast to reproduce the problem

This occurs when using Liquify tool on large canvas with large enough layer. If
you start transformation tool and zoom in, the currently transforming layer may
display with offset.

Please see screencast for details. I created 2 layers with different colors to
make it clear how current layer jumps.

-- 
You are receiving this mail because:
You are watching all bug changes.

[krita] [Bug 378158] New: Transform mask with Liquify

2017-03-27 Thread Dmitry Utkin
https://bugs.kde.org/show_bug.cgi?id=378158

Bug ID: 378158
   Summary: Transform mask with Liquify
   Product: krita
   Version: 3.1.2
  Platform: Appimage
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: transform
  Assignee: krita-bugs-n...@kde.org
  Reporter: loen...@gmail.com
  Target Milestone: ---

Created attachment 104759
  --> https://bugs.kde.org/attachment.cgi?id=104759=edit
screencast to reproduce the problem

Transform mask with Liquify does not work as expected.

If you apply liquify to the transform mask and switch transform layer
visibility off and on, the layer become transparent when mask's visibility is
on.

Also if you try to save when mask's visibility is on (and layer is invisible),
you may see the "Waiting for image operation to complete..." dialog with
non-working "Cancel operation and Save" button.

At this moment suspicious messages in log may appear, such as:

QObject::killTimer: Timers cannot be stopped from another thread

-- 
You are receiving this mail because:
You are watching all bug changes.