[krita] [Bug 459723] Using transform/move tool on empty columns doesn't apply a new autokey
https://bugs.kde.org/show_bug.cgi?id=459723 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/d4fa022e8 ||3a93fbc4d447f06a02c62d81053 ||4d44 Status|CONFIRMED |RESOLVED --- Comment #5 from Eoin O'Neill --- Git commit d4fa022e83a93fbc4d447f06a02c62d810534d44 by Eoin O'Neill. Committed on 22/11/2022 at 08:06. Pushed by eoinoneill into branch 'master'. Autokey Fix Part II There are also some cases where the actual autokey setting was being ignored. This is now fixed by actually respecting user's autokey setting. This should fix most issues (hopefully all issues) around autokey regressions. Please reopen this bug or a new bug if these issues return once more. M +17 -14 libs/ui/tool/strokes/move_stroke_strategy.cpp M +14 -11 plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp M +23 -20 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +21 -18 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/d4fa022e83a93fbc4d447f06a02c62d810534d44 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459723] Using transform/move tool on empty columns doesn't apply a new autokey
https://bugs.kde.org/show_bug.cgi?id=459723 --- Comment #6 from Eoin O'Neill --- Git commit 305fd3fb947a0c11d9219a56555dafaf5162fd31 by Eoin O'Neill. Committed on 22/11/2022 at 07:47. Pushed by eoinoneill into branch 'master'. Add a plethora of missing autokey implementations for movement. There are two problems right now (in general) with autokey compared to previous versions of Krita. 1) Krita was originally heavily reliant on using KisTransactions for autokeying content in a way that essentially inherited. Since dmitry made some changes to the way transactions are applied during brush strokes that allowed them to be multi threaded, this behavior had to be fixed in a previous commit to prevent a data race resuling in a nasty crash on autokey. This means we lost some of the "automatic" autokey behavior and it needs to be reimplemented in a few key strategies in order to achieve parity with older versions. In the case of this particular bug fix, I missed a few edge cases when dealing with raster keyframes. 2) As a result of 1, there's a lot of areas of the code base where we're definitely repeating ourselves. Long term, we should really try to come up with a logical way to reuse any autokey related stroke strategy behavior so that any stroke that needs to respect users autokey wishes can do so with just a few function calls or configurations. For now, there's no real issue with repeating ourselves just to fix regressions. M +19 -0libs/ui/tool/strokes/move_stroke_strategy.cpp M +3-0plugins/tools/basictools/kis_tool_move.cc M +19 -0 plugins/tools/basictools/strokes/move_selection_stroke_strategy.cpp M +13 -0 plugins/tools/tool_transform2/strokes/inplace_transform_stroke_strategy.cpp M +12 -0 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/305fd3fb947a0c11d9219a56555dafaf5162fd31 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459723] Using transform/move tool on empty columns doesn't apply a new autokey
https://bugs.kde.org/show_bug.cgi?id=459723 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #4 from Eoin O'Neill --- For the record, this is purely a regression not an intentional removal. It has to do with the fact that we removed the autokey from the KisTransaction and now have to manually reinstate autokey to any feature that was relying on the "automatic" behavior of KisTransaction. This is something I'll try to double check with dmitry over, since I wasn't really sure about removing this from transaction since it means we now have to repeat ourselves a few times in various parts of the codebase. I will try to make the changes as clean as possible though. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 461869] [Recorder] "Input FPS" option accidentally influences the 'Duration' of end result/result preview
https://bugs.kde.org/show_bug.cgi?id=461869 Eoin O'Neill changed: What|Removed |Added Ever confirmed|0 |1 CC||eoinoneill1...@gmail.com Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459993] Frames being named incorrectly and program being unable to found specified frames to being encoded
https://bugs.kde.org/show_bug.cgi?id=459993 Eoin O'Neill changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED CC||eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459763] Can't copy a selection in a frame that is not the first
https://bugs.kde.org/show_bug.cgi?id=459763 Eoin O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/ca2ec62c0 ||fdeb67d604cb4d0b02a6a370d8b ||cff7 Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #4 from Eoin O'Neill --- Git commit ca2ec62c0fdeb67d604cb4d0b02a6a370d8bcff7 by Eoin O'Neill. Committed on 10/10/2022 at 18:37. Pushed by eoinoneill into branch 'krita/5.1'. Fix copy+paste working strangely with animated layers. Achieved this by "burning" the current frameid into copied paint devices. This is the desired behavior, as copy/pasted selections should really be a simple WYSIWYG interaction where the visible contents of a selection are copied. Related: bug 457319 (cherry picked from commit 72bad700c6835dcd6619fb2d687b862a6353624c) M +26 -0libs/image/kis_paint_device.cc M +18 -0libs/image/kis_paint_device.h M +19 -52 libs/ui/actions/kis_selection_action_factories.cpp https://invent.kde.org/graphics/krita/commit/ca2ec62c0fdeb67d604cb4d0b02a6a370d8bcff7 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457319] animation timeline- copy/paste active layer bug
https://bugs.kde.org/show_bug.cgi?id=457319 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/72bad700c |hics/krita/commit/ca2ec62c0 |6835dcd6619fb2d687b862a6353 |fdeb67d604cb4d0b02a6a370d8b |624c|cff7 --- Comment #6 from Eoin O'Neill --- Git commit ca2ec62c0fdeb67d604cb4d0b02a6a370d8bcff7 by Eoin O'Neill. Committed on 10/10/2022 at 18:37. Pushed by eoinoneill into branch 'krita/5.1'. Fix copy+paste working strangely with animated layers. Achieved this by "burning" the current frameid into copied paint devices. This is the desired behavior, as copy/pasted selections should really be a simple WYSIWYG interaction where the visible contents of a selection are copied. Related: bug 459763 (cherry picked from commit 72bad700c6835dcd6619fb2d687b862a6353624c) M +26 -0libs/image/kis_paint_device.cc M +18 -0libs/image/kis_paint_device.h M +19 -52 libs/ui/actions/kis_selection_action_factories.cpp https://invent.kde.org/graphics/krita/commit/ca2ec62c0fdeb67d604cb4d0b02a6a370d8bcff7 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459420] Brush preset "u) Pixel Brush" should start with "Align Brush Preview" enabled.
https://bugs.kde.org/show_bug.cgi?id=459420 --- Comment #1 from Eoin O'Neill --- Created attachment 152241 --> https://bugs.kde.org/attachment.cgi?id=152241&action=edit Video of pixel brush acting inconsistent between all 4 corners of a pixel. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459420] New: Brush preset "u) Pixel Brush" should start with "Align Brush Preview" enabled.
https://bugs.kde.org/show_bug.cgi?id=459420 Bug ID: 459420 Summary: Brush preset "u) Pixel Brush" should start with "Align Brush Preview" enabled. Classification: Unclassified Product: krita Version: 5.1.1 Platform: Other OS: Linux Status: REPORTED Severity: wishlist Priority: NOR Component: Usability Assignee: krita-bugs-n...@kde.org Reporter: eoinoneill1...@gmail.com Target Milestone: --- SUMMARY A pet peeve of mine with the default presets is that the pixel art preset doesn't behave the way a user would expect it to on a vanilla Krita installation (tested via flatpak). For new pixel artists coming to Krita, especially when working on a 1px scale, ensuring that a pixel is added where intended is an important QOL feature that we should support in this specific preset. I've attached a video illustrating the problem. TESTING PROCEDURE 1. Nuke your krita config and start 5.1.1 2. Switch to the pixel art brush. 3. Go into settings and enable the circle "Brush Cursor Icon" in the "General" tab. 4. Set pixel size to 1 or less. 5. Try painting on the corners within an intended pixel. OBSERVED RESULT There are two noticeable behaviors: 1: `u) Pixel Brush` will not adhere to a 1 pixel grid the way the user would expect for this specific preset when set to 1 pixel. This is because `Sharpness > Align Brush Preview` is disabled by default -- I think it should be on by default on this specific brush. 2: With the default brush preset, on the NW, NE and SW corners the pixels location will seemingly be either off or will similarly be inconsistent with the SE corner. EXPECTED RESULT 1: Pixel art brush should conform to pixel grid by default, as that's the intended use-case of this specific brush. 2: We should try our best to make small brush size stamping as consistent as possible between all 4 corners of a given pixel grid. Perhaps we should even unit-test this specific scenario. ADDITIONAL INFORMATION This is low priority, so I've gone ahead and marked it such. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459135] Limit Cache Frame Size Set to Ridiculously Small Setting Raises Assert on Cache Generation
https://bugs.kde.org/show_bug.cgi?id=459135 Eoin O'Neill changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 459135] New: Limit Cache Frame Size Set to Ridiculously Small Setting Raises Assert on Cache Generation
https://bugs.kde.org/show_bug.cgi?id=459135 Bug ID: 459135 Summary: Limit Cache Frame Size Set to Ridiculously Small Setting Raises Assert on Cache Generation Product: krita Version: 5.1.0 Platform: Other OS: Linux Status: REPORTED Severity: minor Priority: NOR Component: OpenGL Canvas Assignee: krita-bugs-n...@kde.org Reporter: eoinoneill1...@gmail.com Target Milestone: --- SUMMARY Setting the cache size to a stupidly low setting (e.g. 10px) will cause Krita to crash when generating cache. STEPS TO REPRODUCE 1. Open animated KRA file. 2. Set `limit cache frame size` to a really low value, like 10 px 3. Press the play button. OBSERVED RESULT It will hit an assert with the following line: ``` ASSERT (krita): "extraWeight == 1" in file /home/appimage/workspace/Krita_Release_Appimage_Build/krita/libs/image/kis_paint_device.cc, line 763 ``` EXPECTED RESULT At the very least, it won't crash. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Manjaro KDE Running from stable appimage. ADDITIONAL INFORMATION Some questions to keep in mind regarding how we should be handling this scenario. Q1: Stupidly low settings like 10 pixels are basically unusable, so we should reconsider what the lowest value someone should use here. Notably, it wouldn't be very nice looking to be using a 10px frame cache size, so is it really worth it? Personally, I find 128px to be the lowest possible texture size to be still usable. Q2: Stupidly low settings could be resolved by changing our mindset and instead use a percentage of the user's display as a basis for what size to render. Ultimately, this would make this setting easier to use as you could easily reuse settings between different machines with very different resolutions. With this in mind, probably something like 5% of the users current display resolution should be a reasonable value (10% perhaps, which would be a resolution of 108px on a 1080p display.) -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458997] 'Start numbering at' doesn't work when rendering to image sequence
https://bugs.kde.org/show_bug.cgi?id=458997 --- Comment #4 from Eoin O'Neill --- Hi Marteen, No worries, thanks again for reporting the bug. If you want to test it out earlier, you can try out one of Krita's nightly version(s). -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458997] 'Start numbering at' doesn't work when rendering to image sequence
https://bugs.kde.org/show_bug.cgi?id=458997 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/9913555ac ||b209ca826ea543af467ae6fa3ed ||44d1 --- Comment #1 from Eoin O'Neill --- Git commit 9913555acb209ca826ea543af467ae6fa3ed44d1 by Eoin O'Neill. Committed on 12/09/2022 at 19:45. Pushed by eoinoneill into branch 'master'. Fix the "Start Numbering At" Field not Working as Advertised Internally, the code always refers to this as 'numbering offset' so I presume that the labeling changed in the GUI and that wasn't properly reflected in the code to work as intended. In short, I've modified the behavior to work as advertised. I plan to make some modifications to export at some point, but one of the best things we could do short term is clean up variable naming to better reflect intent as that is how this bug happened in the first place (I think...) M +2-2libs/ui/KisAsyncAnimationFramesSavingRenderer.cpp https://invent.kde.org/graphics/krita/commit/9913555acb209ca826ea543af467ae6fa3ed44d1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458997] 'Start numbering at' doesn't work when rendering to image sequence
https://bugs.kde.org/show_bug.cgi?id=458997 Eoin O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com CC||eoinoneill1...@gmail.com Ever confirmed|0 |1 Status|REPORTED|CONFIRMED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458862] Issues and feature requests regarding animation (timeline / onion skinning)
https://bugs.kde.org/show_bug.cgi?id=458862 Eoin O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 458862] Issues and feature requests regarding animation (timeline / onion skinning)
https://bugs.kde.org/show_bug.cgi?id=458862 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- Hi Maarten, Thanks for taking the time to file bugs/wishlist requests. There's quite a few issues to tackle here, so I'll probably take the time to split this up into multiple bug reports once I can confirm them as that's typically how we do things (since 1 post with many issues within makes it hard to track actual progress). If you could, in the future, post 1 issue or wish per post, that would be great. Before I do that though, I have a few questions or observations... > * Layers aren't synchronized while playing > When playing an animation consisting multiple layers with keyframes these > layers don't synchronise but seem to be individual instances playing > individually at a different speed/refresh rate. This is obviously not what we > want when creating frame by frame animations and makes the preview of > animations unreliable. This doesn't sound right, it shouldn't be possible as the image itself is the only keeper of time (a layer and another layer cannot have different "current times", for example.) Can you provide an example project for this? Are you positive you haven't misaligned two keyframe positions in the timeline docker? > * Please keep start and end frames fixed > When working with animations it's pretty frustrating to constantly see the > start and end frames of the timeline loop change 'automatically'. I guess > this got automatically changed when adding frames before the current start > frame or after the end frame, but we never want these start and end > framenumbers to loop to automatically change. For the record, this is configurable as it's something we know users have differing opinions on. You can turn this off in unchecking `Settings > Configure Krita... > General > Miscellaneous > Adapt Playback Range to Keyframes` I think an argument could be made that this setting should be made easier to find. Some users do actually prefer to have some adaptability to playback range (particularly, new users who just want a frame to render at a certain time, for instance.) > * Timeline is skipping keyframes > While playing often keyframes are skipped while playing. They aren't only > skipped in the display of the timeline view, but also in the viewport the > frame is not shown. This makes previewing animations unreliable. This is also a setting, though more cleanly presented in the GUI as the "drop frames" button. Generally speaking, animators like to keep frame time consistency so stopping when the computer slows down is not ideal when it comes animation. So, for example, frame 20 would either always occurs at 0.8333 seconds or is skipped when it misses that deadline in favor of the next immediate frame (when the computer is next available.) You can disable this by unchecking the `drop frames` button on the animation title bar. -- You are receiving this mail because: You are watching all bug changes.
[konsole] [Bug 171598] RIS sequence doesn't clear history
https://bugs.kde.org/show_bug.cgi?id=171598 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #4 from Eoin O'Neill --- This bothers me a lot too. Mostly due to the inconsistency when compared to other terminal emulators. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457044] Render animation does not prompt before overwriting existing video file
https://bugs.kde.org/show_bug.cgi?id=457044 Eoin O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457044] Render animation does not prompt before overwriting existing video file
https://bugs.kde.org/show_bug.cgi?id=457044 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com Status|REPORTED|CONFIRMED Ever confirmed|0 |1 --- Comment #2 from Eoin O'Neill --- I'm not 100% convinced that users will want to confirm exporting every time a user wants to save a gif either. However, I think that if we ask about overwriting frame sequences, we might be able to do both in a single prompt when it's a valid thing to do. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457043] Render GIF animation fails the first time after startup
https://bugs.kde.org/show_bug.cgi?id=457043 Eoin O'Neill changed: What|Removed |Added Keywords||regression --- Comment #2 from Eoin O'Neill --- I found the source of the bug: Something in commit 710e424a965d945ed2f91091f7aabcab431d3199 is causing the exporter to fail on the first export attempt. For now, I've assigned the bug to Dmitry since it was introduced in that commit. I was going to fix it myself, but since it's tied to Windows performance, I wanted to be doubly sure that this is fixed appropriately for the OS. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457043] Render GIF animation fails the first time after startup
https://bugs.kde.org/show_bug.cgi?id=457043 Eoin O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |dimul...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457043] Render GIF animation fails the first time after startup
https://bugs.kde.org/show_bug.cgi?id=457043 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- This seems to be happening with the first export attempt in general after Krita's initial startup currently. For some reason, we're getting a erroneous "filetype not supported" error from the KisImportExportManager's filterForMimeType method until we run again. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 385589] Audio glitching in animation
https://bugs.kde.org/show_bug.cgi?id=385589 Eoin O'Neill changed: What|Removed |Added CC||tuffcatdr...@gmail.com --- Comment #21 from Eoin O'Neill --- *** Bug 457459 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457459] audio starts on selected frame instead of frame 0
https://bugs.kde.org/show_bug.cgi?id=457459 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED --- Comment #1 from Eoin O'Neill --- Hi AmberKat, This is related to another set of bugs. The Audio System is currently being rewritten to fix these plethora of issues. For now, I'm closing this bug as a duplicate since it is currently on our radar. Thanks for taking the time to file a bug report! *** This bug has been marked as a duplicate of bug 385589 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 457319] animation timeline- copy/paste active layer bug
https://bugs.kde.org/show_bug.cgi?id=457319 Eoin O'Neill changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/72bad700c ||6835dcd6619fb2d687b862a6353 ||624c --- Comment #5 from Eoin O'Neill --- Git commit 72bad700c6835dcd6619fb2d687b862a6353624c by Eoin O'Neill. Committed on 03/08/2022 at 23:01. Pushed by eoinoneill into branch 'master'. Fix copy+paste working strangely with animated layers. Achieved this by "burning" the current frameid into copied paint devices. This is the desired behavior, as copy/pasted selections should really be a simple WYSIWYG interaction where the visible contents of a selection are copied. M +26 -0libs/image/kis_paint_device.cc M +18 -0libs/image/kis_paint_device.h M +19 -52 libs/ui/actions/kis_selection_action_factories.cpp https://invent.kde.org/graphics/krita/commit/72bad700c6835dcd6619fb2d687b862a6353624c -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] FFMPEG: Frame rendering will include files outside of intended frame range when using the same file name.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #8 from Eoin O'Neill --- Git commit 124c22c45387f01f0fb08a4d5db941d91d9b908d by Eoin O'Neill. Committed on 28/07/2022 at 20:54. Pushed by eoinoneill into branch 'krita/5.1'. Improve logic for cleaning up files for unique frames only and only video exports. (cherry picked from commit c290356ae92125b25d73d115a5b6fa5a153ca620) M +10 -11 libs/ui/animation/KisAnimationRender.cpp M +12 -1libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.cpp M +1-0libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.h https://invent.kde.org/graphics/krita/commit/124c22c45387f01f0fb08a4d5db941d91d9b908d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] FFMPEG: Frame rendering will include files outside of intended frame range when using the same file name.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #7 from Eoin O'Neill --- Git commit ebe74faf98c4b0ba5607e99596f64dcbfaeaf6a3 by Eoin O'Neill. Committed on 28/07/2022 at 20:49. Pushed by eoinoneill into branch 'cherry-pick-c290356a'. Improve logic for cleaning up files for unique frames only and only video exports. (cherry picked from commit c290356ae92125b25d73d115a5b6fa5a153ca620) M +10 -11 libs/ui/animation/KisAnimationRender.cpp M +12 -1libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.cpp M +1-0libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.h https://invent.kde.org/graphics/krita/commit/ebe74faf98c4b0ba5607e99596f64dcbfaeaf6a3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] FFMPEG: Frame rendering will include files outside of intended frame range when using the same file name.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #6 from Eoin O'Neill --- Git commit abe0d509ef1cc9a4d0266b8558eacc7a858185b6 by Eoin O'Neill. Committed on 28/07/2022 at 20:49. Pushed by eoinoneill into branch 'krita/5.1'. AnimExport: Clean up files when user cancels exporting of frames or when failure occurs. Should cause less circumstances where files exist that should not, causing ffmpeg to render out incorrectly. (cherry picked from commit e1b1c7070f03280b11a99bd87d74b62be99b8fab) M +1-0libs/ui/animation/KisAnimationRender.cpp M +1-1libs/ui/animation/KisFFMpegWrapper.h M +29 -1libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.cpp M +1-0libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.h https://invent.kde.org/graphics/krita/commit/abe0d509ef1cc9a4d0266b8558eacc7a858185b6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] FFMPEG: Frame rendering will include files outside of intended frame range when using the same file name.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #5 from Eoin O'Neill --- So there are some improvements I've made here that I will try to get into 5.1's branch. Canceling the frame export will now properly clean up any files that were made during the progress of exporting. Additionally, there have been improvements made to the unique frames and frame sequence deletion properties that should make this bug less likely to occur. The key word is less likely though since changing the number offset will still occasionally causes this issue. In order to fix this, we will need to migrate some of our FFMpeg calls to use the "concatenate" codec where we specify files in a text file, which will take some time and probably won't make 5.1. If you do a lot of "Start numbering at" value changes, which is admittedly better suited for image sequence only export circumstances, my recommendation for now would be to change the sequence "Base name" entry for circumstances where you want to export the same file multiple times with different time offsets while also needing a video of said frames. I'll let you know when there are any updates. For now, I've updated the title of this bug to better reflect the current problem. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] FFMPEG: Frame rendering will include files outside of intended frame range when using the same file name.
https://bugs.kde.org/show_bug.cgi?id=443105 Eoin O'Neill changed: What|Removed |Added Summary|ffmpeg continues beyond the |FFMPEG: Frame rendering |range specified in Krita. |will include files outside ||of intended frame range ||when using the same file ||name. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] ffmpeg continues beyond the range specified in Krita.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #4 from Eoin O'Neill --- Git commit e1b1c7070f03280b11a99bd87d74b62be99b8fab by Eoin O'Neill. Committed on 28/07/2022 at 01:14. Pushed by eoinoneill into branch 'master'. AnimExport: Clean up files when user cancels exporting of frames or when failure occurs. Should cause less circumstances where files exist that should not, causing ffmpeg to render out incorrectly. M +1-0libs/ui/animation/KisAnimationRender.cpp M +1-1libs/ui/animation/KisFFMpegWrapper.h M +29 -1libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.cpp M +1-0libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.h https://invent.kde.org/graphics/krita/commit/e1b1c7070f03280b11a99bd87d74b62be99b8fab -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] ffmpeg continues beyond the range specified in Krita.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #3 from Eoin O'Neill --- Git commit c290356ae92125b25d73d115a5b6fa5a153ca620 by Eoin O'Neill. Committed on 28/07/2022 at 02:00. Pushed by eoinoneill into branch 'master'. Improve logic for cleaning up files for unique frames only and only video exports. M +10 -11 libs/ui/animation/KisAnimationRender.cpp M +12 -1libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.cpp M +1-0libs/ui/dialogs/KisAsyncAnimationFramesSaveDialog.h https://invent.kde.org/graphics/krita/commit/c290356ae92125b25d73d115a5b6fa5a153ca620 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 443105] ffmpeg continues beyond the range specified in Krita.
https://bugs.kde.org/show_bug.cgi?id=443105 --- Comment #2 from Eoin O'Neill --- (In reply to Halla Rempt from comment #1) > I can confirm the issue. Even though Krita says it's going to delete > existing frames, that does not happen. Eoin, can you take a look? Yeah I'll take a look at this. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456340] "First Frame" and "Last Frame" keyboard shortcuts do nothing
https://bugs.kde.org/show_bug.cgi?id=456340 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/d91e30031 |hics/krita/commit/8494d4f94 |1aa8478f60fa3cb325fdd77756e |9816dc3f5400ba7e0b742ad935a |b07d|fd6e --- Comment #4 from Eoin O'Neill --- Git commit 8494d4f949816dc3f5400ba7e0b742ad935afd6e by Eoin O'Neill. Committed on 07/07/2022 at 23:52. Pushed by eoinoneill into branch 'cherry-pick-d91e3003'. Fix hotkeys not working properly for "last_frame" and "first_frame" actions. Should now work with custom keybinds accessing such features. (cherry picked from commit d91e300311aa8478f60fa3cb325fdd77756eb07d) M +12 -0libs/ui/canvas/kis_animation_player.cpp M +1-0libs/ui/canvas/kis_animation_player.h M +16 -0plugins/dockers/animation/KisAnimTimelineDocker.cpp https://invent.kde.org/graphics/krita/commit/8494d4f949816dc3f5400ba7e0b742ad935afd6e -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456340] "First Frame" and "Last Frame" keyboard shortcuts do nothing
https://bugs.kde.org/show_bug.cgi?id=456340 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #3 from Eoin O'Neill --- Thanks for reporting the bug jlemay.emploi Yeah, looks like I missed two user bindable actions in the binding code. I've gone ahead and patched it. You can try the latest nightly soon or when 5.1 eventually comes out. Thanks again, Eoin. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 456340] "First Frame" and "Last Frame" keyboard shortcuts do nothing
https://bugs.kde.org/show_bug.cgi?id=456340 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/d91e30031 ||1aa8478f60fa3cb325fdd77756e ||b07d --- Comment #2 from Eoin O'Neill --- Git commit d91e300311aa8478f60fa3cb325fdd77756eb07d by Eoin O'Neill. Committed on 07/07/2022 at 23:49. Pushed by eoinoneill into branch 'master'. Fix hotkeys not working properly for "last_frame" and "first_frame" actions. Should now work with custom keybinds accessing such features. M +12 -0libs/ui/canvas/kis_animation_player.cpp M +1-0libs/ui/canvas/kis_animation_player.h M +16 -0plugins/dockers/animation/KisAnimTimelineDocker.cpp https://invent.kde.org/graphics/krita/commit/d91e300311aa8478f60fa3cb325fdd77756eb07d -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg
https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #10 from Eoin O'Neill --- Yeah no worries. :) I agree with you that the whole thing needs a bit of a work -- but for now I think this will have to do since 5.1 is coming soon. I have an interest in taking another crack at the animation exporter once I get the audio branch in a nicer place, so it will be high(ish) on my todo list. We have a few bugs in the exporter that could be resolved or made streamlined in general. I will set a reminder in my email client to take a look at this specific bug report again in a few months just so I don't lose track of it. :) Cheers! Eoin -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg
https://bugs.kde.org/show_bug.cgi?id=455386 --- Comment #7 from Eoin O'Neill --- Alvin, I think I may have solved this issue, but I would like you to test it on Windows to see if the problem persists for you (I don't have a windows test environment atm) and if they do, please reopen the bug. Diving into the FFMPEGWrapper code, there are issues with how we are treading the subprocess. By having a "blocking" ffmpeg process, we are preventing the UI from updating. This is a bad design and we should be approaching this with a "Futures" based approach (I.E. schedule a task to occur after process has concluded.) At some point I plan to redo parts of how our exporter works, which would be a good time to change this approach. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg
https://bugs.kde.org/show_bug.cgi?id=455386 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Status|REPORTED|RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/abb211e6d ||ecfbcb2f5c95a261b95754a8b5b ||907c --- Comment #6 from Eoin O'Neill --- Git commit abb211e6decfbcb2f5c95a261b95754a8b5b907c by Eoin O'Neill. Committed on 29/06/2022 at 23:31. Pushed by eoinoneill into branch 'master'. Hotfix: Attempt to prevent processEvents call when dealing with FFMPEG sub-process. This is a bandaid -- we need remove the need of "blocking" ffmpeg processes and instead opt for a futures based approach. M +5-2libs/ui/animation/KisFFMpegWrapper.cpp https://invent.kde.org/graphics/krita/commit/abb211e6decfbcb2f5c95a261b95754a8b5b907c -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 454547] Crash when changing filter layer opacity
https://bugs.kde.org/show_bug.cgi?id=454547 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED CC||eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455358] Safe assert when moving animated transform mask
https://bugs.kde.org/show_bug.cgi?id=455358 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/aed62045c |hics/krita/commit/359a67e35 |aae675a38e5e9df0bb10bb05aac |32a859d9662d7ad824b3aae9aeb |9284|0654 --- Comment #3 from Eoin O'Neill --- Git commit 359a67e3532a859d9662d7ad824b3aae9aeb0654 by Eoin O'Neill. Committed on 29/06/2022 at 22:15. Pushed by eoinoneill into branch 'krita/5.1'. Changed logic to prevent undo merge when moving an animated transform mask. Animation keyframe undos currently can't be merged, but it's not necessary currently and does not affect undo stack. Might be worth implementing better merging logic later though as it might smooth out performance long term. (cherry picked from commit aed62045caae675a38e5e9df0bb10bb05aac9284) M +1-3libs/ui/tool/strokes/move_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/359a67e3532a859d9662d7ad824b3aae9aeb0654 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 454547] Crash when changing filter layer opacity
https://bugs.kde.org/show_bug.cgi?id=454547 --- Comment #4 from Eoin O'Neill --- Git commit 0400ca67da5ce9b08e76be9b334f74e601be8bef by Eoin O'Neill, on behalf of Emmet O'Neill. Committed on 29/06/2022 at 22:16. Pushed by eoinoneill into branch 'krita/5.1'. Animation Curves: Fixed crash when setting opacity keyframe on copied layer. (cherry picked from commit bc552ba0f327d3ff2ee39f99373bc70936b0bdb5) M +12 -8libs/image/KisAnimatedOpacityProperty.cpp https://invent.kde.org/graphics/krita/commit/0400ca67da5ce9b08e76be9b334f74e601be8bef -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455358] Safe assert when moving animated transform mask
https://bugs.kde.org/show_bug.cgi?id=455358 Eoin O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/aed62045c ||aae675a38e5e9df0bb10bb05aac ||9284 Resolution|--- |FIXED Status|REPORTED|RESOLVED --- Comment #2 from Eoin O'Neill --- Git commit aed62045caae675a38e5e9df0bb10bb05aac9284 by Eoin O'Neill. Committed on 29/06/2022 at 03:08. Pushed by eoinoneill into branch 'master'. Changed logic to prevent undo merge when moving an animated transform mask. Animation keyframe undos currently can't be merged, but it's not necessary currently and does not affect undo stack. Might be worth implementing better merging logic later though as it might smooth out performance long term. M +1-3libs/ui/tool/strokes/move_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/aed62045caae675a38e5e9df0bb10bb05aac9284 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455349] Resize canvas messes up animated transform mask
https://bugs.kde.org/show_bug.cgi?id=455349 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #4 from Eoin O'Neill --- (In reply to Ahab Greybeard from comment #2) > If possible, I'd like this new behaviour to be an option, maybe a 'hidden' > option in kritarc (to avoid the 'option forest' problem). An option might be possible here, but I think I'd prefer to handle that on the next version since we're currently in string freeze. As much as an option forest is a problem, I'm also not sure about burying too many features within the config files as they would still need to be supported and tested, which makes that process more difficult. I don't understand your use-case all that well, and I'm not sure why canvas resizing should cause that much slowdown (since it's basically just math -- the cache reloading would take most of the time but it shouldn't hang the program.) but if you don't mind submitting a new bug report (preferably as wishlist) with an image illustrating the slowdown, that would help. I think we could always treat it as a checkbox option in the crop tool option docker, but at the very least it should apply to all transformation masks (including non-animated) for the sake of consistency. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455464] Clipping, frames not showing, delayed audio for no reason
https://bugs.kde.org/show_bug.cgi?id=455464 Eoin O'Neill changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- Hi Kiwivskiwi, We're aware that audio + animation in krita is currently glitchy and have multiple reports. We're currently working on a new design, but that won't be coming until 5.2 at the earliest. We will keep you updated when there's a public testable version. However, since this is similar to our other existing, I am reporting this as a duplicate. Thanks for taking the time to use and file bug reports for Krita, Eoin. *** This bug has been marked as a duplicate of bug 385589 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 385589] Audio glitching in animation
https://bugs.kde.org/show_bug.cgi?id=385589 Eoin O'Neill changed: What|Removed |Added CC||nightgaze...@yahoo.com --- Comment #20 from Eoin O'Neill --- *** Bug 455464 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455356] Kinetic Scrolling + Left Click: Difficult to drag frames on the animation timeline
https://bugs.kde.org/show_bug.cgi?id=455356 Eoin O'Neill changed: What|Removed |Added Summary|Difficult to drag frames on |Kinetic Scrolling + Left |the animation timeline with |Click: Difficult to drag |kinetic scrolling |frames on the animation ||timeline -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455356] Difficult to drag frames on the animation timeline with kinetic scrolling
https://bugs.kde.org/show_bug.cgi?id=455356 Eoin O'Neill changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- I'm aware of this, but unsure if there's really a way around this for us. I suppose this would probably be a good question for QT upstream, since my thought would be that holding down x seconds on an element and then dragging would a good option, but I'm not sure we can control that yet. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455386] [win] Render animation use-after-free waiting for ffmpeg
https://bugs.kde.org/show_bug.cgi?id=455386 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #5 from Eoin O'Neill --- Hey Alvin, I'm not even sure why processEvents is necessary in that particular callback. I'll have to check out if removing that call has any regressions and report back my findings. If we really need to "process" events, then I think we simply want to call a non-blocking version... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453682] Animation / Multithreading : Creating animations with AutoKey causes Krita to get stuck in an unusable state.
https://bugs.kde.org/show_bug.cgi?id=453682 Eoin O'Neill changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/0f6f9799c ||6caa63cbe2bdad0e20018b2f302 ||5f39 Resolution|--- |FIXED --- Comment #5 from Eoin O'Neill --- Git commit 0f6f9799c6caa63cbe2bdad0e20018b2f3025f39 by Eoin O'Neill. Committed on 16/06/2022 at 20:28. Pushed by eoinoneill into branch 'master'. Fix undo redo frame content updates. Autokey bug should be fully fixed now. M +44 -6libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/0f6f9799c6caa63cbe2bdad0e20018b2f3025f39 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453682] Animation / Multithreading : Creating animations with AutoKey causes Krita to get stuck in an unusable state.
https://bugs.kde.org/show_bug.cgi?id=453682 --- Comment #4 from Eoin O'Neill --- Git commit 38fec364f48b32bddf7488202e44c8ad28f54d73 by Eoin O'Neill, on behalf of Emmet O'Neill. Committed on 16/06/2022 at 20:28. Pushed by eoinoneill into branch 'master'. Animation: Re-added AutoKey support to filters. After moving AutoKey functionality out of KisTransaction and into the calling strokes, we've now re-added the functionality to filter changes too. On top of that we've added registered AutoKey changes with the undo system. (Though it requires 2 separate undos for now.) M +1-1libs/image/KisAnimAutoKey.h M +2-1libs/image/kis_keyframe_commands.cpp M +4-0libs/image/kis_layer_utils.h M +2-1libs/ui/kis_filter_manager.cc M +54 -17 libs/ui/tool/strokes/kis_filter_stroke_strategy.cpp M +2-1libs/ui/tool/strokes/kis_painter_based_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/38fec364f48b32bddf7488202e44c8ad28f54d73 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453682] Animation / Multithreading : Creating animations with AutoKey causes Krita to get stuck in an unusable state.
https://bugs.kde.org/show_bug.cgi?id=453682 --- Comment #3 from Eoin O'Neill --- Git commit ed4e85405ec9dc687cb49bc351f1696f5ab1647a by Eoin O'Neill, on behalf of Emmet O'Neill. Committed on 16/06/2022 at 20:28. Pushed by eoinoneill into branch 'master'. Identified cause of bug, unable to find a solution currently... M +3-1libs/image/kis_node.cpp https://invent.kde.org/graphics/krita/commit/ed4e85405ec9dc687cb49bc351f1696f5ab1647a -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 455349] Resize canvas messes up animated transform mask
https://bugs.kde.org/show_bug.cgi?id=455349 Eoin O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/4fbf6d6dc ||2ed4dd54bf3edf2755e52d54082 ||516f Status|REPORTED|RESOLVED Resolution|--- |FIXED --- Comment #1 from Eoin O'Neill --- Git commit 4fbf6d6dc2ed4dd54bf3edf2755e52d54082516f by Eoin O'Neill. Committed on 16/06/2022 at 03:17. Pushed by eoinoneill into branch 'master'. Animated Transforms now respect cropping translations. NOTE: I'm not happy with how the translation is working as a whole with transform masks after cropping. E.G. In Alvin's test image, the circle drawn is roughly 512px units into the canvas. By that logic, cropping the image should actually move the existing transform keys to near 0 value. However, the actual translation is by roughly 3000 units. This looks correct visually, but the coordinates make no sense. I'll file this as a separate bug. It's not **majorly** important, but it would be nice to have logical coordinates for a transformation masks. I think this bug is there on the base transformation mask, but isn't easily noticable until you have an animated transform mask on where the translation values suddenly matter more. M +19 -0 plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp M +3-0 plugins/tools/tool_transform2/kis_animated_transform_parameters.h https://invent.kde.org/graphics/krita/commit/4fbf6d6dc2ed4dd54bf3edf2755e52d54082516f -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 407505] Animations using audio do not respect the designated playback range.
https://bugs.kde.org/show_bug.cgi?id=407505 Eoin O'Neill changed: What|Removed |Added CC||sneakhit...@gmail.com --- Comment #2 from Eoin O'Neill --- *** Bug 454554 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 454554] Playhead playing outside of pre-selected clip ranges when imported audio is on (not muted)
https://bugs.kde.org/show_bug.cgi?id=454554 Eoin O'Neill changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- Thanks for taking the time to report this bug. Audio is currently being worked on for Krita 5.2 and you can follow the development process here: https://invent.kde.org/graphics/krita/-/merge_requests/1323 As for this bug, I'm marking it a duplicate since there's already one for this specific in our tracker. Once the new audio stuff is merged, we will double back and notify parties involved in reporting that it's available for testing in Krita Next. *** This bug has been marked as a duplicate of bug 407505 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453187] The new HSV color selector expands the specific color selector docker every time it switches between RGB/HSV
https://bugs.kde.org/show_bug.cgi?id=453187 Eoin O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/6e2e5ffca ||2d08a9e0b7ff56bf25cc0ed53a8 ||52d3 --- Comment #2 from Eoin O'Neill --- Git commit 6e2e5ffca2d08a9e0b7ff56bf25cc0ed53a852d3 by Eoin O'Neill, on behalf of Sam Linnfer. Committed on 02/05/2022 at 20:15. Pushed by eoinoneill into branch 'master'. Fixes Specific Color Picker docker from expanding when switching between HSV/RGB The previous code sets the RGB sliders to visible, then hides the HSV sliders. For a split second, the docker is expanded due to the sliders being doubled up. This makes it appear that docker had bloated. The bug occurs when the Specific Color Selector is in a floating state and squished as small as it can be, then switching from HSV to RGB causes it to expand slightly. M +2-2 plugins/dockers/specificcolorselector/kis_specific_color_selector_widget.cc https://invent.kde.org/graphics/krita/commit/6e2e5ffca2d08a9e0b7ff56bf25cc0ed53a852d3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453170] Please add template
https://bugs.kde.org/show_bug.cgi?id=453170 --- Comment #1 from Eoin O'Neill --- *** Bug 453169 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453169] Please add template
https://bugs.kde.org/show_bug.cgi?id=453169 Eoin O'Neill changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED|RESOLVED CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- *** This bug has been marked as a duplicate of bug 453170 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447107] MacOS: [Shift + Click] Fails to Select Multiple Frames in Animation Timeline
https://bugs.kde.org/show_bug.cgi?id=447107 Eoin O'Neill changed: What|Removed |Added Summary|shift + click fails to |MacOS: [Shift + Click] |select multiple frames in |Fails to Select Multiple |animation timeline |Frames in Animation ||Timeline -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453088] Alt clicking layer does no longer toggle Isolate Active Layer (prealpha-917ee65ee2)
https://bugs.kde.org/show_bug.cgi?id=453088 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/e53f96854 ||a1432a096037409c18cd7243454 ||05ee Status|CONFIRMED |RESOLVED --- Comment #3 from Eoin O'Neill --- Git commit e53f96854a1432a096037409c18cd724345405ee by Eoin O'Neill. Committed on 27/04/2022 at 23:56. Pushed by eoinoneill into branch 'master'. Fix alt-click not invoking isolate layer behavior. M +7-9plugins/dockers/layerdocker/NodeDelegate.cpp https://invent.kde.org/graphics/krita/commit/e53f96854a1432a096037409c18cd724345405ee -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 453088] Alt clicking layer does no longer toggle Isolate Active Layer (prealpha-917ee65ee2)
https://bugs.kde.org/show_bug.cgi?id=453088 Eoin O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com CC||eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452396] Crash when deleting a vector layer that has an animated mask
https://bugs.kde.org/show_bug.cgi?id=452396 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/62afc6d92 |hics/krita/commit/54fef37e2 |a54ff664e16a8439a18f4f0efa6 |f086cfff6e830604c83bb671342 |d6e4|1407 --- Comment #4 from Eoin O'Neill --- Git commit 54fef37e2f086cfff6e830604c83bb6713421407 by Eoin O'Neill. Committed on 26/04/2022 at 21:52. Pushed by eoinoneill into branch 'krita/5.0'. Add safe assert on colorspace missing when fetching layer property for alphaChannelDisable. Fixes a user-level crash when deleting a Vector layer with an animated transparency mask. Notably, this shouldn't be null, so I'm leaving a safe assert -- but a safe assert is better than a hard crash for now. (cherry picked from commit 62afc6d92a54ff664e16a8439a18f4f0efa6d6e4) M +1-0libs/image/kis_layer.cc https://invent.kde.org/graphics/krita/commit/54fef37e2f086cfff6e830604c83bb6713421407 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452396] Crash when deleting a vector layer that has an animated mask
https://bugs.kde.org/show_bug.cgi?id=452396 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/62afc6d92 ||a54ff664e16a8439a18f4f0efa6 ||d6e4 --- Comment #3 from Eoin O'Neill --- Git commit 62afc6d92a54ff664e16a8439a18f4f0efa6d6e4 by Eoin O'Neill. Committed on 26/04/2022 at 21:50. Pushed by eoinoneill into branch 'master'. Add safe assert on colorspace missing when fetching layer property for alphaChannelDisable. Fixes a user-level crash when deleting a Vector layer with an animated transparency mask. Notably, this shouldn't be null, so I'm leaving a safe assert -- but a safe assert is better than a hard crash for now. M +1-0libs/image/kis_layer.cc https://invent.kde.org/graphics/krita/commit/62afc6d92a54ff664e16a8439a18f4f0efa6d6e4 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452626] Freehand shortcut not working as expected
https://bugs.kde.org/show_bug.cgi?id=452626 --- Comment #1 from Eoin O'Neill --- Hi CaFeine, I've edited the title of this bug to better reflect the nature of the problem. Though I think my understanding is a bit rough -- are you trying to say you have a custom shortcut (in this case, space key) that would switch to freehand that stops working after ctrl+z invocation? -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452626] Freehand shortcut not working as expected
https://bugs.kde.org/show_bug.cgi?id=452626 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com Summary|Version 5.0.5 on Steam! |Freehand shortcut not ||working as expected -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450781] Transform mask animations don't work after scaling image down.
https://bugs.kde.org/show_bug.cgi?id=450781 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/069dd6baa |hics/krita/commit/11ca47e72 |083c21d9dd8960da4af73aab7ef |3492925588ff34800aa25e8a04c |c3c3|bf41 --- Comment #3 from Eoin O'Neill --- Git commit 11ca47e723492925588ff34800aa25e8a04cbf41 by Eoin O'Neill. Committed on 12/04/2022 at 05:29. Pushed by eoinoneill into branch 'krita/5.0'. We now prevent data loss when scaling an image w/ animated transform masks. The ideal long-term fix would be to modify transform mask keyframes to account for new image size. When the image size changes, positioning data should change to reflect new image sizing. For now, this is enough to at least prevent data loss. (cherry picked from commit 069dd6baa083c21d9dd8960da4af73aab7efc3c3) M +1-1libs/image/processing/kis_transform_processing_visitor.cpp M +12 -0 plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp https://invent.kde.org/graphics/krita/commit/11ca47e723492925588ff34800aa25e8a04cbf41 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450424] Cached Animation Playback Not Respecting Multiple Views To Same Canvas
https://bugs.kde.org/show_bug.cgi?id=450424 --- Comment #2 from Eoin O'Neill --- Git commit d6e6451922e0f78e823554c6cc9eebbbe7b880b5 by Eoin O'Neill. Committed on 12/04/2022 at 05:29. Pushed by eoinoneill into branch 'krita/5.0'. Bugfix: Playback between multiple views / canvas now works correctly (Minus caching uploads, those need to happen even when view is no longer selected.) Related: bug 450425 (cherry picked from commit e1d1a23bac0abfc7f1b5d9c477d32e689b657c48) M +4-0plugins/dockers/animation/KisAnimCurvesDocker.cpp M +2-0plugins/dockers/animation/KisAnimTimelineDocker.cpp M +16 -9plugins/dockers/animation/KisTimeBasedItemModel.cpp https://invent.kde.org/graphics/krita/commit/d6e6451922e0f78e823554c6cc9eebbbe7b880b5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451654] Basename not updating when doing: Krita.instance().writeSetting('','ExportConfiguration-ANIMATION_EXPORT',str_xml)
https://bugs.kde.org/show_bug.cgi?id=451654 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/ea220aae2 |hics/krita/commit/0cd6e7982 |415eb324351ab8e41b926798483 |53d3cdabb5e68590f2dc86be06f |11b6|64dd --- Comment #5 from Eoin O'Neill --- Git commit 0cd6e798253d3cdabb5e68590f2dc86be06f64dd by Eoin O'Neill. Committed on 12/04/2022 at 04:52. Pushed by eoinoneill into branch 'krita/5.0'. Fix incorrect basename for animation when kra filepath or filename changes. This should be a middle ground between keeping the users prefered animation name (which people want when exporting the same animation multiple times to different formats) and reseting the basename to match krita doc filename (which allows users to copy a kra file for modifications / backup and render with a separate name, if they desire.) If this results in users requesting to keep the last basename used regardless of file path, we might need to be creative with solutions here. There's a good argument both ways here. (cherry picked from commit ea220aae2415eb324351ab8e41b92679848311b6) M +3-2libs/ui/animation/KisDlgAnimationRenderer.cpp https://invent.kde.org/graphics/krita/commit/0cd6e798253d3cdabb5e68590f2dc86be06f64dd -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450425] Timeline animation player doesn't properly respond to view changes
https://bugs.kde.org/show_bug.cgi?id=450425 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/e1d1a23ba |hics/krita/commit/d6e645192 |c0abfc7f1b5d9c477d32e689b65 |2e0f78e823554c6cc9eebbbe7b8 |7c48|80b5 --- Comment #2 from Eoin O'Neill --- Git commit d6e6451922e0f78e823554c6cc9eebbbe7b880b5 by Eoin O'Neill. Committed on 12/04/2022 at 05:29. Pushed by eoinoneill into branch 'krita/5.0'. Bugfix: Playback between multiple views / canvas now works correctly (Minus caching uploads, those need to happen even when view is no longer selected.) Related: bug 450424 (cherry picked from commit e1d1a23bac0abfc7f1b5d9c477d32e689b657c48) M +4-0plugins/dockers/animation/KisAnimCurvesDocker.cpp M +2-0plugins/dockers/animation/KisAnimTimelineDocker.cpp M +16 -9plugins/dockers/animation/KisTimeBasedItemModel.cpp https://invent.kde.org/graphics/krita/commit/d6e6451922e0f78e823554c6cc9eebbbe7b880b5 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 451654] Basename not updating when doing: Krita.instance().writeSetting('','ExportConfiguration-ANIMATION_EXPORT',str_xml)
https://bugs.kde.org/show_bug.cgi?id=451654 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/ea220aae2 ||415eb324351ab8e41b926798483 ||11b6 Status|ASSIGNED|RESOLVED --- Comment #4 from Eoin O'Neill --- Git commit ea220aae2415eb324351ab8e41b92679848311b6 by Eoin O'Neill. Committed on 08/04/2022 at 04:16. Pushed by eoinoneill into branch 'master'. Fix incorrect basename for animation when kra filepath or filename changes. This should be a middle ground between keeping the users prefered animation name (which people want when exporting the same animation multiple times to different formats) and reseting the basename to match krita doc filename (which allows users to copy a kra file for modifications / backup and render with a separate name, if they desire.) If this results in users requesting to keep the last basename used regardless of file path, we might need to be creative with solutions here. There's a good argument both ways here. M +3-2libs/ui/animation/KisDlgAnimationRenderer.cpp https://invent.kde.org/graphics/krita/commit/ea220aae2415eb324351ab8e41b92679848311b6 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452307] New scene creates a frame on locked layers.
https://bugs.kde.org/show_bug.cgi?id=452307 --- Comment #2 from Eoin O'Neill --- Git commit 93e280f38259b4d55dcbebb29a38cdbb8cd7b560 by Eoin O'Neill. Committed on 05/04/2022 at 21:16. Pushed by eoinoneill into branch 'krita/5.0'. Fix storyboarding docker creating keyframes on locked layers. Also accounts for layer visibility as well. If you can't see it, you won't edit the data which is probably the expected behavior. Related: bug 447396 (cherry picked from commit 75e397c903274ee8bcb6ab6da9797fccc310ec7d) M +14 -4plugins/dockers/storyboarddocker/StoryboardModel.cpp https://invent.kde.org/graphics/krita/commit/93e280f38259b4d55dcbebb29a38cdbb8cd7b560 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447396] Storyboard add scene adds empty keyframes on locked layers (krita-nightly-x64-5.0.0-beta5-e1828f1cae)
https://bugs.kde.org/show_bug.cgi?id=447396 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/75e397c90 |hics/krita/commit/93e280f38 |3274ee8bcb6ab6da9797fccc310 |259b4d55dcbebb29a38cdbb8cd7 |ec7d|b560 --- Comment #5 from Eoin O'Neill --- Git commit 93e280f38259b4d55dcbebb29a38cdbb8cd7b560 by Eoin O'Neill. Committed on 05/04/2022 at 21:16. Pushed by eoinoneill into branch 'krita/5.0'. Fix storyboarding docker creating keyframes on locked layers. Also accounts for layer visibility as well. If you can't see it, you won't edit the data which is probably the expected behavior. Related: bug 452307 (cherry picked from commit 75e397c903274ee8bcb6ab6da9797fccc310ec7d) M +14 -4plugins/dockers/storyboarddocker/StoryboardModel.cpp https://invent.kde.org/graphics/krita/commit/93e280f38259b4d55dcbebb29a38cdbb8cd7b560 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447396] Storyboard add scene adds empty keyframes on locked layers (krita-nightly-x64-5.0.0-beta5-e1828f1cae)
https://bugs.kde.org/show_bug.cgi?id=447396 Eoin O'Neill changed: What|Removed |Added CC||emmetoneill@gmail.com --- Comment #4 from Eoin O'Neill --- *** Bug 452307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452307] New scene creates a frame on locked layers.
https://bugs.kde.org/show_bug.cgi?id=452307 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com Resolution|--- |DUPLICATE Status|ASSIGNED|RESOLVED --- Comment #1 from Eoin O'Neill --- Closing this as duplicate, but cherry-picking the changes from master into 5.0 branch. *** This bug has been marked as a duplicate of bug 447396 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 452144] Opacity Keyframes can be added to a vector layer but they can't be Saved in the .kra file.
https://bugs.kde.org/show_bug.cgi?id=452144 Eoin O'Neill changed: What|Removed |Added Status|REPORTED|CONFIRMED CC||eoinoneill1...@gmail.com Ever confirmed|0 |1 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447107] shift + click fails to select multiple frames in animation timeline
https://bugs.kde.org/show_bug.cgi?id=447107 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #4 from Eoin O'Neill --- (In reply to vanyossi from comment #2) > This seems to be related to how different stylus and mouse/trackpad events > are on macOS. Just to confirm, this is only an issue on MacOS correct? I haven't had any issues with shift + click on tablet or on mouse on my linux machine or windows machine... -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450781] Transform mask animations don't work after scaling image down.
https://bugs.kde.org/show_bug.cgi?id=450781 Eoin O'Neill changed: What|Removed |Added Status|CONFIRMED |RESOLVED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/069dd6baa ||083c21d9dd8960da4af73aab7ef ||c3c3 Resolution|--- |FIXED --- Comment #2 from Eoin O'Neill --- Git commit 069dd6baa083c21d9dd8960da4af73aab7efc3c3 by Eoin O'Neill. Committed on 24/02/2022 at 23:15. Pushed by eoinoneill into branch 'master'. We now prevent data loss when scaling an image w/ animated transform masks. The ideal long-term fix would be to modify transform mask keyframes to account for new image size. When the image size changes, positioning data should change to reflect new image sizing. For now, this is enough to at least prevent data loss. M +1-1libs/image/processing/kis_transform_processing_visitor.cpp M +12 -0 plugins/tools/tool_transform2/kis_animated_transform_parameters.cpp https://invent.kde.org/graphics/krita/commit/069dd6baa083c21d9dd8960da4af73aab7efc3c3 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450408] Buttons on Animation Dockers Disappear if title bars are hidden and dockers are enabled.
https://bugs.kde.org/show_bug.cgi?id=450408 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #2 from Eoin O'Neill --- Well, since this is technically the case, I'll go ahead and confirm this as an issue-to-resolve at some point. I'm going to keep this relatively low priority though, since it's a very specific and easy to work around edge case in the design. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450781] Transform mask animations don't work after scaling image down.
https://bugs.kde.org/show_bug.cgi?id=450781 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450424] Cached Animation Playback Not Respecting Multiple Views To Same Canvas
https://bugs.kde.org/show_bug.cgi?id=450424 --- Comment #1 from Eoin O'Neill --- Git commit e1d1a23bac0abfc7f1b5d9c477d32e689b657c48 by Eoin O'Neill. Committed on 18/02/2022 at 00:40. Pushed by eoinoneill into branch 'master'. Bugfix: Playback between multiple views / canvas now works correctly (Minus caching uploads, those need to happen even when view is no longer selected.) Related: bug 450425 M +4-0plugins/dockers/animation/KisAnimCurvesDocker.cpp M +2-0plugins/dockers/animation/KisAnimTimelineDocker.cpp M +16 -9plugins/dockers/animation/KisTimeBasedItemModel.cpp https://invent.kde.org/graphics/krita/commit/e1d1a23bac0abfc7f1b5d9c477d32e689b657c48 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450425] Timeline animation player doesn't properly respond to view changes
https://bugs.kde.org/show_bug.cgi?id=450425 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/e1d1a23ba ||c0abfc7f1b5d9c477d32e689b65 ||7c48 Status|REPORTED|RESOLVED --- Comment #1 from Eoin O'Neill --- Git commit e1d1a23bac0abfc7f1b5d9c477d32e689b657c48 by Eoin O'Neill. Committed on 18/02/2022 at 00:40. Pushed by eoinoneill into branch 'master'. Bugfix: Playback between multiple views / canvas now works correctly (Minus caching uploads, those need to happen even when view is no longer selected.) Related: bug 450424 M +4-0plugins/dockers/animation/KisAnimCurvesDocker.cpp M +2-0plugins/dockers/animation/KisAnimTimelineDocker.cpp M +16 -9plugins/dockers/animation/KisTimeBasedItemModel.cpp https://invent.kde.org/graphics/krita/commit/e1d1a23bac0abfc7f1b5d9c477d32e689b657c48 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450449] The audio, when rendered with an animation, skips ahead so that it does not correctly correlate with the animation that it's supposed to sync with. Help please.
https://bugs.kde.org/show_bug.cgi?id=450449 Eoin O'Neill changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED|CONFIRMED CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- I can confirm the bug. Audio is one of the next things we are going to be working on in Krita's animation system so this is actively being worked on. Thanks for taking the time to report the bug, Eoin. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450425] New: Timeline animation player doesn't properly respond to view changes
https://bugs.kde.org/show_bug.cgi?id=450425 Bug ID: 450425 Summary: Timeline animation player doesn't properly respond to view changes Product: krita Version: 5.0.0-beta5 Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: Animation Assignee: eoinoneill1...@gmail.com Reporter: eoinoneill1...@gmail.com Target Milestone: --- SUMMARY Note: Probably related to missing a signal disconnect when switching between views (particularly between the timeline and the animation player.) Requires either subwindow mode or multiple window instances. STEPS TO REPRODUCE 1. Begin Playback on View A of File A 2. Switch to View B of File B OBSERVED RESULT Timeline (frames, etc) will correctly show frame by frame content between views, but playback will continue to move play-head erroneously. EXPECTED RESULT Timeline should visually update to reflect actual state of separate view. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 450424] New: Cached Animation Playback Not Respecting Multiple Views To Same Canvas
https://bugs.kde.org/show_bug.cgi?id=450424 Bug ID: 450424 Summary: Cached Animation Playback Not Respecting Multiple Views To Same Canvas Product: krita Version: 5.0.0-beta5 Platform: Other OS: Linux Status: REPORTED Severity: minor Priority: NOR Component: Animation Assignee: eoinoneill1...@gmail.com Reporter: eoinoneill1...@gmail.com Target Milestone: --- SUMMARY Multiple views to the same animation (when graphics acceleration is enabled) will not update both views simultaneously. You must be in subwindow mode or have a separate window in order to see multiple views of the same canvas. STEPS TO REPRODUCE 1. Enable subwindow mode or instantiate second window 2. Create a duplicate view (or window w/ duplicate view) 3. Play animation back OBSERVED RESULT One view will animate correctly, the other one won't. EXPECTED RESULT Both views should update appropriately. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445691] Alpha Mask not working properly with predefined brush tips
https://bugs.kde.org/show_bug.cgi?id=445691 Eoin O'Neill changed: What|Removed |Added Latest Commit|https://invent.kde.org/grap |https://invent.kde.org/grap |hics/krita/commit/1fc1926d2 |hics/krita/commit/a840b241c |5821867581172ad6b8139893d45 |155d3cae05b28d285d8e59d7a13 |78ac|0128 --- Comment #22 from Eoin O'Neill --- Git commit a840b241c155d3cae05b28d285d8e59d7a130128 by Eoin O'Neill. Committed on 25/01/2022 at 22:29. Pushed by eoinoneill into branch 'master'. Another pass at alpha mask related regression. It seems like the behavior changed due to an unnecessary change to a default value in the KisColorfulBrush header. Changing the autoadjust bool to start at true was causing unintended modifications to ALPHAMASK brush behavior. Checked unit tests and all tests passed after changing the default value back -- plus the behavior was fixed and did not seem to cause regressions anywhere else. (cherry picked from commit 1fc1926d25821867581172ad6b8139893d4578ac) M +1-1libs/brush/KisColorfulBrush.h M +1-27 libs/brush/kis_png_brush.cpp https://invent.kde.org/graphics/krita/commit/a840b241c155d3cae05b28d285d8e59d7a130128 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448546] Whenever I try to add a new blank frame, the program crashes. :(
https://bugs.kde.org/show_bug.cgi?id=448546 --- Comment #5 from Eoin O'Neill --- kmelisargzh, That's good to hear. :) Maybe we can do more to give more feedback for when crashes occur due to certain settings. I'll look into that at some point as well. Hope you have a good week, Eoin -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448546] Whenever I try to add a new blank frame, the program crashes. :(
https://bugs.kde.org/show_bug.cgi?id=448546 Eoin O'Neill changed: What|Removed |Added Resolution|WORKSFORME |NOT A BUG Status|NEEDSINFO |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448430] Bug with rendering animations
https://bugs.kde.org/show_bug.cgi?id=448430 Eoin O'Neill changed: What|Removed |Added Resolution|--- |WAITINGFORINFO Status|REPORTED|NEEDSINFO --- Comment #2 from Eoin O'Neill --- Changing the status of the bug to "Waiting For Info" for now. Posting an update will automatically reopen the bug. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447610] One of the frames in the animation plays back corrupted after moving them a few spaces over.
https://bugs.kde.org/show_bug.cgi?id=447610 --- Comment #7 from Eoin O'Neill --- So those settings don't look like anything I don't have going on in my system. I'll have to see if someone else has hardware similar to yours where we can try to reproduce this issue. One last thing you could try is updating your current driver (it looks like your version is from May of last year, and there might be newer graphics drivers available.) You can also try limiting the frame cache to 1000px and see if that resolves any caching relates issues (it could be that your graphics card is out of memory on longer animations, but in which case we should still probably find ways of preventing this kind of issue.) If the 1000px frame limit works, you could see if on-disk caching at 2500px helps resolve this issue too! I'm sorry that I couldn't be of more help, Eoin. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445361] MacOS - Animation Playback Lag
https://bugs.kde.org/show_bug.cgi?id=445361 Eoin O'Neill changed: What|Removed |Added Summary|Animation Playback Lag |MacOS - Animation Playback ||Lag -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448430] Bug with rendering animations
https://bugs.kde.org/show_bug.cgi?id=448430 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com --- Comment #1 from Eoin O'Neill --- Created attachment 145633 --> https://bugs.kde.org/attachment.cgi?id=145633&action=edit FFMPeg Version Details Hi elgin.p.smith, We will need more details here. What version of FFMPEG do you have installed on your current system? The version information of FFMPEG will be shown on the animation export window, highlighted in the attachment. What you're seeing (the 0% to 15%) is Krita processing each frame change and exporting behind the scenes. It seems to me like this is working on your system, but FFMPEG is failing to render the images to a video at the end of the process. If you could confirm this for me by trying to export as an image sequence instead of a video and tell me if you receive an error message, that'd be great. Sorry for the inconvenience, Eoin. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 448546] Whenever I try to add a new blank frame, the program crashes. :(
https://bugs.kde.org/show_bug.cgi?id=448546 Eoin O'Neill changed: What|Removed |Added Resolution|--- |WORKSFORME Status|ASSIGNED|NEEDSINFO --- Comment #2 from Eoin O'Neill --- Hi there kmelisargzh, So I've poked around on my Windows build and cannot reproduce this issue on my machine. Could you do the following for me? 1) Please try uninstalling and installing Krita 5.0.2 again -- I'm mostly interested to know whether or not a fresh install will change the results here. If this was an upgrade, it could be that some of the old animation-related libraries stayed installed on your system which is causing an interference. 2) If a fresh installation does not solve your problem, please provide me with details regarding your system hardware and configuration (`Display > Canvas Acceleration` and `Performance > Animation Cache` settings page details, in particular, would be nice to know here.) Sorry for the inconvenience, Eoin. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446023] Transform tool with "Fast" preview does not update or insert keyframes for an animated transform mask
https://bugs.kde.org/show_bug.cgi?id=446023 Eoin O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/270948d8f ||240fe28abd9e0d378de2eeb7a2d ||a016 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Eoin O'Neill --- Git commit 270948d8f240fe28abd9e0d378de2eeb7a2da016 by Eoin O'Neill. Committed on 13/01/2022 at 03:03. Pushed by eoinoneill into branch 'master'. Fix "Fast" Transform preview mode not creating or modifying keyframe data for transform masks. Should now work the same as inplace transform mode for the most part. Values do not change in real time due to the way fast mode works, and values will change after being moved to the desired location. This should keep operation uninterrupted and fast (as intended..) M +24 -0 plugins/tools/tool_transform2/strokes/transform_stroke_strategy.cpp https://invent.kde.org/graphics/krita/commit/270948d8f240fe28abd9e0d378de2eeb7a2da016 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436965] When crashing Krita during video import, it leaves a ton of video import files behind.
https://bugs.kde.org/show_bug.cgi?id=436965 Eoin O'Neill changed: What|Removed |Added Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/86db9358f ||2fea2b528346a5f7351dcbe5894 ||8316 Status|CONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Eoin O'Neill --- Git commit 86db9358f2fea2b528346a5f7351dcbe58948316 by Eoin O'Neill. Committed on 11/01/2022 at 21:55. Pushed by eoinoneill into branch 'master'. Use QTemporaryDir class instead of manual temporary directory management. Should help w/ preventing file leakage. In odd case that it does crash on import, QTemporaryDir should safely clean up files (and, if not, files should at least be cleaned on reboot.) M +5-5libs/ui/KisMainWindow.cpp M +5-15 libs/ui/animation/KisDlgImportVideoAnimation.cpp M +1-4libs/ui/animation/KisDlgImportVideoAnimation.h https://invent.kde.org/graphics/krita/commit/86db9358f2fea2b528346a5f7351dcbe58948316 -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436965] When crashing Krita during video import, it leaves a ton of video import files behind.
https://bugs.kde.org/show_bug.cgi?id=436965 --- Comment #3 from Eoin O'Neill --- Git commit b6b1f2355e0118f23c39a002273f0ad1b1c9edfa by Eoin O'Neill. Committed on 06/01/2022 at 23:23. Pushed by eoinoneill into branch 'master'. Initial proof-of-concept of keyframe detection and duplicate frame removal during video import process. Steps remaining... 1) Plug UI in with meaningful value range for users to tweak. 2) Use frame file names to determine position within file, and insert accordingly. ... And more? This should help people when importing animations that are long and repetitive. They might not need every single duplicate frame, depending on their user case. Users will be able to dial in sensitivity to adjust to their liking. M +3-2libs/ui/animation/KisDlgImportVideoAnimation.cpp M +102 -37 libs/ui/animation/VideoImportDialog.ui https://invent.kde.org/graphics/krita/commit/b6b1f2355e0118f23c39a002273f0ad1b1c9edfa -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 446023] Transform tool with "Fast" preview does not update or insert keyframes for an animated transform mask
https://bugs.kde.org/show_bug.cgi?id=446023 Eoin O'Neill changed: What|Removed |Added Assignee|krita-bugs-n...@kde.org |eoinoneill1...@gmail.com CC||eoinoneill1...@gmail.com -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 436965] When crashing Krita during video import, it leaves a ton of video import files behind.
https://bugs.kde.org/show_bug.cgi?id=436965 --- Comment #2 from Eoin O'Neill --- Looking into this more, having now optimized the FFMPEG to import less frames (optionally) for longer files on my own branch, another solution is to properly use the temp directories at krita's disposal. At least on linux, these temp directories will be cleaned up after system reboot. -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 447915] Frames shown during playback are always offset; giving each frame an incorrect timing. Also occurs with scrubbing along frames.
https://bugs.kde.org/show_bug.cgi?id=447915 Eoin O'Neill changed: What|Removed |Added CC||eoinoneill1...@gmail.com Resolution|--- |DUPLICATE Status|REPORTED|NEEDSINFO --- Comment #1 from Eoin O'Neill --- I believe this is a duplicate of 445361, which Ivan is currently assigned to... *** This bug has been marked as a duplicate of bug 445361 *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 445361] Animation Playback Lag
https://bugs.kde.org/show_bug.cgi?id=445361 Eoin O'Neill changed: What|Removed |Added CC||silasni...@gmail.com --- Comment #3 from Eoin O'Neill --- *** Bug 447915 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
[krita] [Bug 429294] Filesize of importing animation frames
https://bugs.kde.org/show_bug.cgi?id=429294 Eoin O'Neill changed: What|Removed |Added Resolution|--- |FIXED Latest Commit||https://invent.kde.org/grap ||hics/krita/commit/ec089d615 ||e2916610614524a4adc3a8380bb ||e7f0 Status|CONFIRMED |RESOLVED --- Comment #2 from Eoin O'Neill --- Git commit ec089d615e2916610614524a4adc3a8380bbe7f0 by Eoin O'Neill, on behalf of Bip Boop. Committed on 05/01/2022 at 23:32. Pushed by eoinoneill into branch 'master'. Crop imported animation frames to content * Reduces file size * Reduces ram usage Optimization attempt of calculateExactBoundsImpl Purge default pixels unconditionaly on import frame Add a checkbox in settings/general/filehandling to disable croping default pixels on frames import * The option to trim frames on import means that the frame is cropped to the document's dimensions * purgeDefaultPixels is called on each imported frame unconditionally M +6-8libs/image/kis_paint_device.cc M +1-1libs/ui/actions/KisPasteActionFactories.cpp M +8-0libs/ui/dialogs/kis_dlg_preferences.cc M +1-0libs/ui/dialogs/kis_dlg_preferences.h M +11 -1libs/ui/forms/wdggeneralsettings.ui M +7-0libs/ui/kis_animation_importer.cpp M +9-0libs/ui/kis_config.cc M +3-0libs/ui/kis_config.h M +1-1plugins/impex/csv/csv_loader.cpp https://invent.kde.org/graphics/krita/commit/ec089d615e2916610614524a4adc3a8380bbe7f0 -- You are receiving this mail because: You are watching all bug changes.
