[xdg-desktop-portal-kde] [Bug 474741] Binding Global Shortcuts through the Portal fails with Python

2024-03-06 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=474741

Lindsay Roberts  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/xdg-desktop-portal-kde/-
   ||/commit/a748343ee8a8cdfaeaa
   ||4a40544ce41a5e3b56e97
 Resolution|--- |FIXED

--- Comment #2 from Lindsay Roberts  ---
Git commit a748343ee8a8cdfaeaa4a40544ce41a5e3b56e97 by Lindsay Roberts, on
behalf of Lindsay Roberts.
Committed on 06/03/2024 at 18:03.
Pushed by roberts into branch 'master'.

GlobalShortcuts: Set shortcuts in BindShortcuts

The protocol changed in
https://github.com/flatpak/xdg-desktop-portal/commit/8cb5b6d997108443ecc26152c95bbca8c8c58fc3
to accept shortcuts in BindShortcuts instead of CreateSession.
xdg-desktop-portal no longer forwards shortcuts from CreateSession so
before this change, no shortcuts could be created.

M  +1-4src/globalshortcuts.cpp
M  +1-10   src/session.cpp
M  +1-1src/session.h

https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/commit/a748343ee8a8cdfaeaa4a40544ce41a5e3b56e97

-- 
You are receiving this mail because:
You are watching all bug changes.

[xdg-desktop-portal-kde] [Bug 474741] Binding Global Shortcuts through the Portal fails with Python

2024-02-24 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=474741

Lindsay Roberts  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 CC||lind...@gmail.com
 Ever confirmed|0   |1

--- Comment #1 from Lindsay Roberts  ---
Hey, found the same issue trying to get my own app to work via this protocol,
and fixed xdg-desktop-portal-kde after some debugging and digging. Just found
your issue which is likely to be the same problem.

Have a merge request open to fix it at
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/274 . It
also contains information on why support ended up broken.

Another merge request in the test code if you'd like to see the change
necessary to have client code work relative to the examples coded against the
draft protocol:
https://invent.kde.org/libraries/xdg-portal-test-kde/-/merge_requests/25

-- 
You are receiving this mail because:
You are watching all bug changes.

[kscreenlocker] [Bug 347934] Part of the desktop visible in the lock screen

2021-01-11 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=347934

Lindsay Roberts  changed:

   What|Removed |Added

 CC||lind...@gmail.com
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
   Assignee|plasma-b...@kde.org |lind...@gmail.com

--- Comment #23 from Lindsay Roberts  ---
Just merged the fix in
https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/23 - before this
fix I could trigger the issue by adding/removing monitors (this can also occur
on resume/wakeup with external monitor attached).

Would be very interested to know if anyone could confirm the change fixed the
issue for them.

Commit:
https://invent.kde.org/plasma/kscreenlocker/-/commit/6f2ef9235c39b068e2cc4df77d660f4db8dfd451

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 393238] Reduce shadow size/strength for background windows

2020-09-24 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=393238

Lindsay Roberts  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #35 from Lindsay Roberts  ---
Merge request committed to master, with added animation support.

https://invent.kde.org/plasma/breeze/-/merge_requests/33

-- 
You are receiving this mail because:
You are watching all bug changes.

[Breeze] [Bug 393238] Reduce shadow size/strength for background windows

2020-09-24 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=393238

Lindsay Roberts  changed:

   What|Removed |Added

 CC||lind...@gmail.com

--- Comment #33 from Lindsay Roberts  ---
Coded up a version that halves shadow strength for inactive windows.

Preview in the merge request.

https://invent.kde.org/plasma/breeze/-/merge_requests/33

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 387833] konsole scrollback functionality often vanishes

2018-10-10 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=387833

Lindsay Roberts  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||lind...@gmail.com
 Status|REPORTED|CONFIRMED

--- Comment #6 from Lindsay Roberts  ---
I can reproduce on git master with the following steps:

1) Open new tab
2) $ ssh 
3) In the ssh session: $ vim
4) On the machine running konsole, kill the ssh session

Seems to work with other programs that have their own scroll mechanisms also,
e.g. tmux

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2017-03-25 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=356479

--- Comment #123 from Lindsay Roberts <lind...@gmail.com> ---
As mentioned in comment #92 and by Andreas above, high CPU usage whilst copying
is tracked in (the still open) https://bugs.kde.org/show_bug.cgi?id=312919 .
Please retarget downstream dependency issues around copying onto that.

(In reply to Dreyk from comment #122)
> This cause only when i switch to Nvidia Prime card (notebook with Nvidia 
> Optimus). When I switch back to Intel integrated graphics - everything is 
> fine. 
> So several years already I can not use Nvidia card with KDE desktop :(

If there is an Nvidia specific problem causing high CPU usage for systray
animations, I think it warrants a new issue. The fix in this item solved this
for all other cases I've heard, and an Nvidia specific problem would require a
new investigation and a new fix, and almost certainly doesn't invalidate the
fix done here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2016-12-30 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=356479

--- Comment #113 from Lindsay Roberts <lind...@gmail.com> ---
Patch has now been backported to the Plasma/5.8 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2016-12-10 Thread Lindsay Roberts
https://bugs.kde.org/show_bug.cgi?id=356479

--- Comment #106 from Lindsay Roberts <lind...@gmail.com> ---
This change has now been in master for two months with no reports of
regression; I now think backporting is a reasonable step. Specifically because
of its impact on laptops and other battery powered machines -- being on battery
and having some kind of connecting icon in the tray are highly correlated.

Will leave it up to one of the more authoritative KDE devs to determine whether
it is tested enough and significant enough.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2016-10-13 Thread Lindsay Roberts via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356479

Lindsay Roberts <lind...@gmail.com> changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #92 from Lindsay Roberts <lind...@gmail.com> ---
Am marking this bug resolved - it's scope being as David mentioned above,
systray related CPU usage.

High CPU usage when copying files via Dolphin with task status is still a
problem; suggest we track that in the existing specific item
https://bugs.kde.org/show_bug.cgi?id=312919 . Doesn't seem to be the same as
issue (2) mentioned above, perf shows lots of dbus.

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2016-10-10 Thread Lindsay Roberts via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356479

--- Comment #91 from Lindsay Roberts <lind...@gmail.com> ---
For all those playing at home, the change in https://phabricator.kde.org/D2986
has now been committed. This makes the changes I suggested above as well as
completely removing the code identified in the perf traces.

Anyone willing to test master to help confirm the fix and it's lack of side
effects is extremely welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.


[frameworks-plasma] [Bug 301841] Plasma tooltip popups block user interface

2016-10-08 Thread Lindsay Roberts via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=301841

Lindsay Roberts <lind...@gmail.com> changed:

   What|Removed |Added

 CC||lind...@gmail.com
 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED

--- Comment #8 from Lindsay Roberts <lind...@gmail.com> ---
Closing as RESOLVED:FIXED - confirmed Igor's findings from 5.4 - tooltips
disappear almost instantly on mouseover.

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2016-10-06 Thread Lindsay Roberts via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356479

--- Comment #89 from Lindsay Roberts <lind...@gmail.com> ---
The file is
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/items/StatusNotifierItem.qml
locally. If you try this, let us know if you see the same icons before and
after or any other changes. Can't guarantee this doesn't produce some kind of
huge regression.

These are the changes I made:

Line 31:
//icon: ToolTipIcon != "" ? ToolTipIcon :
plasmoid.nativeInterface.resolveIcon(IconName != "" ? IconName : Icon,
IconThemePath)
icon: ToolTipIcon != "" ? ToolTipIcon : Icon ? Icon :
plasmoid.nativeInterface.resolveIcon(IconName, IconThemePath)

Line 51:
//source: plasmoid.nativeInterface.resolveIcon(IconName != "" ?
IconName : Icon, IconThemePath)
source: Icon ? Icon : plasmoid.nativeInterface.resolveIcon(IconName,
IconThemePath)

-- 
You are receiving this mail because:
You are watching all bug changes.


[plasmashell] [Bug 356479] plasmashell uses 100% CPU when there is an animation in the task bar

2016-10-06 Thread Lindsay Roberts via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=356479

Lindsay Roberts <lind...@gmail.com> changed:

   What|Removed |Added

 CC||lind...@gmail.com

--- Comment #87 from Lindsay Roberts <lind...@gmail.com> ---
Confirmed Fabian's cause locally using perf/timers.

It seems even worse than thought - in addition to legion allocations, it also
iterates through the filesystem during KIconTheme construction, disk waits and
IO on top of the visible CPU usage.

A trivial test program did also turn up one more interesting bit about the
problem; every time any icon in the systray changes - including a native
KStatusNotifier based icon - all icons are refreshed, and this includes calling
resolveIcon, and heap allocating KIconLoader/KIconTheme and it's associated
fileystem iteration. Not only that, but the system tray QML references the icon
(and resolveIcon) twice, so all this happens twice per affected icon, every
time any icon changes. To salt that quite open wound, this includes icons
hidden inside the expansion area, and in no plausible scenario needing
immediate repaint.

It is clear that KIconLoader is far too heavy to be constructed as part of any
interactive or continuous operation. Without having spent too long in the code,
the right place for any kind of cached per-application/per-icon data would seem
to be in the statusnotifieritem datasource. And it seems that class actually
has code for tracking a custom KIconLoader, resolving icons, and even sending
them. It's possible that the code in resolveIcon is redundant, and is being
used only because the QML prefers using the icon name to the QIcon() passed
along:

source: plasmoid.nativeInterface.resolveIcon(IconName != "" ? IconName
: Icon, IconThemePath)

Prefixing a preference for the provided icon before delving into resolveIcon
(Icon ? Icon : ...)  got rid of all significant CPU usage on my machine aside
from the QML scene graph and the graphics drivers. Would require someone more
knowledgeable in this area and/or significant testing to confirm this wouldn't
produce any negative behaviour, however.

Even with the above, we seem to be doing too much repainting due to small
changes here, I haven't delved in enough to attempt to discover where and why
the repaints are occurring.

-- 
You are receiving this mail because:
You are watching all bug changes.