[Elisa] [Bug 467348] When using the app in a non-English language, cover overlay "Play" and "Add to Playlist" buttons do not work on startup until you switch to a different page and back

2023-04-02 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=467348

--- Comment #9 from Matthieu Gallien  ---
I failed to reproduce even by running LANG=fr_FR ./elisa.
I suspect this to be a weird timing issue.
Would be nice to get someone to run with the patch and see if the added output
shows up in the log.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 467348] When using the app in a non-English language, cover overlay "Play" and "Add to Playlist" buttons do not work on startup until you switch to a different page and back

2023-04-02 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=467348

--- Comment #8 from Matthieu Gallien  ---
Created attachment 157801
  --> https://bugs.kde.org/attachment.cgi?id=157801=edit
patch to add output for missing connection

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 444475] can't find music on Android

2022-06-13 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=75

--- Comment #8 from Matthieu Gallien  ---
Unfortunately, I can reproduce but so far lacked time to really work on a fix.

Will try my best in the following days.

Best regards

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 433892] Elisa does not recognize AAC files

2021-03-07 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=433892

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/f9b949c
   ||150950b15ade9f68664497c56f2
   ||480a9a
 Status|ASSIGNED|RESOLVED
   Version Fixed In||21.04

--- Comment #5 from Matthieu Gallien  ---
Git commit f9b949c150950b15ade9f68664497c56f2480a9a by Matthieu Gallien.
Committed on 07/03/2021 at 10:49.
Pushed by mgallien into branch 'release/20.12'.

still return a valid track even when no extractors support it

that is the case when we get an audio file not with a format not yet
supported by KFileMetaData
FIXED-IN: 21.04

M  +11   -0src/filescanner.cpp

https://invent.kde.org/multimedia/elisa/commit/f9b949c150950b15ade9f68664497c56f2480a9a

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 433892] Elisa does not recognize AAC files

2021-03-03 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=433892

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #3 from Matthieu Gallien  ---
No idea yet why it does not work but I can reproduce it.

Thanks for the report

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 409587] Many inotify_add_watch errors starting Elisa

2021-02-16 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=409587

--- Comment #5 from Matthieu Gallien  ---
Git commit 940c56853d3b4d26ece28f0ac4f1c29faf814dd8 by Matthieu Gallien.
Committed on 16/02/2021 at 07:18.
Pushed by mgallien into branch 'master'.

when using Baloo does not watch for changes itself

rely mostly on Baloo for changes notifications (not complete)

M  +4-4src/baloo/localbaloofilelisting.cpp

https://invent.kde.org/multimedia/elisa/commit/940c56853d3b4d26ece28f0ac4f1c29faf814dd8

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431422] Elisa intermittently crashed in KFileMetaData::Property::Property() when fetching lyrics tag

2021-01-25 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431422

Matthieu Gallien  changed:

   What|Removed |Added

   Version Fixed In||20.12.2

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431422] Elisa intermittently crashed in KFileMetaData::Property::Property() when fetching lyrics tag

2021-01-23 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431422

Matthieu Gallien  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/e2845b5
   ||89170de36851ff37d36d76697ad
   ||de7440
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #8 from Matthieu Gallien  ---
Git commit e2845b589170de36851ff37d36d76697adde7440 by Matthieu Gallien.
Committed on 22/01/2021 at 22:51.
Pushed by mgallien into branch 'release/20.12'.

avoid concurrent access when fetching lyrics

M  +4-2src/models/trackmetadatamodel.cpp
M  +3-0src/models/trackmetadatamodel.h

https://invent.kde.org/multimedia/elisa/commit/e2845b589170de36851ff37d36d76697adde7440

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431422] Elisa intermittently crashed in KFileMetaData::Property::Property() when fetching lyrics tag

2021-01-22 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431422

--- Comment #6 from Matthieu Gallien  ---
So this is a stupid concurrent access on one attributes of an object all within
elisa's code.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431422] Elisa intermittently crashed in KFileMetaData::Property::Property() when fetching lyrics tag

2021-01-22 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431422

--- Comment #5 from Matthieu Gallien  ---
(In reply to Stefan Brüns from comment #4)
> @ngraham: The crash is in elisa, when iterating a QMap coming from KFM.
> Please provide any proof the QMap is incorrect. This has to be investigated
> in elisa first.

I wanted to have a look as soon as I can to the different crashes including
this one.

I have just noticed that the flatpak build seems mostly unaffected while a
local build is crashing on me at each track changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 430089] Elisa closes unexpectedly during listening to music

2021-01-22 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=430089

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #5 from Matthieu Gallien  ---
Thanks for the report and the detailed backtraces.

I can confirm it and will work on a fix as soon as possible.

Sorry for that and the delay

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 420752] Playlist is broken when I open a file with embedded cover via Dolphin

2021-01-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=420752

--- Comment #3 from Matthieu Gallien  ---
I had thought that we were over those bugs in the ListView component. I will
have a look at what I can do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431602] "Show current track" functionality has broken

2021-01-15 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431602

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/afaf25d
   ||815763728ac842922dd422377f6
   ||6079dc
   Version Fixed In||20.12.2

--- Comment #3 from Matthieu Gallien  ---
Git commit afaf25d815763728ac842922dd422377f66079dc by Matthieu Gallien, on
behalf of Nate Graham.
Committed on 15/01/2021 at 16:12.
Pushed by mgallien into branch 'release/20.12'.

Fix "show current track" button

I broke this in 3b80b0001239f8c6a35f95ff940e6ba596075310 by making
PlayListBasicView into a ScrollView, not a ListView. Therefore anything
that wants to target properties and functions of the list view item
needs to be adjusted to do so explicitly.
FIXED-IN: 20.12.2

M  +3-3src/qml/MediaPlayListView.qml
M  +1-0src/qml/PlayListBasicView.qml

https://invent.kde.org/multimedia/elisa/commit/afaf25d815763728ac842922dd422377f66079dc

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 430743] "Apply" button is active in Elisa settings even when there is no change to apply

2021-01-15 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=430743

Matthieu Gallien  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
   |imedia/elisa/commit/9f07add |imedia/elisa/commit/d825da3
   |a03d3b8f1fde87638aeb09b115a |dd869dc2cec45a80ecd6351bc24
   |b46c0d  |1fafcc

--- Comment #4 from Matthieu Gallien  ---
Git commit d825da3dd869dc2cec45a80ecd6351bc241fafcc by Matthieu Gallien.
Committed on 15/01/2021 at 08:10.
Pushed by mgallien into branch 'release/20.12'.

ensure the configuration dialog is not dirty when just open

avoid setting it dirty when reading the setting during the first init

when clicking on cancel, ensure that the c++ backend is reset

M  +34   -11   src/localFileConfiguration/elisaconfigurationdialog.cpp
M  +2-0src/localFileConfiguration/elisaconfigurationdialog.h
M  +4-1src/qml/ElisaConfigurationDialog.qml

https://invent.kde.org/multimedia/elisa/commit/d825da3dd869dc2cec45a80ecd6351bc241fafcc

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421660] PowerManagementInterface printing incessantly about non-existent service

2021-01-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421660

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/c2b3d0d
   ||312ac20c0aa1a4e7a34a765484c
   ||420cc3
 Resolution|--- |FIXED

--- Comment #4 from Matthieu Gallien  ---
Git commit c2b3d0d312ac20c0aa1a4e7a34a765484c420cc3 by Matthieu Gallien.
Committed on 14/01/2021 at 21:59.
Pushed by mgallien into branch 'release/20.12'.

avoid printing useless logs on console when power management is working

M  +7-0src/CMakeLists.txt
M  +6-4src/powermanagementinterface.cpp

https://invent.kde.org/multimedia/elisa/commit/c2b3d0d312ac20c0aa1a4e7a34a765484c420cc3

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 430743] "Apply" button is active in Elisa settings even when there is no change to apply

2021-01-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=430743

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/9f07add
   ||a03d3b8f1fde87638aeb09b115a
   ||b46c0d

--- Comment #3 from Matthieu Gallien  ---
Git commit 9f07adda03d3b8f1fde87638aeb09b115ab46c0d by Matthieu Gallien.
Committed on 14/01/2021 at 21:34.
Pushed by mgallien into branch 'master'.

ensure the configuration dialog is not dirty when just open

avoid setting it dirty when reading the setting during the first init

when clicking on cancel, ensure that the c++ backend is reset

M  +34   -11   src/localFileConfiguration/elisaconfigurationdialog.cpp
M  +2-0src/localFileConfiguration/elisaconfigurationdialog.h
M  +4-1src/qml/ElisaConfigurationDialog.qml

https://invent.kde.org/multimedia/elisa/commit/9f07adda03d3b8f1fde87638aeb09b115ab46c0d

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431587] Elisa Music Player consistently crashes

2021-01-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431587

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Matthieu Gallien  ---
Thanks for the report.

It is a duplicate of 428218 and a fix is pending.

*** This bug has been marked as a duplicate of bug 428218 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428218] Elisa crashes when trying to play or enqueue mp4 files

2021-01-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428218

Matthieu Gallien  changed:

   What|Removed |Added

 CC||m...@sicoop.com

--- Comment #4 from Matthieu Gallien  ---
*** Bug 431587 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431245] Elisa doesn't see mp3, m4a, or FLAC files on Windows

2021-01-13 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431245

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Matthieu Gallien  ---
The fixed version is now available from the store. Closing the bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429733] Toggling "repeat playlist" makes the song title jump

2021-01-10 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429733

--- Comment #2 from Matthieu Gallien  ---
Should this bug be marked as solved ? Looks like it is fixed in the current
stable version.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 430743] "Apply" button is active in Elisa settings even when there is no change to apply

2021-01-10 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=430743

--- Comment #2 from Matthieu Gallien  ---
https://invent.kde.org/multimedia/elisa/-/merge_requests/208 is pending review
with a fix for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431245] Elisa doesn't see mp3, m4a, or FLAC files on Windows

2021-01-10 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431245

--- Comment #4 from Matthieu Gallien  ---
Thanks for the confirmation. The fixed version is still waiting in the upload
queue of the Microsoft Store. I will close the bug once the fixed version is
available.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428218] Elisa crashes when trying to play or enqueue mp4 files

2021-01-10 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428218

--- Comment #3 from Matthieu Gallien  ---
Thanks for your report.

Sorry for the delay.

A fix under review is available in the associated merge request.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431245] Elisa doesn't see mp3, m4a, or FLAC files on Windows

2021-01-08 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431245

--- Comment #2 from Matthieu Gallien  ---
A fixed version is being uploaded to Microsoft Store.

You can also test the fixed version from the latest build from
https://binary-factory.kde.org/view/Windows%2064-bit/job/Elisa_Release_win64/

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 431245] Elisa doesn't see mp3, m4a, or FLAC files on Windows

2021-01-07 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=431245

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report.

I have noticed that a few days ago and I am actively working on it.

Hopefully a fix will be available soon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 409587] Many inotify_add_watch errors starting Elisa

2021-01-06 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=409587

--- Comment #4 from Matthieu Gallien  ---
Git commit 662f88b78a7ee3bef27e584b00ad3ca3c300cf62 by Matthieu Gallien.
Committed on 06/01/2021 at 17:00.
Pushed by mgallien into branch 'release/20.12'.

use a QFlags to handle entities to watch for file system changes

use separate enum values for watching changes to directories or files

by default do like before

M  +22   -14   src/abstractfile/abstractfilelisting.cpp
M  +12   -4src/abstractfile/abstractfilelisting.h
M  +6-6src/baloo/localbaloofilelisting.cpp
M  +1-1src/baloo/localbaloofilelisting.h
M  +2-3src/file/localfilelisting.cpp
M  +1-1src/file/localfilelisting.h

https://invent.kde.org/multimedia/elisa/commit/662f88b78a7ee3bef27e584b00ad3ca3c300cf62

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 430233] Please consider ReplayGain tags

2020-12-10 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=430233

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report.

I have started a MR long time ago. I had never enough time to finish it and it
looked a bit hackish.

https://invent.kde.org/multimedia/elisa/-/merge_requests/5

It would be cool to get a stable and working support for this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429465] Pressing on "+" or "play" at a folder does nothing

2020-12-07 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429465

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/710275f
   ||d7f7efc977f542f59061a0599a0
   ||89b8e7
 Status|CONFIRMED   |RESOLVED

--- Comment #2 from Matthieu Gallien  ---
Git commit 710275fd7f7efc977f542f59061a0599a089b8e7 by Matthieu Gallien.
Committed on 07/12/2020 at 22:38.
Pushed by ngraham into branch 'release/20.12'.

properly enqueue files from file browser to playlist

M  +21   -2src/models/filebrowserproxymodel.cpp

https://invent.kde.org/multimedia/elisa/commit/710275fd7f7efc977f542f59061a0599a089b8e7

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428957] Elisa constantly emitting org.mpris.MediaPlayer2.Player.Seeked

2020-12-07 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428957

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/8315d92
   ||e3add2e6f8db0b0f6bccfb1f98c
   ||0f9515
 Resolution|--- |FIXED

--- Comment #6 from Matthieu Gallien  ---
Git commit 8315d92e3add2e6f8db0b0f6bccfb1f98c0f9515 by Matthieu Gallien.
Committed on 05/12/2020 at 17:34.
Pushed by ngraham into branch 'release/20.12'.

emit Seeked on MPRIS2 interface when player really seeked

M  +7-2src/mpris2/mediaplayer2player.cpp
M  +2-0src/mpris2/mediaplayer2player.h
M  +1-1src/qml/ElisaMainWindow.qml

https://invent.kde.org/multimedia/elisa/commit/8315d92e3add2e6f8db0b0f6bccfb1f98c0f9515

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429942] Feature request: Enable selecting artists or albums from the playlist

2020-12-02 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429942

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Matthieu Gallien  ---
Hello,

Thanks for your report. This is a nice idea.

I believe I can speak not only for me but I would like to get more power
features in Elisa like smart play list or better search and more configurable
views.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-11-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421662

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |NEEDSINFO

--- Comment #17 from Matthieu Gallien  ---
I cannot reproduce this.

I suspect this is because powerdevil is able to handle the application
disappearance even when an inhibition exists. That would be logic because in
case of a crash, you obviously do not want the inhibition to outlive the
crashed application.

I have confirmed that the proposed patch allow to get the uninhibition request
to be emitted. I have used Bustle.

Are you still able to reproduce that bug ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 408295] After starting Elisa, first song played starts in the middle if a song was paused the last time Elisa was quit

2020-11-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=408295

Matthieu Gallien  changed:

   What|Removed |Added

   Version Fixed In||20.12

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 408295] After starting Elisa, first song played starts in the middle if a song was paused the last time Elisa was quit

2020-11-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=408295

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/30f23ab
   ||531c7bbee8b8aaec2b8311f0217
   ||bd53cc

--- Comment #6 from Matthieu Gallien  ---
Git commit 30f23ab531c7bbee8b8aaec2b8311f0217bd53cc by Matthieu Gallien.
Committed on 18/11/2020 at 13:31.
Pushed by ngraham into branch 'release/20.12'.

forget the saved position withing a track when switching to another one

fix wrong initial position at startup if previous session had pause set
and was playing a different track

M  +2-0src/audiowrapper_libvlc.cpp

https://invent.kde.org/multimedia/elisa/commit/30f23ab531c7bbee8b8aaec2b8311f0217bd53cc

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429039] Setting play count does not work

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429039

Matthieu Gallien  changed:

   What|Removed |Added

   Version Fixed In||20.12

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429039] Setting play count does not work

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429039

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/e754656
   ||0c3c1608a42745ad36b5196d5e2
   ||af7864

--- Comment #4 from Matthieu Gallien  ---
Git commit e7546560c3c1608a42745ad36b5196d5e2af7864 by Matthieu Gallien.
Committed on 17/11/2020 at 20:41.
Pushed by mgallien into branch 'release/20.12'.

use a role of the model to also choose the correct delegate for metadata

M  +35   -23   src/qml/MediaTrackMetadataView.qml

https://invent.kde.org/multimedia/elisa/commit/e7546560c3c1608a42745ad36b5196d5e2af7864

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 408295] After starting Elisa, first song played starts in the middle if a song was paused the last time Elisa was quit

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=408295

--- Comment #4 from Matthieu Gallien  ---
Thanks for the detailed instructions to reproduce this.

I will work on a fix. I can easily reproduce it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429036] Track ordering in Album view is messed up

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429036

--- Comment #2 from Matthieu Gallien  ---
I do not reproduce the bug in itself but I am getting lots of warnings in the
console.

qrc:/qml/ListBrowserView.qml:170: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:170: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:170: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined
qrc:/qml/ListBrowserView.qml:0: ReferenceError: viewModeView is not defined


Do you also see them ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429039] Setting play count does not work

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429039

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Matthieu Gallien  ---
This was not intended as being modifiable by the user (at least as a first
step).

This is the same for the other statistics related fields like (first play date,
last play date, play frequency).

As a second step, we should again have a look at the possibility to save that
in the music files. In this case, we should allow editing by the user.

Do you agree with this plan ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429041] Editing any metadata for a file that has embedded album art causes the album art to temporarily disappear

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429041

Matthieu Gallien  changed:

   What|Removed |Added

   Version Fixed In||20.12

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429041] Editing any metadata for a file that has embedded album art causes the album art to temporarily disappear

2020-11-17 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429041

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/7f5e543
   ||6491ce58474e866ea7aba7dadee
   ||cbf303
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Matthieu Gallien  ---
Git commit 7f5e5436491ce58474e866ea7aba7dadeecbf303 by Matthieu Gallien.
Committed on 17/11/2020 at 07:52.
Pushed by mgallien into branch 'release/20.12'.

fix modification of tracks with embedded covers

do not "loose" the embedded cover when modifying a track with an
embedded cover

M  +99   -0autotests/databaseinterfacetest.cpp
M  +2-2src/databaseinterface.cpp

https://invent.kde.org/multimedia/elisa/commit/7f5e5436491ce58474e866ea7aba7dadeecbf303

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429041] Editing any metadata for a file that has embedded album art causes the album art to temporarily disappear

2020-11-15 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429041

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 429041] Editing any metadata for a file that has embedded album art causes the album art to temporarily disappear

2020-11-15 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=429041

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Matthieu Gallien  ---
I can reproduce and will work on a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 406472] Edit metadata from within Elisa

2020-11-12 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=406472

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/9c83b85
   ||33c730ddb90ad3f62e73bd0d9db
   ||d05bd5

--- Comment #6 from Matthieu Gallien  ---
Git commit 9c83b8533c730ddb90ad3f62e73bd0d9dbd05bd5 by Matthieu Gallien.
Committed on 12/11/2020 at 22:08.
Pushed by mgallien into branch 'release/20.12'.

make MediaTrackMetadataView able to modify metadata for tracks

only preliminary implementation

the model is not yet able to modify anything else apart from radios

M  +85   -0src/models/trackmetadatamodel.cpp
M  +1-0src/models/trackmetadatamodel.h
M  +2-4src/qml/DataListView.qml
M  +51   -9src/qml/EditableMetaDataDelegate.qml
M  +0-1src/qml/GridBrowserDelegate.qml
M  +20   -8src/qml/MediaTrackMetadataView.qml
M  +20   -14   src/qml/MetaDataDelegate.qml
M  +0-1src/qml/PlayListEntry.qml

https://invent.kde.org/multimedia/elisa/commit/9c83b8533c730ddb90ad3f62e73bd0d9dbd05bd5

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 427967] Support fast scrolling by holding shift key while scrolling

2020-11-12 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=427967

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/3b80b00
   ||01239f8c6a35f95ff940e6ba596
   ||075310
 Resolution|--- |FIXED
   Version Fixed In||20.12

--- Comment #4 from Matthieu Gallien  ---
Git commit 3b80b0001239f8c6a35f95ff940e6ba596075310 by Matthieu Gallien, on
behalf of Nate Graham.
Committed on 12/11/2020 at 20:49.
Pushed by mgallien into branch 'release/20.12'.

Replace homemade ScrollHelper with standard ScrollViews to hold view items

We created the ScrollHelper component to fix scrolling with touchpads,
which is quite terrible out of the box with QML's default flickables.

However this solution had some drawbacks:

- It broke touch scrolling
- It broke fast scrolling by holding down the shift key while scrolling
- It essentially re-wrote scroll handling locally, which is fragile
- It required a bunch of extra code to handle scrollbar visibility which
  introduced various minor visual bugs in a few places

In addition, this solution was not necessary since we can get the
same result by putting views inside ScrollView components, which is a
100% supported and standard paradigm. Doing so preserves the nice
touchpad scrolling we already have but fixes all of the above items
automatically.
Related: bug 417859
FIXED-IN: 20.12

M  +0-1src/CMakeLists.txt
M  +23   -31   src/qml/GridBrowserView.qml
M  +28   -36   src/qml/ListBrowserView.qml
M  +18   -26   src/qml/MediaTrackMetadataView.qml
M  +113  -120  src/qml/PlayListBasicView.qml
M  +0-3src/qml/PlayListEntry.qml
D  +0-105  src/qml/ScrollHelper.qml
M  +80   -82   src/qml/SimplePlayListView.qml
M  +36   -52   src/qml/ViewSelector.qml
M  +0-1src/resources.qrc

https://invent.kde.org/multimedia/elisa/commit/3b80b0001239f8c6a35f95ff940e6ba596075310

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 417859] Add touch scrolling to main pane

2020-11-12 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=417859

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/3b80b00
   ||01239f8c6a35f95ff940e6ba596
   ||075310
   Version Fixed In||20.12
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Matthieu Gallien  ---
Git commit 3b80b0001239f8c6a35f95ff940e6ba596075310 by Matthieu Gallien, on
behalf of Nate Graham.
Committed on 12/11/2020 at 20:49.
Pushed by mgallien into branch 'release/20.12'.

Replace homemade ScrollHelper with standard ScrollViews to hold view items

We created the ScrollHelper component to fix scrolling with touchpads,
which is quite terrible out of the box with QML's default flickables.

However this solution had some drawbacks:

- It broke touch scrolling
- It broke fast scrolling by holding down the shift key while scrolling
- It essentially re-wrote scroll handling locally, which is fragile
- It required a bunch of extra code to handle scrollbar visibility which
  introduced various minor visual bugs in a few places

In addition, this solution was not necessary since we can get the
same result by putting views inside ScrollView components, which is a
100% supported and standard paradigm. Doing so preserves the nice
touchpad scrolling we already have but fixes all of the above items
automatically.
Related: bug 427967
FIXED-IN: 20.12

M  +0-1src/CMakeLists.txt
M  +23   -31   src/qml/GridBrowserView.qml
M  +28   -36   src/qml/ListBrowserView.qml
M  +18   -26   src/qml/MediaTrackMetadataView.qml
M  +113  -120  src/qml/PlayListBasicView.qml
M  +0-3src/qml/PlayListEntry.qml
D  +0-105  src/qml/ScrollHelper.qml
M  +80   -82   src/qml/SimplePlayListView.qml
M  +36   -52   src/qml/ViewSelector.qml
M  +0-1src/resources.qrc

https://invent.kde.org/multimedia/elisa/commit/3b80b0001239f8c6a35f95ff940e6ba596075310

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428957] Elisa constantly emitting org.mpris.MediaPlayer2.Player.Seeked

2020-11-11 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428957

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Matthieu Gallien  ---
Thanks for the report.

I thought that was fixed. I will have a look during the next days.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428833] Please make the song play with a double click

2020-11-09 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428833

--- Comment #4 from Matthieu Gallien  ---
Thanks for your feedback.

I have a quite different opinion. I think that a music player is dedicated to
manage the playlist. That should show what tracks have been played and will be
played next.

This is one thing I regret from Amarok (i.e. the smart playlists).

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428833] Please make the song play with a double click

2020-11-09 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428833

--- Comment #2 from Matthieu Gallien  ---
That is probably doable. It seems like accidental clearing of the playlist
should not be a problem because we have undo.

Personally, I believe I would prefer enqueue and immediate play. Clearing the
playlist does not seem expected to me.

Anyway, this is not a big deal for me as I do not use double click on tracks.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 418800] Elisa does not show some random cover arts

2020-11-02 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=418800

--- Comment #14 from Matthieu Gallien  ---
Ongoing work on KFileMetaData, the KF5 framework used by Elisa to read the
embedded cover image, will allow to fix this bug within Elisa. That will
require (not yet released) version 5.75 of frameworks and a version of Elisa
with the modified code.

I will keep this bug report in touch with the progress.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428510] Elisa never opens maximized on Wayland

2020-10-31 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428510

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #2 from Matthieu Gallien  ---
I can confirm that I can reproduce this.

It is also the case when running on Windows platform.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428510] Elisa never opens maximized on Wayland

2020-10-31 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428510

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report. I now have a working Plasma Wayland setup. I will have
a look today.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428185] Elisa crashed while browsing multiple local files

2020-10-25 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428185

--- Comment #3 from Matthieu Gallien  ---
Thanks for the backtrace but it is missing symbols info. Please have a look at
https://community.kde.org/Guidelines_and_HOWTOs/Debugging/How_to_create_useful_crash_reports

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 428185] Elisa crashed while browsing multiple local files

2020-10-24 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=428185

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report. Could you please send a backtrace of the crash?

As is, we cannot analyze your report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 427289] "Now Playing" page says "Nothing playing" while Elisa plays certain files

2020-10-11 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=427289

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/36fcaa2
   ||be6bbffba55f2b36e1c10caa0fd
   ||f568aa
 Resolution|--- |FIXED

--- Comment #4 from Matthieu Gallien  ---
Git commit 36fcaa2be6bbffba55f2b36e1c10caa0fdf568aa by Matthieu Gallien, on
behalf of Fabian Baumanis.
Committed on 11/10/2020 at 17:34.
Pushed by mgallien into branch 'master'.

Fix "Nothing played" message when a file only with a title tag is played

M  +1-0src/qml/ContextView.qml

https://invent.kde.org/multimedia/elisa/commit/36fcaa2be6bbffba55f2b36e1c10caa0fdf568aa

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 418003] Improve ease of adding multiple radio stations

2020-09-26 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=418003

--- Comment #2 from Matthieu Gallien  ---
(In reply to hsnnsnc from comment #1)
> Hello there,
> 
> Nobody is interested or nobody is listening to the radio in Elisa :)

We are quite busy with real life or with other tasks.

You could try to do it. It could be relatively easy and you will scratch your
own itch. The feeling of getting a contribution in will be very rewarding.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 426781] wish lyrics could be displayed while playing

2020-09-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=426781

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Matthieu Gallien  ---
Current stable version of Elisa (20.08.1) is already able to display lyrics
embedded as metadata inside audio files.

Could you please test this version (for example via Flathub
https://flathub.org/apps/details/org.kde.elisa) ?

I would like to know if you really need more.

The ability to use web services to fetch metadata about audio files is planned
but not yet started. In this case, lyrics support will be added.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 426781] wish lyrics could be displayed while playing

2020-09-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=426781

--- Comment #2 from Matthieu Gallien  ---
And by the way, thanks for your report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 425940] Elisa crashes on launch on Kubuntu 20.04

2020-09-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=425940

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from Matthieu Gallien  ---


*** This bug has been marked as a duplicate of bug 425112 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 425112] the application crashed

2020-09-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=425112

Matthieu Gallien  changed:

   What|Removed |Added

 CC||caio...@gmail.com

--- Comment #2 from Matthieu Gallien  ---
*** Bug 425940 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424393] Elisa trips Qt assertion when scrolling through album view

2020-09-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424393

Matthieu Gallien  changed:

   What|Removed |Added

 CC||karl.deso...@gmail.com

--- Comment #1 from Matthieu Gallien  ---
*** Bug 424518 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424518] Elisa crashed when scrolling Album list

2020-09-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424518

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Matthieu Gallien  ---


*** This bug has been marked as a duplicate of bug 424393 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 418800] Elisa does not show some random cover arts

2020-09-20 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=418800

--- Comment #13 from Matthieu Gallien  ---
(In reply to FlyingWaffle from comment #11)
> I had encountered the same issue on my Gentoo machine just recently and I
> think I've figured out what is going on.  When I checked my tags using Kid3
> I realized that all of my albums that were not showing artwork had the cover
> art tagged as "Picture" (with 'other' on the dropdown).  After editing the
> tags on all the affected albums to "Picture: Cover (front)", refreshing my
> collection, and restarting Elisa everything works as expected and all my
> album art shows up!
> 
> So Elisa seems to look for album art specifically tagged as "Picture: Cover
> (front)" and ignores everything else.

Thanks a lot for your analysis work.

Sorry for the delay in taking into account your message. I will try to have a
look this week at fixing that. I cannot promise I will manage to do it but will
do my best.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424891] elisa crashed when closed during playback

2020-09-12 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424891

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #1 from Matthieu Gallien  ---
Thanks for the report.

Looks like I can regularly reproduce a crash inside libvlc when stopping the
application while a music is playing.

As far as I can say, this should confirm what you reported.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424932] elisa 20.08 RC reports version as 20.7.90 instead of 20.07.90

2020-09-11 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424932

Matthieu Gallien  changed:

   What|Removed |Added

  Latest Commit|https://invent.kde.org/mult |https://invent.kde.org/mult
   |imedia/elisa/commit/ba84a54 |imedia/elisa/commit/bcc25fc
   |fe00b841499578883e1f533bb34 |51cded5b91b382501bd142a33ee
   |b7888a  |c6a9c5

--- Comment #3 from Matthieu Gallien  ---
Git commit bcc25fc51cded5b91b382501bd142a33eec6a9c5 by Matthieu Gallien, on
behalf of Aurélien COUDERC.
Committed on 11/09/2020 at 20:27.
Pushed by mgallien into branch 'release/20.08'.

Fix incorrect version display in about dialog

(cherry picked from commit 97ae90fcbf14e071b0bc4168ff4d6cbbffd88384)

M  +1-1CMakeLists.txt

https://invent.kde.org/multimedia/elisa/commit/bcc25fc51cded5b91b382501bd142a33eec6a9c5

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424932] elisa 20.08 RC reports version as 20.7.90 instead of 20.07.90

2020-09-11 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424932

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/ba84a54
   ||fe00b841499578883e1f533bb34
   ||b7888a
 Resolution|--- |FIXED

--- Comment #2 from Matthieu Gallien  ---
Git commit ba84a54fe00b841499578883e1f533bb34b7888a by Matthieu Gallien, on
behalf of Aurélien COUDERC.
Committed on 11/09/2020 at 20:25.
Pushed by mgallien into branch 'aureliencouderc/master'.

Fix incorrect version display in about dialog

M  +1-1CMakeLists.txt

https://invent.kde.org/multimedia/elisa/commit/ba84a54fe00b841499578883e1f533bb34b7888a

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 426067] Same song plays twice back-to-back when shuffling

2020-09-08 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=426067

--- Comment #3 from Matthieu Gallien  ---
(In reply to PRIZ ;] from comment #2)
> Where can I download the 20.08 version? It doesn't appear in APT.

You could test the 20.08.1 version through the use of Flatpak. See
https://flathub.org/apps/details/org.kde.elisa .

Apart from that, it is likely Kubuntu might not update the version for your
version (20.04). You can always use Kubuntu support channels to ask for
confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 406467] Option to sort artists' albums by year

2020-09-07 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=406467

--- Comment #8 from Matthieu Gallien  ---
(In reply to Matthieu Gallien from comment #7)
> https://invent.kde.org/multimedia/elisa/-/merge_requests/130 is ready for a
> new review round.
> 
> Sort by year is implemented in all views showing tracks and albums.

This MR has been closed. The devs where a dead end.

Following what I have learnt, I am working on
https://invent.kde.org/multimedia/elisa/-/merge_requests/162 .

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 426067] Same song plays twice back-to-back when shuffling

2020-09-03 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=426067

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|REPORTED|RESOLVED

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report. The 20.08 version has a much improved shuffle mode
where this problem is fixed. A new song can be played only once in a row in
shuffle mode.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 425939] master branch fails with error class 'ElisaApplicationPrivate’ has no member named ‘mCollection’

2020-08-29 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=425939

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED

--- Comment #4 from Matthieu Gallien  ---
Thanks for the information.

Elisa is failing to build without KF5 XmlGui framework. I will see what I can
do (either make it mandatory or fix the build issue).

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 425939] master branch fails with error class 'ElisaApplicationPrivate’ has no member named ‘mCollection’

2020-08-29 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=425939

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report.

Please can you check if KXmlGui has been detected when executing CMake ?

It looks like we have an optional dependency on KXmlGui and that without it
compilation is failing.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 423007] Elisa doesn't play file opened via Dolphin

2020-08-03 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=423007

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/fd8e11b
   ||93f5ab047f05c3f56ade632a099
   ||589b91

--- Comment #7 from Matthieu Gallien  ---
Git commit fd8e11b93f5ab047f05c3f56ade632a099589b91 by Matthieu Gallien.
Committed on 02/08/2020 at 21:56.
Pushed by mgallien into branch 'release/20.08'.

fix enqueue from program arguments (for example from Doplhin)

M  +3-3src/elisaapplication.cpp

https://invent.kde.org/multimedia/elisa/commit/fd8e11b93f5ab047f05c3f56ade632a099589b91

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 423007] Elisa doesn't play file opened via Dolphin

2020-07-31 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=423007

--- Comment #6 from Matthieu Gallien  ---
(In reply to Patrick Silva from comment #5)
> I have applied your patch to 20.08 branch.
> The bug persists.

Thanks for the test.
Sorry for the breakage.

I will fix that MR.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 423007] Elisa doesn't play file opened via Dolphin

2020-07-29 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=423007

--- Comment #4 from Matthieu Gallien  ---
(In reply to Bug Janitor Service from comment #3)
> A possibly relevant merge request was started @
> https://invent.kde.org/multimedia/elisa/-/merge_requests/140

It would be nice if you can confirm that this MR fixes your bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424276] Album covers have horrible downscaling artifacts unless folder.jpg is present

2020-07-28 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424276

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/mult
   ||imedia/elisa/commit/85c3e04
   ||acf58bc97ad73f1f2c227c0f868
   ||c55d03
 Status|CONFIRMED   |RESOLVED

--- Comment #7 from Matthieu Gallien  ---
Git commit 85c3e04acf58bc97ad73f1f2c227c0f868c55d03 by Matthieu Gallien.
Committed on 28/07/2020 at 16:01.
Pushed by mgallien into branch 'release/20.08'.

fix image provider to scale images to requested size with good quality

M  +12   -0src/embeddedcoverageimageprovider.cpp

https://invent.kde.org/multimedia/elisa/commit/85c3e04acf58bc97ad73f1f2c227c0f868c55d03

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 423007] Elisa doesn't play file opened via Dolphin

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=423007

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Matthieu Gallien  ---
I will work on this one.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424276] Album covers have horrible downscaling artifacts unless folder.jpg is present

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424276

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

--- Comment #6 from Matthieu Gallien  ---
I am working on a fix.(In reply to Bug Janitor Service from comment #5)
> A possibly relevant merge request was started @
> https://invent.kde.org/multimedia/elisa/-/merge_requests/139

It would be very nice if you are able to test this possible fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424276] Album covers have horrible downscaling artifacts unless folder.jpg is present

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424276

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #4 from Matthieu Gallien  ---
I am working on a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424154

Matthieu Gallien  changed:

   What|Removed |Added

 Status|ASSIGNED|CONFIRMED

--- Comment #3 from Matthieu Gallien  ---
(In reply to Nate Graham from comment #1)
> Yep, I just noticed this. The background is also misplaced, which seems to
> be related.
> 
> We should fix this before 20.08 ships.

I am not sure I understand the problem with respect to the background.

The fact that the active zone of the slider extends to the full height looks
like a deliberate choice made in https://phabricator.kde.org/D22951 . We have
to decide if we want to keep the easy usage of if we want to revert those
changes.

I can confirm that reverting the changes indeed solves the issue here.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424154] Track progress and volume sliders can be moved by clicking outside of them

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424154

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #2 from Matthieu Gallien  ---
I will work on this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424517] Cannot play files from SMB Share

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424517

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report.

Your first step cannot be solved for the next release because that would need
adding a new error message for invalid paths. Elisa is not supporting smb://
paths right now. This is a feature request.

Your second step might work if the music backend of Elisa is supporting smb://
paths itself and the file path is handled correctly. I will see if this can be
fixed for next release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424621] Não carrega lista de músicas

2020-07-27 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424621

Matthieu Gallien  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report but unfortunately, I can only understand English and
French.

Could you please translate into English ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424479] elisa uses internet without user permissions

2020-07-21 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424479

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #1 from Matthieu Gallien  ---
Elisa is not accessing internet but your local files.

Elisa is using your standard music directory by default instead of asking the
user to configure something. That will not change.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424267] Library disappears and nothing can be found when scanning

2020-07-16 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424267

--- Comment #3 from Matthieu Gallien  ---
Could you please run Elisa with the environment variable (is there a graphical
way to configure that ?):

export
QT_LOGGING_RULES="org.kde.elisa.baloo=true;org.kde.elisa.indexer=true;org.kde.elisa.indexers.manager=true;org.kde.elisa.database=true"

Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424276] Album covers have horrible downscaling artifacts unless folder.jpg is present

2020-07-16 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424276

--- Comment #1 from Matthieu Gallien  ---
Thanks for your report.

There may be an issue with the cover image provider. I will have a look in a
few days and will update the bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 424267] Library disappears and nothing can be found when scanning

2020-07-16 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=424267

--- Comment #2 from Matthieu Gallien  ---
I will have a look at this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 422507] Grouping of multi-disk albums

2020-07-13 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=422507

--- Comment #10 from Matthieu Gallien  ---
(In reply to Till Schäfer from comment #7)
> Created attachment 130082 [details]
> vorbis tag dump of example album
> 
> I have attached the metaflac output of an example album: 
> 
> metaflac --list --block-type VORBIS_COMMENT */*.flac
> 
> Full folder/file structure:
> 
> $ tree .
> .
> ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> ├── CD 01
> │   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> │   ├── 01 - Etnica - The Gilis Voyage.flac
> │   ├── 02 - Etnica - Infinitive Dream.flac
> │   ├── 03 - Etnica - The Gilis Voyage (Ketu Remix).flac
> │   ├── 04 - Etnica - Vickys Dream.flac
> │   ├── 05 - Etnica - Moon Influence.flac
> │   ├── 06 - Etnica - Spheric Koncept.flac
> │   ├── 07 - Etnica - Mystical Apperance In Goa.flac
> │   ├── 08 - Etnica - A Tribute To Goa.flac
> │   ├── 09 - Etnica - Intense Visitation (Visitation Of Energy Mix).flac
> │   └── folder.jpg
> ├── CD 02
> │   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> │   ├── 01 - Etnica - The Gili's Voyage (Early Mix).flac
> │   ├── 02 - Etnica - Mystical Apperance In Goa (Remix).flac
> │   ├── 03 - Etnica - Asian Code 7.flac
> │   ├── 04 - Etnica - Still Botta.flac
> │   ├── 05 - Evolution - Alien Phenomenon.flac
> │   ├── 06 - Etnica - Synthesis (Shadow Of The Moog).flac
> │   ├── 07 - Etnica - Fractal Gates.flac
> │   ├── 08 - Etnica - Acid Shell.flac
> │   ├── 09 - Etnica - Chemical Trance (Original Mix).flac
> │   └── folder.jpg
> ├── CD 03
> │   ├── 00 - Etnica - The Juggeling Alchemists Under The Black Light.m3u
> │   ├── 01 - Etnica - Fingers.flac
> │   ├── 02 - Etnica - Gollum.flac
> │   ├── 03 - Etnica - Big Dust In Chapora For.flac
> │   ├── 04 - Etnica - Whale.flac
> │   ├── 05 - Etnica - Bali Island.flac
> │   ├── 06 - Etnica - 38 Parallelo.flac
> │   ├── 07 - Etnica - Pacific Love.flac
> │   ├── 08 - Etnica - J.H. Sound.flac
> │   ├── 09 - Tribe - Gilligans Island.flac
> │   ├── 10 - Etnica - Evolis.flac
> │   ├── 11 - Etnica - Big Dust In Chapora Fort (Piano Remix).flac
> │   └── folder.jpg
> ├── folder.jpg
> └── guideline_1.6.txt

This is not currently supported. What is supported is the case where all discs
are in the same directory. An evolution of the file indexer will be needed.
Would you like to try to do it yourself?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 406467] Option to sort artists' albums by year

2020-06-23 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=406467

--- Comment #7 from Matthieu Gallien  ---
https://invent.kde.org/multimedia/elisa/-/merge_requests/130 is ready for a new
review round.

Sort by year is implemented in all views showing tracks and albums.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421662

Matthieu Gallien  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---

--- Comment #14 from Matthieu Gallien  ---
(In reply to Gabriel Marcano from comment #13)
> I'd love to take a stab, but I can't do it for the next month and a half, as
> my employer limits what code I can contribute (intellectual property
> assignment clause in contract). I'm actually leaving for grad school in
> August, so I should be able to get around to trying this out around then, if
> no one has figured this out.
> 
> Once bug 423131 is fixed, arguably the importance of this bug should drop to
> minor, as powerdevil should be handling elisa exiting itself. I'd argue we
> still should have elisa emit an Uninhibit request even if in theory
> powerdevil will do it.
> 
> I don't know if Gnome's session implementation is similar or not to
> Plasma's, so I don't know if they handle undoing all inhibits of
> applications that exit automatically.

Thanks for your work so far. This is really a good contribution.

I will try to have a look at solving the Elisa problem as soon as I finish
integrating the few MR I am working on. That should be in few weeks.

I still have Gnome on my laptop. I should be able to test again and see what
happen.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421662] Elisa does not release PowerManagement inhibitions on exit if it's playing when exited

2020-06-18 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421662

--- Comment #12 from Matthieu Gallien  ---
(In reply to Gabriel Marcano from comment #11)
> In terms of what could be done by elise, I'm not too sure as I'm not
> familiar with the entire codebase, but maybe we could install a custom
> handler for "file_quit" that somehow  tells the AudioWrapper to stop playing
> before killing the application? That should get the underlying code of
> AudioWrapper to call setPreventSleep (at least both implementations of the
> AudioWrapper interface do this).

Thanks for your work on this subject.

If you want, you can try to provide a fix for it by using invent.kde.org Gitlab
KDE instance. We will make sure to provide you help to get this integrated.

The possibly easiest way is to get this done from a slot connected to void
QCoreApplication::aboutToQuit() signal.

We are already saving the window geometry in this way
(src/qml/ElisaMainWindow.qml:61).

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 406467] Option to sort artists' albums by year

2020-06-13 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=406467

Matthieu Gallien  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #6 from Matthieu Gallien  ---
I have started to work on that. This is far from done but I will work on this
during the next days.

https://invent.kde.org/multimedia/elisa/-/merge_requests/130

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421522] Elisa preventing Plasma from properly locking screen after passed time out

2020-05-15 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421522

--- Comment #5 from Matthieu Gallien  ---
This is probably related to bug 418433.

I genuinely ignore if the application is responsible for that or the workspace.

I will have to dig that.

If somebody can beat me at that, it would be nice because the code modification
is probably minimal but finding what to do is the complex part here.

You can add to that the needed support for other workspace than KDE Plasma
(currently we support Windows, GNOME 3 and Plasma 5).

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421522] Elisa preventing Plasma from properly locking screen after passed time out

2020-05-15 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421522

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|1   |0
 Status|CONFIRMED   |REPORTED

--- Comment #4 from Matthieu Gallien  ---
(In reply to tneo from comment #3)
> I can test once it is available through openSUSE repo's. However based upon
> your description for the fix, I wonder it will fix this issue.

I was completely confused when looking at your report. You are true. Sorry for
that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421522] Elisa preventing Plasma from properly locking screen after passed time out

2020-05-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421522

--- Comment #2 from Matthieu Gallien  ---
https://invent.kde.org/kde/elisa/-/merge_requests/124 has a possible fix under
review for this issue.

Can you test it ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 421522] Elisa preventing Plasma from properly locking screen after passed time out

2020-05-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=421522

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Matthieu Gallien  ---
I can confirm that.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 406467] Option to sort artists' albums by year

2020-05-12 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=406467

--- Comment #4 from Matthieu Gallien  ---
Sorry, I am kinda late on this. I am trying to clean a lot of old code that is
hard to maintain and evolve.

My hope is that I can get flexible views that can be configured by the use to
do whatever is needed.

I suppose that will need some work on a configuration UI. Do you have any
suggestions ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 420895] Files view rooted at $HOME; cannot be used to browse alternative locations

2020-05-11 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=420895

--- Comment #8 from Matthieu Gallien  ---
(In reply to Nate Graham from comment #7)
> Thanks, that's very helpful. I can reproduce now. Marking as high priority
> since this makes the files view largely useless for the typical purpose of
> browsing to find music *not* in the location where you've configured your
> library (e.g. a flash drive, intermittently-available network share, etc).

I had planned to fix that as part of
https://invent.kde.org/kde/elisa/-/merge_requests/121 but I do not know what to
do UI wise.

Do you have suggestions ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 417468] The right part of elisa shows gibberish chars (maybe GB2312 encoding problem )

2020-04-14 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=417468

--- Comment #10 from Matthieu Gallien  ---
(In reply to Christoph Feck from comment #9)
> New information was added; changing status for inspection. If this is an
> issue in a lower level framework (e.g. KFileMetadata), please reassign.

I am not sure what we can do about that.

Is there a generic way to notify the maintainer of KFileMetaData for advice on
this (and without reassigning) ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 419331] Resume every track from the previous position (of a different track)

2020-04-05 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=419331

Matthieu Gallien  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED

--- Comment #3 from Matthieu Gallien  ---
I have just reproduced it by accident.

I will have a look at it in the near future but might be unable to fix it for
the next stable release.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 419145] Hamburger menu opens in the upper left corner of the screen when Elisa is closed while "Keep running in system tray when main window is closed" feature is enabled

2020-03-31 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=419145

--- Comment #6 from Matthieu Gallien  ---
https://invent.kde.org/kde/elisa/-/merge_requests/113 with a workaround that
should avoid the menu showing when it should not.

-- 
You are receiving this mail because:
You are watching all bug changes.

[elisa] [Bug 419163] System Tray has no context menu

2020-03-31 Thread Matthieu Gallien
https://bugs.kde.org/show_bug.cgi?id=419163

Matthieu Gallien  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Matthieu Gallien  ---
Which Qt version are you using ?

It looks like that could explain why I am seeing a different result from you.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   >