[yakuake] [Bug 360037] KF5 yakuake sometimes gets detached and shows up in the task manager

2021-05-18 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=360037

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit|https://commits.kde.org/yak |https://invent.kde.org/util
   |uake/1071c021ae7507140d2a6f |ities/yakuake/commit/9202df
   |8dd97251841bb3a922  |97322ae2f58104e387e914de15b
   ||06644ff
 Status|ASSIGNED|RESOLVED

--- Comment #29 from Maximilian Schiller  ---
Git commit 9202df97322ae2f58104e387e914de15b06644ff by Maximilian Schiller, on
behalf of Bharadwaj Raju.
Committed on 18/05/2021 at 15:14.
Pushed by mschiller into branch 'master'.

Fix Yakuake icon appearing in taskbar through Qt::Tool window flag

So far we've been setting _NET_WM_STATE_SKIP_TASKBAR ourselves, but
Qt messes with this, leading to race conditions where it still
appears in the taskbar. This sets the Qt::Tool window flag, which
will set it via Qt itself, and won't be clobbered. An old hack has
been removed, as it isn't needed anymore.

Also makes show animation match retract animation.

M  +1-20   app/mainwindow.cpp
M  +0-1app/mainwindow.h

https://invent.kde.org/utilities/yakuake/commit/9202df97322ae2f58104e387e914de15b06644ff

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 430796] Broken link for About KDE

2021-01-07 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=430796

Maximilian Schiller  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/fram
   ||eworks/kxmlgui/commit/f0f8d
   ||cfe0be814418b9cb4d1f799c828
   ||60e9115f
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Maximilian Schiller  ---
Git commit f0f8dcfe0be814418b9cb4d1f799c82860e9115f by Maximilian Schiller.
Committed on 07/01/2021 at 18:03.
Pushed by mschiller into branch 'master'.

Use the correct kde get involved url

The about kde dialog points to an outdated get involved url.

M  +1-1src/kaboutkdedialog_p.cpp

https://invent.kde.org/frameworks/kxmlgui/commit/f0f8dcfe0be814418b9cb4d1f799c82860e9115f

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 414049] Yakuake window can be maximised with keyboard shortcut, then stays maximised

2020-08-22 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=414049

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #5 from Maximilian Schiller  ---
Yeah, this is (kinda) fixed in 20.08. I didn't add the fix to the 20.04 release
because 20.04.03 was the last bugfix release.

See https://bugs.kde.org/show_bug.cgi?id=424286
and the fix https://invent.kde.org/utilities/yakuake/-/merge_requests/26

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 425384] Yakuake jumps between displays since 20.08.0

2020-08-15 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=425384

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #1 from Maximilian Schiller  ---
Can you provide your window settings and also try to reset them.

This might be related to the display scaling which I cant test right now. If
possible could you test it without the scaling?

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424851] yakuake override panel.

2020-08-02 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424851

--- Comment #3 from Maximilian Schiller  ---
Alright, then I'm going to need a little more information.

- Wayland or Xorg?
- Can you reproduce it consistently and without any other programs open (check
your autostart)
- is this "old" panel functional?
- could you provide the system information from kinfocenter

I've seen the exact behavior like this before and the reason was a disabled
compositor. There is also a shortcut to Suspend Compositing (default
Alt+Shift+F12) maybe try pressing that when the "old" panel shows.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424851] yakuake override panel.

2020-07-31 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424851

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #1 from Maximilian Schiller  ---
Try going into System Settings > Display and Monitor > Compositor and uncheck
"Allow applications to block compositing".

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424825] yakuake 20.04.3 wont go fullscreen

2020-07-30 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424825

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #2 from Maximilian Schiller  ---
Could you build yakuake from master and check if the issue persists?

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424746] Yakuake doesn't appear on a second screen when there is a panel on the top.

2020-07-29 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424746

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||manim...@outlook.de

--- Comment #1 from Maximilian Schiller  ---
Fixed in 20.08

*** This bug has been marked as a duplicate of bug 396697 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-07-29 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

Maximilian Schiller  changed:

   What|Removed |Added

 CC||i...@coreja.com

--- Comment #26 from Maximilian Schiller  ---
*** Bug 424746 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424286] hiding and showing doesn't remember fullscreen mode

2020-07-17 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424286

Maximilian Schiller  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/yakuake/commit/21b2d5
   ||0d4c23cd375acda57ed03af288a
   ||e0651af
 Resolution|--- |FIXED

--- Comment #4 from Maximilian Schiller  ---
Git commit 21b2d50d4c23cd375acda57ed03af288ae0651af by Maximilian Schiller, on
behalf of Anton Karmanov.
Committed on 17/07/2020 at 15:41.
Pushed by mschiller into branch 'release/20.08'.

Fix fullscreen mode regression
(cherry picked from commit 946ecc7fb569244f78f8658148b3bef9911a5af4)

M  +4-5app/mainwindow.cpp

https://invent.kde.org/utilities/yakuake/commit/21b2d50d4c23cd375acda57ed03af288ae0651af

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 415762] Exiting the session in a Yakuake tab sometimes crash Yakuake

2020-07-11 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=415762

Maximilian Schiller  changed:

   What|Removed |Added

 CC||brett.ker...@mamber.net

--- Comment #34 from Maximilian Schiller  ---
*** Bug 424006 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424006] yakuake unpredictably crashes

2020-07-11 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424006

Maximilian Schiller  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Maximilian Schiller  ---


*** This bug has been marked as a duplicate of bug 415762 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 424006] yakuake unpredictably crashes

2020-07-09 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=424006

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #1 from Maximilian Schiller  ---
Does it happen after closing a tab/terminal/split or yakuake altogether?

That will be fixed in the next version.
See https://bugs.kde.org/show_bug.cgi?id=415762

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 412496] Can't alter copy/paste shortcut and it doesn't respect the KDE global shortcuts for copy/paste

2020-07-06 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=412496

Maximilian Schiller  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/util
   ||ities/yakuake/commit/a0b08c
   ||b1f71ef18449bfbf5852c01e323
   ||604142f

--- Comment #6 from Maximilian Schiller  ---
Git commit a0b08cb1f71ef18449bfbf5852c01e323604142f by Maximilian Schiller.
Committed on 06/07/2020 at 19:18.
Pushed by mschiller into branch 'master'.

Make it possible to configure the konsolepart shortcuts

This patch allows the user to configure the by konsolepart provided actions.
For example it wasn't possible to configure the copy/paste shortcuts. Also many
the "X is an ambiguous shortcut" can now be fixed and remapped if the user so
desires.

Internally this is done by collecting the actioncollections from the kparts and
then providing the first one to the shortcutconfigure dialog. After the
shortcuts have been configured the actioncollections from all the other
terminals get synchronized.

M  +32   -1app/mainwindow.cpp
M  +27   -0app/sessionstack.cpp
M  +2-0app/sessionstack.h
M  +29   -0app/terminal.cpp
M  +1-1app/terminal.h

https://invent.kde.org/utilities/yakuake/commit/a0b08cb1f71ef18449bfbf5852c01e323604142f

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 149522] Save and restore sessions

2020-07-01 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=149522

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #28 from Maximilian Schiller  ---
If anyone here is still interested:
https://invent.kde.org/utilities/yakuake/-/merge_requests/11

It should work fine: sessions, tabs, splits, working dir and profile are saved
and restored. I have it marked as WIP because the error handling isn't that
great, yet.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-07-01 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

Maximilian Schiller  changed:

   What|Removed |Added

 CC||captainm...@gmail.com

--- Comment #25 from Maximilian Schiller  ---
*** Bug 416382 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 416382] Yakuake will not toggle on screen directly left of main screen

2020-07-01 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=416382

Maximilian Schiller  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #6 from Maximilian Schiller  ---
Fixed

*** This bug has been marked as a duplicate of bug 396697 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 422187] Yakuake crashes on start up

2020-06-29 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=422187

--- Comment #10 from Maximilian Schiller  ---
(In reply to Paul Brown from comment #9)

Very helpful indeed. Based on the crash log I'm suspecting that something is
wrong with your konsole installation.
It does find the konsole part/module correctly which is why you don't get the
error message but the interface seems to be an outdated version. So either you
are running some kind of partial upgrade on your system or you have installed
konsole in some other place from which its loading the module with a higher
priority than the default location.

The system uses qt plugins to load this in so definitely check that don't have
a QT_PLUGIN_PATH environment variable defined and don't have some installation
of konsole under other default search locations (/usr/local, .local, etc...).
The file you need to look out for should be called konsolepart.so (The correct
one should be the one under /usr/lib/qt/plugins).

I probably should add a more explanatory error message to yakuake if this turns
out to be the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 423491] Yakuake sometimes crashing when closing sessions

2020-06-28 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=423491

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||manim...@outlook.de
 Status|REPORTED|RESOLVED

--- Comment #1 from Maximilian Schiller  ---


*** This bug has been marked as a duplicate of bug 415762 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 415762] Exiting the session in a Yakuake tab sometimes crash Yakuake

2020-06-28 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=415762

Maximilian Schiller  changed:

   What|Removed |Added

 CC||raimund.macha...@rm-it.at

--- Comment #32 from Maximilian Schiller  ---
*** Bug 423491 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 422187] Yakuake crashes on start up

2020-06-28 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=422187

--- Comment #7 from Maximilian Schiller  ---
(In reply to Paul Brown from comment #6)
Thank you for being this detailed in your bug report.

Did you try removing you yakuakerc (Should be under ~/.config/)? If not please
try that (but keep a backup of it). 

The snap version probably doesn't contain Konsole but that's unfortunately
something the snap packager did wrong.

The next step would be to either manually build yakuake with debug symbols or
use a slightly modified version of the yakuake-git AUR package (since you are
running Manjaro). If you need help with that I and others who can help are
usually in the #yakuake:kde.org matrix channel.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 423408] Add option to disable system tray icon

2020-06-28 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=423408

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/yakuake/commit/592270
   ||2562bd637a09b7a77ccca0db276
   ||2b43968

--- Comment #3 from Maximilian Schiller  ---
Git commit 5922702562bd637a09b7a77ccca0db2762b43968 by Maximilian Schiller.
Committed on 28/06/2020 at 16:24.
Pushed by mschiller into branch 'master'.

Add option to toggle the systray icon

This patch adds a option to enable and disable the yakuake systray icon.

Because KStatusNotifier doesnt provided support for disabling it has to
be removed and readded whenever the option changes. But deleting causes
the QMenu to be deleted therefore also recreate the menu on deletion.

M  +10   -0app/config/behaviorsettings.ui
M  +5-0app/config/yakuake.kcfg
M  +27   -11   app/mainwindow.cpp

https://invent.kde.org/utilities/yakuake/commit/5922702562bd637a09b7a77ccca0db2762b43968

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 422187] Yakuake crashes on start up

2020-06-28 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=422187

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #5 from Maximilian Schiller  ---
Does it happen after you changed something about you monitor setup?

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 423408] Add option to disable system tray icon

2020-06-25 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=423408

--- Comment #1 from Maximilian Schiller  ---
yeah I didnt want to add another option for a feature that kinda overlaps with
something already provided by plasma.
But I agree in terms of consistency with other apps and the presented use case
that a option should be added.

Will make a mr in a couple of days.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 414322] Yakuake wont show with dual monitor setup stacked on top of each other

2020-06-17 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=414322

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||manim...@outlook.de
 Status|REPORTED|RESOLVED

--- Comment #4 from Maximilian Schiller  ---
This should be fixed in the next release.

*** This bug has been marked as a duplicate of bug 396697 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-06-17 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

Maximilian Schiller  changed:

   What|Removed |Added

 CC||tassilo.schneider@outlook.c
   ||om

--- Comment #24 from Maximilian Schiller  ---
*** Bug 414322 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 399974] Don't show a popup notification by default every time when Yakuake is started

2020-06-13 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=399974

--- Comment #9 from Maximilian Schiller  ---
So I did a implementation if you want to try it out:
https://invent.kde.org/utilities/yakuake/-/merge_requests/14

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 401769] f12 shortcut not working in one display

2020-06-13 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=401769

Maximilian Schiller  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE
 CC||manim...@outlook.de

--- Comment #5 from Maximilian Schiller  ---
This has been fixed in the next release fo yakuake.

*** This bug has been marked as a duplicate of bug 396697 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-06-13 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

Maximilian Schiller  changed:

   What|Removed |Added

 CC||xgd...@msn.com

--- Comment #23 from Maximilian Schiller  ---
*** Bug 401769 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 408374] Terminal not regaining focus after renaming session

2020-06-13 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=408374

Maximilian Schiller  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/util
   ||ities/yakuake/commit/dd60b7
   ||5c811fc26e711193e34f5f895aa
   ||33b2526

--- Comment #8 from Maximilian Schiller  ---
Git commit dd60b75c811fc26e711193e34f5f895aa33b2526 by Maximilian Schiller.
Committed on 13/06/2020 at 10:58.
Pushed by mschiller into branch 'master'.

Reraise the active sesson after renaming a session

This patch gives focus back to the currently active terminal after
renaming a session with either the context menu or the shortcut.

Whenever a tab title is edited signal to the sessionstack to raise the
active session.

M  +3-0app/mainwindow.cpp
M  +2-0app/tabbar.cpp
M  +1-0app/tabbar.h

https://invent.kde.org/utilities/yakuake/commit/dd60b75c811fc26e711193e34f5f895aa33b2526

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 399974] Don't show a popup notification by default every time when Yakuake is started

2020-06-13 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=399974

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #7 from Maximilian Schiller  ---
Not sure if still within the scope of this bug report but I would propose that
the default setting of this notification should be off. 

And instead we should show a system tray icon with KStatusNotifierItem with for
example the following behavior:
- on startup set the status to "active" so it gets shown in the system tray
- after the first retraction change the status to "passive" so it gets now
displayed in the extended menu

Having a tray icon would be more consistent with other applications that run in
the background (or are not visible to the user) most of the time (e.g.
rsibreak). Also it would be great to be able to quit, open and configure
yakuake from this icon.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 416382] Yakuake will not toggle on screen directly left of main screen

2020-06-09 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=416382

--- Comment #5 from Maximilian Schiller  ---
whoops linked the wrong report

https://bugs.kde.org/show_bug.cgi?id=396697

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 416382] Yakuake will not toggle on screen directly left of main screen

2020-06-09 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=416382

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@outlook.de

--- Comment #4 from Maximilian Schiller  ---
I think this is the same issue as in https://bugs.kde.org/show_bug.cgi?id=39669

should be fixed in the next release

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-06-09 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/util
   ||ities/yakuake/commit/df1e72
   ||30410516816b3f3e5b93d463d77
   ||9fe3ae0
 Status|REPORTED|RESOLVED

--- Comment #22 from Maximilian Schiller  ---
commit df1e7230410516816b3f3e5b93d463d779fe3ae0
Author: Maximilian Schiller 
Date:   Sat May 30 21:52:54 2020 +0200

Fix yakuake not opening on multimonitor setups

Fixes yakuake not opening on one monitor when the panel is located on an
edge
between two monitors.

This patch corrects the ExtendedStruct calculations and then checks if
not only the strut intersects with the current monitor but also the
window frame. If the strut intersects but the window frame does not that
window is most likely some king of panel located on an edge between the
current
and the next screen. With this patch those struts and windows will now be
ignored.

12  7   app/mainwindow.cpp

https://invent.kde.org/utilities/yakuake/commit/df1e7230410516816b3f3e5b93d463d779fe3ae0

-- 
You are receiving this mail because:
You are watching all bug changes.

[kcalc] [Bug 412401] Sometimes chained operations cause 'forgetting' of inserted constants or pasted numbers

2020-06-07 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=412401

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/kcalc/commit/cf39d29d
   ||737f7787350b04216c64a22a0b9
   ||36af6

--- Comment #4 from Maximilian Schiller  ---
Git commit cf39d29d737f7787350b04216c64a22a0b936af6 by Maximilian Schiller, on
behalf of Oleg Popkov.
Committed on 07/06/2020 at 08:00.
Pushed by mschiller into branch 'master'.

Fix chained operations involving inserted numbers

In brief, KCalc uses a stack in `CalcEngine` for both numbers and operations in
order to ensure the correct operation evaluation order (such that `2 + 2 * 2 =
6`) and support parentheses. Operations are pushed along with currently
displayed numerical values. KCalc also checks whether it should push the
operation onto the stack or just replace a pushed one with the new one without
changing the associated number (so that `5 + - 3 = 2`), and for this it uses a
flag changed by calling the `CalcEngine::setOnlyUpdateOperation` method.
Obviously, this flag must be cleared after a number is entered by any method,
but it only happens if a number is entered manually. As a result, inserting a
number as a whole, whether as a constant or by pasting from the clipboard,
results in replacing the preceding operation with the succeeding one without
storing the number in question, unless the succeeding operation is `=` or `%`.

M  +19   -1kcalc.cpp
M  +2-0kcalc.h

https://invent.kde.org/utilities/kcalc/commit/cf39d29d737f7787350b04216c64a22a0b936af6

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 421632] yakuake hijacks Shift+TAB key combination

2020-06-02 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=421632

Maximilian Schiller  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://invent.kde.org/util
   ||ities/yakuake/commit/fc6236
   ||b2523059c539f4702dfed01ced3
   ||304a9dd
 Resolution|--- |FIXED
 CC||manim...@outlook.de

--- Comment #1 from Maximilian Schiller  ---
Git commit fc6236b2523059c539f4702dfed01ced3304a9dd by Maximilian Schiller.
Committed on 02/06/2020 at 18:44.
Pushed by mschiller into branch 'master'.

Prevent incorrect terminal switching

This should prevent shift+tab of switching the terminal. If no
keybinding is set to shift+tab it gets correctly forwarded to the
shell/terminal.

The old behavior can easily restored by remapping "Next terminal" to
shift+tab.

M  +5-0app/mainwindow.cpp
M  +1-0app/mainwindow.h

https://invent.kde.org/utilities/yakuake/commit/fc6236b2523059c539f4702dfed01ced3304a9dd

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-05-30 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

--- Comment #20 from Maximilian Schiller  ---
Just created a Merge Request which hopefully should fix this issue.

https://invent.kde.org/utilities/yakuake/-/merge_requests/6

Since multi-monitors bugs are kinda hard to confirm on every type of setup, it
would be great if a couple of people could test this mr if it fixes the issue
on their side and didn't introduce any regressions.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 421948] Yakuake will not open on upper display of multi monitor system

2020-05-23 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=421948

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@hotmail.de

--- Comment #1 from Maximilian Schiller  ---
Where do you have your panel?

Might be related to https://bugs.kde.org/show_bug.cgi?id=396697

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396697] Does not open with multi monitor on left screen when panel located right screen

2020-05-19 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396697

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@hotmail.de

--- Comment #19 from Maximilian Schiller  ---
I did a little bit of investigation and the problem seems to be that if you
have a panel on your right monitor attached to the left side, Plasma creates a
x11 strut area, which essentially spans over your entire left monitor. This
leaves no space for yakuake to open on that monitor.

Not 100% sure what the best way to handle this is, because using workArea with
the list argument - I think - is actually the correct implemented one.

As a quick fix you could set in your panel settings "Windows can go cover".

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 409054] The Yakuake confirm quit option not working when more than one session open

2019-06-23 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=409054

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@hotmail.de

--- Comment #2 from Maximilian Schiller  ---
This should be fixed by:
https://phabricator.kde.org/R369:0c0eb086bdc0a726874a56b46de29fcc73fb792b when
the next version of yakuake is released.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 406999] Konsole crash while using Vim

2019-04-28 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=406999

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@hotmail.de

--- Comment #1 from Maximilian Schiller  ---
Do you know what you were doing during the crash (report seems to suggest you
were selecting text)? Also try to reproduce the crash.

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 396036] Initial directory option not working with zsh

2019-04-26 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=396036

Maximilian Schiller  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/yak
   ||uake/8f9844b8dbb44334dd54b6
   ||4dcc0815cefb404151
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Maximilian Schiller  ---
Git commit 8f9844b8dbb44334dd54b64dcc0815cefb404151 by Maximilian Schiller.
Committed on 26/04/2019 at 15:46.
Pushed by mschiller into branch 'master'.

Remove forcing the initial dir to QDir::homePath()

Summary:
This removes setting the current working dir to the home directory.
Without this patch the KPart's initial directory setting has no effect.
Also the KPart already defaults back to the home directory if nothing has been
set.

Test Plan:
1. Edit Current profile
2. change initial directory to something other than ~
3. restart yakuake / open new tab
4. The shells working dir should be equal to as specified in step 2

Reviewers: hein, #kde_applications

Reviewed By: hein

Differential Revision: https://phabricator.kde.org/D20117

M  +0-2app/terminal.cpp

https://commits.kde.org/yakuake/8f9844b8dbb44334dd54b64dcc0815cefb404151

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 401244] Clicking defaults on the shortcut page clear most of the shortcuts

2019-01-24 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=401244

Maximilian Schiller  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/yak
   ||uake/fb5a395befb40a3edd8b97
   ||69708770f52e497dfc

--- Comment #2 from Maximilian Schiller  ---
Git commit fb5a395befb40a3edd8b9769708770f52e497dfc by Maximilian Schiller.
Committed on 24/01/2019 at 15:00.
Pushed by mschiller into branch 'master'.

Add shortcuts as default shortcuts

Summary:
Add the shortcuts a the default shortcuts to the actionCollection()
When resetting to the default shortcuts this no longers clears them.

Test Plan: Open yakuake and confige shortcuts. Hit the "Defaults" button. The
shortcuts should no longer be cleared.

Reviewers: hein

Reviewed By: hein

Differential Revision: https://phabricator.kde.org/D18500

M  +24   -24   app/mainwindow.cpp

https://commits.kde.org/yakuake/fb5a395befb40a3edd8b9769708770f52e497dfc

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 398776] Pressing the "Close window" closes yakuake without asking if I'm really sure

2018-10-06 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=398776

Maximilian Schiller  changed:

   What|Removed |Added

 CC||yanp.b...@gmail.com

--- Comment #1 from Maximilian Schiller  ---
*** Bug 399284 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 399284] Quit button in the bottom right doesn't ask for confirmation

2018-10-06 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=399284

Maximilian Schiller  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #2 from Maximilian Schiller  ---


*** This bug has been marked as a duplicate of bug 398776 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[yakuake] [Bug 399284] Quit button in the bottom right doesn't ask for confirmation

2018-10-06 Thread Maximilian Schiller
https://bugs.kde.org/show_bug.cgi?id=399284

Maximilian Schiller  changed:

   What|Removed |Added

 CC||manim...@hotmail.de

--- Comment #1 from Maximilian Schiller  ---
It should be fixed with https://phabricator.kde.org/D15535 but its currently
being reviewed.

-- 
You are receiving this mail because:
You are watching all bug changes.