[konsole] [Bug 412596] ViewSplitter is not destroyed

2020-11-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 --- Comment #13 from Nikolay Zlatev --- (In reply to Kurt Hindenburg from comment #12) > Git commit c33eba8c60b99d00cd73c400d23b6f338ef32a85 by Kurt Hindenburg, on > behalf of Carlos Alves. > Committed on 02/11/2020 at 18:14. > Pushed b

[konsole] [Bug 418498] New: Maximize current Terminal (Keyboard vs Mouse)

2020-03-05 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=418498 Bug ID: 418498 Summary: Maximize current Terminal (Keyboard vs Mouse) Product: konsole Version: 19.12.2 Platform: Other OS: Linux Status: REPORTED Severity:

[konsole] [Bug 412596] ViewSplitter is not destroyed

2019-10-17 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 --- Comment #9 from Nikolay Zlatev --- Created attachment 123276 --> https://bugs.kde.org/attachment.cgi?id=123276=edit Patch v2 This is one of the ugliest code i have wrote. -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 412596] ViewSplitter is not destroyed

2019-10-17 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 --- Comment #7 from Nikolay Zlatev --- Created attachment 123271 --> https://bugs.kde.org/attachment.cgi?id=123271=edit ugly patch Working ugly patch/hack Also this fix/resolve #411741 -- You are receiving this mail because: You are watching

[konsole] [Bug 412596] ViewSplitter is not destroyed

2019-10-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 --- Comment #5 from Nikolay Zlatev --- "how complex is to simplify" (best sentence ever) Most complex thing for any developer :) :) :) pseudo code idea void afterTerminalDetached () { if (this->childrenCount == 1 &&

[konsole] [Bug 412596] ViewSplitter is not destroyed

2019-10-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 --- Comment #3 from Nikolay Zlatev --- Also I think this is the reason for https://bugs.kde.org/show_bug.cgi?id=411741 -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 412596] ViewSplitter is not destroyed

2019-10-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 --- Comment #2 from Nikolay Zlatev --- (In reply to Kurt Hindenburg from comment #1) > What are you using that shows those lines? Breeze::WidgetExplorer::eventFilter https://github.com/KDE/breeze/blob/master/kstyle/debug/breezewidgetexplorer.

[konsole] [Bug 412596] New: ViewSplitter is not destroyed

2019-10-04 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412596 Bug ID: 412596 Summary: ViewSplitter is not destroyed Product: konsole Version: master Platform: Other OS: Linux Status: REPORTED Severity: minor

[konsole] [Bug 412020] Certain style/themes cause Konsole split to create new window

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=412020 Nikolay Zlatev changed: What|Removed |Added CC||n...@astrapaging.com --- Comment #4 from

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #16 from Nikolay Zlatev --- (In reply to Kurt Hindenburg from comment #15) > Ok thanks for testing - I misunderstood what is going on - to be clear > "const auto handleWidth = parentSplitter->handleWidth() + 3;" works for

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #14 from Nikolay Zlatev --- Breeze handleWidth = ...pixelMetric(QStyle::PM_SplitterWidth) + 2; ++ || | 0

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #13 from Nikolay Zlatev --- // Find the theme's splitter width + extra space to find valid terminal // https://doc.qt.io/qt-5/qsplitter.html#handleWidth-prop // By default, this property contains a value // that depends on the user's

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-10-03 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 Nikolay Zlatev changed: What|Removed |Added Ever confirmed|0 |1 Status|RESOLVED

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-09-19 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #9 from Nikolay Zlatev --- > // Find the theme's splitter width + extra space to find valid terminal >const auto handleWidth = > parentSplitter->style()->pixelMetric(QStyle::PM_SplitterWidth) + 2; On Breeze handleWidt

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-09-10 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #7 from Nikolay Zlatev --- (In reply to Kurt Hindenburg from comment #6) > the null check looks reasonable even though I can't it to crash here with > any theme. The "+1" is worrisome as it appears to be theme speci

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #5 from Nikolay Zlatev --- Final patch diff --git a/src/ViewSplitter.cpp b/src/ViewSplitter.cpp index 7e31172c..38c576a9 100644 --- a/src/ViewSplitter.cpp +++ b/src/ViewSplitter.cpp @@ -147,7 +147,7 @@ void ViewSplitter

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #4 from Nikolay Zlatev --- It appears this is theme related issue. When I use Breeze everything is OK. For Breeze const auto handleWidth = parentSplitter->handleWidth() <= 1 ? 4 : parentSplitter->handleWidth(); returns 4 as a

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #3 from Nikolay Zlatev --- This only happens on some split layouts and only with keyboard navigation. targetSplitter->widget(0) returns Konsole::ViewSplitter and then casting to TerminalDisplay fail. -- You are receiving this m

[konsole] [Bug 411387] Split View crash with keyboard navigation

2019-08-30 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 --- Comment #2 from Nikolay Zlatev --- Created attachment 122418 --> https://bugs.kde.org/attachment.cgi?id=122418=edit Debug session -- You are receiving this mail because: You are watching all bug changes.

[konsole] [Bug 411387] New: Split View crash with keyboard navigation

2019-08-28 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=411387 Bug ID: 411387 Summary: Split View crash with keyboard navigation Product: konsole Version: 19.08.0 Platform: Other OS: Linux Status: REPORTED Severity: minor

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-09 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #21 from Nikolay Zlatev <n...@astrapaging.com> --- (In reply to Eike Hein from comment #20) > Patch for the Exec= issue: https://phabricator.kde.org/D10405 Tested everything works fine. -- You are receiving this mail bec

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #18 from Nikolay Zlatev <n...@astrapaging.com> --- > фев 08 16:10:12 telamon kdeinit5[20168]: Service > "org.kde.StatusNotifierHost-28341" unregistered > фев 08 16:10:12 telamon systemd[1]: Started Process Cor

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #17 from Nikolay Zlatev <n...@astrapaging.com> --- (In reply to Eike Hein from comment #15) > > If we have pinned launcher with 'Exec' parameter that not exists, on start > > whole plasmashell crash. > > I can't rep

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #16 from Nikolay Zlatev <n...@astrapaging.com> --- (In reply to Eike Hein from comment #15) > > If we have pinned launcher with 'Exec' parameter that not exists, on start > > whole plasmashell crash. > > I can't rep

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-08 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #14 from Nikolay Zlatev <n...@astrapaging.com> --- Can confirm, patch D10383 resolve spaces issue. Plasma 5.11.5 -- You are receiving this mail because: You are watching all bug changes.

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-05 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #12 from Nikolay Zlatev <n...@astrapaging.com> --- Created attachment 110352 --> https://bugs.kde.org/attachment.cgi?id=110352=edit Taskmanager plasmashell crash If we have pinned launcher with 'Exec' parameter that not exists,

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-05 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #10 from Nikolay Zlatev <n...@astrapaging.com> --- Problem with libreoffice: All launchers execute same file (/usr/bin/libreoffice) with parameter (--calc for example). Wrapping executable to libreoffice_calc improves things

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2018-02-05 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 --- Comment #7 from Nikolay Zlatev <n...@astrapaging.com> --- If .desktop file contains 'space' in the file name, launcher can't be pinned at all (correctly placed and drawed in task manager) Tested with Arch x86_64 Plasma 5.11.5 Framework

[plasmashell] [Bug 385942] Applications with URLs constructed with spaces can't be pinned and/or jump around

2017-12-14 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385942 Nikolay Zlatev <n...@astrapaging.com> changed: What|Removed |Added CC||n...@astrapagi

[plasmashell] [Bug 385594] launchInPlace is broken from libtaskmanager; causes Icons-Only Task manager icons to jump around

2017-12-14 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385594 --- Comment #47 from Nikolay Zlatev <n...@astrapaging.com> --- (In reply to Nikolay Zlatev from comment #46) > Application with space in the name can't be pinned at all. > No error message, but if I choose "Add to Panel(Widget)" fr

[plasmashell] [Bug 385594] launchInPlace is broken from libtaskmanager; causes Icons-Only Task manager icons to jump around

2017-12-14 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385594 --- Comment #46 from Nikolay Zlatev <n...@astrapaging.com> --- Application with space in the name can't be pinned at all. No error message, but if I choose "Add to Panel(Widget)" from menu, application attach to panel but system receive

[plasmashell] [Bug 385594] launchInPlace is broken from libtaskmanager; causes Icons-Only Task manager icons to jump around

2017-10-27 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385594 --- Comment #36 from Nikolay Zlatev <n...@astrapaging.com> --- (In reply to Paul from comment #35) > Created attachment 108586 [details] > Screenshot > > This is still happening with the icon for Libre Office, as shown in the >

[plasmashell] [Bug 385594] launchInPlace is broken from libtaskmanager; causes Icons-Only Task manager icons to jump around

2017-10-13 Thread Nikolay Zlatev
https://bugs.kde.org/show_bug.cgi?id=385594 Nikolay Zlatev <n...@astrapaging.com> changed: What|Removed |Added CC||n...@astrapagi