[frameworks-baloo] [Bug 484828] [Enhancement] Have Baloo split camelCase words

2024-04-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=484828

--- Comment #5 from Stefan Brüns  ---
(In reply to tagwerk19 from comment #4)
> (In reply to Stefan Brüns from comment #2)

> The question is what "traps for unwary" look like in other languages...

German: BAFöG, MwSt, GmbH ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 484828] [Enhancement] Have Baloo split camelCase words

2024-04-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=484828

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #2 from Stefan Brüns  ---
CamelCase is not actually something which can be trivially split.

Yes, it would work for the cases you presented, but there are too many cases
where it would not work, e.g. mixed-case acronyms. While these are not very
common for english acronyms, baloo also has to work for other languages. Also,
trademark names often have mixed cases (either because they are actually
acronyms, to let them stand out, or to just make them trademark-able at all).

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 380456] Suspected memory leak in baloo_file_extractor

2024-03-27 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=380456

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #22 from Stefan Brüns  ---
(In reply to tagwerk19 from comment #21)
> Created attachment 143869 [details]
> pdftotext results from
> https://ipfs.io/ipfs/QmVqWhPuQkE7reTN5F9TiSeA75z62VNaZUSFZz3FdWTLbC
> 
> (In reply to Adam Fontenot from comment #20)
> > ... The file, in their view, is pathological ...
> Applying a modicum of patience, running:
> 
> nice -19 pdftotext QmVqWhPuQkE7reTN5F9TiSeA75z62VNaZUSFZz3FdWTLbC.pdf
> 
> took 37 hours on a machine with 16GB memory 8-]
> 
> The process gradually ate memory, reaching 10 GB. There wasn't an obvious
> impact on performance - but I would expect you'd see that bite when reaching
> the limits/starting to swap.

The long runtime is caused by some algorithmically bad implementation, i.e.
O(n^2) were e.g. O(n log n) is sufficient. The huge memory footprint is caused
by some problematic data arrangement and too greedy pre/overallocation.

I have filed two MRs [1],[2] for poppler, with both applied the extractions
runs in ~50 seconds on my 3 year old laptop, with a peak memory consumption of
1.8 GByte.

[1] https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1514  
[2] https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1515

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 410680] KFileMetaData plain text extractor sometimes fails for non-UTF text files

2024-03-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=410680

Stefan Brüns  changed:

   What|Removed |Added

Summary|baloo doesn't index words   |KFileMetaData plain text
   |far down in HTML documents  |extractor sometimes fails
   ||for non-UTF text files

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 440537] KFileMetaData plain text extractor sometimes fails for non-UTF text files

2024-03-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=440537

Stefan Brüns  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Stefan Brüns  ---
In case the non-ASCII character (byte) still forms a valid UTF-8 code sequence
(something which often appears when an UTF-8 text is interpreted as e.g.
ISO8859-1), the file will still be extracted completely, though with some
occasional incorrect codepoints.

As this bug report does not contain anything on top of the information present
in bug 410680 closing as duplicate.

*** This bug has been marked as a duplicate of bug 410680 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 410680] baloo doesn't index words far down in HTML documents

2024-03-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=410680

--- Comment #12 from Stefan Brüns  ---
*** Bug 440537 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 440537] KFileMetaData plain text extractor sometimes fails for non-UTF text files

2024-03-18 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=440537

Stefan Brüns  changed:

   What|Removed |Added

Summary|KFileExtractor doesn't work |KFileMetaData plain text
   |with non-UTF text files |extractor sometimes fails
   ||for non-UTF text files
 CC||stefan.bruens@rwth-aachen.d
   ||e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 390830] Files in plasma vault indexed and available when the vault is closed

2024-03-17 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=390830

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #16 from Stefan Brüns  ---
(In reply to Detlef Eppers from comment #13)
> Okular and Gwenview also don't know about Vaults and collect potentially
> sensitive metadata in ~/.local/share/okular/docdata and
> ~/.local/share/gwenview/recentfolders.

Also, thumbnails may leak out. These do not only show the preview, with up to
512x512 pixels, but also contain the full file name.

This only happens when the home directory is on encrypted storage, but when you
use Vaults even though the home directory is encrypted, you probably do for a
reason (i.e. additional confidentiality).

That is a fairly recent change for the worse, and it was mentioned in the MR
(https://invent.kde.org/frameworks/kio/-/merge_requests/1287#note_687728), but
people seem to be fine with this.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 428967] title field not populated for jpegs

2024-03-05 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=428967

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #7 from Stefan Brüns  ---
Waiting for confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 316766] Baloo does not read tags from Windows 7 tagged Images

2024-03-05 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=316766

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|CONFIRMED   |RESOLVED
Product|frameworks-baloo|frameworks-kfilemetadata
Version|unspecified |5.245.0
  Component|Baloo File Daemon   |general

--- Comment #10 from Stefan Brüns  ---
Waiting for confirmation

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 410680] baloo doesn't index words far down in HTML documents

2024-03-05 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=410680

--- Comment #11 from Stefan Brüns  ---
If you want the original content (without Wayback inserts/link mangling), you
have to use:

https://web.archive.org/web/20131225011444im_/https://demo.borland.com/testsite/stadyn_largepagewithimages.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 410680] baloo doesn't index words far down in HTML documents

2024-03-05 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=410680

Stefan Brüns  changed:

   What|Removed |Added

Version|5.59.0  |5.115.0
Product|frameworks-baloo|frameworks-kfilemetadata
  Component|Engine  |general

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 439857] baloo only indexes first 4096 bytes of non-UTF-8 text and html files

2024-03-05 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=439857

--- Comment #2 from Stefan Brüns  ---
Not a baloo bug. The text is not extracted by KFileMetaData's
plaintextextractor, but for that a BR already exists.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 477855] Plasmashell consumes CPU time doing nothing until System Tray popup is opened once

2023-12-23 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477855

Stefan Brüns  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Resolution|WAITINGFORINFO  |---
 Status|NEEDSINFO   |CONFIRMED

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 477274] Untranslated string in File Search KCM

2023-12-19 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477274

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/plasma-desktop/-/commit/
   ||7ecf315258b4e171ab76d7929ce
   ||7b8db5cfc3011
 Status|ASSIGNED|RESOLVED

--- Comment #12 from Stefan Brüns  ---
Git commit 7ecf315258b4e171ab76d7929ce7b8db5cfc3011 by Stefan Brüns.
Committed on 19/12/2023 at 14:08.
Pushed by bruns into branch 'master'.

Fix hiding of filename label when indexer is idle

This fixes a regression caused by commit 6ea58c0f0ac6 ("kcms/baloo: make
"current indexing" label a full path again"). Prior to this commit, the
condition included the boolean "monitor.currentlyIndexing" property.

Using the filePath.length and completionPercentage is insufficient,
as the filepath value is only valid when the state is *not* idle, and
may show e.g. a placeholder value during idle state.

M  +1-1kcms/baloo/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/7ecf315258b4e171ab76d7929ce7b8db5cfc3011

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 477274] Untranslated string in File Search KCM

2023-12-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477274

--- Comment #11 from Stefan Brüns  ---
Why is assigning the bug to the right component unacceptable?

Why is mentioning where your conclusions are incorrect unacceptable?

The bug lies in the KCM, and is caused by a change you have done:
https://invent.kde.org/plasma/plasma-desktop/-/commit/6ea58c0f0ac6b9d91b255a41e51032a597238476

You removed the "monitor.currentlyIndexing" condition, and you did so in an
apparently unrelated change. The problematic change was not justified in any
way in the commit message, not even mentioned.

I have tried to give you a chance to fix it yourself, I pointed you to the
problematic line in the main.qml
(https://bugs.kde.org/show_bug.cgi?id=477274#c5), but you kept blaming baloo.

I have now created a MR which fixes the regression: 
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1925

-- 
You are receiving this mail because:
You are watching all bug changes.

[systemsettings] [Bug 477274] Untranslated string in File Search KCM

2023-12-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477274

Stefan Brüns  changed:

   What|Removed |Added

  Component|general |kcm_baloo
   Assignee|baloo-bugs-n...@kde.org |plasma-b...@kde.org
Product|frameworks-baloo|systemsettings
 CC||baloo-bugs-n...@kde.org

--- Comment #9 from Stefan Brüns  ---
(In reply to Nate Graham from comment #8)
> Created attachment 164153 [details]
> Filename not shown while indexer is idle
> 
> > 1. The filename is obviously *not* hidden when the indexer is idle.
> 
> The filename *is* hidden when the indexer is idle. I am attaching a
> screenshot as evidence, disproving your confidently incorrect assertion.
> Furthermore this is not related to the bug report, which is about the
> untranslated string, for which there is already an open merge request.

It is *sometimes* hidden, not always. The check is incorrect, failing
*sometimes*.

It should not base the decision on the length of the filename (or, as in this
case, the length of an irrelevant placeholder).

It is a regression caused by recent code changes.

> > 3. There is no "Plasma Desktop" bug component, or anything else which 
> > matches in the
> > "Plasma" group. So assigning it to the kde catchall ...
> 
> General Plasma issues live in the "plasmashell" product, which is where this
> ticket lived in the past and you can see that in the History page. Issues in
> System Settings KCMs live in the System Settings product. Please learn to
> use the bug tracker properly and don't intentionally assign tickets to
> incorrect products.

You keep assigning this bug to the wrong product.

> I'm yet again moving the ticket back to the product for the Baloo framework,
> which is where the issue lies, as evidenced by the merge request
> https://invent.kde.org/frameworks/baloo/-/merge_requests/180 that fixes it.

It does not fix it. 'i18n("idle")' does also return an non-zero string.

> Do not move it elsewhere again.

Why not, if your assumptions are just plain wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.

[policykit-kde-agent-1] [Bug 477805] Service start timeout is ridiculously short

2023-12-09 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477805

--- Comment #5 from Stefan Brüns  ---
Git commit 2ae70fd9c55fc85275c81ea96f5043a793628f79 by Stefan Brüns.
Committed on 10/12/2023 at 05:46.
Pushed by bruns into branch 'master'.

Remove service start timeout

On a slow machine the service may take longer than 5 seconds (walltime) to
start,
especially during session start when multiple processes are competing for
CPU time and I/O.

The original reasoning for the timeout is to limit the time to quit the process
when the session is shut down, but that can be set with TimeoutStopSec.

Whether the start timeout is useful at all is questionable. It only helps if
there is some deadlock during startup which would be cured by a fresh
start, otherwise it is just consuming CPU time again and again.

For comparision, Gnome does not use Timeout[Start]Sec at all, but
only TimeoutStopSec.

M  +1-1daemon/plasma-powerdevil.service.in

https://invent.kde.org/plasma/powerdevil/-/commit/2ae70fd9c55fc85275c81ea96f5043a793628f79

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 477855] Plasmashell consumes CPU time doing nothing until System Tray popup is opened once

2023-12-08 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477855

--- Comment #2 from Stefan Brüns  ---
I have seen this also after "plasmashell --replace", so probably unrelated to
session start (though, there may be some timing related stuff which has an
influence).

One influenced system was a fresh installation, i.e. very basic.

-- 
You are receiving this mail because:
You are watching all bug changes.

[policykit-kde-agent-1] [Bug 477805] Service start timeout is ridiculously short

2023-12-04 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477805

Stefan Brüns  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
  Latest Commit||https://invent.kde.org/plas
   ||ma/polkit-kde-agent-1/-/com
   ||mit/094b64cf3d50d2b0cc74da2
   ||9c59e5829cf5e9747
 Resolution|--- |FIXED

--- Comment #3 from Stefan Brüns  ---
Git commit 094b64cf3d50d2b0cc74da29c59e5829cf5e9747 by Stefan Brüns.
Committed on 04/12/2023 at 18:09.
Pushed by bruns into branch 'master'.

Extend service start timeout

On a slow machine the service may take longer than 5 seconds (walltime) to
start,
especially during session start when multiple processes are competing for
CPU time and I/O.

The original reasoning for the timeout is to limit the time to quit the process
when the session is shut down, but that can be set with TimeoutStopSec.

Remove the start timeout, as it os questionable if is useful at all. It only
helps if there is some deadlock during startup which would be cured by a
fresh start, otherwise it is just consuming CPU time again and again.

For comparison, Gnome does not use Timeout[Start]Sec at all, but
only TimeoutStopSec.

M  +1-1plasma-polkit-agent.service.in

https://invent.kde.org/plasma/polkit-kde-agent-1/-/commit/094b64cf3d50d2b0cc74da29c59e5829cf5e9747

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-12-02 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

--- Comment #12 from Stefan Brüns  ---
(In reply to tagwerk19 from comment #11)
> (In reply to tagwerk19 from comment #10)
> > Maybe when baloo_file does its initial scan through the filestructure to set
> > up iNotify watches, it could do a sanity check of the folder name against
> > the DocId.
> OK, I think that would catch this particular issue.

I mentioned already in the FSID change that there is no guarantee a document in
the DB is currently reachable by its path, see network mounts, see thumbdrives,
etc. But unfortunately everyone ignored my reservations, as everyone else
apparently knows better how Baloo works than me ...

> It seems that the FSID change triggers the issue of (comment #3):
> > Confusing "empty" results when searching from a particular directory (as
> > opposed to "Your Files"). That's the Bug 474973   
> but there's no guarantee that this is the only cause. Doing a sanity check
> of ensuring the folder is indexed before creating an iNotify watch would
> catch any similar issues. Whatever the root cause.

You fall into the same trap as others have before, these are not synchronous.
First, inotify works with paths, and second, it works with a sequence of
events. You will have intermediate states which may no longer be valid, e.g.
when doing renames. Trying to "synchronize" inotify and DB state have been the
source of inconsistent DB states in the past, this will only make things worse.
The DB must be self-consistent, but may temporarily be in a different state
than the FS.

But actually, these comments are off-topic here. This BR is about DB
inconsistencies caused by code changes, nothing else.

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 477855] New: Plasmashell consumes CPU time doing nothing

2023-12-01 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477855

Bug ID: 477855
   Summary: Plasmashell consumes CPU time doing nothing
Classification: Plasma
   Product: plasmashell
   Version: 5.27.9
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: major
  Priority: NOR
 Component: Panel
  Assignee: plasma-b...@kde.org
  Reporter: stefan.bru...@rwth-aachen.de
CC: niccolo.venera...@gmail.com
  Target Milestone: 1.0

SUMMARY

After plasmashell has started, it is consuming CPU time doing apparently
nothing.

According to strace, it is woken up due to a ~16ms ppoll timeout. This is
likely some animation which has not been stopped correctly.

The polling stops as soon as the "Status and Notification" popup is opened the
first time, afterwards the process is completely idle.

STEPS TO REPRODUCE
1. Start plasmashell (as part of the session, or with --restart, does not
matter)
2. Attach strace to the main thread
3. Open the popup using the ^ up arrow

OBSERVED RESULT
Plasmashell consumes CPU time doing nothing, and behaves correctly after
opening the popup once.

EXPECTED RESULT
Plasmashell becomes idle immediately after start, without user intervention.


SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 5.27.9
KDE Frameworks Version: 5.112
Qt Version: 5.15.11

ADDITIONAL INFORMATION

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 476973] HDDs conected to plug-in SATA card classified by Dolphin as Removable Devices rather than Devices

2023-12-01 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476973

--- Comment #23 from Stefan Brüns  ---
Currently, only the host adapter self matches.
Can you try the following two variants (remove the # comment character from one
line at a time):

---
# SUBSYSTEMS=="pci", SUBSYSTEM=="block",  ATTRS{vendor}=="0x1022",
ATTRS{device}=="0x43c8", ENV{UDISKS_SYSTEM_INTERNAL}="1"
# SUBSYSTEM=="block",  ENV{ID_PATH}=="pci-:03:00.1*",
ENV{UDISKS_SYSTEM_INTERNAL}="1"
---

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 476973] HDDs conected to plug-in SATA card classified by Dolphin as Removable Devices rather than Devices

2023-12-01 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476973

--- Comment #21 from Stefan Brüns  ---
The udevadm info --export-db should have an "E: UDISKS_SYSTEM_INTERNAL=1" in
each block for the controller and attached disks. If unsure, append the output
here again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[kde] [Bug 477274] Untranslated string in File Search KCM

2023-12-01 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477274

Stefan Brüns  changed:

   What|Removed |Added

  Component|general |general
Version|5.246.0 |unspecified
Product|frameworks-baloo|kde
   Assignee|baloo-bugs-n...@kde.org |unassigned-b...@kde.org

--- Comment #7 from Stefan Brüns  ---
Nate, again you are spreading incorrect information, please be more thorough.

1. The filename is obviously *not* hidden when the indexer is idle. I even
pointed out the incorrect code. You can even verify this by looking at the
screenshot - progress is != 100%, and the filepath length is > 0, so it is
visible.

There is even an unused "currentlyIndexing" property which could be used for
this check, but the property is completely unused.

2. As far as I can see there is no untranslated string visible here (beside the
filename placeholder). The state is already translated, see
https://invent.kde.org/frameworks/baloo/-/blob/master/src/engine/indexerstate.cpp?ref_type=heads

3. There is no "Plasma Desktop" bug component, or anything else which matches
in the "Plasma" group. So assigning it to the kde catchall ...

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 476973] HDDs conected to plug-in SATA card classified by Dolphin as Removable Devices rather than Devices

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476973

--- Comment #19 from Stefan Brüns  ---
(In reply to Scott from comment #18)
> I correctly followed your instructions this time with the same result.

Have you reload'ed the udev configuration?

Is the UDISK_SYSTEM_INTERNAL env variable set in the udevadm output?

-- 
You are receiving this mail because:
You are watching all bug changes.

[policykit-kde-agent-1] [Bug 477805] Service start timeout is ridiculously short

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477805

--- Comment #1 from Stefan Brüns  ---
Also see https://bbs.archlinux.org/viewtopic.php?id=289979

-- 
You are receiving this mail because:
You are watching all bug changes.

[plasmashell] [Bug 477274] Untranslated string in File Search KCM

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477274

Stefan Brüns  changed:

   What|Removed |Added

   Assignee|baloo-bugs-n...@kde.org |plasma-b...@kde.org
Version|5.246.0 |master
   Target Milestone|--- |1.0
  Component|general |general
Product|frameworks-baloo|plasmashell
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #5 from Stefan Brüns  ---
Whoever "improved" this dialog should fix it, the filename should be hidden
when the indexer is idle. This was the case previously.

This condition is wrong: "visible: fileSearchEnabled.checked &&
monitor.completionPercentage !== 100 && monitor.filePath.length > 0"

-- 
You are receiving this mail because:
You are watching all bug changes.

[policykit-kde-agent-1] [Bug 477805] Service start timeout is ridiculously short

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477805

Stefan Brüns  changed:

   What|Removed |Added

   Assignee|unassigned-b...@kde.org |k...@davidedmundson.co.uk

-- 
You are receiving this mail because:
You are watching all bug changes.

[policykit-kde-agent-1] [Bug 477805] New: Service start timeout is ridiculously short

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477805

Bug ID: 477805
   Summary: Service start timeout is ridiculously short
Classification: Plasma
   Product: policykit-kde-agent-1
   Version: 5.27.9
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: unassigned-b...@kde.org
  Reporter: stefan.bru...@rwth-aachen.de
CC: d...@kde.org, jgrul...@redhat.com, jrez...@redhat.com
  Target Milestone: ---

SUMMARY

The start timeout (walltime) is 5 seconds, which is significantly too short in
an emulated virtual machine, especially during session start when many services
are causing CPU and disk load.

STEPS TO REPRODUCE
1. Create an emulated virtual machine, e.g. aarch64 on x86_64
2. (install/use a live distribution)
3. Start a Plasma session

OBSERVED RESULT

polkit-kde-agent-1 is starting and killed after 5 seconds, started again,
killed again, etc.

This can happen 100 times in a row. Sometimes other plasma services run into
the same problem, exaggerating the problem.

EXPECTED RESULT

All services are just started once, as fast or slow as the system permits.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version:  5.27.9
KDE Frameworks Version: 5.112.0
Qt Version: 5.15

ADDITIONAL INFORMATION

https://invent.kde.org/plasma/plasma-workspace/-/wikis/Plasma-and-the-systemd-boot

> The default timeout between quit signal and killing is ridiculously long

The "quit" timeout should be set with "TimeoutStopSec", not with "TimeoutSec". 
Gnome services have this correctly set, all Plasma services have this wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 476973] HDDs conected to plug-in SATA card classified by Dolphin as Removable Devices rather than Devices

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476973

Stefan Brüns  changed:

   What|Removed |Added

 Status|ASSIGNED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #17 from Stefan Brüns  ---
Please try adding a file "/etc/udev/rules.d/70-fixup-removable.conf"

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 476973] HDDs conected to plug-in SATA card classified by Dolphin as Removable Devices rather than Devices

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476973

--- Comment #16 from Stefan Brüns  ---
(In reply to Scott from comment #14)
> Created attachment 163647 [details]
> copy of /etc/udev/rules.d/70-snap.snapd.rules
> 
> Here is the edited file, I have added the lines at line 1137.

Thats the reason I asked you to create a *new* file, with just the given
contents.

1. The added lines will never be executed when added at the position you have
used
2. The changes will be removed: "# This file is automatically generated. ... #
do not edit this file, it will be overwritten on update"

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-solid] [Bug 476973] HDDs conected to plug-in SATA card classified by Dolphin as Removable Devices rather than Devices

2023-11-30 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476973

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #13 from Stefan Brüns  ---
The "removable" classification is done by the kernel (based on flags set by the
hardware), and forwarded via udisks2 to solid.

http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Drive.html#gdbus-property-org-freedesktop-UDisks2-Drive.Removable
> Note that this is only a guess. 

But as this is a somewhat common problem, it is possible to override it, and
already for 12 years now:
https://bugs.freedesktop.org/show_bug.cgi?id=22879#c9

Please try adding a file "/etc/udev/rules.d/70-fixup-removable.conf" with the
following contents (without the "---"):

---
# PCI SATA misclassified all drives as removable (probably eSATA), mark as
internal
SUBSYSTEMS=="pci", ENV{PCI_SLOT_NAME}==":03:00.1",
ENV{UDISKS_SYSTEM_INTERNAL}="1"
# Probably better, use vendor/product ID of SATA expansion card:
# SUBSYSTEMS=="pci",  ATTR{vendor}=="0x0123", ATTR{device}=="0xabcd",
ENV{UDISKS_SYSTEM_INTERNAL}="1"
---

Afterwards, reload the udev configuration:
$> sudo udevadm control --reload

In case this does not work, please provide the output of:
$> udevadm info --export-db

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 475352] FLAC Ogg files incorrectly use the TagLib::Ogg::Vorbis extractor instead of TagLib::Ogg::FLAC

2023-11-27 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475352

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |FIXED
 Status|NEEDSINFO   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 475352] FLAC Ogg files incorrectly use the TagLib::Ogg::Vorbis extractor instead of TagLib::Ogg::FLAC

2023-11-27 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475352

Stefan Brüns  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Stefan Brüns  ---
Fix available, needs confirmation.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-24 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

--- Comment #8 from Stefan Brüns  ---
So, although I had asked Nate *twice* about notifying users about the breaking
change, he chose to ignore it.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-23 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

--- Comment #6 from Stefan Brüns  ---
https://discuss.kde.org/t/baloo-and-frameworks-5-111/6348/1

> Purging and reindexing as above is not necessary but probably sensible…

That's obviously incorrect, it is necessary for BTRFS and Ext to have it
working correctly. It is better to err on the safe side here.

And while I appreciate you have mentioned it on Discuss, the reach is fairly
small, thats the reason I asked Nate to get the message out.

And the number of bugs filed or other reports  is not a good measure of systems
affected - people may simply not want to invest the time (and contrary to the
automated kcrash reports it takes significantly more time to do so). 

Also, Debian and Ubuntu are both currently shipping older KF5 version
(5.107/5.110) not yet affected.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-23 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

--- Comment #4 from Stefan Brüns  ---
The problems are:
- Sudden misbehavior seen by users not affected so for (Ext3/4, probably
others)
- Doubling of index size for users on e.g. Ext4


Btw, the systemd limit does not actually help so much (if at all), it are the
fixes which went in afterwards which made the index behavior significantly
better.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-22 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

--- Comment #2 from Stefan Brüns  ---
@ngraham: How about notifying the users about the regression caused by the ID
change, to keep the impact as small as possible?

This is currently not fixed, and even if it were,  the next KF5 release
(KF5.113) is still some weeks in the future (+ distribution delay). 

More and more people will be hit by this. Most notably, it will affect also
users with Ext* filesystems, which as of now had no problems with the
filesystem/device ID.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

--- Comment #14 from Stefan Brüns  ---
(In reply to tagwerk19 from comment #11)
> (In reply to Christoph Feck from comment #4)
> > From the backtrace, it looks like there is a text file larger than 2 GiB. 
> > Qt only supports up to 2 GiB.
> Not sure what Baloo would do with a 2GB file...
> 
> Thought there was a "rough limit" of 10 Mbyte, see
> https://bugs.kde.org/show_bug.cgi?id=410680#c7
> 
> Doesn't always seem to cut in, maybe does for some filetypes and not others.
> Cf Bug 447681

The limit is currently only applied when the detected mimetype is a subtype of
"text/", not when it is a specialized (inherited) type of e.g. text/plain. For
example, "application/json" or "message/rfc822".

For a more complete list:
$> grep -E '\t\2 @ ; p} '  | tee
/dev/stderr | wc -l

That lists 64 types.

You can find such files with e.g.
$> baloosearch -t Text mimetype:application or mimetype:message

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kcrash] [Bug 477115] New: KCrash interferes with QProcess::exitStatus

2023-11-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477115

Bug ID: 477115
   Summary: KCrash interferes with QProcess::exitStatus
Classification: Frameworks and Libraries
   Product: frameworks-kcrash
   Version: 5.112.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: fa...@kde.org
  Reporter: stefan.bru...@rwth-aachen.de
CC: kdelibs-b...@kde.org
  Target Milestone: ---

SUMMARY

Whenever KCrash catches e.g. SIGSEGV or SIGILL, it may either reraise the
signal after DrKonqi has closed, or do an `_exit(253)`.

Which of the two happens depends on the setting of
/proc/sys/kernel/core_pattern.  

STEPS TO REPRODUCE
1. execute an external program which uses KCrash using QProcess::start(...)
  (a program known to crash - for a reproducer, just use `raise(SIGSEGV)`).
2. listen to the `QProcess::finished(...)` signal
3. Evaluate the `QProcess::exitStatus`

OBSERVED RESULT
The `exitStatus` should be `QProcess::CrashExit`

EXPECTED RESULT
The `exitStatus` *may be* `QProcess::NormalExit` with an exitCode of 253.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma:  5.112.0
KDE Frameworks Version: 5.112.0
Qt Version: 5.15

ADDITIONAL INFORMATION
When `systemd-coredump` is installed, the `core_pattern` is set to a pipe.

The intention seems to not produce a core file when a crash is caught by
KCrash. There a other ways to achieve this, as outlined in `man 5 core`, e.g.
setting the RLIMIT_CORE to { 0, 0 }.

This behavior is not mentioned in any documentation, at least not in
https://api.kde.org/frameworks/kcrash/html/namespaceKCrash.html

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

Stefan Brüns  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=477115

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 316766] Baloo does not read tags from Windows 7 tagged Images

2023-11-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=316766

--- Comment #9 from Stefan Brüns  ---
Git commit 06d98a1b9ad475332af12df7de503ee4bb93478f by Stefan Brüns.
Committed on 16/11/2023 at 21:46.
Pushed by bruns into branch 'master'.

[Exiv2Extractor] Add support for XMP DC Title, Subject, Description

The XMP Dublin Core metadata may contain title, subject and description
values, extract it.

Update JPEG, JXL and WebP test images to include Title and Subject.
Related: bug 428967

M  +17   -3autotests/exiv2extractortest.cpp
D  +0-25   autotests/exiv2extractortest.h
M  +---autotests/samplefiles/test.jpg
M  +---autotests/samplefiles/test.jxl
M  +---autotests/samplefiles/test.webp
M  +25   -0src/extractors/exiv2extractor.cpp

https://invent.kde.org/frameworks/kfilemetadata/-/commit/06d98a1b9ad475332af12df7de503ee4bb93478f

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 428967] title field not populated for jpegs

2023-11-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=428967

--- Comment #6 from Stefan Brüns  ---
Git commit 06d98a1b9ad475332af12df7de503ee4bb93478f by Stefan Brüns.
Committed on 16/11/2023 at 21:46.
Pushed by bruns into branch 'master'.

[Exiv2Extractor] Add support for XMP DC Title, Subject, Description

The XMP Dublin Core metadata may contain title, subject and description
values, extract it.

Update JPEG, JXL and WebP test images to include Title and Subject.
Related: bug 316766

M  +17   -3autotests/exiv2extractortest.cpp
D  +0-25   autotests/exiv2extractortest.h
M  +---autotests/samplefiles/test.jpg
M  +---autotests/samplefiles/test.jxl
M  +---autotests/samplefiles/test.webp
M  +25   -0src/extractors/exiv2extractor.cpp

https://invent.kde.org/frameworks/kfilemetadata/-/commit/06d98a1b9ad475332af12df7de503ee4bb93478f

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 398101] Insufficient documentation

2023-11-16 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=398101

--- Comment #3 from Stefan Brüns  ---
Git commit e8a7446ad77f2259957e7bb3c325451fe7affe14 by Stefan Brüns.
Committed on 14/11/2023 at 02:02.
Pushed by bruns into branch 'master'.

[ExternalExtractorTest] Test TypeInfo and Properties

M  +8-2autotests/externalextractortest.cpp
M  +10   -2autotests/samplefiles/testexternalextractor/main.py

https://invent.kde.org/frameworks/kfilemetadata/-/commit/e8a7446ad77f2259957e7bb3c325451fe7affe14

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 431422] Elisa intermittently crashed in KFileMetaData::Property::Property() when fetching lyrics tag

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=431422

Stefan Brüns  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=458607

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 458607] Elisa crashes on launch in KFileMetaData::ExtractorCollectionPrivate::getExtractors() with existing playlist and shuffle enabled

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=458607

Stefan Brüns  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=431422

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 458607] Elisa crashes on launch in KFileMetaData::ExtractorCollectionPrivate::getExtractors() with existing playlist and shuffle enabled

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=458607

Stefan Brüns  changed:

   What|Removed |Added

   Assignee|pinak.ah...@gmail.com   |matthieu_gall...@yahoo.fr
Version|5.97.0  |22.08.0
  Component|general |general
Product|frameworks-kfilemetadata|Elisa

--- Comment #3 from Stefan Brüns  ---
Likely duplicate of 431422

KFileMetadata::ExtractorCollection is reentrant, but not thread safe.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

--- Comment #13 from Stefan Brüns  ---
Git commit fd24c90c1e465324baa81a622f8767b62eef by Stefan Brüns.
Committed on 16/11/2023 at 04:18.
Pushed by bruns into branch 'kf5'.

[ExtractorProcess] Handle signal mangling by DrKonqi

DrKonqui catches the SIGSEGV or SIGILL from a misbehaving extractor,
and then eventually quits the process. This may happen either by
re-raising the signal, or just are regular `_exit(253)`.

Which one is used depends on the kernel `/proc/sys/kernel/core_pattern`
setting - if it uses a pipe, the signal will be reraised.

The unexpected exit status was not handled before, and could cause
a blocking indexer, as neither a `done()` or `failed()` signal would
ever be emitted.

This also causes the list of failed files to stay empty, i.e.
`balooctl failed` would not return anything.
(cherry picked from commit 819cb757b5742372cf017fba84955178c1f1a7d1)

M  +1-1autotests/unit/file/CMakeLists.txt
M  +1-1src/file/CMakeLists.txt
M  +12   -4src/file/extractorprocess.cpp

https://invent.kde.org/frameworks/baloo/-/commit/fd24c90c1e465324baa81a622f8767b62eef

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

--- Comment #12 from Stefan Brüns  ---
Git commit 819cb757b5742372cf017fba84955178c1f1a7d1 by Stefan Brüns.
Committed on 14/11/2023 at 01:28.
Pushed by bruns into branch 'master'.

[ExtractorProcess] Handle signal mangling by DrKonqi

DrKonqui catches the SIGSEGV or SIGILL from a misbehaving extractor,
and then eventually quits the process. This may happen either by
re-raising the signal, or just are regular `_exit(253)`.

Which one is used depends on the kernel `/proc/sys/kernel/core_pattern`
setting - if it uses a pipe, the signal will be reraised.

The unexpected exit status was not handled before, and could cause
a blocking indexer, as neither a `done()` or `failed()` signal would
ever be emitted.

This also causes the list of failed files to stay empty, i.e.
`balooctl failed` would not return anything.

M  +1-1src/file/CMakeLists.txt
M  +12   -4src/file/extractorprocess.cpp

https://invent.kde.org/frameworks/baloo/-/commit/819cb757b5742372cf017fba84955178c1f1a7d1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

Stefan Brüns  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=475919

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 475919] Dolphin search shows doubled results

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475919

Stefan Brüns  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=477068
 CC||stefan.bruens@rwth-aachen.d
   ||e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

Stefan Brüns  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=474973

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 474973] baloosearch (as well as Dolphin and other apps using baloo) do not find anything when serching files inside the Downloads directory

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=474973

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e
   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=477068

--- Comment #31 from Stefan Brüns  ---
(In reply to tagwerk19 from comment #27)
> Maybe I'm a step further. I have a system where I see the same behaviour,
> something I consider a remarkable step forward 8-/
> 
> Bad news is it's a "bashed about" Neon Unstable, not something I can
> reproduceably rebuild. Further bad news is that if I leave the configuration
> and test files untouched, do a "balooctl6 purge" and reindex, the behaviour
> goes away.
> 
> That would help explain why the issue is so slippery. It also means that
> when you have the issue, copy your .local/share/baloo/index somewhere safe
> so you can go back to it.
> 
> It's also quite possible that this is one cause of the problem rather then
> "the" cause, but what I see is:
> 
>$ baloosearch -i  test
> 144044ed0da2dd /home/test/testfiles/test.txt
> 14ba61fc01 /home/test/testfiles
> 14ba61ed0da2dd /home/test/testfiles
> Elapsed: 0.297092 msecs
> 
>   [...]
>
> $ baloosearch -i test
> 144044ed0da2dd /home/test/testfiles/test.txt
> 14ba61ed0da2dd /home/test/testfiles
> Elapsed: 0.410179 msecs
> 
> $ baloosearch -i -d /home/test/testfiles test
> 144044ed0da2dd /home/test/testfiles/test.txt
> 14ba61ed0da2dd /home/test/testfiles
> Elapsed: 0.307979 msecs
> 
> The index has two records for the /home/test/testfiles folder with different
> DocIDs and the "test.txt" file was created with the new format DocID and it
> was not found in the search. After the reindex, it was found.

("WARNING: term  points to unknown document 5698695752383489 (/???)" - that is
143eeffc01 in hex, so it points to the same problem)

@tagwerk19 Thanks for investigating this.

I think the conclusion this is caused by the change of the FSID generation
(https://invent.kde.org/frameworks/baloo/-/merge_requests/131) is spot on, and
shows that the MR is missing the required safety measures. (Although the MR
mentioned this problem explicitly.)

The change was obviously not tested and analyzed for possible side effect. But
my reservations were unfortunately just ignored, and the change merged
nevertheless, without prior notice (24 minutes from removing the Draft status,
"resolving" all comments and merging it).

After the change, the DB contents are semantically garbage, and the DB has to
be purged (You have noticed this before, I know). This should have been done
automatically, but nobody implemented it. Nobody announced the breakage to the
broader public.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 477068] New: DB must be purged whenever the DB scheme/contents change in an incompatible way

2023-11-15 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=477068

Bug ID: 477068
   Summary: DB must be purged whenever the DB scheme/contents
change in an incompatible way
Classification: Frameworks and Libraries
   Product: frameworks-baloo
   Version: 5.112.0
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Baloo File Daemon
  Assignee: baloo-bugs-n...@kde.org
  Reporter: stefan.bru...@rwth-aachen.de
CC: tagwer...@innerjoin.org
  Target Milestone: ---

Up to now code changes were done to no cause any incompatibility issues with
existing DB contents, but unfortunate
https://invent.kde.org/frameworks/baloo/-/merge_requests/131 introduced such a
change.

To be able to deal with such issues, the DB should contain a version to notify
about incompatible changes of the DB scheme etc. The DB should be recreated in
such a case, and the library should check if the DB is compatible (which could
happen with e.g. KF5 and KF6 installed at the same time).

-- 
You are receiving this mail because:
You are watching all bug changes.

[kdenetwork-filesharing] [Bug 475946] Share properties page shows incorrect, bogus error message

2023-11-14 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475946

Stefan Brüns  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/netw
   ||ork/kdenetwork-filesharing/
   ||-/commit/456c127ee95b8be252
   ||c28046f444091230b47b24
 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #2 from Stefan Brüns  ---
Git commit 456c127ee95b8be252c28046f444091230b47b24 by Stefan Brüns.
Committed on 11/11/2023 at 00:25.
Pushed by bruns into branch 'master'.

Remove wrong group check from group manager

Samba allows any group name for usershares. As long as the user is part
of the group the group name does not affect the function of usershares
at all.

The "net" man page even spells out "serverops" as example, which is
currently not accepted.

The remaining checks when creating the group is still bogus, but is
quite limited in scope, and has no effect when the group already exists.

M  +2-2samba/filepropertiesplugin/authhelper.cpp
M  +0-13   samba/filepropertiesplugin/groupmanager.cpp

https://invent.kde.org/network/kdenetwork-filesharing/-/commit/456c127ee95b8be252c28046f444091230b47b24

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 410680] baloo doesn't index words far down in HTML documents

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=410680

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REOPENED|NEEDSINFO

--- Comment #9 from Stefan Brüns  ---
Can not be reproduced, provided link
(https://demo.borland.com/testsite/stadyn_largepagewithimages.html) is dead.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 439857] baloo only indexes first 4096 bytes of non-UTF-8 text and html files

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=439857

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|RESOLVED
 Resolution|--- |NOT A BUG

--- Comment #1 from Stefan Brüns  ---
You are mistaken. I reads the first 4096 bytes to get the correct mimetype
based on the contents.

See https://doc.qt.io/qt-6/qmimedatabase.html#mimeTypeForData

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

--- Comment #10 from Stefan Brüns  ---
(In reply to Christoph Feck from comment #4)
> From the backtrace, it looks like there is a text file larger than 2 GiB. Qt
> only supports up to 2 GiB.
> 
> I suggest to add incremental loading to the plaintextextractor.

I suggest to open a MR.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

--- Comment #9 from Stefan Brüns  ---
On Tumbleweed, the pattern is set by installing the `systemd-coredump` package:

$> grep core_pattern /usr/lib/sysctl.d/50-coredump.conf
kernel.core_pattern=|/usr/lib/systemd/systemd-coredump %P %u %g %s %t %c %h

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 407664] Dolphin search fully fail sometimes (impredectibly)

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=407664

--- Comment #12 from Stefan Brüns  ---
Git commit 6dbc3212825b2ffc360fda65f0022be224d9a5a1 by Stefan Brüns.
Committed on 13/11/2023 at 21:41.
Pushed by bruns into branch 'kf5'.

[QueryTest] Add test case for terms folded to empty strings

The termgenerator removes leading, trailing and isolated punctuation
characters. While this is no problem for leading or trailing punctuation
as the normalized term is still non-empty, isolated punctuation ends up
as an empty string.

The matcher then tries to find e.g. "(content:'' OR filename:'')", which
returns not results, instead of the exptedted "everything". Unfortunately
it is non-trivial to remove such Terms.

For the prase test, this is not at problem, as it always sees the whole
phrase and can just skip the problematic part.
(cherry picked from commit c8d1b7cabcc810867f400e5ccfb96e41b03e0635)

M  +15   -0autotests/integration/querytest.cpp

https://invent.kde.org/frameworks/baloo/-/commit/6dbc3212825b2ffc360fda65f0022be224d9a5a1

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 412421] 25+ char string without spaces search fails

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=412421

--- Comment #9 from Stefan Brüns  ---
Git commit af0b611bced29e6cc00f120e9ff69470bd657a7d by Stefan Brüns.
Committed on 13/11/2023 at 21:41.
Pushed by bruns into branch 'kf5'.

[SearchStore] Always use TermGenerator instead of QueryParser

The QueryParser handles two fairly distinct tasks, parsing of quoting
characters, and splitting of phrases into terms.

The Phrase/Term splitting is similar to the TermGenerator, but slightly
different. Using a different implementation for searching and DB storage
can cause matching errors.

While the nested QueryParser quoting /can/ be used, it is fairly
redundant, and problematic:

- Quoting is already handled by the AdvancedQueryParser, which always
  sits in front of the SearchStore.
- The QueryParser is *only* used for "contains" queries (e.g.
  filename:foo.png) not "equal" queries ("filename=foo.png").
- Quoting of phrases for both variants is different,
  content:\"\'a b\'\" vs. content=\"a \"b".
- The QueryParser does not handle term truncation (see bug reference).

Use the TermGenerator in all cases, so term splitting and quoting is
uniform.
(cherry picked from commit b7c8ce1a999225f0362b8be274a9d5c786c3edda)

M  +0-1autotests/integration/querytest.cpp
M  +7-3src/lib/searchstore.cpp

https://invent.kde.org/frameworks/baloo/-/commit/af0b611bced29e6cc00f120e9ff69470bd657a7d

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 462009] After changing config settings, old entries/paths may be reported in the progress info

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=462009

--- Comment #11 from Stefan Brüns  ---
Git commit 16271af71c7ac04627b3e3e6221668c9773817a8 by Stefan Brüns.
Committed on 13/11/2023 at 21:41.
Pushed by bruns into branch 'kf5'.

[Extractor] Do not emit startedIndexingFile for skipped documents

The signal was already omitted for deleted files, so there is precedence
for not emitting it.

The signal will now only be emitted if an extractor is actually started
for the file, otherwise emit only finishedIndexingFile.
(cherry picked from commit 43baad236dab33ed7107d1ce6b3289203e79408c)

M  +6-3src/file/extractor/app.cpp

https://invent.kde.org/frameworks/baloo/-/commit/16271af71c7ac04627b3e3e6221668c9773817a8

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 425020] baloosearch's search support for Chinese, Japanese and Korean is very weak.

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=425020

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 362647] Can't search with Chinese characters

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=362647

Stefan Brüns  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||5.76.0
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 424165] Negated terms in queries

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=424165

Stefan Brüns  changed:

   What|Removed |Added

 CC||j.straight-...@straights.ne
   ||t

--- Comment #4 from Stefan Brüns  ---
*** Bug 474994 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 474994] baloo needs to support logical NOT

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=474994

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #1 from Stefan Brüns  ---


*** This bug has been marked as a duplicate of bug 424165 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 412421] 25+ char string without spaces search fails

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=412421

Stefan Brüns  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 433369] Failed service: app-baloo_file-autostart

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=433369

Stefan Brüns  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |DOWNSTREAM

--- Comment #1 from Stefan Brüns  ---
Packaging bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 469699] SIGABRT in libldap

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=469699

Stefan Brüns  changed:

   What|Removed |Added

   Version Fixed In||5.108.0
 Resolution|--- |FIXED
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|RESOLVED

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 476857] Baloo crashes after login with Wayland compositor.

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=476857

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||5.108.0
 Status|REPORTED|RESOLVED
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 470387] Baloo aborted at login

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=470387

Stefan Brüns  changed:

   What|Removed |Added

   Version Fixed In||5.108.0
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 470176] Crash window appears very randomly.. no idea why

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=470176

Stefan Brüns  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
   Version Fixed In||5.108.0
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Resolution|--- |FIXED

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 470088] baloo thing randomly crashed

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=470088

Stefan Brüns  changed:

   What|Removed |Added

   Version Fixed In||5.108.0
 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #4 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 471918] Baloo file extractor crashes constantly

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=471918

Stefan Brüns  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 Resolution|--- |FIXED
 CC||stefan.bruens@rwth-aachen.d
   ||e
   Version Fixed In||5.108.0

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 471351] baloo_file: signal: Bus error

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=471351

Stefan Brüns  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Resolution|--- |FIXED
   Version Fixed In||5.108.0

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 471206] Baloo File Extractor Crashes on login

2023-11-13 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=471206

Stefan Brüns  changed:

   What|Removed |Added

   Version Fixed In||5.108.0
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #1 from Stefan Brüns  ---
(Untested) Memory constraints interfering with regular operation, fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 421317] Baloo is crashing at startup

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=421317

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #6 from Stefan Brüns  ---
(In reply to DaBler from comment #2)
> (In reply to Stefan Brüns from comment #1)
> > The extractor from KFileMetadata is crashing.
> > 
> > 'balooctl failed' will tell which file causes the crash.
> 
> $ balooctl failed
> All Files were indexed successfully

This is probably caused by DrKonqi messing up signal delivery.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 458607] Elisa crashes on launch in KFileMetaData::ExtractorCollectionPrivate::getExtractors() with existing playlist and shuffle enabled

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=458607

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #2 from Stefan Brüns  ---
The backtrace is incomplete, please install debuginfo packages.

Also, debug traces from kfilemetadata would be helpful:
$> QT_LOGGING_RULES='kf.filemetadata.debug=true' elisa

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 448182] Support module music formats in TaglibExtractor (MOD, S3M, XM, IT)

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=448182

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e
   Keywords||junior-jobs

--- Comment #1 from Stefan Brüns  ---
This is quite trivial to add, even for a new contributor.

A MR should contain test files (with appropriate licenses) for all formats, and
cover the all supported properties in unit tests.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 438186] kfilemetadata: Executable ExternalExtractors are ignored, contrary to the documentation.

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=438186

Stefan Brüns  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
 CC||stefan.bruens@rwth-aachen.d
   ||e

-- 
You are receiving this mail because:
You are watching all bug changes.

[Elisa] [Bug 415330] Songs aren't shown if id3v1 is used

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=415330

Stefan Brüns  changed:

   What|Removed |Added

   Assignee|pinak.ah...@gmail.com   |matthieu_gall...@yahoo.fr
 CC||stefan.bruens@rwth-aachen.d
   ||e
Product|frameworks-kfilemetadata|Elisa
Version|5.64.0  |unspecified
  Component|general |general

--- Comment #2 from Stefan Brüns  ---
KFileMetaData has no problem with file having only an ID3v1 tag, and extracts
all the available information.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 330989] Add support for XMP Metadata in Image Files

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=330989

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|RESOLVED

--- Comment #2 from Stefan Brüns  ---
This is the information currently extracted from the sample file:

/home/stefan/Downloads/DwC-SampleImage.jpg image/jpeg
Exiv2Extractor For <...>
Artist: Corbis (QString)
Document Generated By: http://www.idimager.com (QString)
Copyright: © Corbis.  All Rights Reserved. (QString)
Width: 1024 (uint)
Height: 768 (uint)
Image Date Time: 2008-03-14T13:59:26.000Z (QDateTime)
Image Orientation: 1 (int)
X Dimension: 1024 (qlonglong)
Y Dimension: 768 (qlonglong)
Original Date Time: 2008-03-14T13:59:26.000Z (QDateTime)

So XMP fields from Dublin Core (dc) and exif are extracted.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 453148] Elisa crashes in KFileMetaData::EmbeddedImageData::imageData() shortly after launch

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=453148

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #2 from Stefan Brüns  ---
It obviously crashes inside taglib itself.

Ubuntu 22.04 uses an old version of taglib (v 1.11.1), and should either update
or backport relevant fixes.

Issue should be verified with a current KFileMetaData built with a current
taglib (1.13.1).

In case the issue is still present, the problematic file should be provided,
either as an attachment, or if there are e.g. copyright or privacy issues, some
other arrangement should be made.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 458313] autotests CMakeLists tries to build ffmpegextractortest even when only some FFmpeg components are found

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=458313

--- Comment #5 from Stefan Brüns  ---
Git commit 4d6337c594b7a54d70cc53b07f3e96217c2d490b by Stefan Brüns.
Committed on 12/11/2023 at 19:11.
Pushed by bruns into branch 'kf5'.

[FFmpegExtractor] Bail out on first missing component during find_package

The various FFmpeg componets have different version schemes, so it is
not possible to query all components in a single call.

On the other hand, subsequent find_package calls will overwrite the
FOUND_FFMPEG variable with the last result, thus FOUND_FFMPEG will be
set even when only libavutil is installed.

Make the component checks dependent on the earlier ones, so the summary
shows the correct result.
(cherry picked from commit f5c605d07f7f97057be8fce5e4b63863330baf8b)

M  +6-2CMakeLists.txt

https://invent.kde.org/frameworks/kfilemetadata/-/commit/4d6337c594b7a54d70cc53b07f3e96217c2d490b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 458313] autotests CMakeLists tries to build ffmpegextractortest even when only some FFmpeg components are found

2023-11-12 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=458313

--- Comment #4 from Stefan Brüns  ---
Git commit f5c605d07f7f97057be8fce5e4b63863330baf8b by Stefan Brüns.
Committed on 12/11/2023 at 19:01.
Pushed by bruns into branch 'master'.

[FFmpegExtractor] Bail out on first missing component during find_package

The various FFmpeg componets have different version schemes, so it is
not possible to query all components in a single call.

On the other hand, subsequent find_package calls will overwrite the
FOUND_FFMPEG variable with the last result, thus FOUND_FFMPEG will be
set even when only libavutil is installed.

Make the component checks dependent on the earlier ones, so the summary
shows the correct result.

M  +6-2CMakeLists.txt

https://invent.kde.org/frameworks/kfilemetadata/-/commit/f5c605d07f7f97057be8fce5e4b63863330baf8b

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 475352] FLAC Ogg files incorrectly use the TagLib::Ogg::Vorbis extractor instead of TagLib::Ogg::FLAC

2023-11-11 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475352

--- Comment #7 from Stefan Brüns  ---
Git commit 1af1bfc1da39eb8d702a22eb1c467321ec993ff8 by Stefan Brüns.
Committed on 12/11/2023 at 01:10.
Pushed by bruns into branch 'kf5'.

[TaglibExtractor] Add support for Ogg stream with FLAC (audio/x-flac+ogg)

FLAC audio was only supported as standalone streams, but not the newer
FLAC stream wrapped in Ogg transport layer.

Use the corresponding taglib handler, and add a test file covering
basic stream information, metadata tags and cover art extraction.
(cherry picked from commit e2b64ea0fdcf8978ffe36fc81783bf19f0a7ca07)

M  +3-0autotests/extractorcoveragetest.cpp
A  +---autotests/samplefiles/test.flac.ogg
M  +12   -0autotests/taglibextractortest.cpp
M  +11   -0src/extractors/taglibextractor.cpp
M  +1-0src/extractors/taglibextractor.json

https://invent.kde.org/frameworks/kfilemetadata/-/commit/1af1bfc1da39eb8d702a22eb1c467321ec993ff8

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 475352] FLAC Ogg files incorrectly use the TagLib::Ogg::Vorbis extractor instead of TagLib::Ogg::FLAC

2023-11-11 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475352

--- Comment #6 from Stefan Brüns  ---
Git commit e2b64ea0fdcf8978ffe36fc81783bf19f0a7ca07 by Stefan Brüns.
Committed on 11/11/2023 at 02:48.
Pushed by bruns into branch 'master'.

[TaglibExtractor] Add support for Ogg stream with FLAC (audio/x-flac+ogg)

FLAC audio was only supported as standalone streams, but not the newer
FLAC stream wrapped in Ogg transport layer.

Use the corresponding taglib handler, and add a test file covering
basic stream information, metadata tags and cover art extraction.

M  +3-0autotests/extractorcoveragetest.cpp
A  +---autotests/samplefiles/test.flac.ogg
M  +12   -0autotests/taglibextractortest.cpp
M  +11   -0src/extractors/taglibextractor.cpp
M  +1-0src/extractors/taglibextractor.json

https://invent.kde.org/frameworks/kfilemetadata/-/commit/e2b64ea0fdcf8978ffe36fc81783bf19f0a7ca07

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 458313] autotests CMakeLists tries to build ffmpegextractortest even when only some FFmpeg components are found

2023-11-11 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=458313

Stefan Brüns  changed:

   What|Removed |Added

 Ever confirmed|0   |1
Summary|CMake not checking for  |autotests CMakeLists tries
   |libavformat before  |to build
   |attempting compile  |ffmpegextractortest even
   ||when only some FFmpeg
   ||components are found
 Status|REPORTED|CONFIRMED
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #2 from Stefan Brüns  ---
The complete error message is:

---
[ 66%] Building CXX object
autotests/CMakeFiles/ffmpegextractortest.dir/__/src/extractors/ffmpegextractor.cpp.o
cc1plus: warning:
/home/stefan/Sources/kfilemetadata/autotests/AVCODEC_INCLUDE_DIRS-NOTFOUND: No
such file or directory [-Wmissing-include-dirs]
cc1plus: warning:
/home/stefan/Sources/kfilemetadata/autotests/AVFORMAT_INCLUDE_DIRS-NOTFOUND: No
such file or directory [-Wmissing-include-dirs]
/home/stefan/Sources/kfilemetadata/src/extractors/ffmpegextractor.cpp:26:10:
fatal error: libavformat/avformat.h: No such file or directory
   26 | #include 
  |  ^~~~
compilation terminated.
make[2]: *** [autotests/CMakeFiles/ffmpegextractortest.dir/build.make:104:
autotests/CMakeFiles/ffmpegextractortest.dir/__/src/extractors/ffmpegextractor.cpp.o]
Error 1
make[1]: *** [CMakeFiles/Makefile2:1383:
autotests/CMakeFiles/ffmpegextractortest.dir/all] Error 2
---

So the compilation of the tests failed, which would have been helpful
information.

Also, already CMake complains:
---
CMake Error: The following variables are used in this project, but they are set
to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake
files:
/home/stefan/Sources/kfilemetadata/autotests/AVCODEC_INCLUDE_DIRS
   used as include directory in directory
/home/stefan/Sources/kfilemetadata/autotests
/home/stefan/Sources/kfilemetadata/autotests/AVFORMAT_INCLUDE_DIRS
   used as include directory in directory
/home/stefan/Sources/kfilemetadata/autotests
AVCODEC_LIBRARIES (ADVANCED)
linked by target "ffmpegextractortest" in directory
/home/stefan/Sources/kfilemetadata/autotests
AVFORMAT_LIBRARIES (ADVANCED)
linked by target "ffmpegextractortest" in directory
/home/stefan/Sources/kfilemetadata/autotests
---

-- 
You are receiving this mail because:
You are watching all bug changes.

[baloo-widgets] [Bug 420841] Metadata labels in ‘Details’ view in file properties dialogue is cut off (truncated)

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=420841

Stefan Brüns  changed:

   What|Removed |Added

  Component|general |general
   Assignee|pinak.ah...@gmail.com   |baloo-bugs-n...@kde.org
Version|5.69.0  |23.08.3
Product|frameworks-kfilemetadata|baloo-widgets
 CC||stefan.bruens@rwth-aachen.d
   ||e

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 398101] Insufficient documentation

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=398101

Stefan Brüns  changed:

   What|Removed |Added

   Keywords||junior-jobs

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 398101] Insufficient documentation

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=398101

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #2 from Stefan Brüns  ---
@skierpage - That are extractors implemented as shared libraries, not
standalone executables for external extractors, so the README.md is correct.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 438455] KFileMetadata does not support some Microsoft Office .doc file versions

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=438455

Stefan Brüns  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #40 from Stefan Brüns  ---
Bugs in several upstream projects (catdoc, shared-mime-info), which should
contain the fixes by now.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 475352] FLAC Ogg files incorrectly use the TagLib::Ogg::Vorbis extractor instead of TagLib::Ogg::FLAC

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=475352

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #5 from Stefan Brüns  ---
The mimetype for FLAC in a Ogg transport layer stream is "audio/x-flac+ogg".
This is currently not supported by kfilemetadata.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 428416] Baloo_file use 100% cpu and 4Gb of RAM for Checking for unindexed files

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=428416

Stefan Brüns  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Resolution|--- |WAITINGFORINFO

--- Comment #9 from Stefan Brüns  ---
Response required

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 460763] Baloo_file_extractor crashes

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=460763

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|NEEDSINFO

--- Comment #1 from Stefan Brüns  ---
The problematic file can be queried with "balooctl failed".

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-kfilemetadata] [Bug 460882] Wishlist: KFileMetadata extractor for .eml files

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=460882

Stefan Brüns  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||stefan.bruens@rwth-aachen.d
   ||e
 Status|REPORTED|CONFIRMED
   Keywords||junior-jobs
Summary|Wishlist: Baloo and .eml|Wishlist: KFileMetadata
   |files   |extractor for .eml files

--- Comment #1 from Stefan Brüns  ---
A minimal parser should be fairly trivial to write, it just has to handle the
header part.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 470326] Baloo crashed

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=470326

Stefan Brüns  changed:

   What|Removed |Added

 Resolution|--- |WAITINGFORINFO
 Status|REPORTED|NEEDSINFO

--- Comment #5 from Stefan Brüns  ---
Missing response from reporter, no reproducer.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 470326] Baloo crashed

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=470326

Stefan Brüns  changed:

   What|Removed |Added

 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #4 from Stefan Brüns  ---
(In reply to aronkvh from comment #1)
> Created attachment 162475 [details]
> New crash information added by DrKonqi
> 
> baloo_file_extractor (5.111.0) using Qt 5.15.11
> 
> Crash loop after turning on the device, I didn't use search or dolphin yet
> 
> -- Backtrace (Reduced):
> #6  __strcmp_sse2_unaligned () at
> ../sysdeps/x86_64/multiarch/strcmp-sse2-unaligned.S:32
> #7  0x7fa7d86d9338 in FindNode () from /lib/libepub.so.0
> #8  0x7fa7d86d8009 in _opf_manifest_get_by_id () from /lib/libepub.so.0
> #9  0x7fa7d86d51bd in _get_spine_it_url () from /lib/libepub.so.0
> #10 0x7fa7d86d5262 in epub_it_get_curr () from /lib/libepub.so.0

This is unrelated.

Note, many distributions ship a known buggy version of libepub/ebook-tools.
openSUSE uses a known fixed and maintained version, for others please use the
distribution bugtracker.

-- 
You are receiving this mail because:
You are watching all bug changes.

[frameworks-baloo] [Bug 469351] Baloo crashed while starting a torrent

2023-11-10 Thread Stefan Brüns
https://bugs.kde.org/show_bug.cgi?id=469351

Stefan Brüns  changed:

   What|Removed |Added

 Status|REPORTED|NEEDSINFO
 Resolution|--- |WAITINGFORINFO
 CC||stefan.bruens@rwth-aachen.d
   ||e

--- Comment #1 from Stefan Brüns  ---
Missing information:
- incomplete backtrace
- unclear which file actually caused the crash. This can be queried with the
"balooctl failed" command.

-- 
You are receiving this mail because:
You are watching all bug changes.

  1   2   3   4   5   6   7   8   9   >