[Discover] [Bug 391126] Dscover does not list apps from flathub in settings

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391126

Nate Graham  changed:

   What|Removed |Added

 Resolution|FIXED   |---
 Status|RESOLVED|REOPENED

--- Comment #6 from Nate Graham  ---
Nope, broken again. And also, now the KDE apps Flatpak repo doesn't work
either. Something needs to be done to make this more robust, and maybe we
should an add an autotest, too.

With that line of debugging code added, here's what's printed the the console
when I try to browse to Flathub and then KDEapps:

search result Filters(extends:"org.kde.discover.desktop",) 305
search result Filters(origin:"Central repository of Flatpak applications",) 305
search result Filters(origin:"KDE Applications (nightly builds)",) 305

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391126] Dscover does not list apps from flathub in settings

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391126

Nate Graham  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #5 from Nate Graham  ---
Huh, it actually works now with the latest commits. :/

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391126] Dscover does not list apps from flathub in settings

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=391126

--- Comment #4 from Aleix Pol  ---
I cannot reproduce neither on my devel system or my neon and kubuntu systems.

Could you maybe try to dig a little bit?

This patch could help:

diff --git a/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
b/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
index 3d071e0b..30072b91 100644
--- a/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
+++ b/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp
@@ -1105,6 +1105,8 @@ ResultsStream * FlatpakBackend::search(const
AbstractResourcesBackend::Filters &
 }
 auto f = [this](AbstractResource* l, AbstractResource* r) { return
flatpakResourceLessThan(l,r); };
 std::sort(ret.begin(), ret.end(), f);
+
+qWarning() << "search result" << filter << ret.size();
 return new ResultsStream(QStringLiteral("FlatpakStream"), ret);
 }

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391126] Dscover does not list apps from flathub in settings

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391126

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #3 from Nate Graham  ---
Not fixed, I'm afraid. The problem remains on both the Plasma Plasma/5.12 and
master branches.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391126] Dscover does not list apps from flathub in settings

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=391126

Aleix Pol  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/dis
   ||cover/b38e157f3a0fb70e8b876
   ||089dca4cd9236a38465

--- Comment #2 from Aleix Pol  ---
Git commit b38e157f3a0fb70e8b876089dca4cd9236a38465 by Aleix Pol.
Committed on 27/02/2018 at 13:01.
Pushed by apol into branch 'Plasma/5.12'.

Fix flatpak source filtering

Can't filter by display name, should filter by id.

M  +1-1discover/qml/SourcesPage.qml

https://commits.kde.org/discover/b38e157f3a0fb70e8b876089dca4cd9236a38465

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391126] Dscover does not list apps from flathub in settings

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391126

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org
 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #1 from Nate Graham  ---
Yep, this recently regressed for me too in git master. I kept forgetting to
report it, so thanks, Dr Chapatin!

-- 
You are receiving this mail because:
You are watching all bug changes.