[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=391941

Aleix Pol  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
  Latest Commit||https://commits.kde.org/dis
   ||cover/6ec2f2cf22285acd662e6
   ||afc772515f11a70168f
 Resolution|BACKTRACE   |FIXED

--- Comment #7 from Aleix Pol  ---
Git commit 6ec2f2cf22285acd662e6afc772515f11a70168f by Aleix Pol.
Committed on 05/04/2018 at 01:01.
Pushed by apol into branch 'Plasma/5.12'.

Don't crash when cancelling flatpak jobs

Instead of parenting the thread, let the thread destroy itself when it's
done.

M  +3-3libdiscover/backends/FlatpakBackend/FlatpakTransaction.cpp
M  +3-2libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.cpp
M  +2-2libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.h

https://commits.kde.org/discover/6ec2f2cf22285acd662e6afc772515f11a70168f

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Christoph Feck]

https://bugs.kde.org/show_bug.cgi?id=391941

--- Comment #6 from Christoph Feck  ---
Aleix, does the backtrace from comment #5 provide useful information?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=391941

--- Comment #5 from Dr. Chapatin  ---
info from your link was not enough for me.
However after some searches I compiled discover with debug enabled.

Thread 36 (Thread 0x7fff96ab8700 (LWP 17614)):
#0  0x7361e879 in syscall () at /usr/lib/libc.so.6
#1  0x7fffedca8dcd in g_cond_wait_until ()
at /usr/lib/libglib-2.0.so.0
#2  0x7fffedc35753 in  () at /usr/lib/libglib-2.0.so.0
#3  0x7fffedc8ac76 in  () at /usr/lib/libglib-2.0.so.0
#4  0x7fffedc8a26a in  () at /usr/lib/libglib-2.0.so.0
#5  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#6  0x73623e7f in clone () at /usr/lib/libc.so.6

Thread 27 (Thread 0x7fffc2b76700 (LWP 17564)):
#0  0x7361b9bc in fsync () at /usr/lib/libc.so.6
#1  0x7fffc051c6a1 in  () at /usr/lib/libostree-1.so.1
#2  0x7fffc051ee47 in ostree_repo_commit_transaction ()
at /usr/lib/libostree-1.so.1
---Type  to continue, or q  to quit---
#3  0x7fffc1a9f68a in  () at /usr/lib/libflatpak.so.0
#4  0x7fffc1aa2902 in  () at /usr/lib/libflatpak.so.0
#5  0x7fffc1a8b181 in flatpak_installation_install_full ()
at /usr/lib/libflatpak.so.0
#6  0x7fffc1a8b32b in flatpak_installation_install ()
at /usr/lib/libflatpak.so.0
#7  0x7fffc1f57dc0 in FlatpakTransactionJob::run() (this=0x565846a0)
at
/home/stalker/discover/repos/extra-x86_64/src/discover-5.12.3/libdiscover/backends/FlatpakBackend/FlatpakTransactionJob.cpp:106
installRelatedRef = 
localError = 0x0
ref = 0x0
refName = {static null = {}, d = 0x56ea7150}
kind = 1
#8  0x73d1bb4d in  () at /usr/lib/libQt5Core.so.5
---Type  to continue, or q  to quit---
#9  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#10 0x73623e7f in clone () at /usr/lib/libc.so.6

Thread 25 (Thread 0x7fffb0957700 (LWP 17562)):
#0  0x7361997b in poll () at /usr/lib/libc.so.6
#1  0x7fffedc61ff3 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fffedc623b2 in g_main_loop_run ()
at /usr/lib/libglib-2.0.so.0
#3  0x7fffc179a6d8 in  () at /usr/lib/libgio-2.0.so.0
#4  0x7fffedc8a26a in  () at /usr/lib/libglib-2.0.so.0
#5  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#6  0x73623e7f in clone () at /usr/lib/libc.so.6

Thread 13 (Thread 0x7fffa915d700 (LWP 17295)):
#0  0x7361997b in poll () at /usr/lib/libc.so.6
#1  0x7fffedc61ff3 in  () at /usr/lib/libglib-2.0.so.0
---Type  to continue, or q  to quit---
#2  0x7fffedc6210e in g_main_context_iteration ()
at /usr/lib/libglib-2.0.so.0
#3  0x7fffedc62162 in  () at /usr/lib/libglib-2.0.so.0
#4  0x7fffedc8a26a in  () at /usr/lib/libglib-2.0.so.0
#5  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#6  0x73623e7f in clone () at /usr/lib/libc.so.6

Thread 11 (Thread 0x7fffabb6f700 (LWP 17292)):
#0  0x7361997b in poll () at /usr/lib/libc.so.6
#1  0x7fffedc61ff3 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fffedc6210e in g_main_context_iteration ()
at /usr/lib/libglib-2.0.so.0
#3  0x73f652f1 in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#4  0x73f073db in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
---Type  to continue, or q  to quit---
#5  0x73d167ae in QThread::exec() () at /usr/lib/libQt5Core.so.5
#6  0x73d1bb4d in  () at /usr/lib/libQt5Core.so.5
#7  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#8  0x73623e7f in clone () at /usr/lib/libc.so.6

Thread 7 (Thread 0x7fffc3377700 (LWP 17280)):
#0  0x7361997b in poll () at /usr/lib/libc.so.6
#1  0x7fffedc61ff3 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fffedc6210e in g_main_context_iteration ()
at /usr/lib/libglib-2.0.so.0
#3  0x73f652f1 in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#4  0x73f073db in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
#5  0x73d167ae in QThread::exec() () at /usr/lib/libQt5Core.so.5
#6  0x73d1bb4d in  () at /usr/lib/libQt5Core.so.5
---Type  to continue, or q  to quit---
#7  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#8  0x73623e7f in clone () at /usr/lib/libc.so.6

Thread 6 (Thread 0x7fffc3fff700 (LWP 17279)):
#0  0x7361997b in poll () at /usr/lib/libc.so.6
#1  0x7fffedc61ff3 in  () at /usr/lib/libglib-2.0.so.0
#2  0x7fffedc6210e in g_main_context_iteration ()
at /usr/lib/libglib-2.0.so.0
#3  0x73f652f1 in
QEventDispatcherGlib::processEvents(QFlags) ()
at /usr/lib/libQt5Core.so.5
#4  0x73f073db in
QEventLoop::exec(QFlags) () at
/usr/lib/libQt5Core.so.5
#5  0x73d167ae in QThread::exec() () at /usr/lib/libQt5Core.so.5
#6  0x73d1bb4d in  () at /usr/lib/libQt5Core.so.5
#7  0x7fffefe9308c in start_thread () at /usr/lib/libpthread.so.0
#8 

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=391941

--- Comment #4 from Aleix Pol  ---
See the link I pasted. It explains how to provide backtraces with debug symbols
by recompiling the package.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=391941

--- Comment #3 from Dr. Chapatin  ---
backtrace already posted here is the better I can do.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=391941

Aleix Pol  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |BACKTRACE

--- Comment #2 from Aleix Pol  ---
Could not reproduce. Not on the test, not running the application.

Please provide a backtrace if you can reproduce.
https://wiki.archlinux.org/index.php/Debug_-_Getting_Traces#PKGBUILD

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Aleix Pol]

https://bugs.kde.org/show_bug.cgi?id=391941

--- Comment #1 from Aleix Pol  ---
Git commit b73e08da262316a2f08f07d4b4d68024fb687064 by Aleix Pol.
Committed on 18/03/2018 at 23:50.
Pushed by apol into branch 'Plasma/5.12'.

Include a test for cancelling flatpak installations

Sadly didn't get he crash.

M  +17   -0libdiscover/backends/FlatpakBackend/tests/FlatpakTest.cpp

https://commits.kde.org/discover/b73e08da262316a2f08f07d4b4d68024fb687064

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=391941

Nate Graham  changed:

   What|Removed |Added

 CC||n...@kde.org

-- 
You are receiving this mail because:
You are watching all bug changes.

[Discover] [Bug 391941] Crash when flatpak installation is canceled

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=391941

Dr. Chapatin  changed:

   What|Removed |Added

   Severity|normal  |crash

-- 
You are receiving this mail because:
You are watching all bug changes.